phantomjs.rb 1.0.1 → 1.0.2

data/lib/phantomjs.rb

@@ -19,11 +19,11 @@ class Phantomjs
 
     begin
       if block_given?
-        IO.popen("#{EXEC} #{script} #{string_args}").each_line do |line|
+        IO.popen([EXEC, script, args].flatten).each_line do |line|
           yield line
         end
       else
-        `#{EXEC} #{script} #{string_args}`
+        IO.popen([EXEC, script, args].flatten).read
       end
     rescue Errno::ENOENT
       raise CommandNotFoundError.new('Phantomjs is not installed')

data/lib/phantomjs/version.rb

@@ -1,3 +1,3 @@
 class Phantomjs
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/spec/phantomjs_spec.rb

@@ -24,7 +24,7 @@ describe Phantomjs do
     it "runs phantomjs binary with the correct arguments" do
       script = File.expand_path('./spec/runner.js')
       result = Phantomjs.run(script, 'foo1', 'foo2')
-      result.should eq("bar foo1 foo2\n")
+      result.should eq("bar\nfoo1\nfoo2\n")
     end
     
     it "accepts a block that will get called for each line of output" do
@@ -33,7 +33,37 @@ describe Phantomjs do
       Phantomjs.run(script, 'foo1', 'foo2') do |l|
         line << l
       end
-      line.should eq("bar foo1 foo2\n")
+      line.should eq("bar\nfoo1\nfoo2\n")
+    end
+
+    it "accepts empty parameters" do
+      line = ''
+      script = File.expand_path('./spec/runner.js')
+      Phantomjs.run(script, 'foo1', 'foo2', '') do |l|
+        line << l
+      end
+      line.should eq("bar\nfoo1\nfoo2\n\n")
+    end
+
+    it "accepts parameters with spaces" do
+      line = ''
+      script = File.expand_path('./spec/runner.js')
+      Phantomjs.run(script, 'foo bar', 'foo2') do |l|
+        line << l
+      end
+      line.should eq("bar\nfoo bar\nfoo2\n")
+    end
+
+    it "accepts empty parameters without block" do
+      script = File.expand_path('./spec/runner.js')
+      output = Phantomjs.run(script, 'foo1', 'foo2', '')
+      output.should eq("bar\nfoo1\nfoo2\n\n")
+    end
+
+    it "accepts parameters with spaces without block" do
+      script = File.expand_path('./spec/runner.js')
+      output = Phantomjs.run(script, 'foo bar', 'foo2')
+      output.should eq("bar\nfoo bar\nfoo2\n")
     end
   end
 end

data/spec/runner.js

@@ -1,2 +1,5 @@
-console.log('bar ' + phantom.args[0] + ' ' + phantom.args[1]);
+console.log('bar');
+for (var i = 0; i < phantom.args.length; i++) {
+   console.log(phantom.args[i]);
+}
 phantom.exit();

metadata

@@ -1,18 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: phantomjs.rb
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
+  prerelease: 
 platform: ruby
 authors:
 - William Estoque
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-17 00:00:00.000000000 Z
+date: 2013-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -20,6 +22,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -27,6 +30,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -34,6 +38,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -61,28 +66,34 @@ files:
 - spec/runner.js
 homepage: http://westoque.com
 licenses: []
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -794486166950785980
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -794486166950785980
 requirements: []
 rubyforge_project: phantomjs.rb
-rubygems_version: 2.0.3
+rubygems_version: 1.8.24
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Ruby wrapper for phantomjs
 test_files:
 - spec/phantomjs_spec.rb
 - spec/runner.js
-has_rdoc: 

checksums.yaml

@@ -1,15 +0,0 @@
----
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    YzdiZTc3OWFlMWE3MDc2N2NkMWZiMzczMjEwY2FiOGUzN2Q2OTYyOA==
-  data.tar.gz: !binary |-
-    MjI4ODIyNTY3ZGFjYmIzOTMxMWJkZGQzNmNiNGZlNGE4ZDczOWUwMw==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    M2UwYjQzOThmNGI2MTM1YTlhNzk4NDVmZTU1OTkyMDRjYjdmOGE4MTlmNTU5
-    OTg3ZDU0MGE3MmRlMzE3NDdkZTVkYzEwYWZjZDI3MTE0Njc3YTQ5Zjk0ZjE0
-    N2I4NjU3OTk1YjYyZGE4YjI4OTdhMmM1MzUwNWRhNDczZTdkZmY=
-  data.tar.gz: !binary |-
-    Mjk5YmVmZTg5YWE1MzVkMzE4ZjA1NzJkMzAwNWU4OTI3YjMxOWFjYmI0MjQw
-    OGM0YThkZWI4NmM3NTliNDg5NGNjOGZkMWJlYThmMjI3MzdhNmZkY2E1ZDI5
-    ZTUzZmZhZThiMDUwY2Y5ZGY3NzAzNjE5ZTBiOWViYTA3NmZkYTg=