ph_model 1.0.2 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 18eb5a8b10e9378536d448b174f91f656023547c
-  data.tar.gz: 98833d553696e61f645270860eab78de9e46a9a8
+SHA256:
+  metadata.gz: 22c9a24cf0e12f417a5dfa23f3fb967828e9772533bfde21e1ea8ff4547d8bfe
+  data.tar.gz: b5ea967101912061b338ed8d80e9bdd06f79848cd3996e7fa51234bd77bec316
 SHA512:
-  metadata.gz: 4def997bc8690a1a6273a3fe9006013996980c098bad2a4031fdfc2b3ebeab40eb1ba4a904ef4280afaa177671050bf4d414fc4025ae412b267d48372f1ea440
-  data.tar.gz: 8b99a104a0715cccba40ad6b1f837d828c72dba5b40e87dbc1f71d3cfb4a0f3a191b83caa8af2a2ac3c0fbdf2ea05e445002f82f07fc546ea3c69c4839487171
+  metadata.gz: b33ddd683bbee7054fa38ba0ee5ca8841276d75a3cba2cc3c5915297a9a4a4bcecd9a826339ab23048c8d42a54b26977bc5b6e93765ced081b753b99367c157d
+  data.tar.gz: e6b149296201228a3d72a4dd6edad1480a4a97b904e3fa35a1782be1d36e1a4ab8f192395fc15794642c21f8aff62912bec6dee7cf9d909271fad5012ec692bd

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Change Log
 
+## [v1.1.0](https://github.com/payrollhero/ph_model/tree/v1.1.0) (2017-05-23)
+[Full Changelog](https://github.com/payrollhero/ph_model/compare/v1.0.2...v1.1.0)
+
+## [v1.0.2](https://github.com/payrollhero/ph_model/tree/v1.0.2) (2017-04-06)
+[Full Changelog](https://github.com/payrollhero/ph_model/compare/v1.0.1...v1.0.2)
+
+## [v1.0.1](https://github.com/payrollhero/ph_model/tree/v1.0.1) (2017-04-04)
+[Full Changelog](https://github.com/payrollhero/ph_model/compare/v1.0.0...v1.0.1)
+
 ## [v1.0.0](https://github.com/payrollhero/ph_model/tree/v1.0.0) (2017-04-04)
 [Full Changelog](https://github.com/payrollhero/ph_model/compare/v0.0.1...v1.0.0)
 

data/README.md

@@ -11,6 +11,7 @@
 [![Code Climate](https://codeclimate.com/github/payrollhero/ph_model/badges/gpa.svg)](https://codeclimate.com/github/payrollhero/ph_model)
 [![Issue Count](https://codeclimate.com/github/payrollhero/ph_model/badges/issue_count.svg)](https://codeclimate.com/github/payrollhero/ph_model)
 [![Dependency Status](https://gemnasium.com/payrollhero/ph_model.svg)](https://gemnasium.com/payrollhero/ph_model)
+[![Gem Version](https://badge.fury.io/rb/ph_model.svg)](https://badge.fury.io/rb/ph_model)
 
 This Gem basically marries ActiveModel and ActiveAttr is a nice package.
 

data/lib/active_model/validations/type_validator.rb

@@ -18,7 +18,7 @@ module ActiveModel
           allowed_classes = classes.to_sentence two_words_connector: " or ",
                                                 last_word_connector: ", or "
 
-          record.errors[attribute] << (options[:message] || "must be a #{allowed_classes}")
+          record.errors.add(attribute, (options[:message] || "must be a #{allowed_classes}"))
         end
       end
     end

data/lib/ph_model/concerns/attribute_nested_validation.rb

@@ -13,7 +13,7 @@ module PhModel
           if info[:type].is_a? Array
             if value.respond_to? :each_with_index
               value.each_with_index do |item_value, index|
-                check_one(item_value, "#{attribute_name}[#{index}]")
+                check_one(item_value, format_nested_attribute_name(attribute_name, index, item_value))
               end
             end
           else
@@ -22,6 +22,10 @@ module PhModel
         end
       end
 
+      def format_nested_attribute_name(attribute_name, index, item_value)
+        "#{attribute_name}[#{index}]"
+      end
+
       def check_one(value, attribute_name)
         return if !value.respond_to?(:valid?) || !value.respond_to?(:errors) || value.errors.nil? || value.valid?
         value.errors.full_messages.each do |message|

data/lib/ph_model/concerns/attribute_type_validation.rb

@@ -1,5 +1,11 @@
 module PhModel
   module Concerns
+
+    # This will validate any attribute defined with `type: `
+    # the type value should be a class, or the special notation `[SomeClass]` which is meant to designate that this is
+    # a collection of those classes
+    #
+    # `no_type_check: true` can be optionally passed to disable this check (other features might use the `type` column)
     module AttributeTypeValidation
       extend ActiveSupport::Concern
 
@@ -9,7 +15,7 @@ module PhModel
 
       def ensure_typed_attributes_class
         self.class.attributes.each do |attribute_name, info|
-          if info[:type] && !type_match?(attribute_name)
+          if info[:type] && !info[:no_type_check] && !type_match?(attribute_name)
             errors.add(attribute_name, "must be #{info[:type].inspect}, was #{type_summary(attribute_name)}")
           end
         end

data/lib/ph_model/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module PhModel
-  VERSION = '1.0.2'.freeze
+  VERSION = '1.1.2'.freeze
 end

data/lib/ph_model.rb

@@ -31,7 +31,7 @@ module PhModel
   include Concerns::AttributeNestedValidation
   include Concerns::AttributeOfArrayTypeInitialization
 
-  def as_json
+  def as_json(*)
     {}.tap do |hash|
       self.class.attributes.each do |attribute_name, _info|
         hash[attribute_name] = send(attribute_name).as_json

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ph_model
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.2
 platform: ruby
 authors:
 - Piotr Banasik
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-04-06 00:00:00.000000000 Z
+date: 2022-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -231,8 +231,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 3.2.32
 signing_key: 
 specification_version: 4
 summary: ph-model -- active_model, active_attr brought together at last