pgtk 0.30.9 → 0.30.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e73feebd4e15e2cd5ed8a862dd3f739e417cb2b24967efb084be032ceb4ea0a
-  data.tar.gz: 6e992abff2e960da1cf93b9bbac4c4f09a72482b65ce2e60e89e8597bb40bc20
+  metadata.gz: eef46168e2daa0ddc6721aac48a99dc20f8aa80f078cfc76a31fa4ec70759af6
+  data.tar.gz: 13dc7a6f18fcb34385c3580700e8e192b3bb38daab86f64b85fa64ac3f3dcce0
 SHA512:
-  metadata.gz: 9279442627e304c9489fba9ad8a2b3bef33fa4ec5602656cd2955f683087338f171593cc4d686a1b5b79d105bb4bb0000a99ea5176c0e64c61b709d97b400e64
-  data.tar.gz: f94ac7b9215ca461f2b9fc1692c2ba9ca5a1ad7ebc06363480812b01cc7b91a425d945f28f6f36ee52dd774f07ea016778469e3243afefba1c379f749f1a6645
+  metadata.gz: 18489070b6f37d64338982c7ade356881ffe7a6fc01f6cc1b837f2433ed2779a4838388ec60468ec80c3a21342b7f9c19b52bb87792c7bf0dc7011fb7163d9cd
+  data.tar.gz: bc115bdd5e53ff555e1e1d383d90f9ecc80d33b282cd57e89b03540a14f35792e718b5f74c64a637c761da7762791edcc9534f49612ebe5984836817c1e1c314

data/lib/pgtk/retry.rb

@@ -49,11 +49,17 @@ require_relative 'impatient'
 # Copyright:: Copyright (c) 2019-2026 Yegor Bugayenko
 # License:: MIT
 class Pgtk::Retry
+  # Raised when all retry attempts have been exhausted. The original
+  # exception that caused the last failure is available via #cause,
+  # so its message and stack trace are preserved for debugging.
+  class Exhausted < StandardError; end
+
   # Constructor.
   #
   # @param [Pgtk::Pool] pool The pool to decorate
   # @param [Integer] attempts Number of attempts to make (default: 3)
   def initialize(pool, attempts: 3)
+    raise(ArgumentError, "Attempts must be at least 2, while #{attempts} provided") if attempts < 2
     @pool = pool
     @attempts = attempts
   end
@@ -79,10 +85,11 @@ class Pgtk::Retry
     ].join("\n")
   end
 
-  # Execute a SQL query with automatic retry for SELECT queries.
-  # Also retries PG::ConnectionBad and Pgtk::Impatient::TooSlow errors
-  # for all query types, since they indicate the query never completed
-  # against PostgreSQL and can be safely re-issued.
+  # Execute a SQL query with automatic retry for SELECT queries only.
+  # Non-SELECT queries fail on the first error, since a failure may occur
+  # after the server received the query but before the acknowledgement
+  # reached the client, and retrying a non-idempotent write could duplicate
+  # it.
   #
   # @param [String] sql The SQL query with params inside (possibly)
   # @return [Array] Result rows
@@ -91,14 +98,10 @@ class Pgtk::Retry
     attempt = 0
     begin
       @pool.exec(sql, *)
-    rescue PG::ConnectionBad, Pgtk::Impatient::TooSlow => e
-      attempt += 1
-      raise(e) if attempt >= @attempts
-      retry
-    rescue StandardError => e
+    rescue StandardError, Pgtk::Impatient::TooSlow => e
       raise(e) unless query.strip.upcase.start_with?('SELECT')
       attempt += 1
-      raise(e) if attempt >= @attempts
+      raise(Exhausted, "Retry gave up after #{@attempts} attempts: #{e.message}") if attempt >= @attempts
       retry
     end
   end

data/lib/pgtk/version.rb

@@ -10,5 +10,5 @@ require_relative '../pgtk'
 # Copyright:: Copyright (c) 2019-2026 Yegor Bugayenko
 # License:: MIT
 module Pgtk
-  VERSION = '0.30.9' unless defined?(VERSION)
+  VERSION = '0.30.10' unless defined?(VERSION)
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pgtk
 version: !ruby/object:Gem::Version
-  version: 0.30.9
+  version: 0.30.10
 platform: ruby
 authors:
 - Yegor Bugayenko