pgslice 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 595fd1ef4439e8f5180ee6f84596c088124cf900
-  data.tar.gz: 6a7144e70f93c4edeb7b48be0efe28e6ccfd87f9
+  metadata.gz: 27fdf533604b2635d75b2eb92043617f8a53ed7a
+  data.tar.gz: 5f5579762fdfe759f38a4eb03cce91acb90a7397
 SHA512:
-  metadata.gz: ffb023c7ceacab8f0362808131a6a8d680455d756ab636f558257390c68b20214edf2ad4eefb3dd6f5fb46b9a9b7a8eb264fa070ffc4fca34e051c9b069ca66f
-  data.tar.gz: 44869b8f950334d8db95a9a081937966367e1cac30caa5ce03254b694f54f893f04a429f935e2f6a80487465c5283005f280512ac3b600f027a2f9fd87d4ec16
+  metadata.gz: ac1abb9261c93e8b0bf057b6b16fd1a864f3e2ddd9b85f196df095731fbbbdac0b49e3878b966632c15ce9d7c6774d64231dc03d2e4a42b74fd185ffc177a8b5
+  data.tar.gz: 9524851474990255e54c008477db65de535fcea6412900ea0c68a801518a79b7124175cde7cddd5e932a6575c76d282047642d7c8f4016e6cce13fd703a90877

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.1.3
+
+- Fixed table inheritance
+
 ## 0.1.2
 
 - Added `--dry-run` option

data/README.md

@@ -93,7 +93,7 @@ $ pgslice prep locations created_at day
 BEGIN;
 
 CREATE TABLE locations_intermediate (
-  LIKE locations INCLUDING INDEXES INCLUDING DEFAULTS
+  LIKE locations INCLUDING ALL
 );
 
 CREATE FUNCTION locations_insert_trigger()
@@ -116,20 +116,29 @@ $ pgslice add_partitions locations --intermediate --past 1 --future 1
 BEGIN;
 
 CREATE TABLE locations_20160423 (
-  LIKE locations_intermediate INCLUDING INDEXES INCLUDING DEFAULTS,
   CHECK (created_at >= '2016-04-23'::date AND created_at < '2016-04-24'::date)
 ) INHERITS (locations_intermediate);
 
+ALTER TABLE locations_20160423 ADD PRIMARY KEY (id);
+
+CREATE INDEX ON locations_20160423 USING btree (updated_at, shopper_id);
+
 CREATE TABLE locations_20160424 (
-  LIKE locations_intermediate INCLUDING INDEXES INCLUDING DEFAULTS,
   CHECK (created_at >= '2016-04-24'::date AND created_at < '2016-04-25'::date)
 ) INHERITS (locations_intermediate);
 
+ALTER TABLE locations_20160424 ADD PRIMARY KEY (id);
+
+CREATE INDEX ON locations_20160424 USING btree (updated_at, shopper_id);
+
 CREATE TABLE locations_20160425 (
-  LIKE locations_intermediate INCLUDING INDEXES INCLUDING DEFAULTS,
   CHECK (created_at >= '2016-04-25'::date AND created_at < '2016-04-26'::date)
 ) INHERITS (locations_intermediate);
 
+ALTER TABLE locations_20160425 ADD PRIMARY KEY (id);
+
+CREATE INDEX ON locations_20160425 USING btree (updated_at, shopper_id);
+
 COMMIT;
 ```
 
@@ -159,6 +168,11 @@ gem install specific_install
 gem specific_install ankane/pgslice
 ```
 
+## TODO
+
+- Command to sync index changes with partitions
+- Disable indexing for faster `fill`
+
 ## Contributing
 
 Everyone is encouraged to help improve this project. Here are a few ways you can help:

data/lib/pgslice/version.rb

@@ -1,3 +1,3 @@
 module PgSlice
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/pgslice.rb

@@ -63,7 +63,7 @@ module PgSlice
 
       queries << <<-SQL
 CREATE TABLE #{intermediate_table} (
-  LIKE #{table} INCLUDING INDEXES INCLUDING DEFAULTS
+  LIKE #{table} INCLUDING ALL
 );
       SQL
 
@@ -122,6 +122,9 @@ FOR EACH ROW EXECUTE PROCEDURE #{trigger_name}();
       days = range.map { |n| today + (n * inc) }
       queries = []
 
+      index_defs = execute("select pg_get_indexdef(indexrelid) from pg_index where indrelid = $1::regclass AND indisprimary = 'f'", [original_table]).map { |r| r["pg_get_indexdef"] }
+      primary_key = self.primary_key(table)
+
       days.each do |day|
         partition_name = "#{original_table}_#{day.strftime(name_format)}"
         next if table_exists?(partition_name)
@@ -130,10 +133,15 @@ FOR EACH ROW EXECUTE PROCEDURE #{trigger_name}();
 
         queries << <<-SQL
 CREATE TABLE #{partition_name} (
-  LIKE #{table} INCLUDING INDEXES INCLUDING DEFAULTS,
   CHECK (#{field} >= '#{day.strftime(date_format)}'::date AND #{field} < '#{(day + inc).strftime(date_format)}'::date)
 ) INHERITS (#{table});
         SQL
+
+        queries << "ALTER TABLE #{partition_name} ADD PRIMARY KEY (#{primary_key});"
+
+        index_defs.each do |index_def|
+          queries << index_def.sub(" ON #{original_table} USING ", " ON #{partition_name} USING ").sub(/ INDEX .+ ON /, " INDEX ON ") + ";"
+        end
       end
 
       run_queries(queries) if queries.any?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pgslice
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Andrew Kane