pghero 3.3.1 → 3.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f26e73390b749930f287536790ab7951268d105c074211c3273c595105558b4e
-  data.tar.gz: 8d6e752dde349c152e5569f93f282035c35357f4eb54edf682ddd5c2e3a23986
+  metadata.gz: '002087a8cb8c6db43d1f084fd773aa4c8320c6fe77be3d4f42b6ca55ff91d39d'
+  data.tar.gz: fd4cb80b991e10232d7628604049e25685ae3723c53c7dd3231288b369015976
 SHA512:
-  metadata.gz: 9f2be7dd596e50df9319cc794e2098226833445f4b6a1fefb2f57aca21eb38e3f2676c78bc14d620bcc36da413e6825709e053020646b00ae428b33860534406
-  data.tar.gz: b852564d036d3c2e427e4f4ccccdfc9cb00c13507a64cf742d0fadf3c6ec35cfc6eddbe5c6a8e29f2d71692fe6a3a663f91ee0bd8807fa946a537938908456c6
+  metadata.gz: 42a29de1135ce51d59423e0aedafff5261ffea8e93740a40aa80d472a48d01a799349ea9c48f78c027f86d493e342901698707894156b149236ca7e8f101a0a1
+  data.tar.gz: 68e636a77b47b825803c04ef90005827a66ae6abc0dab5f60bde8877f0c0d4aa580daa60c7959042bb0f9f0bb374eda3e885e0903069247a00c7a9a8779945a2

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 3.3.3 (2023-04-18)
+
+- Fixed error with system stats for Azure Database
+
+## 3.3.2 (2023-04-12)
+
+- Fixed error with suggested indexes and empty statements
+
 ## 3.3.1 (2023-03-15)
 
 - Fixed error with Uglifier

data/app/controllers/pg_hero/home_controller.rb

@@ -248,9 +248,16 @@ module PgHero
       stats =
         case @database.system_stats_provider
         when :azure
-          [
-            {name: "IO Consumption", data: @database.azure_stats("io_consumption_percent", **system_params), library: chart_library_options}
-          ]
+          if @database.send(:azure_flexible_server?)
+            [
+              {name: "Read IOPS", data: @database.read_iops_stats(**system_params).map { |k, v| [k, v ? v.round : v] }, library: chart_library_options},
+              {name: "Write IOPS", data: @database.write_iops_stats(**system_params).map { |k, v| [k, v ? v.round : v] }, library: chart_library_options}
+            ]
+          else
+            [
+              {name: "IO Consumption", data: @database.azure_stats("io_consumption_percent", **system_params), library: chart_library_options}
+            ]
+          end
         when :gcp
           [
             {name: "Read Ops", data: @database.read_iops_stats(**system_params).map { |k, v| [k, v ? v.round : v] }, library: chart_library_options},

data/lib/pghero/methods/suggested_indexes.rb

@@ -194,6 +194,7 @@ module PgHero
       end
 
       def best_index_structure(statement)
+        return {error: "Empty statement"} if statement.to_s.empty?
         return {error: "Too large"} if statement.to_s.length > 10000
 
         begin

data/lib/pghero/methods/system.rb

@@ -102,7 +102,8 @@ module PgHero
           end
 
         client = Azure::Monitor::Profiles::Latest::Mgmt::Client.new
-        timespan = "#{start_time.iso8601}/#{end_time.iso8601}"
+        # call utc to convert +00:00 to Z
+        timespan = "#{start_time.utc.iso8601}/#{end_time.utc.iso8601}"
         results = client.metrics.list(
           azure_resource_id,
           metricnames: metric_name,
@@ -269,12 +270,13 @@ module PgHero
             used = azure_stats("storage_used", **options)
             free_space(quota, used)
           else
-            # no read_iops, write_iops
-            # could add io_consumption_percent
+            replication_lag_stat = azure_flexible_server? ? "physical_replication_delay_in_seconds" : "pg_replica_log_delay_in_seconds"
             metrics = {
               cpu: "cpu_percent",
               connections: "active_connections",
-              replication_lag: "pg_replica_log_delay_in_seconds"
+              replication_lag: replication_lag_stat,
+              read_iops: "read_iops", # flexible server only
+              write_iops: "write_iops" # flexible server only
             }
             raise Error, "Metric not supported" unless metrics[metric_key]
             azure_stats(metrics[metric_key], **options)
@@ -284,6 +286,10 @@ module PgHero
         end
       end
 
+      def azure_flexible_server?
+        azure_resource_id.include?("/Microsoft.DBforPostgreSQL/flexibleServers/")
+      end
+
       # only use data points included in both series
       # this also eliminates need to align Time.now
       def free_space(quota, used)

data/lib/pghero/version.rb

@@ -1,3 +1,3 @@
 module PgHero
-  VERSION = "3.3.1"
+  VERSION = "3.3.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pghero
 version: !ruby/object:Gem::Version
-  version: 3.3.1
+  version: 3.3.3
 platform: ruby
 authors:
 - Andrew Kane
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-16 00:00:00.000000000 Z
+date: 2023-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -124,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.6
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: A performance dashboard for Postgres