pghero 3.1.0 → 3.3.0

data/app/assets/stylesheets/pghero/application.css

@@ -187,7 +187,7 @@ hr {
 }
 
 #slider-container {
-  padding: 6px 140px 20px 140px;
+  padding: 6px 8px 14px 8px;
 }
 
 .queries-table th a, .space-table th a {
@@ -195,7 +195,7 @@ hr {
 }
 
 #slider {
-  margin-bottom: 20px;
+  margin: 0px 14px 18px 14px;
 }
 
 #range-start {
@@ -485,6 +485,12 @@ body {
   color: #999;
 }
 
+.pie-chart {
+  height: 260px;
+  line-height: 260px;
+  margin-bottom: 20px;
+}
+
 .unused-index {
   color: #f0ad4e;
   font-size: 11px;

data/app/assets/stylesheets/pghero/nouislider.css

@@ -1,4 +1,3 @@
-/*! nouislider - 14.6.1 - 8/17/2020 */
 /* Functional styling;
  * These styles are required for noUiSlider to function.
  * You don't need to change these rules to apply your design.
@@ -39,20 +38,14 @@
   z-index: 1;
   top: 0;
   right: 0;
+  height: 100%;
+  width: 100%;
   -ms-transform-origin: 0 0;
   -webkit-transform-origin: 0 0;
   -webkit-transform-style: preserve-3d;
   transform-origin: 0 0;
   transform-style: flat;
 }
-.noUi-connect {
-  height: 100%;
-  width: 100%;
-}
-.noUi-origin {
-  height: 10%;
-  width: 10%;
-}
 /* Offset direction
  */
 .noUi-txt-dir-rtl.noUi-horizontal .noUi-origin {
@@ -63,6 +56,7 @@
  * connect elements.
  */
 .noUi-vertical .noUi-origin {
+  top: -100%;
   width: 0;
 }
 .noUi-horizontal .noUi-origin {
@@ -103,7 +97,7 @@
   width: 28px;
   height: 34px;
   right: -6px;
-  top: -17px;
+  bottom: -17px;
 }
 .noUi-txt-dir-rtl.noUi-horizontal .noUi-handle {
   left: -17px;

data/app/controllers/pg_hero/home_controller.rb

@@ -46,11 +46,18 @@ module PgHero
 
       @transaction_id_danger = @database.transaction_id_danger(threshold: 1500000000)
 
-      @readable_sequences, @unreadable_sequences = @database.sequences.partition { |s| s[:readable] }
+      sequences, @sequences_timeout = rescue_timeout([]) { @database.sequences }
+      @readable_sequences, @unreadable_sequences = sequences.partition { |s| s[:readable] }
 
       @sequence_danger = @database.sequence_danger(threshold: (params[:sequence_threshold] || 0.9).to_f, sequences: @readable_sequences)
 
-      @indexes = @database.indexes
+      @indexes, @indexes_timeout =
+        if @sequences_timeout
+          # skip indexes for faster loading
+          [[], true]
+        else
+          rescue_timeout([]) { @database.indexes }
+        end
       @invalid_indexes = @database.invalid_indexes(indexes: @indexes)
       @invalid_constraints = @database.invalid_constraints
       @duplicate_indexes = @database.duplicate_indexes(indexes: @indexes)
@@ -80,7 +87,7 @@ module PgHero
       @days = (params[:days] || 7).to_i
       @database_size = @database.database_size
       @only_tables = params[:tables].present?
-      @relation_sizes = @only_tables ? @database.table_sizes : @database.relation_sizes
+      @relation_sizes, @sizes_timeout = rescue_timeout([]) { @only_tables ? @database.table_sizes : @database.relation_sizes }
       @space_stats_enabled = @database.space_stats_enabled? && !@only_tables
       if @space_stats_enabled
         space_growth = @database.space_growth(days: @days, relation_sizes: @relation_sizes)
@@ -157,8 +164,9 @@ module PgHero
           )
         end
 
-      @indexes = @database.indexes
-      set_suggested_indexes
+      if !@historical_query_stats_enabled || request.xhr?
+        set_suggested_indexes
+      end
 
       # fix back button issue with caching
       response.headers["Cache-Control"] = "must-revalidate, no-store, no-cache, private"
@@ -193,7 +201,8 @@ module PgHero
 
         if @tables.any?
           @row_counts = @database.table_stats(table: @tables).to_h { |i| [i[:table], i[:estimated_rows]] }
-          @indexes_by_table = @database.indexes.group_by { |i| i[:table] }
+          indexes, @indexes_timeout = rescue_timeout([]) { @database.indexes }
+          @indexes_by_table = indexes.group_by { |i| i[:table] }
         end
       else
         render_text "Unknown query", status: :not_found
@@ -395,6 +404,7 @@ module PgHero
       redirect_backward alert: "The database user does not have permission to enable query stats"
     end
 
+    # TODO disable if historical query stats enabled?
     def reset_query_stats
       success =
         if @database.server_version_num >= 120000
@@ -440,14 +450,18 @@ module PgHero
     end
 
     def set_suggested_indexes(min_average_time = 0, min_calls = 0)
+      if @database.suggested_indexes_enabled? && !@indexes
+        @indexes, @indexes_timeout = rescue_timeout([]) { @database.indexes }
+      end
+
       @suggested_indexes_by_query =
-        if @database.suggested_indexes_enabled?
-          @database.suggested_indexes_by_query(query_stats: @query_stats.select { |qs| qs[:average_time] >= min_average_time && qs[:calls] >= min_calls })
+        if !@indexes_timeout && @database.suggested_indexes_enabled?
+          @database.suggested_indexes_by_query(query_stats: @query_stats.select { |qs| qs[:average_time] >= min_average_time && qs[:calls] >= min_calls }, indexes: @indexes)
         else
           {}
         end
 
-      @suggested_indexes = @database.suggested_indexes(suggested_indexes_by_query: @suggested_indexes_by_query, indexes: @indexes)
+      @suggested_indexes = @database.suggested_indexes(suggested_indexes_by_query: @suggested_indexes_by_query)
       @query_stats_by_query = @query_stats.index_by { |q| q[:query] }
       @debug = params[:debug].present?
     end
@@ -495,5 +509,13 @@ module PgHero
         redirect_to root_path, alert: "Query stats not enabled"
       end
     end
+
+    # rescue QueryCanceled for case when
+    # statement timeout is less than lock timeout
+    def rescue_timeout(default)
+      [yield, false]
+    rescue ActiveRecord::LockWaitTimeout, ActiveRecord::QueryCanceled
+      [default, true]
+    end
   end
 end

data/app/helpers/pg_hero/home_helper.rb

@@ -12,8 +12,8 @@ module PgHero
       end
     end
 
-    def pghero_js_var(name, value)
-      "var #{name} = #{json_escape(value.to_json(root: false))};".html_safe
+    def pghero_js_value(value)
+      json_escape(value.to_json(root: false)).html_safe
     end
 
     def pghero_remove_index(query)

data/app/views/layouts/pg_hero/application.html.erb

@@ -7,7 +7,7 @@
     <%= favicon_link_tag "pghero/favicon.png" %>
     <% if defined?(Propshaft::Railtie) %>
       <%= stylesheet_link_tag "pghero/nouislider", "pghero/arduino-light", "pghero/application" %>
-      <%= javascript_include_tag "pghero/jquery", "pghero/nouislider", "pghero/Chart.bundle", "pghero/chartkick", "pghero/highlight.pack", "pghero/application" %>
+      <%= javascript_include_tag "pghero/jquery", "pghero/nouislider", "pghero/Chart.bundle", "pghero/chartkick", "pghero/highlight.min", "pghero/application" %>
     <% else %>
       <%= stylesheet_link_tag "pghero/application" %>
       <%= javascript_include_tag "pghero/application" %>

data/app/views/pg_hero/home/_query_stats_slider.html.erb

@@ -5,12 +5,12 @@
 </div>
 
 <script>
-  <%= pghero_js_var("sort", @sort) %>
-  <%= pghero_js_var("minAverageTime", @min_average_time) %>
-  <%= pghero_js_var("minCalls", @min_calls) %>
-  <%= pghero_js_var("debug", @debug) %>
-  <%= pghero_js_var("startAt", params[:start_at] ? @start_at.to_i * 1000 : nil) %>
-  <%= pghero_js_var("endAt", @end_at.to_i * 1000) %>
+  var sort = <%= pghero_js_value(@sort) %>;
+  var minAverageTime = <%= pghero_js_value(@min_average_time) %>;
+  var minCalls = <%= pghero_js_value(@min_calls) %>;
+  var debug = <%= pghero_js_value(@debug) %>;
+  var startAt = <%= pghero_js_value(params[:start_at] ? @start_at.to_i * 1000 : nil) %>;
+  var endAt = <%= pghero_js_value(@end_at.to_i * 1000) %>;
 
   initSlider();
 </script>

data/app/views/pg_hero/home/connections.html.erb

@@ -6,24 +6,24 @@
   <% if @total_connections > 0 %>
     <h3>By Database</h3>
 
-    <div id="chart-1" class="chart" style="height: 260px; line-height: 260px; margin-bottom: 20px;">Loading...</div>
+    <div id="chart-1" class="chart pie-chart">Loading...</div>
     <script>
-      new Chartkick.PieChart("chart-1", <%= json_escape(@connections_by_database.to_json).html_safe %>);
+      new Chartkick.PieChart("chart-1", <%= pghero_js_value(@connections_by_database) %>);
     </script>
 
     <h3>By User</h3>
 
-    <div id="chart-2" class="chart" style="height: 260px; line-height: 260px; margin-bottom: 20px;">Loading...</div>
+    <div id="chart-2" class="chart pie-chart">Loading...</div>
     <script>
-      new Chartkick.PieChart("chart-2", <%= json_escape(@connections_by_user.to_json).html_safe %>);
+      new Chartkick.PieChart("chart-2", <%= pghero_js_value(@connections_by_user) %>);
     </script>
 
     <% if @connections_by_ssl_status %>
       <h3>By Security</h3>
 
-      <div id="chart-3" class="chart" style="height: 260px; line-height: 260px; margin-bottom: 20px;">Loading...</div>
+      <div id="chart-3" class="chart pie-chart">Loading...</div>
       <script>
-        new Chartkick.PieChart("chart-3", <%= json_escape(@connections_by_ssl_status.to_json).html_safe %>);
+        new Chartkick.PieChart("chart-3", <%= pghero_js_value(@connections_by_ssl_status) %>);
       </script>
     <% end %>
 

data/app/views/pg_hero/home/index.html.erb

@@ -55,9 +55,11 @@
       Vacuuming healthy
     <% end %>
   </div>
-  <div class="alert alert-<%= @sequence_danger && @sequence_danger.empty? ? "success" : "warning" %>">
+  <div class="alert alert-<%= @sequence_danger && @sequence_danger.empty? && !@sequences_timeout ? "success" : "warning" %>">
     <% if @sequence_danger.any? %>
       <%= pluralize(@sequence_danger.size, "column") %> approaching overflow
+    <% elsif @sequences_timeout %>
+      Sequences not available (system catalog locked)
     <% else %>
       No columns near integer overflow
     <% end %>

data/app/views/pg_hero/home/queries.html.erb

@@ -1,9 +1,11 @@
 <div class="content">
-  <% if @query_stats_enabled %>
+  <% if @query_stats_enabled && !@historical_query_stats_enabled %>
     <%= button_to "Reset", reset_query_stats_path, class: "btn btn-danger", style: "float: right;" %>
   <% end %>
 
-  <h1 style="float: left;">Queries</h1>
+  <% if !@historical_query_stats_enabled %>
+    <h1 style="float: left;">Queries</h1>
+  <% end %>
 
   <% if @historical_query_stats_enabled %>
     <%= render partial: "query_stats_slider" %>

data/app/views/pg_hero/home/relation_space.html.erb

@@ -9,6 +9,6 @@
   <h1>Size</h1>
   <div id="chart-1" class="chart" style="margin-bottom: 20px;">Loading...</div>
   <script>
-    new Chartkick.LineChart("chart-1", <%= json_escape(@chart_data.to_json).html_safe %>, {colors: ["#5bc0de"], legend: false, min: null, bytes: true, library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
+    new Chartkick.LineChart("chart-1", <%= pghero_js_value(@chart_data) %>, {colors: ["#5bc0de"], legend: false, min: null, bytes: true, library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
   </script>
 </div>

data/app/views/pg_hero/home/show_query.html.erb

@@ -49,19 +49,19 @@
     <h1>Total Time <small>ms</small></h1>
     <div id="chart-1" class="chart" style="margin-bottom: 20px;">Loading...</div>
     <script>
-      new Chartkick.LineChart("chart-1", <%= json_escape(@chart_data.to_json).html_safe %>, {colors: ["#5bc0de"], legend: false, library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
+      new Chartkick.LineChart("chart-1", <%= pghero_js_value(@chart_data) %>, {colors: ["#5bc0de"], legend: false, library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
     </script>
 
     <h1>Average Time <small>ms</small></h1>
     <div id="chart-2" class="chart" style="margin-bottom: 20px;">Loading...</div>
     <script>
-      new Chartkick.LineChart("chart-2", <%= json_escape(@chart2_data.to_json).html_safe %>, {colors: ["#5bc0de"], legend: false, library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
+      new Chartkick.LineChart("chart-2", <%= pghero_js_value(@chart2_data) %>, {colors: ["#5bc0de"], legend: false, library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
     </script>
 
     <h1>Calls</h1>
     <div id="chart-3" class="chart" style="margin-bottom: 20px;">Loading...</div>
     <script>
-      new Chartkick.LineChart("chart-3", <%= json_escape(@chart3_data.to_json).html_safe %>, {colors: ["#5bc0de"], legend: false, library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
+      new Chartkick.LineChart("chart-3", <%= pghero_js_value(@chart3_data) %>, {colors: ["#5bc0de"], legend: false, library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
     </script>
   <% else %>
     <p>
@@ -88,15 +88,19 @@
             <td><%= table %></td>
             <td><%= @row_counts[table] %></td>
             <td>
-              <ul>
-                <% @indexes_by_table[table].to_a.sort_by { |i| [i[:primary] ? 0 : 1, i[:columns]] }.each do |i3| %>
-                  <li>
-                    <%= i3[:columns].join(", ") %><% if i3[:using] != "btree" %>
-                    <%= i3[:using].to_s.upcase %><% end %>
-                    <% if i3[:primary] %> PRIMARY<% elsif i3[:unique] %> UNIQUE<% end %>
-                  </li>
-                <% end %>
-              </ul>
+              <% if @indexes_timeout %>
+                Not available
+              <% else %>
+                <ul>
+                  <% @indexes_by_table[table].to_a.sort_by { |i| [i[:primary] ? 0 : 1, i[:columns]] }.each do |i3| %>
+                    <li>
+                      <%= i3[:columns].join(", ") %><% if i3[:using] != "btree" %>
+                      <%= i3[:using].to_s.upcase %><% end %>
+                      <% if i3[:primary] %> PRIMARY<% elsif i3[:unique] %> UNIQUE<% end %>
+                    </li>
+                  <% end %>
+                </ul>
+              <% end %>
             </td>
           </tr>
         <% end %>

data/app/views/pg_hero/home/space.html.erb

@@ -6,7 +6,7 @@
   <% if @system_stats_enabled %>
     <div id="chart-1" class="chart" style="margin-bottom: 20px;">Loading...</div>
     <script>
-      new Chartkick.LineChart("chart-1", <%= json_escape(free_space_stats_path.to_json).html_safe %>, {colors: ["#5bc0de"], bytes: true, library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
+      new Chartkick.LineChart("chart-1", <%= pghero_js_value(free_space_stats_path) %>, {colors: ["#5bc0de"], bytes: true, library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
     </script>
   <% end %>
 
@@ -37,47 +37,51 @@
     </div>
   <% end %>
 
-  <table class="table space-table">
-    <thead>
-      <tr>
-        <th><%= link_to (@only_tables ? "Table" : "Relation"), @header_options.merge(sort: "name") %></th>
-        <th style="width: 15%;"><%= link_to "Size", @header_options %></th>
-        <% if @space_stats_enabled %>
-          <th style="width: 15%;"><%= link_to "#{@days}d Growth", @header_options.merge(sort: "growth") %></th>
-        <% end %>
-      </tr>
-    </thead>
-    <tbody>
-      <% @relation_sizes.each do |query| %>
+  <% if @sizes_timeout %>
+    <p>Breakdown not available (system catalog locked)</p>
+  <% else %>
+    <table class="table space-table">
+      <thead>
         <tr>
-          <td style="<%= query[:type] == "index" ? "font-style: italic;" : "" %>">
-            <span style="word-break: break-all;">
-              <% name = query[:relation] || query[:table] %>
-              <% if @space_stats_enabled %>
-                <%= link_to name, relation_space_path(name, schema: query[:schema]), target: "_blank", style: "color: inherit;" %>
-              <% else %>
-                <%= name %>
-              <% end %>
-            </span>
-            <% if query[:schema] != "public" %>
-              <span class="text-muted"><%= query[:schema] %></span>
-            <% end %>
-            <% if @unused_index_names.include?(query[:relation]) %>
-              <span class="unused-index">UNUSED</span>
-            <% end %>
-          </td>
-          <td><%= query[:size] %></td>
+          <th><%= link_to (@only_tables ? "Table" : "Relation"), @header_options.merge(sort: "name") %></th>
+          <th style="width: 15%;"><%= link_to "Size", @header_options %></th>
           <% if @space_stats_enabled %>
-            <td>
-              <% if @growth_bytes_by_relation[[query[:schema], query[:relation]]] %>
-                <% if @growth_bytes_by_relation[[query[:schema], query[:relation]]] < 0 %>-<% end %><%= PgHero.pretty_size(@growth_bytes_by_relation[[query[:schema], query[:relation]]].abs) %>
-              <% else %>
-                <span class="text-muted">Unknown</span>
-              <% end %>
-            </td>
+            <th style="width: 15%;"><%= link_to "#{@days}d Growth", @header_options.merge(sort: "growth") %></th>
           <% end %>
         </tr>
-      <% end %>
-    </tbody>
-  </table>
+      </thead>
+      <tbody>
+        <% @relation_sizes.each do |query| %>
+          <tr>
+            <td style="<%= query[:type] == "index" ? "font-style: italic;" : "" %>">
+              <span style="word-break: break-all;">
+                <% name = query[:relation] || query[:table] %>
+                <% if @space_stats_enabled %>
+                  <%= link_to name, relation_space_path(name, schema: query[:schema]), target: "_blank", style: "color: inherit;" %>
+                <% else %>
+                  <%= name %>
+                <% end %>
+              </span>
+              <% if query[:schema] != "public" %>
+                <span class="text-muted"><%= query[:schema] %></span>
+              <% end %>
+              <% if @unused_index_names.include?(query[:relation]) %>
+                <span class="unused-index">UNUSED</span>
+              <% end %>
+            </td>
+            <td><%= query[:size] %></td>
+            <% if @space_stats_enabled %>
+              <td>
+                <% if @growth_bytes_by_relation[[query[:schema], query[:relation]]] %>
+                  <% if @growth_bytes_by_relation[[query[:schema], query[:relation]]] < 0 %>-<% end %><%= PgHero.pretty_size(@growth_bytes_by_relation[[query[:schema], query[:relation]]].abs) %>
+                <% else %>
+                  <span class="text-muted">Unknown</span>
+                <% end %>
+              </td>
+            <% end %>
+          </tr>
+        <% end %>
+      </tbody>
+    </table>
+  <% end %>
 </div>

data/app/views/pg_hero/home/system.html.erb

@@ -1,34 +1,34 @@
 <div class="content">
   <p id="periods">
     <% @periods.each do |name, options| %>
-      <%= link_to name, system_path(options) %>
+      <%= link_to name, system_path(params: options) %>
     <% end %>
   </p>
-  <% path_options = {duration: @duration, period: @period} %>
+  <% path_options = {params: {duration: @duration, period: @period}} %>
 
   <h1>CPU</h1>
   <div id="chart-1" class="chart" style="margin-bottom: 20px;">Loading...</div>
   <script>
-    new Chartkick.LineChart("chart-1", <%= json_escape(cpu_usage_path(path_options).to_json).html_safe %>, {max: 100, colors: ["#5bc0de"], suffix: "%", library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
+    new Chartkick.LineChart("chart-1", <%= pghero_js_value(cpu_usage_path(path_options)) %>, {max: 100, colors: ["#5bc0de"], suffix: "%", library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
   </script>
 
   <h1>Load</h1>
   <div id="chart-2" class="chart" style="margin-bottom: 20px;">Loading...</div>
   <script>
-    new Chartkick.LineChart("chart-2", <%= json_escape(load_stats_path(path_options).to_json).html_safe %>, {colors: ["#5bc0de", "#d9534f"], library: {plugins: {tooltip: {intersect: false, mode: "nearest"}}}})
+    new Chartkick.LineChart("chart-2", <%= pghero_js_value(load_stats_path(path_options)) %>, {colors: ["#5bc0de", "#d9534f"], library: {plugins: {tooltip: {intersect: false, mode: "nearest"}}}})
   </script>
 
   <h1>Connections</h1>
   <div id="chart-3" class="chart" style="margin-bottom: 20px;">Loading...</div>
   <script>
-    new Chartkick.LineChart("chart-3", <%= json_escape(connection_stats_path(path_options).to_json).html_safe %>, {colors: ["#5bc0de"], library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
+    new Chartkick.LineChart("chart-3", <%= pghero_js_value(connection_stats_path(path_options)) %>, {colors: ["#5bc0de"], library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
   </script>
 
   <% if @database.replica? %>
     <h1>Replication Lag</h1>
     <div id="chart-4" class="chart" style="margin-bottom: 20px;">Loading...</div>
     <script>
-      new Chartkick.LineChart("chart-4", <%= json_escape(replication_lag_stats_path(path_options).to_json).html_safe %>, {colors: ["#5bc0de"], library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
+      new Chartkick.LineChart("chart-4", <%= pghero_js_value(replication_lag_stats_path(path_options)) %>, {colors: ["#5bc0de"], library: {plugins: {tooltip: {intersect: false, mode: "index"}}}})
     </script>
   <% end %>
 </div>

data/lib/generators/pghero/query_stats_generator.rb

@@ -1,3 +1,4 @@
+require "rails/generators"
 require "rails/generators/active_record"
 
 module Pghero

data/lib/generators/pghero/space_stats_generator.rb

@@ -1,3 +1,4 @@
+require "rails/generators"
 require "rails/generators/active_record"
 
 module Pghero

data/lib/pghero/engine.rb

@@ -5,7 +5,7 @@ module PgHero
     initializer "pghero", group: :all do |app|
       # check if Rails api mode
       if app.config.respond_to?(:assets)
-        if defined?(Sprockets) && Sprockets::VERSION >= "4"
+        if defined?(Sprockets) && Sprockets::VERSION.to_i >= 4
           app.config.assets.precompile << "pghero/application.js"
           app.config.assets.precompile << "pghero/application.css"
           app.config.assets.precompile << "pghero/favicon.png"

data/lib/pghero/methods/basic.rb

@@ -112,15 +112,8 @@ module PgHero
         ::PgHero::Stats.connection
       end
 
-      def insert_stats(table, columns, values)
-        values = values.map { |v| "(#{v.map { |v2| quote(v2) }.join(",")})" }.join(",")
-        columns = columns.map { |v| quote_table_name(v) }.join(",")
-        stats_connection.execute("INSERT INTO #{quote_table_name(table)} (#{columns}) VALUES #{values}")
-      end
-
-      # from ActiveSupport
       def squish(str)
-        str.to_s.gsub(/\A[[:space:]]+/, "").gsub(/[[:space:]]+\z/, "").gsub(/[[:space:]]+/, " ")
+        str.to_s.squish
       end
 
       def add_source(sql)
@@ -135,6 +128,10 @@ module PgHero
         connection.quote_table_name(value)
       end
 
+      def quote_column_name(value)
+        connection.quote_column_name(value)
+      end
+
       def unquote(part)
         if part && part.start_with?('"')
           part[1..-2]

data/lib/pghero/methods/connections.rb

@@ -3,7 +3,7 @@ module PgHero
     module Connections
       def connections
         if server_version_num >= 90500
-          select_all <<-SQL
+          select_all <<~SQL
             SELECT
               pg_stat_activity.pid,
               datname AS database,
@@ -20,7 +20,7 @@ module PgHero
               pg_stat_activity.pid
           SQL
         else
-          select_all <<-SQL
+          select_all <<~SQL
             SELECT
               pid,
               datname AS database,
@@ -41,7 +41,7 @@ module PgHero
       end
 
       def connection_states
-        states = select_all <<-SQL
+        states = select_all <<~SQL
           SELECT
             state,
             COUNT(*) AS connections
@@ -57,7 +57,7 @@ module PgHero
       end
 
       def connection_sources
-        select_all <<-SQL
+        select_all <<~SQL
           SELECT
             datname AS database,
             usename AS user,

data/lib/pghero/methods/constraints.rb

@@ -4,7 +4,7 @@ module PgHero
       # referenced fields can be nil
       # as not all constraints are foreign keys
       def invalid_constraints
-        select_all <<-SQL
+        select_all <<~SQL
           SELECT
             nsp.nspname AS schema,
             rel.relname AS table,

data/lib/pghero/methods/indexes.rb

@@ -2,7 +2,7 @@ module PgHero
   module Methods
     module Indexes
       def index_hit_rate
-        select_one <<-SQL
+        select_one <<~SQL
           SELECT
             (sum(idx_blks_hit)) / nullif(sum(idx_blks_hit + idx_blks_read), 0) AS rate
           FROM
@@ -11,7 +11,7 @@ module PgHero
       end
 
       def index_caching
-        select_all <<-SQL
+        select_all <<~SQL
           SELECT
             schemaname AS schema,
             relname AS table,
@@ -29,7 +29,7 @@ module PgHero
       end
 
       def index_usage
-        select_all <<-SQL
+        select_all <<~SQL
           SELECT
             schemaname AS schema,
             relname AS table,
@@ -47,7 +47,7 @@ module PgHero
       end
 
       def missing_indexes
-        select_all <<-SQL
+        select_all <<~SQL
           SELECT
             schemaname AS schema,
             relname AS table,
@@ -69,7 +69,7 @@ module PgHero
       end
 
       def unused_indexes(max_scans: 50, across: [])
-        result = select_all_size <<-SQL
+        result = select_all_size <<~SQL
           SELECT
             schemaname AS schema,
             relname AS table,
@@ -104,7 +104,7 @@ module PgHero
       end
 
       def last_stats_reset_time
-        select_one <<-SQL
+        select_one <<~SQL
           SELECT
             pg_stat_get_db_stat_reset_time(oid) AS reset_time
           FROM
@@ -126,7 +126,7 @@ module PgHero
       # TODO parse array properly
       # https://stackoverflow.com/questions/2204058/list-columns-with-indexes-in-postgresql
       def indexes
-        indexes = select_all(<<-SQL
+        indexes = select_all(<<~SQL
           SELECT
             schemaname AS schema,
             t.relname AS table,
@@ -186,7 +186,7 @@ module PgHero
       # thanks @jberkus and @mbanck
       def index_bloat(min_size: nil)
         min_size ||= index_bloat_bytes
-        select_all <<-SQL
+        select_all <<~SQL
           WITH btree_index_atts AS (
             SELECT
               nspname, relname, reltuples, relpages, indrelid, relam,