pghero 1.7.0 → 2.0.0

data/app/helpers/pg_hero/base_helper.rb

@@ -0,0 +1,15 @@
+module PgHero
+  module BaseHelper
+    def pghero_pretty_ident(table, schema: nil)
+      ident = table
+      if schema && schema != "public"
+        indent = "#{schema}.#{table}"
+      end
+      if ident =~ /\A[a-z0-9_]+\z/
+        ident
+      else
+        @database.quote_ident(ident)
+      end
+    end
+  end
+end

data/app/views/layouts/pg_hero/application.html.erb

@@ -51,7 +51,7 @@
             <ul class="nav">
               <% @databases.each do |database| %>
                 <li class="<%= ("active-database" if @database.id == database.id) %>">
-                  <%= link_to database.name, database: database.id %>
+                  <%= link_to database.name, action_name == "show_query" ? root_path(database: database.id) : {database: database.id} %>
                 </li>
               <% end %>
             </ul>

data/app/views/pg_hero/home/_connections_table.html.erb

@@ -8,8 +8,8 @@
   <tbody>
     <% connection_sources.each do |source| %>
       <tr>
-        <td><%= source["source"] %> <div class="text-muted"><%= [source["user"], source["database"], source["ip"]].compact.join(" - ") %></div></td>
-        <td><%= number_with_delimiter(source["total_connections"]) %></td>
+        <td><%= source[:source] %> <div class="text-muted"><%= [source[:user], source[:database], source[:ip]].compact.join(" - ") %></div></td>
+        <td><%= number_with_delimiter(source[:total_connections]) %></td>
       </tr>
     <% end %>
   </tbody>

data/app/views/pg_hero/home/_live_queries_table.html.erb

@@ -10,21 +10,25 @@
   <tbody>
     <% queries.reverse.each do |query| %>
       <tr>
-        <td><%= query["pid"] %></td>
-        <td><%= number_with_delimiter(query["duration_ms"].to_f.round) %> ms</td>
-        <td><%= query["state"] %></td>
+        <td><%= query[:pid] %></td>
+        <td><%= number_with_delimiter(query[:duration_ms].round) %> ms</td>
+        <td><%= query[:state] %></td>
         <td class="text-right">
-          <% button_path, button_options = Rails.version >= "4.1" ? [explain_path, {params: {query: query["query"]}}] : [explain_path(query: query["query"]), {}] %>
+          <% button_path, button_options = Rails.version >= "4.1" ? [explain_path, {params: {query: query[:query]}}] : [explain_path(query: query[:query]), {}] %>
           <%= button_to "Explain", button_path, button_options.merge(form: {target: "_blank"}, class: "btn btn-info") %>
-          <%= button_to "Kill", kill_path(pid: query["pid"]), class: "btn btn-danger" %>
+          <%= button_to "Kill", kill_path(pid: query[:pid]), class: "btn btn-danger" %>
         </td>
       </tr>
       <tr>
         <td colspan="6" style="border-top: none; padding: 0;">
-          <%= query["source"] %> <span class="text-muted"><%= query["user"] %></span>
-          <pre><%= query["query"] %></pre>
+          <%= query[:source] %> <span class="text-muted"><%= query[:user] %></span>
+          <pre style="margin-top: 1em;"><code><%= query[:query] %></code></pre>
         </td>
       </tr>
     <% end %>
   </tbody>
 </table>
+
+<script>
+  highlightQueries();
+</script>

data/app/views/pg_hero/home/_queries_table.html.erb

@@ -25,9 +25,9 @@
     <% queries.each do |query| %>
       <tr>
         <td>
-          <%= number_with_delimiter(query["total_minutes"].to_f.round) %> min
+          <%= number_with_delimiter(query[:total_minutes].round) %> min
           <span class="percent">
-            <% percent = query["total_percent"].to_f %>
+            <% percent = query[:total_percent] %>
             <% if percent > 1 %>
               <%= percent.round %>%
             <% elsif percent > 0.1 %>
@@ -37,21 +37,32 @@
             <% end %>
           </span>
         </td>
-        <td><%= number_with_delimiter(query["average_time"].to_f.round) %> ms</td>
         <td>
-          <%= number_with_delimiter(query["calls"].to_i) %>
-          <% if query["user"] %>
-            <span class="user"><%= query["user"] %></span>
-          <% end %>
+          <%= number_with_delimiter(query[:average_time].round) %> ms
+        </td>
+        <td>
+          <%= number_with_delimiter(query[:calls]) %>
+
+          <span class="user">
+            <% if query[:user] %>
+              <%= query[:user] %>
+              <% if @show_details %>
+                &middot;
+              <% end %>
+            <% end %>
+            <% if @show_details %>
+              <%= link_to "details", show_query_path(query[:query_hash]), target: "_blank" %>
+            <% end %>
+          </span>
         </td>
       </tr>
       <tr>
         <td colspan="3" style="border-top: none; padding: 0;">
-          <code><pre style="max-height: 230px; overflow: hidden;" onclick="this.style.maxHeight = 'none';"><%= query["query"] %></pre></code>
-          <% if query["query"] == "<insufficient privilege>" %>
+          <pre><code style="max-height: 230px; overflow: hidden;" onclick="this.style.maxHeight = 'none';"><%= query[:query] %></code></pre>
+          <% if query[:query] == "<insufficient privilege>" %>
             <p class="text-muted">For security reasons, only superusers can see queries executed by other users.</p>
           <% end %>
-          <% if local_assigns[:suggested_indexes] != false && (details = @suggested_indexes_by_query[query["query"]]) %>
+          <% if local_assigns[:suggested_indexes] != false && (details = @suggested_indexes_by_query[query[:query]]) && (details[:index] || @debug) %>
             <%= render partial: "suggested_index", locals: {index: details[:index], details: details} %>
           <% end %>
         </td>

data/app/views/pg_hero/home/_suggested_index.html.erb

@@ -13,6 +13,6 @@ Row estimates
 <%= details[:row_estimates].to_a.map { |k, v| "- #{k}: #{v}" }.join("\n") %><% end %><% if details[:table_indexes] %>
 
 Existing indexes
-<% details[:table_indexes].sort_by { |i| [PgHero.truthy?(i["primary"]) ? 0 : 1, i["columns"]] }.each do |i3| %>- <%= i3["columns"].join(", ") %><% if i3["using"] != "btree" %> <%= i3["using"].to_s.upcase %><% end %><% if PgHero.truthy?(i3["primary"]) %> PRIMARY<% elsif PgHero.truthy?(i3["unique"]) %> UNIQUE<% end %>
+<% details[:table_indexes].sort_by { |i| [i[:primary] ? 0 : 1, i[:columns]] }.each do |i3| %>- <%= i3[:columns].join(", ") %><% if i3[:using] != "btree" %> <%= i3[:using].to_s.upcase %><% end %><% if i3[:primary] %> PRIMARY<% elsif i3[:unique] %> UNIQUE<% end %>
 <% end %><% end %></pre></code>
 </div>

data/app/views/pg_hero/home/connections.html.erb

@@ -6,28 +6,16 @@
   <% if @total_connections > 0 %>
     <h3>By Database</h3>
 
-    <% top_connections = Hash.new(0) %>
-    <% @connection_sources.each do |source| %>
-      <% top_connections[source["database"]] += source["total_connections"].to_i %>
-    <% end %>
-    <% top_connections = top_connections.sort_by { |k, v| [-v, k] } %>
-
     <div id="chart-1" class="chart" style="height: 260px; line-height: 260px; margin-bottom: 20px;">Loading...</div>
     <script>
-      new Chartkick.PieChart("chart-1", <%= json_escape(top_connections.to_json).html_safe %>);
+      new Chartkick.PieChart("chart-1", <%= json_escape(@connections_by_database.to_json).html_safe %>);
     </script>
 
     <h3>By User</h3>
 
-    <% top_connections = Hash.new(0) %>
-    <% @connection_sources.each do |source| %>
-      <% top_connections[source["user"]] += source["total_connections"].to_i %>
-    <% end %>
-    <% top_connections = top_connections.sort_by { |k, v| [-v, k] } %>
-
     <div id="chart-2" class="chart" style="height: 260px; line-height: 260px; margin-bottom: 20px;">Loading...</div>
     <script>
-      new Chartkick.PieChart("chart-2", <%= json_escape(top_connections.to_json).html_safe %>);
+      new Chartkick.PieChart("chart-2", <%= json_escape(@connections_by_user.to_json).html_safe %>);
     </script>
 
     <%= render partial: "connections_table", locals: {connection_sources: @connection_sources} %>

data/app/views/pg_hero/home/explain.html.erb

@@ -14,7 +14,7 @@
     <% if @visualize %>
       <p>Paste the output below into the <%= link_to "Postgres Explain Visualizer", "http://tatiyants.com/pev/#/plans/new", target: "_blank" %></p>
     <% end %>
-    <pre><%= @explanation %></pre>
+    <pre><code><%= @explanation %></code></pre>
     <% unless @visualize %>
       <p><%= link_to "See how to interpret this", "http://www.postgresql.org/docs/current/static/using-explain.html", target: "_blank" %></p>
     <% end %>

data/app/views/pg_hero/home/index.html.erb

@@ -8,6 +8,10 @@
       <% end %>
       <span class="tiny"><%= number_with_delimiter((@replication_lag * 1000).round) %> ms</span>
     </div>
+  <% elsif @inactive_replication_slots.any? %>
+    <div class="alert alert-warning">
+      <%= pluralize(@inactive_replication_slots.size, "inactive replication slot") %>
+    </div>
   <% end %>
   <div class="alert alert-<%= @long_running_queries.empty? ? "success" : "warning" %>">
     <% if @long_running_queries.any? %>
@@ -103,6 +107,29 @@
   </div>
 <% end %>
 
+<% if @inactive_replication_slots && @inactive_replication_slots.any? %>
+  <div class="content">
+    <h1>Inactive Replication Slots</h1>
+    <p>Inactive replication slots can cause a lot of disk space to be consumed.</p>
+    <p>For each, run:</p>
+    <pre><code>SELECT pg_drop_replication_slot('slot_name');</code></pre>
+    <table class="table">
+      <thead>
+        <tr>
+          <th>Name</th>
+        </tr>
+      </thead>
+      <tbody>
+        <% @inactive_replication_slots.each do |slot| %>
+          <tr>
+            <td><%= slot[:slot_name] %></td>
+          </tr>
+        <% end %>
+      </tbody>
+    </table>
+  </div>
+<% end %>
+
 <% if @long_running_queries.any? %>
   <div class="content">
     <%= button_to "Kill All", kill_long_running_queries_path, class: "btn btn-danger", style: "float: right;" %>
@@ -136,7 +163,7 @@
 
     <p><%= link_to "Use connection pooling", "http://www.craigkerstiens.com/2014/05/22/on-connection-pooling/", target: "_blank" %> for better performance. <%= link_to "PgBouncer", "https://wiki.postgresql.org/wiki/PgBouncer", target: "_blank" %> is a solid option.</p>
 
-    <%= render partial: "connections_table", locals: {connection_sources: @database.connection_sources(by_database_and_user: true).first(10)} %>
+    <%= render partial: "connections_table", locals: {connection_sources: @database.connection_sources.first(10)} %>
   </div>
 <% end %>
 
@@ -145,7 +172,7 @@
     <h2>Vacuuming Needed</h2>
     <p>The database <strong>will shutdown</strong> when there are fewer than 1,000,000 transactions left. <%= link_to "Read more", "http://www.postgresql.org/docs/9.1/static/routine-vacuuming.html#VACUUM-FOR-WRAPAROUND", target: "_blank" %>.</p>
     <p>For each table, run:</p>
-    <code><pre>VACUUM FREEZE VERBOSE table;</pre></code>
+    <pre><code>VACUUM FREEZE VERBOSE table;</code></pre>
     <table class="table">
       <thead>
         <tr>
@@ -156,8 +183,13 @@
       <tbody>
         <% @transaction_id_danger.each do |query| %>
           <tr>
-            <td><%= query["table"] %></td>
-            <td><%= number_with_delimiter(query["transactions_before_shutdown"]) %></td>
+            <td>
+              <%= query[:table] %>
+              <% if query[:schema] != "public" %>
+                <span class="text-muted"><%= query[:schema] %></span>
+              <% end %>
+            </td>
+            <td><%= number_with_delimiter(query[:transactions_left]) %></td>
           </tr>
         <% end %>
       </tbody>
@@ -179,19 +211,19 @@
         </tr>
       </thead>
       <tbody>
-        <% @sequence_danger.sort_by { |s| [s["table"], s["column"]] }.each do |query| %>
+        <% @sequence_danger.sort_by { |s| [s[:table], s[:column]] }.each do |query| %>
           <tr>
             <td>
-              <%= query["table"] %>.<%= query["column"] %>
+              <%= query[:table] %>.<%= query[:column] %>
             </td>
             <td>
-              <%= query["column_type"] %>
+              <%= query[:column_type] %>
             </td>
             <td>
-              <%= number_with_delimiter(query["max_value"].to_i - query["last_value"].to_i) %>
+              <%= number_with_delimiter(query[:max_value] - query[:last_value]) %>
             </td>
             <td>
-              <%= number_to_percentage((query["max_value"].to_i - query["last_value"].to_i) * 100.0 / query["max_value"].to_i, precision: 2, significant: true) %>
+              <%= number_to_percentage((query[:max_value] - query[:last_value]) * 100.0 / query[:max_value], precision: 2, significant: true) %>
             </td>
           </tr>
         <% end %>
@@ -213,9 +245,9 @@
         </tr>
       </thead>
       <tbody>
-        <% @invalid_indexes.each do |query| %>
+        <% @invalid_indexes.each do |index| %>
           <tr>
-            <td><%= query["index"] %></td>
+            <td><%= index[:name] %></td>
           </tr>
         <% end %>
       </tbody>
@@ -239,10 +271,10 @@
       <pre>rails g migration remove_unneeded_indexes</pre>
       <p>And paste</p>
       <pre style="overflow: scroll; white-space: pre; word-break: normal;"><% @duplicate_indexes.each do |query| %>
-remove_index <%= query["unneeded_index"]["table"].to_sym.inspect %>, name: <%= query["unneeded_index"]["name"].to_s.inspect %><% end %></pre>
+remove_index <%= query[:unneeded_index][:table].to_sym.inspect %>, name: <%= query[:unneeded_index][:name].to_s.inspect %><% end %></pre>
     </div>
 
-    <table class="table">
+    <table class="table duplicate-indexes">
       <thead>
         <tr>
           <th>Details</th>
@@ -250,14 +282,14 @@ remove_index <%= query["unneeded_index"]["table"].to_sym.inspect %>, name: <%= q
       </thead>
       <tbody>
         <% @duplicate_indexes.each do |index| %>
-          <% unneeded_index = index["unneeded_index"] %>
-          <% covering_index = index["covering_index"] %>
+          <% unneeded_index = index[:unneeded_index] %>
+          <% covering_index = index[:covering_index] %>
           <tr>
-            <td style="padding-top: 15px; padding-bottom: 5px;">
-              On <%= unneeded_index["table"] %>
-              <pre><%= unneeded_index["name"] %> (<%= unneeded_index["columns"].join(", ") %>)</pre>
+            <td>
+              On <%= unneeded_index[:table] %>
+              <pre><%= unneeded_index[:name] %> (<%= unneeded_index[:columns].join(", ") %>)</pre>
               is covered by
-              <pre><%= covering_index["name"] %> (<%= covering_index["columns"].join(", ") %>)</pre>
+              <pre><%= covering_index[:name] %> (<%= covering_index[:columns].join(", ") %>)</pre>
             </td>
           </tr>
         <% end %>
@@ -343,7 +375,7 @@ pg_stat_statements.track = all</pre>
       <pre>rails g migration remove_unused_indexes</pre>
       <p>And paste</p>
       <pre style="overflow: scroll; white-space: pre; word-break: normal;"><% @unused_indexes.each do |query| %>
-remove_index <%= query["table"].to_sym.inspect %>, name: <%= query["index"].to_s.inspect %><% end %></pre>
+remove_index <%= query[:table].to_sym.inspect %>, name: <%= query[:index].to_s.inspect %><% end %></pre>
     </div>
 
     <table class="table">
@@ -356,11 +388,15 @@ remove_index <%= query["table"].to_sym.inspect %>, name: <%= query["index"].to_s
       <tbody>
         <% @unused_indexes.each do |query| %>
           <tr>
-            <td><%= query["index"] %><div class="text-muted">on <%= query["table"] %></div></td>
-            <td><%= query["index_size"] %></td>
+            <td><%= query[:index] %><div class="text-muted">on <%= query[:table] %></div></td>
+            <td><%= query[:size] %></td>
           </tr>
         <% end %>
       </tbody>
     </table>
   </div>
 <% end %>
+
+<script>
+  highlightQueries();
+</script>

data/app/views/pg_hero/home/index_bloat.html.erb

@@ -0,0 +1,69 @@
+<div class="content">
+  <h1>Index Bloat</h1>
+
+  <% if @index_bloat.any? %>
+
+    <p>Indexes can become <%= link_to "bloated over time", "https://www.compose.com/articles/postgresql-bloat-origins-monitoring-and-managing/", target: "_blank" %>. Recreate them to remove bloat.</p>
+
+    <p>For each index, run:</p>
+    <pre><code>CREATE INDEX CONCURRENTLY new_index ...;
+ANALYZE table;
+DROP INDEX CONCURRENTLY index;
+ANALYZE table;
+ALTER INDEX new_index RENAME TO index;</code></pre>
+
+    <p>
+      <% if @show_sql %>
+        <%= link_to "Hide SQL", {} %>
+      <% else %>
+        <%= link_to "Show SQL", {sql: "t"} %>
+      <% end %>
+      for each index
+    </p>
+
+    <table class="table">
+      <thead>
+        <tr>
+          <th>Index</th>
+          <th style="width: 15%;">Bloat</th>
+          <th style="width: 15%;">Size</th>
+        </tr>
+      </thead>
+      <tbody>
+        <% @index_bloat.each do |index| %>
+          <tr>
+            <td>
+              <span style="word-break: break-all;"><%= index[:index] %></span>
+            </td>
+            <td><%= PgHero.pretty_size(index[:bloat_bytes]) %></td>
+            <td><%= PgHero.pretty_size(index[:index_bytes]) %></td>
+          </tr>
+          <% if @show_sql %>
+            <tr>
+              <td colspan="3" style="border-top: none; padding: 0;">
+                <% new_index = "new_#{index[:index]}".first(63) %>
+                <pre><code><%= index[:definition].sub(" INDEX ", " INDEX CONCURRENTLY \n    ").sub(index[:index], new_index) %>;
+
+ANALYZE <%= pghero_pretty_ident(index[:table], schema: index[:schema]) %>;
+
+DROP INDEX CONCURRENTLY
+    <%= pghero_pretty_ident(index[:index]) %>;
+
+ANALYZE <%= pghero_pretty_ident(index[:table], schema: index[:schema]) %>;
+
+ALTER INDEX <%= pghero_pretty_ident(new_index) %>
+    RENAME TO <%= pghero_pretty_ident(index[:index]) %>;</code></pre>
+              </td>
+            </tr>
+          <% end %>
+        <% end %>
+      </tbody>
+    </table>
+  <% else %>
+    <p>No significant index bloat!</p>
+  <% end %>
+</div>
+
+<script>
+  highlightQueries();
+</script>

data/app/views/pg_hero/home/maintenance.html.erb

@@ -13,23 +13,23 @@
       <% @maintenance_info.each do |table| %>
         <tr>
           <td>
-            <%= table["table"] %>
-            <% if table["schema"] != "public" %>
-              <span class="text-muted"><%= table["schema"] %></span>
+            <%= table[:table] %>
+            <% if table[:schema] != "public" %>
+              <span class="text-muted"><%= table[:schema] %></span>
             <% end %>
           </td>
           <td>
-            <% time = [table["last_autovacuum"], table["last_vacuum"]].compact.max %>
+            <% time = [table[:last_autovacuum], table[:last_vacuum]].compact.max %>
             <% if time %>
-              <%= @time_zone.parse(time).strftime("%-m/%-e %l:%M %P") %>
+              <%= time.in_time_zone(@time_zone).strftime("%-m/%-e %l:%M %P") %>
             <% else %>
               <span class="text-muted">Unknown</span>
             <% end %>
           </td>
           <td>
-            <% time = [table["last_autoanalyze"], table["last_analyze"]].compact.max %>
+            <% time = [table[:last_autoanalyze], table[:last_analyze]].compact.max %>
             <% if time %>
-              <%= @time_zone.parse(time).strftime("%-m/%-e %l:%M %P") %>
+              <%= time.in_time_zone(@time_zone).strftime("%-m/%-e %l:%M %P") %>
             <% else %>
               <span class="text-muted">Unknown</span>
             <% end %>

data/app/views/pg_hero/home/queries.html.erb

@@ -7,6 +7,13 @@
 
   <% if @historical_query_stats_enabled %>
     <%= render partial: "query_stats_slider" %>
+  <% elsif @database.query_stats_table_exists? && (columns = @database.missing_query_stats_columns).any? %>
+    <div style="clear: both;">
+      <p>Add missing columns to re-enable historical query stats.</p>
+      <pre><code><% @database.missing_query_stats_columns.each do |column| %>ALTER TABLE pghero_query_stats ADD COLUMN "<%= column %>" <%= column == "query_hash" ? "bigint" : "text" %>;
+<% end %></code></pre>
+      <p>Then restart the web server.</p>
+    </div>
   <% end %>
 
   <% if @query_stats_enabled %>
@@ -14,6 +21,9 @@
       <div class="alert alert-danger">Cannot understand start or end time.</div>
     <% elsif @query_stats.any? || @historical_query_stats_enabled %>
       <%= render partial: "queries_table", locals: {queries: @query_stats, sort_headers: true} %>
+      <script>
+        highlightQueries();
+      </script>
     <% else %>
       <p>Stats are not available yet. Come back soon!</p>
     <% end %>