pghero 1.5.3 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 822e5e1791b9a405db29590569bad48b312738aa
-  data.tar.gz: 628fdcaad3d38fedd644bd2574582c3676cfb37b
+  metadata.gz: b86a04757fce4dfc91177eb7794c20ae289ec2d5
+  data.tar.gz: ba8f9f333064208ea84fd6a4c222cd531f18637b
 SHA512:
-  metadata.gz: f586c4e66499887b8694463665b0be0bf4b90f4428b470635750cd65d83e1071018730f9954819e8203b8b5cafefad360d254e7e843174c3afb4d3a940ffcd51
-  data.tar.gz: 2a0ef31b0a3a9510ae835535cf9563180974781f9d4d761a2224866a82b5e845ac5750d00709c054700416479bc3492d09d0cc28e978f05cdb76dfd5bc63d628
+  metadata.gz: d97627eb0174decf527ea8ca4554fcb8d45bc95c28eeb4fc250b7921c544f685af741ec85c5cfd1815a7749af36b4f75a4e90ef2b261adae873a9718ded34de3
+  data.tar.gz: e8fedfa37a433af1d4c2b647242b06bc6cc8ba1697f45e564123d3d77a8db599e722322a047d7c51b4c528805324df5db1f5f08b7bda5ae62ffda093d7f4a718

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## 1.6.0
+
+- Removed mostly inactionable items (cache hit rate and index usage)
+- Restored duplicate indexes to homepage
+- Fixed issue with exact duplicate indexes
+- Way better `blocked_queries` method
+
 ## 1.5.3
 
 - Fixed Rails 5 error with multiple databases

data/README.md

@@ -1,10 +1,10 @@
 # PgHero
 
-A performance dashboard for Postgres
+A performance dashboard for Postgres - health checks, suggested indexes, and more :tada:
 
 [See it in action](https://pghero.herokuapp.com/)
 
-[![Screenshot](https://pghero.herokuapp.com/assets/screenshot-a54dead9c9bfc4c1176b184c5bd97ca1.png)](https://pghero.herokuapp.com/)
+[![Screenshot](https://pghero.herokuapp.com/assets/screenshot-5a368624ada55b32e7668c96926840f9.png)](https://pghero.herokuapp.com/)
 
 :speech_balloon: Get [handcrafted updates](http://chartkick.us7.list-manage.com/subscribe?u=952c861f99eb43084e0a49f98&id=6ea6541e8e&group[0][16]=true) for new features
 

data/app/controllers/pg_hero/home_controller.rb

@@ -16,21 +16,19 @@ module PgHero
 
     def index
       @title = "Overview"
+      @extended = params[:extended]
       @query_stats = @database.query_stats(historical: true, start_at: 3.hours.ago)
       @slow_queries = @database.slow_queries(query_stats: @query_stats)
       @long_running_queries = @database.long_running_queries
-      @index_hit_rate = @database.index_hit_rate
-      @table_hit_rate = @database.table_hit_rate
-      @missing_indexes =
-        if @database.suggested_indexes_enabled?
-          []
-        else
-          @database.missing_indexes
-        end
+      if @extended
+        @index_hit_rate = @database.index_hit_rate
+        @table_hit_rate = @database.table_hit_rate
+        @good_cache_rate = @table_hit_rate >= @database.cache_hit_rate_threshold.to_f / 100 && @index_hit_rate >= @database.cache_hit_rate_threshold.to_f / 100
+      end
+
       @unused_indexes = @database.unused_indexes.select { |q| q["index_scans"].to_i == 0 }
       @invalid_indexes = @database.invalid_indexes
-      @duplicate_indexes = @database.duplicate_indexes if params[:duplicate_indexes]
-      @good_cache_rate = @table_hit_rate >= @database.cache_hit_rate_threshold.to_f / 100 && @index_hit_rate >= @database.cache_hit_rate_threshold.to_f / 100
+      @duplicate_indexes = @database.duplicate_indexes
       unless @query_stats_enabled
         @query_stats_available = @database.query_stats_available?
         @query_stats_extension_enabled = @database.query_stats_extension_enabled? if @query_stats_available

data/app/views/layouts/pg_hero/application.html.erb

@@ -36,7 +36,6 @@
             <% if @query_stats_enabled %>
               <li class="<%= controller.action_name == "queries" ? "active" : "" %>"><%= link_to "Queries", queries_path %></li>
             <% end %>
-            <li class="<%= controller.action_name == "index_usage" ? "active" : "" %>"><%= link_to "Index Usage", index_usage_path %></li>
             <li class="<%= controller.action_name == "space" ? "active" : "" %>"><%= link_to "Space", space_path %></li>
             <li class="<%= controller.action_name == "connections" ? "active" : "" %>"><%= link_to "Connections", connections_path %></li>
             <li class="<%= controller.action_name == "live_queries" ? "active" : "" %>"><%= link_to "Live Queries", live_queries_path %></li>

data/app/views/pg_hero/home/index.html.erb

@@ -16,16 +16,18 @@
       No long running queries
     <% end %>
   </div>
-  <div class="alert alert-<%= @good_cache_rate ? "success" : "warning" %>">
-    <% if @good_cache_rate %>
-      Cache hit rate above <%= @database.cache_hit_rate_threshold %>%
-    <% else %>
-      Low cache hit rate
-    <% end %>
-  </div>
+  <% if @extended %>
+    <div class="alert alert-<%= @good_cache_rate ? "success" : "warning" %>">
+      <% if @good_cache_rate %>
+        Cache hit rate above <%= @database.cache_hit_rate_threshold %>%
+      <% else %>
+        Low cache hit rate
+      <% end %>
+    </div>
+  <% end %>
   <div class="alert alert-<%= @good_total_connections ? "success" : "warning" %>">
     <% if @good_total_connections %>
-      Healthy number of connections
+      Number of connections healthy
     <% else %>
       High number of connections
     <% end %>
@@ -42,7 +44,7 @@
     <% if @sequence_danger.any? %>
       <%= pluralize(@sequence_danger.size, "columns") %> approaching overflow
     <% else %>
-      No columns near overflow
+      No columns near integer overflow
     <% end %>
   </div>
   <div class="alert alert-<%= @invalid_indexes.empty? ? "success" : "warning" %>">
@@ -69,14 +71,6 @@
         No suggested indexes
       <% end %>
     </div>
-  <% else %>
-    <div class="alert alert-<%= @missing_indexes.empty? ? "success" : "warning" %>">
-      <% if @missing_indexes.any? %>
-        <%= pluralize(@missing_indexes.size, "table appears", "tables appear") %> to be missing indexes
-      <% else %>
-        No missing indexes
-      <% end %>
-    </div>
   <% end %>
   <div class="alert alert-<%= @query_stats_enabled && @slow_queries.empty? ? "success" : "warning" %>">
     <% if !@query_stats_enabled %>
@@ -106,7 +100,7 @@
   </div>
 <% end %>
 
-<% if !@good_cache_rate %>
+<% if @extended && !@good_cache_rate %>
   <div class="content">
     <h1>Low Cache Hit Rate</h1>
 
@@ -135,7 +129,7 @@
     <h2>Vacuuming Needed</h2>
     <p>The database <strong>will shutdown</strong> when there are fewer than 1,000,000 transactions left. <%= link_to "Read more", "http://www.postgresql.org/docs/9.1/static/routine-vacuuming.html#VACUUM-FOR-WRAPAROUND", target: "_blank" %>.</p>
     <p>For each table, run:</p>
-    <code><pre>VACUUM FREEZE VERBOSE table</pre></code>
+    <code><pre>VACUUM FREEZE VERBOSE table;</pre></code>
     <table class="table">
       <thead>
         <tr>
@@ -270,11 +264,13 @@ remove_index <%= query["unneeded_index"]["table"].to_sym.inspect %>, name: <%= q
     <div id="migration3" style="display: none;">
       <pre>rails g migration add_suggested_indexes</pre>
       <p>And paste</p>
-      <pre style="overflow: scroll; white-space: pre; word-break: normal;"><% @suggested_indexes.each do |index| %>
+      <pre style="overflow: scroll; white-space: pre; word-break: normal;">commit_db_transaction
+<% @suggested_indexes.each do |index| %>
 <% if index[:using] == "gist" %>
 connection.execute("CREATE INDEX CONCURRENTLY ON <%= index[:table] %><% if index[:using] %> USING <%= index[:using] %><% end %> (<%= index[:columns].join(", ") %>)")
 <% else %>
-add_index <%= index[:table].to_sym.inspect %>, [<%= index[:columns].map(&:to_sym).map(&:inspect).join(", ") %>], algorithm: :concurrently<% end %><% end %></pre>
+add_index <%= index[:table].to_sym.inspect %>, [<%= index[:columns].map(&:to_sym).map(&:inspect).join(", ") %>], algorithm: :concurrently<% end %>
+<% end %></pre>
     </div>
 
     <% @suggested_indexes.each_with_index do |index, i| %>
@@ -286,33 +282,6 @@ add_index <%= index[:table].to_sym.inspect %>, [<%= index[:columns].map(&:to_sym
   </div>
 <% end %>
 
-<% if @missing_indexes.any? %>
-  <div class="content">
-    <h1>Missing Indexes</h1>
-
-    <p>These tables have a large number of rows but indexes are not used often. Add indexes for faster queries.</p>
-
-    <table class="table">
-      <thead>
-        <tr>
-          <th>Table</th>
-          <th>% of Time Index Used</th>
-          <th>Rows in Table</th>
-        </tr>
-      </thead>
-      <tbody>
-        <% @missing_indexes.each do |query| %>
-          <tr>
-            <td><%= query["table"] %></td>
-            <td style="width: 30%;"><%= query["percent_of_times_index_used"] %></td>
-            <td style="width: 20%;"><%= number_with_delimiter(query["rows_in_table"]) %></td>
-          </tr>
-        <% end %>
-      </tbody>
-    </table>
-  </div>
-<% end %>
-
 <% if !@query_stats_enabled %>
   <div class="content">
     <h1>Query Stats</h1>

data/app/views/pg_hero/home/maintenance.html.erb

@@ -22,12 +22,16 @@
             <% time = [table["last_autovacuum"], table["last_vacuum"]].compact.max %>
             <% if time %>
               <%= @time_zone.parse(time).strftime("%m/%-e %l:%M %P") %>
+            <% else %>
+              <span class="text-muted">Unknown</span>
             <% end %>
           </td>
           <td>
             <% time = [table["last_autoanalyze"], table["last_analyze"]].compact.max %>
             <% if time %>
               <%= @time_zone.parse(time).strftime("%m/%-e %l:%M %P") %>
+            <% else %>
+              <span class="text-muted">Unknown</span>
             <% end %>
           </td>
         </tr>

data/guides/Linux.md

@@ -186,6 +186,26 @@ sudo pghero config:set PGHERO_SECRET_ACCESS_KEY=secret123
 sudo pghero config:set PGHERO_DB_INSTANCE_IDENTIFIER=epona
 ```
 
+## Multiple Databases
+
+Create a `pghero.yml` with:
+
+```yml
+production:
+  databases:
+    primary:
+      url: postgres://...
+    replica:
+      url: postgres://...
+```
+
+And run:
+
+```sh
+cat pghero.yml | sudo pghero run sh -c "cat > config/pghero.yml"
+sudo service pghero restart
+```
+
 ## Customize
 
 Minimum time for long running queries

data/lib/pghero/methods/indexes.rb

@@ -142,7 +142,7 @@ module PgHero
         indexes_by_table = self.indexes.group_by { |i| i["table"] }
         indexes_by_table.values.flatten.select { |i| PgHero.falsey?(i["primary"]) && PgHero.falsey?(i["unique"]) && !i["indexprs"] && !i["indpred"] && PgHero.truthy?(i["valid"]) }.each do |index|
           covering_index = indexes_by_table[index["table"]].find { |i| index_covers?(i["columns"], index["columns"]) && i["using"] == index["using"] && i["name"] != index["name"] && !i["indexprs"] && !i["indpred"] && PgHero.truthy?(i["valid"]) }
-          if covering_index
+          if covering_index && (covering_index["columns"] != index["columns"] || index["name"] > covering_index["name"])
             indexes << {"unneeded_index" => index, "covering_index" => covering_index}
           end
         end

data/lib/pghero/methods/queries.rb

@@ -57,28 +57,37 @@ module PgHero
       end
 
       # from https://wiki.postgresql.org/wiki/Lock_Monitoring
+      # and http://big-elephants.com/2013-09/exploring-query-locks-in-postgres/
       def blocked_queries
         select_all <<-SQL
           SELECT
-            bl.pid AS blocked_pid,
-            a.usename AS blocked_user,
-            ka.query AS current_or_recent_query_in_blocking_process,
-            ka.state AS state_of_blocking_process,
-            age(now(), ka.query_start) AS blocking_duration,
-            kl.pid AS blocking_pid,
-            ka.usename AS blocking_user,
-            a.query AS blocked_query,
-            age(now(), a.query_start) AS blocked_duration
+            COALESCE(blockingl.relation::regclass::text,blockingl.locktype) as locked_item,
+            blockeda.pid AS blocked_pid,
+            blockeda.usename AS blocked_user,
+            blockeda.query as blocked_query,
+            age(now(), blockeda.query_start) AS blocked_duration,
+            blockedl.mode as blocked_mode,
+            blockinga.pid AS blocking_pid,
+            blockinga.usename AS blocking_user,
+            blockinga.state AS state_of_blocking_process,
+            blockinga.query AS current_or_recent_query_in_blocking_process,
+            age(now(), blockinga.query_start) AS blocking_duration,
+            blockingl.mode as blocking_mode
           FROM
-            pg_catalog.pg_locks bl
-          JOIN
-            pg_catalog.pg_stat_activity a ON a.pid = bl.pid
-          JOIN
-            pg_catalog.pg_locks kl ON kl.transactionid = bl.transactionid AND kl.pid != bl.pid
-          JOIN
-            pg_catalog.pg_stat_activity ka ON ka.pid = kl.pid
+            pg_catalog.pg_locks blockedl
+          LEFT JOIN
+            pg_stat_activity blockeda ON blockedl.pid = blockeda.pid
+          LEFT JOIN
+            pg_catalog.pg_locks blockingl ON blockedl.pid != blockingl.pid AND (
+              blockingl.transactionid = blockedl.transactionid
+              OR (blockingl.relation = blockedl.relation AND blockingl.locktype = blockedl.locktype)
+            )
+          LEFT JOIN
+            pg_stat_activity blockinga ON blockingl.pid = blockinga.pid AND blockinga.datid = blockeda.datid
           WHERE
-            NOT bl.GRANTED
+            NOT blockedl.granted
+            AND blockeda.query <> '<insufficient privilege>'
+            AND blockeda.datname = current_database()
           ORDER BY
             blocked_duration DESC
         SQL

data/lib/pghero/version.rb

@@ -1,3 +1,3 @@
 module PgHero
-  VERSION = "1.5.3"
+  VERSION = "1.6.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pghero
 version: !ruby/object:Gem::Version
-  version: 1.5.3
+  version: 1.6.0
 platform: ruby
 authors:
 - Andrew Kane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-07 00:00:00.000000000 Z
+date: 2016-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord