pgdexter 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b472c8289c8c878c0ea790a3ec5fdf43e22bfaa1
-  data.tar.gz: 55f96eb8bd0a8739c79fb7c749a8aee68b2a119f
+  metadata.gz: 9f136be602609b6abb8f11ef02fa7cf18a8db33a
+  data.tar.gz: c58324b44d32b867df2a5a127a70b4d713e2dfa2
 SHA512:
-  metadata.gz: 873d3d0f9471f90c9b90721274623c6c3dcfbcfe88989143a6b66a5ce1345a2187bab75ef4f32f52efd9f34a1e1806524696854348e592d6eb31bec25ca193c8
-  data.tar.gz: a545b2b1a9d2f6650ec04c1769b243863c412fbff3b1e0575ab4cc6c98648119e487a2bc75f0afeeb704895184580ada13169a05edb3e00bc0caca37759183bc
+  metadata.gz: 8f39e8a9794a937fe79a637f46e76ee71eba53e9bf3b60a734ad6af270a9236216d5182440586bde0762fd05d48be11c02bb3e620039ec02e2acce1633b81d36
+  data.tar.gz: b870ca6f00a6bc2f6d76c49d6805d0910d4053457ca5c11ccb666de863406fcd07acf37fdf7f23fb4d89f0df6795724fe74fca601738aa47f6832edbafa03a86

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.1.3
+
+- Fixed error with non-lowercase columns
+- Fixed error with `json` columns
+
 ## 0.1.2
 
 - Added `--exclude` option

data/README.md

@@ -40,7 +40,7 @@ tail -F -n +1 <log-file> | dexter <database-url>
 
 This finds slow queries and generates output like:
 
-```log
+```
 2017-06-25T17:52:19+00:00 Started
 2017-06-25T17:52:22+00:00 Processing 189 new query fingerprints
 2017-06-25T17:52:22+00:00 Index found: genres_movies (genre_id)
@@ -54,9 +54,9 @@ This finds slow queries and generates output like:
 
 To be safe, Dexter will not create indexes unless you pass the `--create` flag. In this case, you’ll see:
 
-```log
+```
 2017-06-25T17:52:22+00:00 Index found: ratings (user_id)
-2017-06-25T17:52:22+00:00 Creating index: CREATE INDEX CONCURRENTLY ON ratings (user_id)
+2017-06-25T17:52:22+00:00 Creating index: CREATE INDEX CONCURRENTLY ON "ratings" ("user_id")
 2017-06-25T17:52:37+00:00 Index created: 15243 ms
 ```
 
@@ -86,3 +86,18 @@ Everyone is encouraged to help improve this project. Here are a few ways you can
 - Fix bugs and [submit pull requests](https://github.com/ankane/dexter/pulls)
 - Write, clarify, or fix documentation
 - Suggest or add new features
+
+To get started, run:
+
+```sh
+git clone https://github.com/ankane/dexter.git
+cd dexter
+bundle
+rake install
+```
+
+To run tests, use:
+
+```sh
+rake test
+```

data/Rakefile

@@ -5,6 +5,7 @@ Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
   t.test_files = FileList["test/**/*_test.rb"]
+  t.warning = false
 end
 
 task default: :test

data/lib/dexter/indexer.rb

@@ -106,7 +106,9 @@ module Dexter
       candidates = {}
       columns(tables).each do |col|
         unless index_set.include?([col[:table], [col[:column]]])
-          candidates[col] = select_all("SELECT * FROM hypopg_create_index('CREATE INDEX ON #{col[:table]} (#{[col[:column]].join(", ")})');").first["indexname"]
+          unless ["json", "jsonb"].include?(col[:type])
+            candidates[col] = select_all("SELECT * FROM hypopg_create_index('CREATE INDEX ON #{quote_ident(col[:table])} (#{[col[:column]].map { |c| quote_ident(c)  }.join(", ")})')").first["indexname"]
+          end
         end
       end
       candidates
@@ -190,7 +192,7 @@ module Dexter
           # 3. create indexes that still don't exist
           # 4. release lock
           new_indexes.each do |index|
-            statement = "CREATE INDEX CONCURRENTLY ON #{index[:table]} (#{index[:columns].join(", ")})"
+            statement = "CREATE INDEX CONCURRENTLY ON #{quote_ident(index[:table])} (#{index[:columns].map { |c| quote_ident(c) }.join(", ")})"
             log "Creating index: #{statement}"
             started_at = Time.now
             select_all(statement)
@@ -198,7 +200,7 @@ module Dexter
           end
         end
       else
-        log "No indexes found"
+        log "No new indexes found"
       end
 
       new_indexes
@@ -222,7 +224,7 @@ module Dexter
     end
 
     def select_all(query)
-      # use exec_params instead of exec for securiy
+      # use exec_params instead of exec for security
       #
       # Unlike PQexec, PQexecParams allows at most one SQL command in the given string.
       # (There can be semicolons in it, but not more than one nonempty command.)
@@ -260,7 +262,8 @@ module Dexter
       columns = select_all <<-SQL
         SELECT
           table_name,
-          column_name
+          column_name,
+          data_type
         FROM
           information_schema.columns
         WHERE
@@ -268,7 +271,7 @@ module Dexter
           table_name IN (#{tables.map { |t| quote(t) }.join(", ")})
       SQL
 
-      columns.map { |v| {table: v["table_name"], column: v["column_name"]} }
+      columns.map { |v| {table: v["table_name"], column: v["column_name"], type: v["data_type"]} }
     end
 
     def indexes(tables)

data/lib/dexter/version.rb

@@ -1,3 +1,3 @@
 module Dexter
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/pgdexter.gemspec

@@ -26,4 +26,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "minitest"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pgdexter
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Andrew Kane
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-27 00:00:00.000000000 Z
+date: 2017-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slop
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - andrew@chartkick.com