pgbus 0.15.0 → 0.15.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c9e24beb40f37672bb2d5b51db5c6ffeb2894e1a2be3711ff6b17cc5c2ed52b7
-  data.tar.gz: 4fe85e1733dd8257b1f13af40778fbc449146015d707e9d2889b287ad83af78b
+  metadata.gz: c419d130102e92e1bd355df6e98211e44eeead76298f9ce58bd6c285b1de24a9
+  data.tar.gz: dab0eefe9c7a23aee676b928521841adffb6d38f084993c6bb3ab56f9ade207f
 SHA512:
-  metadata.gz: b8e23d2e38e12c2dd882dcdb5de8c23763b469551c869511718cd9d52a85ccdceb344779ae48ab3a3cfec2f1d3e8373d642f8d97f712c30f98893ed0450abc0d
-  data.tar.gz: 142d408f3fa304d82593cf9fdf6167592c3bf2cafb64016702b057e374a98c7476e33922d6b05be00e7a71136861a77d9b8267dbd1fabb1dc6ed48c6fd1e15ae
+  metadata.gz: d8cedff08ffed91f3b9a9c1b9df1b2147790ec9bf7e5117b22a4af19b865b239df4883d6708153ec2efc9de5207e007cb4d2cfd06440ac3b4bd25e63d1eea369
+  data.tar.gz: fcb2ec48f7daf53dc46d5c388cb3b4e1acd99a568e74e92253736efb8ba4bc52fd9704d287fbaafcea893d063676b3f68ceac3d82b79fc3906ef4d7bbc43dcd3

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+### Fixed
+
+- **`current_attributes` capture skips an unpersisted record instead of raising at enqueue (issue #435).** An attribute holding an Active Record instance with no id — a dev-mode fallback record assigned to `Current`, a form-built model captured before `save`, a destroyed record whose locate is guaranteed to fail — made every `perform_later` in that context raise `Pgbus::CurrentAttributesError`, even though such a record can never round-trip (no id → no GlobalID) and capture is ambient: the enqueuer never opted into persisting that attribute per-call, so its momentary state must not abort the enqueue. `capture` now skips any attribute value that answers `persisted?` falsey (so destroyed-but-id-bearing records are skipped too, not just `new_record?`) with a debug log naming the class, attribute and why; the rest of the class's attributes still persist. The `except:` guidance and the loud `CurrentAttributesError` remain for genuinely unserializable values — objects without the Active Record duck-type (`respond_to?(:persisted?)`) are untouched. Applies to jobs and event-bus publish alike (same capture path). Refs #435.
+
 ### Added
 
 - **First-class `Current` support: ActiveSupport::CurrentAttributes persist across enqueue → perform (issue #430).** The executor already reset `CurrentAttributes` around every job (so nothing leaked) but nothing restored it — `Current.tenant` was always nil inside a job. New `config.current_attributes` (`nil` = off; `:auto` = every `ActiveSupport::CurrentAttributes` subclass; an Array of classes/names; or a Hash of class => `{ only: [...] }` / `{ except: [...] }`). The new `Pgbus::ActiveJob::CurrentAttributes` mixin (included on `ActiveJob::Base` by the engine next to `BatchId`) captures the assigned attributes of each persisted class in `serialize` — serialized with `ActiveJob::Arguments`, so records become GlobalIDs and fall under the `allowed_global_id_models` allowlist on the way back — under the job-hash key `pgbus_current`, and restores them by wrapping the **whole** `perform_now` in nested `Current.set`, so `before_perform`, `perform`, `rescue_from`, `retry_on` / `discard_on` blocks and jobs enqueued from inside `perform` all see the context, under the pgbus worker and Rails' `:test` / `:inline` adapters alike. A deserialized job re-serializes the context it was enqueued with, so a `retry_on` re-enqueue keeps the original; concurrency-blocked promotion, dead-letter / dashboard retry and `perform_all_later` carry it by construction. An unserializable attribute raises `Pgbus::CurrentAttributesError` at `perform_later` naming the class, attribute and the `except:` fix — nothing is dropped silently; a class that no longer exists or an attribute no longer defined is skipped with a log line (Sidekiq parity). Per job class: `self.pgbus_persist_current_attributes = false` or a spec override. Unconfigured installs have byte-identical payloads. Dashboard: failed-job and dead-letter detail pages gain a **Context** card (`Pgbus::Web::JobContext`, through `PayloadFilter`). Event bus follows in #431. Refs #430.

data/README.md

@@ -674,7 +674,7 @@ end
 
 Events get the same hop: `Pgbus.publish` captures `Current` into the event envelope and the consumer restores it around every `handle` — including across the transactional outbox (captured at `Outbox.publish_event`, inside your transaction). Handlers can also read the raw form via `event.context`.
 
-Captured at enqueue via `ActiveJob::Arguments` (records become GlobalIDs, gated by `allowed_global_id_models`), preserved across retries, concurrency-blocked promotion, dead-letter retry and `perform_all_later`; an unserializable attribute raises at `perform_later` with the `except:` fix. The dashboard shows the context on failed-job and dead-letter pages. Details: [Active Job → Current attributes](https://pgbus.zoolutions.llc/docs/active-job).
+Captured at enqueue via `ActiveJob::Arguments` (records become GlobalIDs, gated by `allowed_global_id_models`), preserved across retries, concurrency-blocked promotion, dead-letter retry and `perform_all_later`; an unserializable attribute raises at `perform_later` with the `except:` fix, while an **unpersisted** record (no id — it could never be restored) is skipped with a debug log instead of aborting the enqueue. The dashboard shows the context on failed-job and dead-letter pages. Details: [Active Job → Current attributes](https://pgbus.zoolutions.llc/docs/active-job).
 
 ### Consumer priority
 

data/lib/pgbus/current_attributes.rb

@@ -8,8 +8,11 @@ module Pgbus
   # (config.current_attributes: :auto, an explicit list, or per-class
   # only:/except: filters) serialized through ActiveJob::Arguments — so
   # GlobalID models, Symbols, Times round-trip like job arguments and fall
-  # under the allowed_global_id_models allowlist on the way back. `restore`
-  # nests `klass.set(attrs)` for the duration of a block.
+  # under the allowed_global_id_models allowlist on the way back. An
+  # attribute holding an unpersisted record is skipped with a debug log
+  # (no id → no GlobalID → it could never be restored; see
+  # #reject_unpersisted). `restore` nests `klass.set(attrs)` for the
+  # duration of a block.
   #
   # The ActiveJob side (Pgbus::ActiveJob::CurrentAttributes) calls capture
   # from `serialize` and restore around `perform_now`, so the hop works under
@@ -34,7 +37,7 @@ module Pgbus
         captured = {}
         persisted_specs(config, override: override).each do |spec|
           klass = resolve_class(spec[:name]) or next
-          attrs = filter_attrs(klass.attributes, spec)
+          attrs = reject_unpersisted(klass, filter_attrs(klass.attributes, spec))
           next if attrs.empty?
 
           captured[klass.name] = serialize_attrs(klass, attrs)
@@ -126,6 +129,27 @@ module Pgbus
         attrs
       end
 
+      # An unpersisted record cannot round-trip by definition — no id, no
+      # GlobalID — and capture is ambient: the enqueuer never opted into
+      # persisting this attribute per-call, so its momentary state (a dev-mode
+      # fallback record, a form-built model assigned to Current before save,
+      # a destroyed record whose locate is guaranteed to fail) must not abort
+      # the enqueue. Skip it like an unassigned attribute. persisted? (not
+      # new_record?) so destroyed-but-id-bearing records are skipped too;
+      # objects without the Active Record duck-type pass through untouched
+      # and still hit serialize_attrs' loud CurrentAttributesError if bad.
+      def reject_unpersisted(klass, attrs)
+        attrs.reject do |name, value|
+          next false unless value.respond_to?(:persisted?) && !value.persisted?
+
+          Pgbus.logger.debug do
+            "[Pgbus] current_attributes: #{klass.name}##{name} holds an unpersisted #{value.class} — " \
+              "skipped (no id to serialize; it could never be restored)"
+          end
+          true
+        end
+      end
+
       def serialize_attrs(klass, attrs)
         ::ActiveJob::Arguments.serialize([attrs]).first
       rescue ::ActiveJob::SerializationError, URI::Error

data/lib/pgbus/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pgbus
-  VERSION = "0.15.0"
+  VERSION = "0.15.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pgbus
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.15.1
 platform: ruby
 authors:
 - Mikael Henriksson