pg_trunk 0.1.2 → 0.1.3

data/spec/operations/rules/create_rule_spec.rb

@@ -0,0 +1,119 @@
+# frozen_string_literal: true
+
+describe ActiveRecord::Migration, "#create_rule" do
+  before_all do
+    run_migration <<~RUBY
+      create_table :users do |t|
+        t.string :name
+      end
+
+      create_table :user_updates do |t|
+        t.timestamps
+      end
+    RUBY
+  end
+
+  context "with a minimal definition" do
+    let(:migration) do
+      <<~RUBY
+        create_rule "users", "prevent_insertion" do |r|
+          r.event :insert
+          r.kind :instead
+          r.comment "Prevent insertion to users"
+        end
+      RUBY
+    end
+
+    its(:execution) { is_expected.to insert(migration).into_schema }
+    its(:inversion) { is_expected.not_to change_schema }
+  end
+
+  context "with a commands definition" do
+    let(:migration) do
+      <<~RUBY
+        create_rule "users", "count_updates" do |r|
+          r.event :update
+          r.command <<~Q.chomp
+            INSERT INTO user_updates (created_at) VALUES (now())
+          Q
+          r.comment "Count updates of users"
+        end
+      RUBY
+    end
+
+    its(:execution) { is_expected.to insert(migration).into_schema }
+    its(:inversion) { is_expected.not_to change_schema }
+  end
+
+  context "without an explicit name of the rule" do
+    let(:migration) do
+      <<~RUBY
+        create_rule "users" do |r|
+          r.event :update
+          r.command <<~Q.chomp
+            INSERT INTO user_updates (created_at) VALUES (now())
+          Q
+          r.comment "Count updates of users"
+        end
+      RUBY
+    end
+
+    its(:execution) { is_expected.to insert(migration).into_schema }
+    its(:inversion) { is_expected.not_to change_schema }
+  end
+
+  context "with the `replace_existing: true` option" do
+    let(:migration) do
+      <<~RUBY
+        create_rule "users", replace_existing: true do |r|
+          r.event :update
+          r.command <<~Q.chomp
+            INSERT INTO user_updates (created_at) VALUES (now());
+          Q
+          r.comment "Count updates of users"
+        end
+      RUBY
+    end
+    let(:snippet) do
+      <<~RUBY
+        create_rule "users" do |r|
+          r.event :update
+          r.command <<~Q.chomp
+            INSERT INTO user_updates (created_at) VALUES (now())
+          Q
+          r.comment "Count updates of users"
+        end
+      RUBY
+    end
+
+    its(:execution) { is_expected.to insert(snippet).into_schema }
+    it { is_expected.to be_irreversible.because_of(/replace_existing: true/i) }
+  end
+
+  context "without an event" do
+    let(:migration) do
+      <<~RUBY
+        create_rule "users" do |r|
+          r.kind :instead
+          r.comment "Prevent insertion to users"
+        end
+      RUBY
+    end
+
+    it { is_expected.to fail_validation.because(/event can't be blank/i) }
+  end
+
+  context "without a table" do
+    let(:migration) do
+      <<~RUBY
+        create_rule do |r|
+          r.event :insert
+          r.kind :instead
+          r.comment "Prevent insertion to users"
+        end
+      RUBY
+    end
+
+    it { is_expected.to fail_validation.because(/table can't be blank/i) }
+  end
+end

data/spec/operations/rules/drop_rule_spec.rb

@@ -0,0 +1,117 @@
+# frozen_string_literal: true
+
+describe ActiveRecord::Migration, "#drop_rule" do
+  before_all do
+    run_migration <<~RUBY
+      create_table :users do |t|
+        t.string :name
+      end
+    RUBY
+  end
+  before { run_migration(snippet) }
+
+  context "when a rule was named" do
+    let(:snippet) do
+      <<~RUBY
+        create_rule "users", "prevent_insertion" do |r|
+          r.event :insert
+          r.kind :instead
+          r.comment "Prevent insertion to users"
+        end
+      RUBY
+    end
+
+    context "with a full definition" do
+      let(:migration) do
+        <<~RUBY
+          drop_rule "users", "prevent_insertion" do |r|
+            r.event :insert
+            r.kind :instead
+            r.comment "Prevent insertion to users"
+          end
+        RUBY
+      end
+
+      its(:execution) { is_expected.to remove(snippet).from_schema }
+      its(:inversion) { is_expected.not_to change_schema }
+    end
+
+    context "with a name only" do
+      let(:migration) do
+        <<~RUBY
+          drop_rule "users", "prevent_insertion"
+        RUBY
+      end
+
+      its(:execution) { is_expected.to remove(snippet).from_schema }
+      it { is_expected.to be_irreversible.because(/event can't be blank/i) }
+    end
+
+    context "with if_exists: true option" do
+      let(:migration) do
+        <<~RUBY
+          drop_rule "users", "prevent_insertion", if_exists: true do |r|
+            r.event :insert
+            r.kind :instead
+            r.comment "Prevent insertion to users"
+          end
+        RUBY
+      end
+
+      its(:execution) { is_expected.to remove(snippet).from_schema }
+      it { is_expected.to be_irreversible.because_of(/if_exists: true/i) }
+    end
+
+    context "with force: :cascade option" do
+      let(:migration) do
+        <<~RUBY
+          drop_rule "users", "prevent_insertion", force: :cascade do |r|
+            r.event :insert
+            r.kind :instead
+            r.comment "Prevent insertion to users"
+          end
+        RUBY
+      end
+
+      its(:execution) { is_expected.to remove(snippet).from_schema }
+      it { is_expected.to be_irreversible.because_of(/force: :cascade/i) }
+    end
+  end
+
+  context "when a rule was anonymous" do
+    let(:snippet) do
+      <<~RUBY
+        create_rule "users" do |r|
+          r.event :insert
+          r.kind :instead
+          r.comment "Prevent insertion to users"
+        end
+      RUBY
+    end
+
+    context "with a full definition" do
+      let(:migration) do
+        <<~RUBY
+          drop_rule "users" do |r|
+            r.event :insert
+            r.kind :instead
+            r.comment "Prevent insertion to users"
+          end
+        RUBY
+      end
+
+      its(:execution) { is_expected.to remove(snippet).from_schema }
+      its(:inversion) { is_expected.not_to change_schema }
+    end
+
+    context "with a table only" do
+      let(:migration) do
+        <<~RUBY
+          drop_rule "users"
+        RUBY
+      end
+
+      it { is_expected.to fail_validation.because(/name can't be blank/i) }
+    end
+  end
+end

data/spec/operations/rules/rename_rule_spec.rb

@@ -0,0 +1,148 @@
+# frozen_string_literal: true
+
+describe ActiveRecord::Migration, "#rename_rule" do
+  before_all do
+    run_migration <<~RUBY
+      create_table :users do |t|
+        t.string :name
+      end
+    RUBY
+  end
+  before { run_migration(old_snippet) }
+
+  context "when a rule was named" do
+    let(:old_snippet) do
+      <<~RUBY
+        create_rule "users", "prevent_insertion" do |r|
+          r.event :insert
+          r.kind :instead
+          r.comment "Prevent insertion to users"
+        end
+      RUBY
+    end
+
+    context "with a new name" do
+      let(:migration) do
+        <<~RUBY
+          rename_rule "users", "prevent_insertion", to: "do_nothing"
+        RUBY
+      end
+      let(:new_snippet) do
+        <<~RUBY
+          create_rule "users", "do_nothing" do |r|
+            r.event :insert
+            r.kind :instead
+            r.comment "Prevent insertion to users"
+          end
+        RUBY
+      end
+
+      its(:execution) { is_expected.to remove(old_snippet).from_schema }
+      its(:execution) { is_expected.to insert(new_snippet).into_schema }
+      its(:inversion) { is_expected.not_to change_schema }
+    end
+
+    context "with the same name" do
+      let(:migration) do
+        <<~RUBY
+          rename_rule "users", "prevent_insertion", to: "prevent_insertion"
+        RUBY
+      end
+
+      it { is_expected.to fail_validation.because(/new name must be different/i) }
+    end
+
+    context "without new name" do
+      let(:migration) do
+        <<~RUBY
+          rename_rule "users", "prevent_insertion" do |r|
+            r.event :insert
+            r.kind :instead
+          end
+        RUBY
+      end
+      let(:new_snippet) do
+        <<~RUBY
+          create_rule "users" do |r|
+            r.event :insert
+            r.kind :instead
+            r.comment "Prevent insertion to users"
+          end
+        RUBY
+      end
+
+      its(:execution) { is_expected.to remove(old_snippet).from_schema }
+      its(:execution) { is_expected.to insert(new_snippet).into_schema }
+      its(:inversion) { is_expected.not_to change_schema }
+    end
+
+    context "when absent name can't be generated from kind/event" do
+      let(:migration) do
+        <<~RUBY
+          rename_rule "users", "prevent_insertion"
+        RUBY
+      end
+
+      it { is_expected.to fail_validation.because(/new name can't be blank/i) }
+    end
+  end
+
+  context "when a rule was anonymous" do
+    let(:old_snippet) do
+      <<~RUBY
+        create_rule "users" do |r|
+          r.event :insert
+          r.kind :instead
+          r.comment "Prevent insertion to users"
+        end
+      RUBY
+    end
+
+    context "with a new name" do
+      let(:migration) do
+        <<~RUBY
+          rename_rule "users", to: "do_nothing" do |r|
+            r.event :insert
+            r.kind :instead
+          end
+        RUBY
+      end
+      let(:new_snippet) do
+        <<~RUBY
+          create_rule "users", "do_nothing" do |r|
+            r.event :insert
+            r.kind :instead
+            r.comment "Prevent insertion to users"
+          end
+        RUBY
+      end
+
+      its(:execution) { is_expected.to remove(old_snippet).from_schema }
+      its(:execution) { is_expected.to insert(new_snippet).into_schema }
+      its(:inversion) { is_expected.not_to change_schema }
+    end
+
+    context "without new name" do
+      let(:migration) do
+        <<~RUBY
+          rename_rule "users" do |r|
+            r.event :insert
+            r.kind :instead
+          end
+        RUBY
+      end
+
+      it { is_expected.to fail_validation.because(/new name must be different/i) }
+    end
+
+    context "when absent name can't be generated" do
+      let(:migration) do
+        <<~RUBY
+          rename_rule "users", to: "do_nothing"
+        RUBY
+      end
+
+      it { is_expected.to fail_validation.because(/name can't be blank/i) }
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_trunk
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Andrew Kozin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-16 00:00:00.000000000 Z
+date: 2022-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -169,6 +169,11 @@ files:
 - lib/pg_trunk/operations/procedures/create_procedure.rb
 - lib/pg_trunk/operations/procedures/drop_procedure.rb
 - lib/pg_trunk/operations/procedures/rename_procedure.rb
+- lib/pg_trunk/operations/rules.rb
+- lib/pg_trunk/operations/rules/base.rb
+- lib/pg_trunk/operations/rules/create_rule.rb
+- lib/pg_trunk/operations/rules/drop_rule.rb
+- lib/pg_trunk/operations/rules/rename_rule.rb
 - lib/pg_trunk/operations/statistics.rb
 - lib/pg_trunk/operations/statistics/base.rb
 - lib/pg_trunk/operations/statistics/create_statistics.rb
@@ -238,6 +243,9 @@ files:
 - spec/operations/procedures/create_procedure_spec.rb
 - spec/operations/procedures/drop_procedure_spec.rb
 - spec/operations/procedures/rename_procedure_spec.rb
+- spec/operations/rules/create_rule_spec.rb
+- spec/operations/rules/drop_rule_spec.rb
+- spec/operations/rules/rename_rule_spec.rb
 - spec/operations/statistics/create_statistics_spec.rb
 - spec/operations/statistics/drop_statistics_spec.rb
 - spec/operations/statistics/rename_statistics_spec.rb
@@ -277,72 +285,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Empower PostgreSQL migrations in Rails app
-test_files:
-- spec/dummy/.gitignore
-- spec/dummy/Rakefile
-- spec/dummy/bin/bundle
-- spec/dummy/bin/rails
-- spec/dummy/bin/rake
-- spec/dummy/config.ru
-- spec/dummy/config/application.rb
-- spec/dummy/config/boot.rb
-- spec/dummy/config/database.yml
-- spec/dummy/config/environment.rb
-- spec/dummy/db/materialized_views/admin_users_v01.sql
-- spec/dummy/db/migrate/.keep
-- spec/dummy/db/schema.rb
-- spec/dummy/db/views/admin_users_v01.sql
-- spec/dummy/db/views/admin_users_v02.sql
-- spec/operations/check_constraints/add_check_constraint_spec.rb
-- spec/operations/check_constraints/drop_check_constraint_spec.rb
-- spec/operations/check_constraints/rename_check_constraint_spec.rb
-- spec/operations/composite_types/change_composite_type_spec.rb
-- spec/operations/composite_types/create_composite_type_spec.rb
-- spec/operations/composite_types/drop_composite_type_spec.rb
-- spec/operations/composite_types/rename_composite_type_spec.rb
-- spec/operations/dependency_resolver_spec.rb
-- spec/operations/domains/change_domain_spec.rb
-- spec/operations/domains/create_domain_spec.rb
-- spec/operations/domains/drop_domain_spec.rb
-- spec/operations/domains/rename_domain_spec.rb
-- spec/operations/enums/change_enum_spec.rb
-- spec/operations/enums/create_enum_spec.rb
-- spec/operations/enums/drop_enum_spec.rb
-- spec/operations/enums/rename_enum_spec.rb
-- spec/operations/foreign_keys/add_foreign_key_spec.rb
-- spec/operations/foreign_keys/drop_foreign_key_spec.rb
-- spec/operations/foreign_keys/rename_foreign_key_spec.rb
-- spec/operations/functions/change_function_spec.rb
-- spec/operations/functions/create_function_spec.rb
-- spec/operations/functions/drop_function_spec.rb
-- spec/operations/functions/rename_function_spec.rb
-- spec/operations/indexes/add_index_spec.rb
-- spec/operations/materialized_views/change_materialized_view_spec.rb
-- spec/operations/materialized_views/create_materialized_view_spec.rb
-- spec/operations/materialized_views/drop_materialized_view_spec.rb
-- spec/operations/materialized_views/refresh_materialized_view_spec.rb
-- spec/operations/materialized_views/rename_materialized_view_spec.rb
-- spec/operations/procedures/change_procedure_spec.rb
-- spec/operations/procedures/create_procedure_spec.rb
-- spec/operations/procedures/drop_procedure_spec.rb
-- spec/operations/procedures/rename_procedure_spec.rb
-- spec/operations/statistics/create_statistics_spec.rb
-- spec/operations/statistics/drop_statistics_spec.rb
-- spec/operations/statistics/rename_statistics_spec.rb
-- spec/operations/tables/create_table_spec.rb
-- spec/operations/tables/rename_table_spec.rb
-- spec/operations/triggers/change_trigger_spec.rb
-- spec/operations/triggers/create_trigger_spec.rb
-- spec/operations/triggers/drop_trigger_spec.rb
-- spec/operations/triggers/rename_trigger_spec.rb
-- spec/operations/views/change_view_spec.rb
-- spec/operations/views/create_view_spec.rb
-- spec/operations/views/drop_view_spec.rb
-- spec/operations/views/rename_view_spec.rb
-- spec/pg_trunk/dependencies_resolver_spec.rb
-- spec/spec_helper.rb
-- spec/support/migrations_helper.rb
+test_files: []