pg_sql_triggers 1.0.1 → 1.1.0

data/Goal.md

@@ -83,7 +83,7 @@ Registry tracks:
 - ~~table_name~~
 - ~~version~~
 - ~~enabled~~
-- ~~checksum~~ (⚠️ partially - uses placeholder in registry manager)
+- ~~checksum~~ (✅ fully implemented - consistent field-concatenation algorithm)
 - ~~source (dsl / generated / manual_sql)~~
 - ~~environment~~
 - ~~installed_at~~
@@ -92,37 +92,39 @@ Registry tracks:
 Rails must always know:
 - ~~what exists~~
 - ~~how it was created~~
-- ⚠️ whether it drifted (drift detection not fully implemented)
+- ✅ whether it drifted (drift detection fully implemented)
 
 ---
 
-### D. Safe Apply & Deploy ❌ (not implemented)
+### D. Safe Apply & Deploy ✅ (fully implemented via migrations)
 
 Applying triggers must:
-- ⚠️ Run in a transaction (migrations use transactions, but no explicit "apply" method)
-- ❌ Diff expected vs actual (not implemented)
-- ⚠️ Never blindly DROP + CREATE (migrations handle this, but no explicit safety checks)
-- ⚠️ Support rollback on failure (migration rollback exists, but not explicit apply rollback)
-- ⚠️ Update registry atomically (registry updated but not in explicit apply method)
+- ✅ Run in a transaction (migrations run in transactions)
+- ✅ Diff expected vs actual (fully implemented - pre-apply comparison before migration execution)
+- ✅ Never blindly DROP + CREATE (fully implemented - safety validator blocks unsafe DROP + CREATE patterns)
+- ✅ Support rollback on failure (migration rollback exists)
+- ✅ Update registry atomically (registry updated during migration execution)
+
+**Status:** Core functionality fully implemented through migration system. Pre-apply comparison shows diff between expected (from migration) and actual (from database) state before applying migrations. Safety validator explicitly blocks unsafe DROP + CREATE operations, preventing migrations from blindly dropping and recreating existing database objects without validation.
 
 ---
 
-### E. Drift Detection ⚠️ (autoloaded but implementation missing)
+### E. Drift Detection ✅ (fully implemented)
 
 System must detect:
-- ❌ Missing triggers (not implemented)
-- ❌ Version mismatch (not implemented)
-- ❌ Function body drift (not implemented)
-- ❌ Manual SQL overrides (not implemented)
-- ❌ Unknown external triggers (not implemented)
+- ✅ Missing triggers (implemented via DROPPED state)
+- ✅ Version mismatch (implemented via checksum comparison)
+- ✅ Function body drift (implemented via checksum comparison)
+- ✅ Manual SQL overrides (implemented via MANUAL_OVERRIDE state)
+- ✅ Unknown external triggers (implemented via UNKNOWN state)
 
 Drift states:
-1. ❌ Managed & In Sync (constants defined, logic missing)
-2. ❌ Managed & Drifted (constants defined, logic missing)
-3. ❌ Manual Override (constants defined, logic missing)
-4. ❌ Disabled (constants defined, logic missing)
-5. ❌ Dropped (Recorded) (constants defined, logic missing)
-6. ❌ Unknown (External) (constants defined, logic missing)
+1. ✅ Managed & In Sync (fully implemented)
+2. ✅ Managed & Drifted (fully implemented)
+3. ✅ Manual Override (fully implemented)
+4. ✅ Disabled (fully implemented)
+5. ✅ Dropped (Recorded) (fully implemented)
+6. ✅ Unknown (External) (fully implemented)
 
 ---
 
@@ -134,14 +136,14 @@ Provide console APIs:
 ~~PgSqlTriggers::Registry.enabled~~
 ~~PgSqlTriggers::Registry.disabled~~
 ~~PgSqlTriggers::Registry.for_table(:users)~~
-~~PgSqlTriggers::Registry.diff~~ (⚠️ calls drift detection which is not fully implemented)
+~~PgSqlTriggers::Registry.diff~~ (✅ fully working with drift detection)
 ~~PgSqlTriggers::Registry.validate!~~
 
 ~~No raw SQL required by users.~~
 
 ---
 
-## 4. Free-Form SQL Execution (MANDATORY) ❌ (routes exist but implementation missing)
+## 4. Free-Form SQL Execution (MANDATORY) ❌ (routes defined but no implementation)
 
 The gem MUST support free-form SQL execution.
 
@@ -154,7 +156,7 @@ This is required for:
 
 Free-form SQL is wrapped in **named SQL capsules**:
 
-- ❌ Must be named (routes exist, implementation missing)
+- ❌ Must be named (routes defined in `config/routes.rb`, no controller exists)
 - ❌ Must declare environment (not implemented)
 - ❌ Must declare purpose (not implemented)
 - ❌ Must be applied explicitly (not implemented)
@@ -165,6 +167,8 @@ Rules:
 - ❌ Registry updated (not implemented)
 - ❌ Marked as `source = manual_sql` (not implemented)
 
+**Status:** Routes exist for `sql_capsules#new`, `sql_capsules#create`, `sql_capsules#show`, and `sql_capsules#execute`, but no controller, views, or logic implemented. Autoload reference exists in `lib/pg_sql_triggers/sql.rb` but file does not exist.
+
 ---
 
 ## 5. Permissions Model v1 ⚠️ (structure exists, not enforced)
@@ -264,27 +268,27 @@ trigger.enable!(confirmation: "EXECUTE TRIGGER_ENABLE")
 
 UI is operational, not decorative.
 
-### Dashboard ✅ (partial)
-- ~~Trigger name~~
-- ~~Table~~
-- ~~Version~~
-- ~~Status~~
-- ~~Source~~
-- ⚠️ Drift state (displayed but drift detection not fully implemented)
-- ~~Environment~~
-- ⚠️ Last applied (installed_at exists but not displayed)
-
-### Trigger Detail Page ❌ (not implemented)
-- ❌ Summary panel (trigger info shown in tables/show but no dedicated page)
-- ❌ SQL diff
-- ❌ Registry state
-
-### Actions (State-Based) ⚠️ (structure exists, not fully implemented)
-- ⚠️ Enable (method exists but no UI buttons/flow)
-- ⚠️ Disable (method exists but no UI buttons/flow)
-- ❌ Drop (not implemented)
-- ❌ Re-execute (not implemented)
-- ❌ Execute SQL capsule (not implemented)
+### Dashboard ✅ (implemented, drift display pending)
+- ✅ Trigger name
+- ✅ Table
+- ✅ Version
+- ✅ Status (enabled/disabled)
+- ✅ Source
+- ⚠️ Drift state (UI shows drift count but drift detection logic not implemented)
+- ✅ Environment
+- ❌ Last applied (installed_at exists in registry but not displayed in dashboard)
+
+### Trigger Detail Page ⚠️ (partial - shown in tables/show but not dedicated)
+- ⚠️ Summary panel (trigger info shown in tables/show view but no dedicated detail route/page)
+- ❌ SQL diff (expected vs actual comparison)
+- ⚠️ Registry state (basic info shown, but not comprehensive state display)
+
+### Actions (State-Based) ⚠️ (backend methods exist, UI actions missing)
+- ⚠️ Enable (console method `TriggerRegistry#enable!` exists with kill switch protection, but no UI buttons)
+- ⚠️ Disable (console method `TriggerRegistry#disable!` exists with kill switch protection, but no UI buttons)
+- ❌ Drop (not implemented - no method or UI)
+- ❌ Re-execute (not implemented - no method or UI)
+- ❌ Execute SQL capsule (not implemented - SQL capsules not implemented)
 
 Buttons must:
 - ❌ Be permission-aware (permissions defined but not enforced in UI)
@@ -335,6 +339,26 @@ This gem must be described as:
 
 ## 13. Implementation Status & Improvements Needed
 
+### 📊 Quick Status Summary
+
+**Fully Implemented:**
+- ✅ Trigger Declaration DSL (Section 3.A)
+- ✅ Trigger Generation (Section 3.B)
+- ✅ Trigger Registry (Section 3.C) - with consistent field-concatenation checksum algorithm
+- ✅ Safe Apply & Deploy (Section 3.D) - fully implemented with safety validation
+- ✅ Drift Detection (Section 3.E) - fully implemented with all 6 drift states
+- ✅ Rails Console Introspection (Section 3.F) - including working diff method
+- ✅ Kill Switch for Production Safety (Section 6) - fully implemented
+- ✅ Basic UI Dashboard (Section 8) - migration management, tables view, generator
+
+**Partially Implemented:**
+- ⚠️ UI (Section 8) - dashboard and tables view exist, but no dedicated trigger detail page, no enable/disable buttons
+- ⚠️ Permissions Model (Section 5) - structure exists but not enforced
+
+**Not Implemented (Critical):**
+- ❌ SQL Capsules (Section 4) - MANDATORY feature, routes exist but no implementation
+- ❌ Drop & Re-Execute Flow (Section 9) - CRITICAL operational requirement
+
 ### ✅ Achieved Features
 
 **Core Infrastructure:**
@@ -343,6 +367,7 @@ This gem must be described as:
 - ✅ Trigger Generation (form-based wizard, DSL + migration files) - Section 3.B
 - ✅ Database Introspection (tables, triggers, columns) - Supporting infrastructure
 - ✅ Trigger Migrations system (rake tasks + UI) - Supporting infrastructure
+- ✅ Drift Detection (all 6 states, detector, reporter, console APIs) - Section 3.E
 - ✅ Rails Console Introspection APIs (`PgSqlTriggers::Registry.*`) - Section 3.F
 - ✅ Enable/Disable trigger methods on TriggerRegistry model - Basic functionality
 - ✅ Kill Switch for Production Safety (fully implemented) - Section 6
@@ -363,16 +388,35 @@ This gem must be described as:
 
 **From Section 3.C (Trigger Registry):**
 - ✅ Registry tracks: trigger_name, table_name, version, enabled, source, environment, installed_at, last_verified_at
-- ✅ Registry tracks checksum (⚠️ partially - uses placeholder in registry manager)
+- ✅ Registry tracks checksum (✅ consistent field-concatenation algorithm across all creation paths)
 - ✅ Rails knows what exists and how it was created
 
+**From Section 3.E (Drift Detection):**
+- ✅ Drift::Detector class with all 6 drift states
+- ✅ Drift::Reporter class for formatting drift reports
+- ✅ Drift::DbQueries helper for PostgreSQL system catalog queries
+- ✅ Detection of missing triggers (DROPPED state)
+- ✅ Detection of version/function body drift (DRIFTED state via checksum)
+- ✅ Detection of manual SQL overrides (MANUAL_OVERRIDE state)
+- ✅ Detection of unknown external triggers (UNKNOWN state)
+- ✅ Detection of disabled triggers (DISABLED state)
+- ✅ Detection of in-sync triggers (IN_SYNC state)
+- ✅ Registry convenience methods (drifted, in_sync, unknown_triggers, dropped)
+- ✅ TriggerRegistry instance methods (drift_state, drift_result, drifted?, in_sync?, dropped?)
+- ✅ Comprehensive test coverage for Detector and Reporter
+
 **From Section 3.F (Rails Console Introspection):**
 - ✅ `PgSqlTriggers::Registry.list` (note: namespace differs slightly from goal)
 - ✅ `PgSqlTriggers::Registry.enabled`
 - ✅ `PgSqlTriggers::Registry.disabled`
 - ✅ `PgSqlTriggers::Registry.for_table(:users)`
 - ✅ `PgSqlTriggers::Registry.validate!`
-- ✅ No raw SQL required by users for basic operations
+- ✅ `PgSqlTriggers::Registry.diff` (fully working with drift detection)
+- ✅ `PgSqlTriggers::Registry.drifted` (returns all drifted triggers)
+- ✅ `PgSqlTriggers::Registry.in_sync` (returns all in-sync triggers)
+- ✅ `PgSqlTriggers::Registry.unknown_triggers` (returns all external triggers)
+- ✅ `PgSqlTriggers::Registry.dropped` (returns all dropped triggers)
+- ✅ No raw SQL required by users for basic operations (enable/disable via console methods)
 
 **From Section 5 (Permissions Model):**
 - ✅ Permission structure exists (Viewer, Operator, Admin roles defined)
@@ -388,44 +432,43 @@ This gem must be described as:
 - ✅ Thread-safe override mechanism
 
 **From Section 8 (UI):**
-- ✅ Dashboard with: Trigger name, Table, Version, Status, Source, Environment
-- ✅ Dashboard displays drift state (⚠️ drift detection not fully implemented)
+- ✅ Dashboard with: Trigger name, Table, Version, Status (enabled/disabled), Source, Environment
+- ⚠️ Dashboard displays drift count (UI shows drifted stat, but drift detection logic not implemented, so will be 0 or error)
+- ✅ Tables view with table listing and trigger details
+- ✅ Tables/show view shows trigger info for a specific table (not a dedicated trigger detail page)
+- ✅ Generator UI (form-based wizard for creating triggers)
+- ✅ Migration management UI (up/down/redo with kill switch protection)
+- ❌ Trigger detail page (no dedicated route/page, only shown in tables/show)
 
 ---
 
 ### 🔴 HIGH PRIORITY - Critical Missing Features
 
-#### 1. Drift Detection (Section 3.E)
-**Priority:** HIGH - Core functionality
+**Note:** Priorities have been adjusted based on actual implementation status. SQL Capsules (marked MANDATORY in Section 4) moved from MEDIUM to HIGH priority as it's a critical missing feature.
+
+#### 1. SQL Capsules (MANDATORY - Section 4) - CRITICAL
+**Priority:** HIGH - Mandatory feature for emergency operations
 
-**Status:** Autoloaded but implementation files missing
+**Status:** Routes defined, but no implementation
 
 **Missing Files:**
-- ❌ `lib/pg_sql_triggers/drift/detector.rb` - Drift detection logic
-- ❌ `lib/pg_sql_triggers/drift/reporter.rb` - Drift reporting
+- ❌ `lib/pg_sql_triggers/sql/capsule.rb` - SQL capsule definition class (autoloaded but file doesn't exist)
+- ❌ `lib/pg_sql_triggers/sql/executor.rb` - SQL execution with transaction, checksum, registry update
+- ❌ `app/controllers/pg_sql_triggers/sql_capsules_controller.rb` - UI controller (routes reference it but it doesn't exist)
+- ❌ SQL capsule views (new, show, create, execute)
+- ❌ SQL capsule storage mechanism (could use registry table with `source = manual_sql`)
 
 **Missing Functionality:**
-- ❌ Detection of missing triggers
-- ❌ Version mismatch detection
-- ❌ Function body drift detection
-- ❌ Manual SQL override detection
-- ❌ Unknown external trigger detection
-- ❌ All 6 drift states properly implemented (Managed & In Sync, Managed & Drifted, Manual Override, Disabled, Dropped (Recorded), Unknown (External))
-
-#### 2. Safe Apply & Deploy (Section 3.D)
-**Priority:** HIGH - Deployment safety
+- ❌ Named SQL capsules with environment and purpose declaration
+- ❌ Explicit application workflow with confirmation
+- ❌ Transactional execution
+- ❌ Checksum verification
+- ❌ Registry update with `source = manual_sql`
+- ❌ Kill switch protection (should block in production)
 
-**Status:** Not implemented
+**Impact:** Critical feature marked as MANDATORY in goal but completely missing. Emergency SQL execution not possible.
 
-**Missing:**
-- ❌ Safe apply method that runs in a transaction
-- ❌ Diff expected vs actual state before applying
-- ❌ Explicit safety checks (never blindly DROP + CREATE)
-- ❌ Rollback on failure with registry rollback
-- ❌ Atomic registry update
-- ❌ Integration with migrations and generator service
-
-#### 3. Drop & Re-Execute Flow (CRITICAL - Section 9)
+#### 2. Drop & Re-Execute Flow (Section 9) - CRITICAL
 **Priority:** HIGH - Operational requirements
 
 **Status:** Not implemented
@@ -437,30 +480,35 @@ This gem must be described as:
 - ❌ Confirmation dialogs with typed confirmation text
 - ❌ Transactional execution and registry update
 
----
+**Impact:** Cannot safely drop or re-execute triggers. Operational workflows blocked.
 
-### 🟡 MEDIUM PRIORITY - User-Facing Features
+#### 3. Safe Apply & Deploy (Section 3.D) - ✅ FULLY IMPLEMENTED
+**Priority:** MEDIUM-HIGH - Deployment safety enhancement
 
-#### 4. SQL Capsules (MANDATORY - Section 4)
-**Priority:** MEDIUM - Emergency operations
+**Status:** Fully implemented - pre-apply comparison and safety validation added
 
-**Status:** Routes exist but implementation missing
+**What Works:**
+- ✅ Migrations run in transactions
+- ✅ Migration rollback supported
+- ✅ Registry updated during migrations
+- ✅ Pre-apply comparison (diff expected vs actual) before migration execution
+- ✅ Diff reporting shows what will change before applying
+- ✅ Safety validator blocks unsafe DROP + CREATE operations
+- ✅ Explicit validation prevents migrations from blindly dropping and recreating existing objects
 
-**Missing Files:**
-- ❌ `lib/pg_sql_triggers/sql/capsule.rb` - SQL capsule definition class
-- ❌ `lib/pg_sql_triggers/sql/executor.rb` - SQL execution with transaction, checksum, registry update
-- ❌ `app/controllers/pg_sql_triggers/sql_capsules_controller.rb` - UI controller
-- ❌ SQL capsule views (new, show, create)
-- ❌ SQL capsule storage mechanism
-
-**Requirements to implement:**
-- Named SQL capsules with environment and purpose declaration
-- Explicit application workflow
-- Transactional execution
-- Checksum verification
-- Registry update with `source = manual_sql`
-
-#### 5. Trigger Detail Page (Section 8 - UI)
+**Implementation Details:**
+- `Migrator::SafetyValidator` class detects unsafe DROP + CREATE patterns in migrations
+- Validator checks if migrations would drop existing database objects and recreate them
+- Blocks migration execution if unsafe patterns detected (unless explicitly allowed)
+- Configuration option `allow_unsafe_migrations` (default: false) for global override
+- Environment variable `ALLOW_UNSAFE_MIGRATIONS=true` for per-migration override
+- Provides clear error messages explaining unsafe operations and how to proceed
+
+---
+
+### 🟡 MEDIUM PRIORITY - User-Facing Features
+
+#### 4. Trigger Detail Page (Section 8 - UI)
 **Priority:** MEDIUM - Usability
 
 **Status:** Partial (shown in tables/show but not dedicated page)
@@ -473,51 +521,43 @@ This gem must be described as:
 - ❌ Action buttons (Enable/Disable/Drop/Re-execute/Execute SQL capsule)
 - ❌ Permission-aware, environment-aware, kill switch-aware button visibility
 
-#### 6. UI Actions & Permissions Enforcement (Section 8)
-**Priority:** MEDIUM - Usability & security
+#### 5. UI Actions (Section 8)
+**Priority:** MEDIUM - Usability
 
-**Status:** Structure exists but not fully enforced
+**Status:** Backend methods exist, UI buttons missing
 
 **Missing:**
-- ❌ Enable/Disable buttons in dashboard and detail pages
-- ❌ Drop button (Admin only)
-- ❌ Re-execute button with flow
-- ❌ Execute SQL capsule button (Admin only)
-- ❌ Permission checking in controllers
-- ❌ Permission checking in UI (hide/disable buttons)
-- ✅ Kill switch enforcement in UI (fully implemented - see Section 6)
-- ❌ Environment awareness in UI actions
-
----
+- ❌ Enable/Disable buttons in dashboard and tables/show pages (methods exist: `TriggerRegistry#enable!` and `#disable!`)
+- ❌ Drop button (requires drop functionality from Section 9)
+- ❌ Re-execute button (requires re-execute functionality from Section 9)
+- ❌ Execute SQL capsule button (requires SQL capsules from Section 4)
 
-### 🟢 LOW PRIORITY - Polish & Improvements
+**What Works:**
+- ✅ Kill switch enforcement in UI (fully implemented - see Section 6)
+- ✅ Migration actions (up/down/redo) with kill switch protection
 
-#### 8. Console/CLI Permission Enforcement (Section 5)
-**Priority:** LOW - Security polish
+#### 6. Permissions Enforcement (Section 5)
+**Priority:** MEDIUM - Security
 
-**Status:** Not enforced
+**Status:** Permission structure exists but not enforced
 
 **Missing:**
-- ❌ Permission checks in `TriggerRegistry#enable!` and `disable!`
+- ❌ Permission checking in controllers (UI actions should check permissions)
+- ❌ Permission checking in UI (hide/disable buttons based on role)
+- ❌ Permission checks in `TriggerRegistry#enable!` and `disable!` (currently only kill switch checked)
 - ❌ Permission checks in rake tasks
 - ❌ Permission checks in console APIs
 - ❌ Actor context passing through all operations
 
-#### 9. Checksum Implementation Consistency
-**Priority:** LOW - Technical debt
-
-**Status:** Partially implemented
+**What Exists:**
+- ✅ Permission structure (Viewer, Operator, Admin roles defined)
+- ✅ Permission model classes (`PgSqlTriggers::Permissions::Checker`)
 
-**Issues:**
-- ⚠️ Registry manager uses "placeholder" checksum instead of calculating real checksum
-- ✅ Generator service calculates checksum correctly
-- ⚠️ Need consistent checksum calculation across all creation paths
+---
 
-**Fix Required:**
-- Replace "placeholder" in `Registry::Manager.register` with actual checksum calculation
-- Ensure checksum is calculated consistently (same algorithm as generator)
+### 🟢 LOW PRIORITY - Polish & Improvements
 
-#### 10. Enhanced Logging & Audit Trail
+#### 7. Enhanced Logging & Audit Trail
 **Priority:** LOW - Operational polish
 
 **Status:** Kill switch logging is comprehensive; audit trail could be enhanced
@@ -527,7 +567,7 @@ This gem must be described as:
 - ✅ Kill switch overrides logging (fully implemented)
 - ⚠️ Comprehensive audit trail table for production operation attempts (optional enhancement - logging exists but structured audit table would be better)
 
-#### 11. Error Handling Consistency
+#### 8. Error Handling Consistency
 **Priority:** LOW - Code quality
 
 **Status:** Kill switch errors are properly implemented; other error types need consistency
@@ -535,10 +575,10 @@ This gem must be described as:
 **Missing:**
 - ✅ Kill switch violations raise `KillSwitchError` (fully implemented)
 - ❌ Permission violations should raise `PermissionError`
-- ❌ Drift issues should raise `DriftError`
+- ✅ Drift detection implemented (can be used for error handling)
 - ❌ Consistent error handling across all operations
 
-#### 12. Testing Coverage
+#### 9. Testing Coverage
 **Priority:** LOW - Quality assurance
 
 **Status:** Kill switch has comprehensive tests; other areas need coverage
@@ -546,11 +586,11 @@ This gem must be described as:
 **Missing:**
 - ❌ SQL capsules need tests
 - ✅ Kill switch has comprehensive tests (fully tested)
-- ❌ Drift detection needs tests
+- ✅ Drift detection has comprehensive tests (fully tested)
 - ❌ Permission enforcement needs tests
 - ❌ Drop/re-execute flow needs tests
 
-#### 13. Documentation Updates
+#### 10. Documentation Updates
 **Priority:** LOW - User experience
 
 **Status:** Kill switch is well documented; other areas need documentation
@@ -560,17 +600,19 @@ This gem must be described as:
 - ✅ README includes kill switch documentation with enforcement details (fully documented)
 - ❌ Need examples for SQL capsules
 - ❌ Need examples for permission configuration
-
-#### 14. Partial Implementation Notes
-**Priority:** LOW - Known issues
-
-- ⚠️ Permissions Model - Structure exists but not enforced in UI/CLI/console
-- ✅ Kill Switch - Fully implemented (see Section 6 for details)
-- ⚠️ Checksum - Implemented in generator service correctly, but Registry::Manager.register uses "placeholder" (needs fix for DSL-registered triggers)
-- ⚠️ Drift Detection - Constants defined, Detector and Reporter classes missing
-- ⚠️ Dashboard - Drift state displayed but drift detection not fully implemented (will work once drift detection is implemented)
-- ⚠️ Dashboard - Last applied (installed_at exists in registry but not displayed in UI)
-- ⚠️ `PgSqlTriggers::Registry.diff` - Calls drift detection which is not fully implemented
+- ✅ Drift detection fully documented in implementation plan
+
+#### 11. Partial Implementation Notes
+**Priority:** LOW - Known issues and technical debt
+
+**Known Issues:**
+- ⚠️ **Permissions Model** - Structure exists but not enforced in UI/CLI/console
+- ✅ **Kill Switch** - Fully implemented (see Section 6 for details)
+- ✅ **Checksum** - Fully implemented with consistent field-concatenation algorithm across all creation paths
+- ✅ **Drift Detection** - Fully implemented with all 6 drift states, comprehensive tests, and console APIs
+- ⚠️ **Dashboard** - `installed_at` exists in registry table but not displayed in UI
+- ⚠️ **Trigger Detail Page** - No dedicated route/page, info shown in tables/show view only
+- ⚠️ **Enable/Disable UI** - Console methods exist with kill switch protection, but no UI buttons
 
 ---
 

data/README.md

@@ -117,6 +117,12 @@ After checking out the repo, run `bin/setup` to install dependencies. Run `rake
 
 To install this gem locally, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and run `bundle exec rake release`.
 
+## Test Coverage
+
+See [COVERAGE.md](COVERAGE.md) for detailed coverage information.
+
+**Total Coverage: 84.97%**
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/samaswin87/pg_sql_triggers.

data/app/controllers/pg_sql_triggers/dashboard_controller.rb

@@ -4,11 +4,14 @@ module PgSqlTriggers
   class DashboardController < ApplicationController
     def index
       @triggers = PgSqlTriggers::TriggerRegistry.order(created_at: :desc)
+
+      # Get drift summary
+      drift_summary = PgSqlTriggers::Drift::Reporter.summary
       @stats = {
         total: @triggers.count,
         enabled: @triggers.enabled.count,
         disabled: @triggers.disabled.count,
-        drifted: 0 # Will be calculated by Drift::Detector
+        drifted: drift_summary[:drifted]
       }
 
       # Migration status with pagination

data/app/controllers/pg_sql_triggers/generator_controller.rb

@@ -8,7 +8,16 @@ module PgSqlTriggers
     # GET /generator/new
     # Display the multi-step form wizard
     def new
-      @form = PgSqlTriggers::Generator::Form.new
+      # Restore form data from session if available (when user clicks "Back to Edit")
+      session_data = session[:generator_form_data]
+      if session_data
+        # Convert to hash and symbolize keys for Form initialization
+        form_data = session_data.is_a?(Hash) ? session_data.symbolize_keys : session_data.to_h.symbolize_keys
+        @form = PgSqlTriggers::Generator::Form.new(form_data)
+        session.delete(:generator_form_data)
+      else
+        @form = PgSqlTriggers::Generator::Form.new
+      end
       @available_tables = fetch_available_tables
     end
 
@@ -17,7 +26,19 @@ module PgSqlTriggers
     def preview
       @form = PgSqlTriggers::Generator::Form.new(generator_params)
 
+      # If user clicked "Back to Edit", store form data in session and redirect
+      if params[:back_to_edit].present?
+        # Store form data as a hash (convert ActionController::Parameters to hash)
+        session[:generator_form_data] = generator_params.to_h
+        redirect_to new_generator_path
+        return
+      end
+
       if @form.valid?
+        # Store form data in session so it can be restored if user clicks "Back to Edit"
+        # Convert ActionController::Parameters to hash
+        session[:generator_form_data] = generator_params.to_h
+
         # Validate SQL function body (required field)
         @sql_validation = validate_function_sql(@form)
 
@@ -58,6 +79,8 @@ module PgSqlTriggers
         result = PgSqlTriggers::Generator::Service.create_trigger(@form, actor: current_actor)
 
         if result[:success]
+          # Clear session data after successful creation
+          session.delete(:generator_form_data)
           files_msg = "Migration: #{result[:migration_path]}, DSL: #{result[:dsl_path]}"
           redirect_to root_path,
                       notice: "Trigger generated successfully. Files created: #{files_msg}"
@@ -104,7 +127,7 @@ module PgSqlTriggers
     def generator_params
       params.require(:pg_sql_triggers_generator_form).permit(
         :trigger_name, :table_name, :function_name, :version,
-        :enabled, :condition, :generate_function_stub, :function_body,
+        :enabled, :condition, :timing, :generate_function_stub, :function_body,
         events: [], environments: []
       )
     end
@@ -137,13 +160,52 @@ module PgSqlTriggers
       return nil if form.function_body.blank?
 
       # Create a temporary trigger registry object for validation
-      temp_registry = PgSqlTriggers::TriggerRegistry.new(
+      # Only include condition if the column exists
+      registry_attributes = {
         trigger_name: form.trigger_name,
+        table_name: form.table_name,
         function_body: form.function_body
-      )
+      }
+      # Only set condition if the column exists in the database
+      if PgSqlTriggers::TriggerRegistry.column_names.include?("condition")
+        registry_attributes[:condition] = form.condition
+      end
+
+      temp_registry = PgSqlTriggers::TriggerRegistry.new(registry_attributes)
+
+      # Build definition JSON for condition validation
+      definition = {
+        name: form.trigger_name,
+        table_name: form.table_name,
+        function_name: form.function_name,
+        events: form.events.compact_blank,
+        version: form.version,
+        enabled: form.enabled,
+        environments: form.environments.compact_blank,
+        condition: form.condition,
+        timing: form.timing || "before",
+        function_body: form.function_body
+      }
+      temp_registry.definition = definition.to_json
 
       validator = PgSqlTriggers::Testing::SyntaxValidator.new(temp_registry)
-      validator.validate_function_syntax
+
+      # Validate function syntax
+      function_result = validator.validate_function_syntax
+      return function_result unless function_result[:valid]
+
+      # Validate condition if present
+      if form.condition.present?
+        condition_result = validator.validate_condition
+        unless condition_result[:valid]
+          return {
+            valid: false,
+            error: "WHEN condition validation failed: #{condition_result[:error]}"
+          }
+        end
+      end
+
+      function_result
     rescue StandardError => e
       { valid: false, error: "Validation error: #{e.message}" }
     end