pg_search 2.3.0 → 2.3.6

data/spec/lib/pg_search/multisearch_spec.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require "active_support/deprecation"
 
+# rubocop:disable RSpec/NestedGroups
 describe PgSearch::Multisearch do
-  with_table "pg_search_documents", {}, &DOCUMENTS_SCHEMA
+  with_table "pg_search_documents", &DOCUMENTS_SCHEMA
 
   with_model :MultisearchableModel do
     table do |t|
@@ -18,22 +20,31 @@ describe PgSearch::Multisearch do
 
   let(:model) { MultisearchableModel }
   let(:connection) { model.connection }
-  let(:documents) { double(:documents) }
 
   describe ".rebuild" do
     before do
       model.multisearchable against: :title
     end
 
-    it "should operate inside a transaction" do
-      expect(model).to receive(:transaction).once
+    it "operates inside a transaction" do
+      allow(model).to receive(:transaction)
 
-      PgSearch::Multisearch.rebuild(model)
+      described_class.rebuild(model)
+      expect(model).to have_received(:transaction).once
+    end
+
+    context "when transactional is false" do
+      it "does not operate inside a transaction" do
+        allow(model).to receive(:transaction)
+
+        described_class.rebuild(model, transactional: false)
+        expect(model).not_to have_received(:transaction)
+      end
     end
 
     describe "cleaning up search documents for this model" do
       before do
-        connection.execute <<-SQL.strip_heredoc
+        connection.execute <<~SQL.squish
           INSERT INTO pg_search_documents
             (searchable_type, searchable_id, content, created_at, updated_at)
             VALUES
@@ -47,28 +58,39 @@ describe PgSearch::Multisearch do
       end
 
       context "when clean_up is not passed" do
-        it "should delete the document for the model" do
-          PgSearch::Multisearch.rebuild(model)
+        it "deletes the document for the model" do
+          described_class.rebuild(model)
           expect(PgSearch::Document.count).to eq(1)
           expect(PgSearch::Document.first.searchable_type).to eq("Bar")
         end
       end
 
       context "when clean_up is true" do
-        let(:clean_up) { true }
-
-        it "should delete the document for the model" do
-          PgSearch::Multisearch.rebuild(model, clean_up)
+        it "deletes the document for the model" do
+          described_class.rebuild(model, clean_up: true)
           expect(PgSearch::Document.count).to eq(1)
           expect(PgSearch::Document.first.searchable_type).to eq("Bar")
         end
       end
 
       context "when clean_up is false" do
-        let(:clean_up) { false }
+        it "does not delete the document for the model" do
+          described_class.rebuild(model, clean_up: false)
+          expect(PgSearch::Document.count).to eq(2)
+        end
+      end
 
-        it "should not delete the document for the model" do
-          PgSearch::Multisearch.rebuild(model, clean_up)
+      context "when deprecated_clean_up is true" do
+        it "deletes the document for the model" do
+          ActiveSupport::Deprecation.silence { described_class.rebuild(model, true) }
+          expect(PgSearch::Document.count).to eq(1)
+          expect(PgSearch::Document.first.searchable_type).to eq("Bar")
+        end
+      end
+
+      context "when deprecated_clean_up is false" do
+        it "does not delete the document for the model" do
+          ActiveSupport::Deprecation.silence { described_class.rebuild(model, false) }
           expect(PgSearch::Document.count).to eq(2)
         end
       end
@@ -76,7 +98,7 @@ describe PgSearch::Multisearch do
       context "when the model implements .rebuild_pg_search_documents" do
         before do
           def model.rebuild_pg_search_documents
-            connection.execute <<-SQL.strip_heredoc
+            connection.execute <<~SQL.squish
               INSERT INTO pg_search_documents
                 (searchable_type, searchable_id, content, created_at, updated_at)
                 VALUES
@@ -85,31 +107,36 @@ describe PgSearch::Multisearch do
           end
         end
 
-        it "should call .rebuild_pg_search_documents and skip the default behavior" do
-          expect(PgSearch::Multisearch).not_to receive(:rebuild_sql)
-          PgSearch::Multisearch.rebuild(model)
+        it "calls .rebuild_pg_search_documents and skips the default behavior" do
+          without_partial_double_verification do
+            allow(model).to receive(:rebuild_sql)
+            described_class.rebuild(model)
 
-          record = PgSearch::Document.find_by_searchable_type_and_searchable_id("Baz", 789)
-          expect(record.content).to eq("baz")
+            record = PgSearch::Document.find_by(searchable_type: "Baz", searchable_id: 789)
+            expect(model).not_to have_received(:rebuild_sql)
+            expect(record.content).to eq("baz")
+          end
         end
       end
     end
 
     describe "inserting the new documents" do
       let!(:new_models) { [] }
+
       before do
         new_models << model.create!(title: "Foo", content: "Bar")
         new_models << model.create!(title: "Baz", content: "Bar")
       end
 
-      it "should create new documents for the two models" do
-        PgSearch::Multisearch.rebuild(model)
+      it "creates new documents for the two models" do
+        described_class.rebuild(model)
         expect(PgSearch::Document.last(2).map(&:searchable).map(&:title)).to match_array(new_models.map(&:title))
       end
     end
 
     describe "the generated SQL" do
       let(:now) { Time.now }
+
       before { allow(Time).to receive(:now).and_return(now) }
 
       context "with one attribute" do
@@ -117,8 +144,8 @@ describe PgSearch::Multisearch do
           model.multisearchable against: [:title]
         end
 
-        it "should generate the proper SQL code" do
-          expected_sql = <<-SQL.strip_heredoc
+        it "generates the proper SQL code" do
+          expected_sql = <<~SQL.squish
             INSERT INTO #{PgSearch::Document.quoted_table_name} (searchable_type, searchable_id, content, created_at, updated_at)
               SELECT #{connection.quote(model.name)} AS searchable_type,
                      #{model.quoted_table_name}.id AS searchable_id,
@@ -133,7 +160,7 @@ describe PgSearch::Multisearch do
           statements = []
           allow(connection).to receive(:execute) { |sql| statements << sql.strip }
 
-          PgSearch::Multisearch.rebuild(model)
+          described_class.rebuild(model)
 
           expect(statements).to include(expected_sql.strip)
         end
@@ -144,8 +171,8 @@ describe PgSearch::Multisearch do
           model.multisearchable against: %i[title content]
         end
 
-        it "should generate the proper SQL code" do
-          expected_sql = <<-SQL.strip_heredoc
+        it "generates the proper SQL code" do
+          expected_sql = <<~SQL.squish
             INSERT INTO #{PgSearch::Document.quoted_table_name} (searchable_type, searchable_id, content, created_at, updated_at)
               SELECT #{connection.quote(model.name)} AS searchable_type,
                      #{model.quoted_table_name}.id AS searchable_id,
@@ -160,7 +187,7 @@ describe PgSearch::Multisearch do
           statements = []
           allow(connection).to receive(:execute) { |sql| statements << sql.strip }
 
-          PgSearch::Multisearch.rebuild(model)
+          described_class.rebuild(model)
 
           expect(statements).to include(expected_sql.strip)
         end
@@ -168,3 +195,4 @@ describe PgSearch::Multisearch do
     end
   end
 end
+# rubocop:enable RSpec/NestedGroups