pg_search 2.1.2 → 2.3.6

data/spec/lib/pg_search/multisearchable_spec.rb

@@ -1,36 +1,66 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
+# rubocop:disable RSpec/NestedGroups
 describe PgSearch::Multisearchable do
-  with_table "pg_search_documents", {}, &DOCUMENTS_SCHEMA
+  with_table "pg_search_documents", &DOCUMENTS_SCHEMA
 
   describe "a model that is multisearchable" do
     with_model :ModelThatIsMultisearchable do
       model do
-        include PgSearch
+        include PgSearch::Model
         multisearchable
       end
     end
 
+    with_model :MultisearchableParent do
+      table do |t|
+        t.string :secret
+      end
+
+      model do
+        include PgSearch::Model
+        multisearchable
+
+        has_many :multisearchable_children, dependent: :destroy
+      end
+    end
+
+    with_model :MultisearchableChild do
+      table do |t|
+        t.belongs_to :multisearchable_parent, index: false
+      end
+
+      model do
+        belongs_to :multisearchable_parent
+
+        after_destroy do
+          multisearchable_parent.update_attribute(:secret, rand(1000).to_s) # rubocop:disable Rails/SkipsModelValidations
+        end
+      end
+    end
+
     describe "callbacks" do
       describe "after_create" do
         let(:record) { ModelThatIsMultisearchable.new }
 
         describe "saving the record" do
-          it "should create a PgSearch::Document record" do
+          it "creates a PgSearch::Document record" do
             expect { record.save! }.to change(PgSearch::Document, :count).by(1)
           end
 
           context "with multisearch disabled" do
             before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(false) }
 
-            it "should not create a PgSearch::Document record" do
+            it "does not create a PgSearch::Document record" do
               expect { record.save! }.not_to change(PgSearch::Document, :count)
             end
           end
         end
 
         describe "the document" do
-          it "should be associated to the record" do
+          it "is associated to the record" do
             record.save!
             newest_pg_search_document = PgSearch::Document.last
             expect(record.pg_search_document).to eq(newest_pg_search_document)
@@ -47,20 +77,22 @@ describe PgSearch::Multisearchable do
 
           describe "saving the record" do
             it "calls save on the pg_search_document" do
-              expect(record.pg_search_document).to receive(:save)
+              allow(record.pg_search_document).to receive(:save)
               record.save!
+              expect(record.pg_search_document).to have_received(:save)
             end
 
-            it "should not create a PgSearch::Document record" do
+            it "does not create a PgSearch::Document record" do
               expect { record.save! }.not_to change(PgSearch::Document, :count)
             end
 
             context "with multisearch disabled" do
               before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(false) }
 
-              it "should not create a PgSearch::Document record" do
-                expect(record.pg_search_document).not_to receive(:save)
+              it "does not create a PgSearch::Document record" do
+                allow(record.pg_search_document).to receive(:save)
                 expect { record.save! }.not_to change(PgSearch::Document, :count)
+                expect(record.pg_search_document).not_to have_received(:save)
               end
             end
           end
@@ -70,14 +102,14 @@ describe PgSearch::Multisearchable do
           before { record.pg_search_document = nil }
 
           describe "saving the record" do
-            it "should create a PgSearch::Document record" do
+            it "creates a PgSearch::Document record" do
               expect { record.save! }.to change(PgSearch::Document, :count).by(1)
             end
 
             context "with multisearch disabled" do
               before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(false) }
 
-              it "should not create a PgSearch::Document record" do
+              it "does not create a PgSearch::Document record" do
                 expect { record.save! }.not_to change(PgSearch::Document, :count)
               end
             end
@@ -86,84 +118,114 @@ describe PgSearch::Multisearchable do
       end
 
       describe "after_destroy" do
-        it "should remove its document" do
+        it "removes its document" do
           record = ModelThatIsMultisearchable.create!
           document = record.pg_search_document
           expect { record.destroy }.to change(PgSearch::Document, :count).by(-1)
           expect { PgSearch::Document.find(document.id) }.to raise_error(ActiveRecord::RecordNotFound)
         end
+
+        it "removes its document in case of complex associations" do
+          parent = MultisearchableParent.create!
+
+          MultisearchableChild.create!(multisearchable_parent: parent)
+          MultisearchableChild.create!(multisearchable_parent: parent)
+
+          document = parent.pg_search_document
+
+          expect { parent.destroy }.to change(PgSearch::Document, :count).by(-1)
+          expect { PgSearch::Document.find(document.id) }.to raise_error(ActiveRecord::RecordNotFound)
+        end
       end
     end
 
     describe "populating the searchable text" do
-      let(:record) { ModelThatIsMultisearchable.new }
       subject { record }
 
+      let(:record) { ModelThatIsMultisearchable.new }
+
       before do
         ModelThatIsMultisearchable.multisearchable(multisearchable_options)
       end
 
       context "when searching against a single column" do
-        let(:multisearchable_options) { {:against => :some_content} }
+        let(:multisearchable_options) { { against: :some_content } }
         let(:text) { "foo bar" }
+
         before do
-          allow(record).to receive(:some_content) { text }
+          without_partial_double_verification do
+            allow(record).to receive(:some_content) { text }
+          end
           record.save
         end
 
         describe '#content' do
           subject { super().pg_search_document.content }
+
           it { is_expected.to eq(text) }
         end
       end
 
       context "when searching against multiple columns" do
-        let(:multisearchable_options) { {:against => %i[attr1 attr2]} }
+        let(:multisearchable_options) { { against: %i[attr_1 attr_2] } }
+
         before do
-          allow(record).to receive(:attr1) { '1' }
-          allow(record).to receive(:attr2) { '2' }
+          without_partial_double_verification do
+            allow(record).to receive(:attr_1).and_return('1')
+            allow(record).to receive(:attr_2).and_return('2')
+          end
           record.save
         end
 
         describe '#content' do
           subject { super().pg_search_document.content }
+
           it { is_expected.to eq("1 2") }
         end
       end
     end
 
     describe "populating the searchable attributes" do
-      let(:record) { ModelThatIsMultisearchable.new }
       subject { record }
 
+      let(:record) { ModelThatIsMultisearchable.new }
+
       before do
         ModelThatIsMultisearchable.multisearchable(multisearchable_options)
       end
 
       context "when searching against a single column" do
-        let(:multisearchable_options) { {:against => :some_content} }
+        let(:multisearchable_options) { { against: :some_content } }
         let(:text) { "foo bar" }
+
         before do
-          allow(record).to receive(:some_content) { text }
+          without_partial_double_verification do
+            allow(record).to receive(:some_content) { text }
+          end
           record.save
         end
 
         describe '#content' do
           subject { super().pg_search_document.content }
+
           it { is_expected.to eq(text) }
         end
       end
 
       context "when searching against multiple columns" do
-        let(:multisearchable_options) { {:against => %i[attr1 attr2]} }
+        let(:multisearchable_options) { { against: %i[attr_1 attr_2] } }
+
         before do
-          allow(record).to receive(:attr1) { '1' }
-          allow(record).to receive(:attr2) { '2' }
+          without_partial_double_verification do
+            allow(record).to receive(:attr_1).and_return('1')
+            allow(record).to receive(:attr_2).and_return('2')
+          end
           record.save
         end
 
         describe '#content' do
           subject { super().pg_search_document.content }
+
           it { is_expected.to eq("1 2") }
         end
       end
@@ -171,7 +233,7 @@ describe PgSearch::Multisearchable do
       context "with additional_attributes" do
         let(:multisearchable_options) do
           {
-            :additional_attributes => lambda do |record|
+            additional_attributes: lambda do |record|
               { foo: record.bar }
             end
           }
@@ -179,18 +241,21 @@ describe PgSearch::Multisearchable do
         let(:text) { "foo bar" }
 
         it "sets the attributes" do
-          allow(record).to receive(:bar).and_return(text)
-          expect(record)
-            .to receive(:create_pg_search_document)
-            .with(content: '', foo: text)
-          record.save
+          without_partial_double_verification do
+            allow(record).to receive(:bar).and_return(text)
+            allow(record).to receive(:create_pg_search_document)
+            record.save
+            expect(record)
+              .to have_received(:create_pg_search_document)
+              .with(content: '', foo: text)
+          end
         end
       end
 
       context "when selectively updating" do
         let(:multisearchable_options) do
           {
-            :update_if => lambda do |record|
+            update_if: lambda do |record|
               record.bar?
             end
           }
@@ -198,39 +263,46 @@ describe PgSearch::Multisearchable do
         let(:text) { "foo bar" }
 
         it "creates the document" do
-          allow(record).to receive(:bar?).and_return(false)
-          expect(record)
-            .to receive(:create_pg_search_document)
-            .with(content: '')
-          record.save
+          without_partial_double_verification do
+            allow(record).to receive(:bar?).and_return(false)
+            allow(record).to receive(:create_pg_search_document)
+            record.save
+            expect(record)
+              .to have_received(:create_pg_search_document)
+              .with(content: '')
+          end
         end
 
-        context "the document is created" do
+        context "when the document is created" do
           before { record.save }
 
-          context "update_if returns false" do
+          context "when update_if returns false" do
             before do
-              allow(record).to receive(:bar?).and_return(false)
+              without_partial_double_verification do
+                allow(record).to receive(:bar?).and_return(false)
+              end
             end
 
             it "does not update the document" do
-              expect_any_instance_of(PgSearch::Document)
-                .to_not receive(:update_attributes)
-
-              record.save
+              without_partial_double_verification do
+                allow(record.pg_search_document).to receive(:update)
+                record.save
+                expect(record.pg_search_document).not_to have_received(:update)
+              end
             end
           end
 
-          context "update_if returns true" do
+          context "when update_if returns true" do
             before do
-              allow(record).to receive(:bar?).and_return(true)
+              without_partial_double_verification do
+                allow(record).to receive(:bar?).and_return(true)
+              end
             end
 
             it "updates the document" do
-              expect_any_instance_of(PgSearch::Document)
-                .to receive(:update_attributes)
-
+              allow(record.pg_search_document).to receive(:update)
               record.save
+              expect(record.pg_search_document).to have_received(:update)
             end
           end
         end
@@ -246,8 +318,8 @@ describe PgSearch::Multisearchable do
         end
 
         model do
-          include PgSearch
-          multisearchable :if => ->(record) { record.multisearchable? }
+          include PgSearch::Model
+          multisearchable if: ->(record) { record.multisearchable? }
         end
       end
 
@@ -255,25 +327,25 @@ describe PgSearch::Multisearchable do
         describe "after_create" do
           describe "saving the record" do
             context "when the condition is true" do
-              let(:record) { ModelThatIsMultisearchable.new(:multisearchable => true) }
+              let(:record) { ModelThatIsMultisearchable.new(multisearchable: true) }
 
-              it "should create a PgSearch::Document record" do
+              it "creates a PgSearch::Document record" do
                 expect { record.save! }.to change(PgSearch::Document, :count).by(1)
               end
 
               context "with multisearch disabled" do
                 before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(false) }
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
               end
             end
 
             context "when the condition is false" do
-              let(:record) { ModelThatIsMultisearchable.new(:multisearchable => false) }
+              let(:record) { ModelThatIsMultisearchable.new(multisearchable: false) }
 
-              it "should not create a PgSearch::Document record" do
+              it "does not create a PgSearch::Document record" do
                 expect { record.save! }.not_to change(PgSearch::Document, :count)
               end
             end
@@ -281,7 +353,7 @@ describe PgSearch::Multisearchable do
         end
 
         describe "after_update" do
-          let(:record) { ModelThatIsMultisearchable.create!(:multisearchable => true) }
+          let(:record) { ModelThatIsMultisearchable.create!(multisearchable: true) }
 
           context "when the document is present" do
             before { expect(record.pg_search_document).to be_present }
@@ -289,11 +361,12 @@ describe PgSearch::Multisearchable do
             describe "saving the record" do
               context "when the condition is true" do
                 it "calls save on the pg_search_document" do
-                  expect(record.pg_search_document).to receive(:save)
+                  allow(record.pg_search_document).to receive(:save)
                   record.save!
+                  expect(record.pg_search_document).to have_received(:save)
                 end
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
               end
@@ -302,11 +375,12 @@ describe PgSearch::Multisearchable do
                 before { record.multisearchable = false }
 
                 it "calls destroy on the pg_search_document" do
-                  expect(record.pg_search_document).to receive(:destroy)
+                  allow(record.pg_search_document).to receive(:destroy)
                   record.save!
+                  expect(record.pg_search_document).to have_received(:destroy)
                 end
 
-                it "should remove its document" do
+                it "removes its document" do
                   document = record.pg_search_document
                   expect { record.save! }.to change(PgSearch::Document, :count).by(-1)
                   expect { PgSearch::Document.find(document.id) }.to raise_error(ActiveRecord::RecordNotFound)
@@ -318,9 +392,10 @@ describe PgSearch::Multisearchable do
                   allow(PgSearch).to receive(:multisearch_enabled?).and_return(false)
                 end
 
-                it "should not create a PgSearch::Document record" do
-                  expect(record.pg_search_document).not_to receive(:save)
+                it "does not create a PgSearch::Document record" do
+                  allow(record.pg_search_document).to receive(:save)
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
+                  expect(record.pg_search_document).not_to have_received(:save)
                 end
               end
             end
@@ -331,14 +406,14 @@ describe PgSearch::Multisearchable do
 
             describe "saving the record" do
               context "when the condition is true" do
-                it "should create a PgSearch::Document record" do
+                it "creates a PgSearch::Document record" do
                   expect { record.save! }.to change(PgSearch::Document, :count).by(1)
                 end
 
                 context "with multisearch disabled" do
                   before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(false) }
 
-                  it "should not create a PgSearch::Document record" do
+                  it "does not create a PgSearch::Document record" do
                     expect { record.save! }.not_to change(PgSearch::Document, :count)
                   end
                 end
@@ -347,7 +422,7 @@ describe PgSearch::Multisearchable do
               context "when the condition is false" do
                 before { record.multisearchable = false }
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
               end
@@ -356,9 +431,9 @@ describe PgSearch::Multisearchable do
         end
 
         describe "after_destroy" do
-          let(:record) { ModelThatIsMultisearchable.create!(:multisearchable => true) }
+          let(:record) { ModelThatIsMultisearchable.create!(multisearchable: true) }
 
-          it "should remove its document" do
+          it "removes its document" do
             document = record.pg_search_document
             expect { record.destroy }.to change(PgSearch::Document, :count).by(-1)
             expect { PgSearch::Document.find(document.id) }.to raise_error(ActiveRecord::RecordNotFound)
@@ -374,8 +449,8 @@ describe PgSearch::Multisearchable do
         end
 
         model do
-          include PgSearch
-          multisearchable :unless => ->(record) { record.not_multisearchable? }
+          include PgSearch::Model
+          multisearchable unless: ->(record) { record.not_multisearchable? }
         end
       end
 
@@ -383,25 +458,25 @@ describe PgSearch::Multisearchable do
         describe "after_create" do
           describe "saving the record" do
             context "when the condition is false" do
-              let(:record) { ModelThatIsMultisearchable.new(:not_multisearchable => false) }
+              let(:record) { ModelThatIsMultisearchable.new(not_multisearchable: false) }
 
-              it "should create a PgSearch::Document record" do
+              it "creates a PgSearch::Document record" do
                 expect { record.save! }.to change(PgSearch::Document, :count).by(1)
               end
 
               context "with multisearch disabled" do
                 before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(false) }
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
               end
             end
 
             context "when the condition is true" do
-              let(:record) { ModelThatIsMultisearchable.new(:not_multisearchable => true) }
+              let(:record) { ModelThatIsMultisearchable.new(not_multisearchable: true) }
 
-              it "should not create a PgSearch::Document record" do
+              it "does not create a PgSearch::Document record" do
                 expect { record.save! }.not_to change(PgSearch::Document, :count)
               end
             end
@@ -409,7 +484,7 @@ describe PgSearch::Multisearchable do
         end
 
         describe "after_update" do
-          let!(:record) { ModelThatIsMultisearchable.create!(:not_multisearchable => false) }
+          let!(:record) { ModelThatIsMultisearchable.create!(not_multisearchable: false) }
 
           context "when the document is present" do
             before { expect(record.pg_search_document).to be_present }
@@ -417,21 +492,26 @@ describe PgSearch::Multisearchable do
             describe "saving the record" do
               context "when the condition is false" do
                 it "calls save on the pg_search_document" do
-                  expect(record.pg_search_document).to receive(:save)
+                  allow(record.pg_search_document).to receive(:save)
                   record.save!
+                  expect(record.pg_search_document).to have_received(:save)
                 end
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
 
                 context "with multisearch disabled" do
                   before do
                     allow(PgSearch).to receive(:multisearch_enabled?).and_return(false)
-                    expect(record.pg_search_document).not_to receive(:save)
+                    allow(record.pg_search_document).to receive(:save)
+                  end
+
+                  it "does not call save on the document" do
+                    expect(record.pg_search_document).not_to have_received(:save)
                   end
 
-                  it "should not create a PgSearch::Document record" do
+                  it "does not create a PgSearch::Document record" do
                     expect { record.save! }.not_to change(PgSearch::Document, :count)
                   end
                 end
@@ -441,11 +521,12 @@ describe PgSearch::Multisearchable do
                 before { record.not_multisearchable = true }
 
                 it "calls destroy on the pg_search_document" do
-                  expect(record.pg_search_document).to receive(:destroy)
+                  allow(record.pg_search_document).to receive(:destroy)
                   record.save!
+                  expect(record.pg_search_document).to have_received(:destroy)
                 end
 
-                it "should remove its document" do
+                it "removes its document" do
                   document = record.pg_search_document
                   expect { record.save! }.to change(PgSearch::Document, :count).by(-1)
                   expect { PgSearch::Document.find(document.id) }.to raise_error(ActiveRecord::RecordNotFound)
@@ -459,7 +540,7 @@ describe PgSearch::Multisearchable do
 
             describe "saving the record" do
               context "when the condition is false" do
-                it "should create a PgSearch::Document record" do
+                it "creates a PgSearch::Document record" do
                   expect { record.save! }.to change(PgSearch::Document, :count).by(1)
                 end
               end
@@ -467,7 +548,7 @@ describe PgSearch::Multisearchable do
               context "when the condition is true" do
                 before { record.not_multisearchable = true }
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
               end
@@ -475,7 +556,7 @@ describe PgSearch::Multisearchable do
               context "with multisearch disabled" do
                 before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(false) }
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
               end
@@ -484,7 +565,7 @@ describe PgSearch::Multisearchable do
         end
 
         describe "after_destroy" do
-          it "should remove its document" do
+          it "removes its document" do
             record = ModelThatIsMultisearchable.create!
             document = record.pg_search_document
             expect { record.destroy }.to change(PgSearch::Document, :count).by(-1)
@@ -503,8 +584,8 @@ describe PgSearch::Multisearchable do
         end
 
         model do
-          include PgSearch
-          multisearchable :if => :multisearchable?
+          include PgSearch::Model
+          multisearchable if: :multisearchable?
         end
       end
 
@@ -512,25 +593,25 @@ describe PgSearch::Multisearchable do
         describe "after_create" do
           describe "saving the record" do
             context "when the condition is true" do
-              let(:record) { ModelThatIsMultisearchable.new(:multisearchable => true) }
+              let(:record) { ModelThatIsMultisearchable.new(multisearchable: true) }
 
-              it "should create a PgSearch::Document record" do
+              it "creates a PgSearch::Document record" do
                 expect { record.save! }.to change(PgSearch::Document, :count).by(1)
               end
 
               context "with multisearch disabled" do
                 before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(false) }
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
               end
             end
 
             context "when the condition is false" do
-              let(:record) { ModelThatIsMultisearchable.new(:multisearchable => false) }
+              let(:record) { ModelThatIsMultisearchable.new(multisearchable: false) }
 
-              it "should not create a PgSearch::Document record" do
+              it "does not create a PgSearch::Document record" do
                 expect { record.save! }.not_to change(PgSearch::Document, :count)
               end
             end
@@ -538,7 +619,7 @@ describe PgSearch::Multisearchable do
         end
 
         describe "after_update" do
-          let!(:record) { ModelThatIsMultisearchable.create!(:multisearchable => true) }
+          let!(:record) { ModelThatIsMultisearchable.create!(multisearchable: true) }
 
           context "when the document is present" do
             before { expect(record.pg_search_document).to be_present }
@@ -546,21 +627,26 @@ describe PgSearch::Multisearchable do
             describe "saving the record" do
               context "when the condition is true" do
                 it "calls save on the pg_search_document" do
-                  expect(record.pg_search_document).to receive(:save)
+                  allow(record.pg_search_document).to receive(:save)
                   record.save!
+                  expect(record.pg_search_document).to have_received(:save)
                 end
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
 
                 context "with multisearch disabled" do
                   before do
                     allow(PgSearch).to receive(:multisearch_enabled?).and_return(false)
-                    expect(record.pg_search_document).not_to receive(:save)
+                    allow(record.pg_search_document).to receive(:save)
                   end
 
-                  it "should not create a PgSearch::Document record" do
+                  it "does not call save on the document" do
+                    expect(record.pg_search_document).not_to have_received(:save)
+                  end
+
+                  it "does not create a PgSearch::Document record" do
                     expect { record.save! }.not_to change(PgSearch::Document, :count)
                   end
                 end
@@ -570,11 +656,12 @@ describe PgSearch::Multisearchable do
                 before { record.multisearchable = false }
 
                 it "calls destroy on the pg_search_document" do
-                  expect(record.pg_search_document).to receive(:destroy)
+                  allow(record.pg_search_document).to receive(:destroy)
                   record.save!
+                  expect(record.pg_search_document).to have_received(:destroy)
                 end
 
-                it "should remove its document" do
+                it "removes its document" do
                   document = record.pg_search_document
                   expect { record.save! }.to change(PgSearch::Document, :count).by(-1)
                   expect { PgSearch::Document.find(document.id) }.to raise_error(ActiveRecord::RecordNotFound)
@@ -591,7 +678,7 @@ describe PgSearch::Multisearchable do
                 before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(true) }
 
                 context "when the condition is true" do
-                  it "should create a PgSearch::Document record" do
+                  it "creates a PgSearch::Document record" do
                     expect { record.save! }.to change(PgSearch::Document, :count).by(1)
                   end
                 end
@@ -599,7 +686,7 @@ describe PgSearch::Multisearchable do
                 context "when the condition is false" do
                   before { record.multisearchable = false }
 
-                  it "should not create a PgSearch::Document record" do
+                  it "does not create a PgSearch::Document record" do
                     expect { record.save! }.not_to change(PgSearch::Document, :count)
                   end
                 end
@@ -608,7 +695,7 @@ describe PgSearch::Multisearchable do
               context "with multisearch disabled" do
                 before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(false) }
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
               end
@@ -617,9 +704,9 @@ describe PgSearch::Multisearchable do
         end
 
         describe "after_destroy" do
-          let(:record) { ModelThatIsMultisearchable.create!(:multisearchable => true) }
+          let(:record) { ModelThatIsMultisearchable.create!(multisearchable: true) }
 
-          it "should remove its document" do
+          it "removes its document" do
             document = record.pg_search_document
             expect { record.destroy }.to change(PgSearch::Document, :count).by(-1)
             expect { PgSearch::Document.find(document.id) }.to raise_error(ActiveRecord::RecordNotFound)
@@ -635,8 +722,8 @@ describe PgSearch::Multisearchable do
         end
 
         model do
-          include PgSearch
-          multisearchable :unless => :not_multisearchable?
+          include PgSearch::Model
+          multisearchable unless: :not_multisearchable?
         end
       end
 
@@ -644,24 +731,24 @@ describe PgSearch::Multisearchable do
         describe "after_create" do
           describe "saving the record" do
             context "when the condition is true" do
-              let(:record) { ModelThatIsMultisearchable.new(:not_multisearchable => true) }
+              let(:record) { ModelThatIsMultisearchable.new(not_multisearchable: true) }
 
-              it "should not create a PgSearch::Document record" do
+              it "does not create a PgSearch::Document record" do
                 expect { record.save! }.not_to change(PgSearch::Document, :count)
               end
             end
 
             context "when the condition is false" do
-              let(:record) { ModelThatIsMultisearchable.new(:not_multisearchable => false) }
+              let(:record) { ModelThatIsMultisearchable.new(not_multisearchable: false) }
 
-              it "should create a PgSearch::Document record" do
+              it "creates a PgSearch::Document record" do
                 expect { record.save! }.to change(PgSearch::Document, :count).by(1)
               end
 
               context "with multisearch disabled" do
                 before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(false) }
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
               end
@@ -670,7 +757,7 @@ describe PgSearch::Multisearchable do
         end
 
         describe "after_update" do
-          let!(:record) { ModelThatIsMultisearchable.create!(:not_multisearchable => false) }
+          let!(:record) { ModelThatIsMultisearchable.create!(not_multisearchable: false) }
 
           context "when the document is present" do
             before { expect(record.pg_search_document).to be_present }
@@ -680,11 +767,12 @@ describe PgSearch::Multisearchable do
                 before { record.not_multisearchable = true }
 
                 it "calls destroy on the pg_search_document" do
-                  expect(record.pg_search_document).to receive(:destroy)
+                  allow(record.pg_search_document).to receive(:destroy)
                   record.save!
+                  expect(record.pg_search_document).to have_received(:destroy)
                 end
 
-                it "should remove its document" do
+                it "removes its document" do
                   document = record.pg_search_document
                   expect { record.save! }.to change(PgSearch::Document, :count).by(-1)
                   expect { PgSearch::Document.find(document.id) }.to raise_error(ActiveRecord::RecordNotFound)
@@ -693,21 +781,26 @@ describe PgSearch::Multisearchable do
 
               context "when the condition is false" do
                 it "calls save on the pg_search_document" do
-                  expect(record.pg_search_document).to receive(:save)
+                  allow(record.pg_search_document).to receive(:save)
                   record.save!
+                  expect(record.pg_search_document).to have_received(:save)
                 end
 
-                it "should not create a PgSearch::Document record" do
+                it "does not create a PgSearch::Document record" do
                   expect { record.save! }.not_to change(PgSearch::Document, :count)
                 end
 
                 context "with multisearch disabled" do
                   before do
                     allow(PgSearch).to receive(:multisearch_enabled?).and_return(false)
-                    expect(record.pg_search_document).not_to receive(:save)
+                    allow(record.pg_search_document).to receive(:save)
+                  end
+
+                  it "does not call save on the document" do
+                    expect(record.pg_search_document).not_to have_received(:save)
                   end
 
-                  it "should not create a PgSearch::Document record" do
+                  it "does not create a PgSearch::Document record" do
                     expect { record.save! }.not_to change(PgSearch::Document, :count)
                   end
                 end
@@ -725,20 +818,20 @@ describe PgSearch::Multisearchable do
                 context "when the condition is true" do
                   before { record.not_multisearchable = true }
 
-                  it "should not create a PgSearch::Document record" do
+                  it "does not create a PgSearch::Document record" do
                     expect { record.save! }.not_to change(PgSearch::Document, :count)
                   end
                 end
 
                 context "when the condition is false" do
-                  it "should create a PgSearch::Document record" do
+                  it "creates a PgSearch::Document record" do
                     expect { record.save! }.to change(PgSearch::Document, :count).by(1)
                   end
 
                   context "with multisearch disabled" do
                     before { allow(PgSearch).to receive(:multisearch_enabled?).and_return(false) }
 
-                    it "should not create a PgSearch::Document record" do
+                    it "does not create a PgSearch::Document record" do
                       expect { record.save! }.not_to change(PgSearch::Document, :count)
                     end
                   end
@@ -749,9 +842,9 @@ describe PgSearch::Multisearchable do
         end
 
         describe "after_destroy" do
-          let(:record) { ModelThatIsMultisearchable.create!(:not_multisearchable => false) }
+          let(:record) { ModelThatIsMultisearchable.create!(not_multisearchable: false) }
 
-          it "should remove its document" do
+          it "removes its document" do
             document = record.pg_search_document
             expect { record.destroy }.to change(PgSearch::Document, :count).by(-1)
             expect { PgSearch::Document.find(document.id) }.to raise_error(ActiveRecord::RecordNotFound)
@@ -761,3 +854,4 @@ describe PgSearch::Multisearchable do
     end
   end
 end
+# rubocop:enable RSpec/NestedGroups