pg_reports 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ebdc855958933d677530a6bee64fe5534e3b13244e4b851ee3cd06b37e1df10b
-  data.tar.gz: 1fae6baba2619b57b10ad86ef37678a34b279c49a7cf0f014810f4b167c2ae80
+  metadata.gz: 72b693934d81353991eadfbfaf0a17a9f6c73e33048270435cb6ad917d3bee1c
+  data.tar.gz: 56159c5cd3315d96cff002af0ab3328c3ce4345f463bbf22c3ddfca3f3180ae0
 SHA512:
-  metadata.gz: 7b2960a2f1df123331f8cd8d41d258fcd61f45b118451bac7859e890a5fde822266e7ab77e60a5820bf1856548ebf3ec2fff77a3f7938dc8913eca53cb087582
-  data.tar.gz: 8bfeeff753903a9a29329221108628ae2119759f859dd01e2c1395a9ae317a956556fb115bfa28b046b859e784ea42fc0b51df7fee56b7a6a6aef1674335a96a
+  metadata.gz: 9d71b455e90c577a21a0793899d4d6cfddd6afc73c2bad4d5f681e4c45fcf23380a0b2e76159d4b5d42ee198b75c64ebdb3b8048761f3af141c004a48676f159
+  data.tar.gz: a96c4dd926bb28c041283d3a3c025111545fa46995290791785ab43d6c976f4b39d3f009929b829376ef4b2dbcb8704d9966e349183210a5f6619d01fd681fd8

data/CHANGELOG.md

@@ -5,6 +5,28 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.2.3] - 2026-01-28
+
+### Added
+
+- Query Analyzer modal with parameter input fields for `$1`, `$2`, etc. placeholders
+- Execute Query button to run queries and view results (alongside EXPLAIN ANALYZE)
+- Parameter syntax highlighting in Query Analyzer (rose color for `$1`, `$2`, etc.)
+
+### Changed
+
+- Split `show.html.erb` into partials for better maintainability:
+  - `_show_styles.html.erb` - CSS styles
+  - `_show_scripts.html.erb` - JavaScript
+  - `_show_modals.html.erb` - Modal dialogs
+- EXPLAIN ANALYZE button now only shown for SELECT queries
+- Query encoding uses base64 to handle special characters (newlines, quotes)
+
+### Fixed
+
+- EXPLAIN ANALYZE button not working for queries with special characters
+- Security: Only SELECT queries allowed for EXPLAIN ANALYZE, SELECT/SHOW for Execute Query
+
 ## [0.2.2] - 2026-01-28
 
 ### Added

data/app/controllers/pg_reports/dashboard_controller.rb

@@ -114,31 +114,33 @@ module PgReports
 
     def explain_analyze
       query = params[:query]
+      query_params = params[:params] || {}
 
       if query.blank?
         render json: {success: false, error: "Query is required"}, status: :unprocessable_entity
         return
       end
 
-      # Security: Only allow SELECT queries for EXPLAIN ANALYZE
+      # Security: Only allow SELECT queries for EXPLAIN ANALYZE (SHOW not supported by EXPLAIN)
       normalized = query.strip.gsub(/\s+/, " ").downcase
       unless normalized.start_with?("select")
         render json: {success: false, error: "Only SELECT queries are allowed for EXPLAIN ANALYZE"}, status: :unprocessable_entity
         return
       end
 
-      # Check for parameterized queries (from pg_stat_statements normalization)
-      if query.match?(/\$\d+/)
+      # Substitute parameters if provided
+      final_query = substitute_params(query, query_params)
+
+      # Check for remaining unsubstituted parameters
+      if final_query.match?(/\$\d+/)
         render json: {
           success: false,
-          error: "This query contains parameter placeholders ($1, $2, etc.) from pg_stat_statements normalization. " \
-                 "EXPLAIN ANALYZE cannot be run on parameterized queries without actual values. " \
-                 "Copy the query and replace parameters with real values to analyze it manually."
+          error: "Please provide values for all parameter placeholders ($1, $2, etc.)"
         }, status: :unprocessable_entity
         return
       end
 
-      result = ActiveRecord::Base.connection.execute("EXPLAIN (ANALYZE, BUFFERS, FORMAT TEXT) #{query}")
+      result = ActiveRecord::Base.connection.execute("EXPLAIN (ANALYZE, BUFFERS, FORMAT TEXT) #{final_query}")
       explain_output = result.map { |r| r["QUERY PLAN"] }.join("\n")
 
       # Extract stats from the output
@@ -161,6 +163,69 @@ module PgReports
       render json: {success: false, error: e.message}, status: :unprocessable_entity
     end
 
+    def execute_query
+      query = params[:query]
+      query_params = params[:params] || {}
+
+      if query.blank?
+        render json: {success: false, error: "Query is required"}, status: :unprocessable_entity
+        return
+      end
+
+      # Security: Only allow SELECT and SHOW queries
+      normalized = query.strip.gsub(/\s+/, " ").downcase
+      unless normalized.start_with?("select") || normalized.start_with?("show")
+        render json: {success: false, error: "Only SELECT and SHOW queries are allowed"}, status: :unprocessable_entity
+        return
+      end
+
+      # Substitute parameters if provided
+      final_query = substitute_params(query, query_params)
+
+      # Check for remaining unsubstituted parameters
+      if final_query.match?(/\$\d+/)
+        render json: {
+          success: false,
+          error: "Please provide values for all parameter placeholders ($1, $2, etc.)"
+        }, status: :unprocessable_entity
+        return
+      end
+
+      # Execute with LIMIT to prevent huge result sets
+      limited_query = add_limit_if_missing(final_query, 100)
+
+      start_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+      result = ActiveRecord::Base.connection.execute(limited_query)
+      end_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+      execution_time = ((end_time - start_time) * 1000).round(2)
+
+      rows = result.to_a
+      columns = rows.first&.keys || []
+
+      # Check if we need to get total count
+      total_count = rows.size
+      truncated = false
+
+      if rows.size >= 100
+        # Check if there are more rows
+        count_result = ActiveRecord::Base.connection.execute("SELECT COUNT(*) FROM (#{final_query}) AS count_query")
+        total_count = count_result.first["count"].to_i
+        truncated = total_count > 100
+      end
+
+      render json: {
+        success: true,
+        columns: columns,
+        rows: rows,
+        count: rows.size,
+        total_count: total_count,
+        truncated: truncated,
+        execution_time: execution_time
+      }
+    rescue => e
+      render json: {success: false, error: e.message}, status: :unprocessable_entity
+    end
+
     def create_migration
       file_name = params[:file_name]
       code = params[:code]
@@ -218,5 +283,51 @@ module PgReports
 
       mod.public_send(report_key)
     end
+
+    def substitute_params(query, params_hash)
+      result = query.dup
+
+      # Sort by param number descending to replace $10 before $1
+      params_hash.keys.map(&:to_i).sort.reverse.each do |num|
+        value = params_hash[num.to_s] || params_hash[num]
+        next if value.nil? || value.to_s.empty?
+
+        # Quote the value appropriately
+        quoted_value = quote_param_value(value)
+        result = result.gsub("$#{num}", quoted_value)
+      end
+
+      result
+    end
+
+    def quote_param_value(value)
+      str = value.to_s
+
+      # Check if it looks like a number
+      if str.match?(/\A-?\d+(\.\d+)?\z/)
+        str
+      # Check if it looks like a boolean
+      elsif str.downcase.in?(["true", "false"])
+        str.downcase
+      # Check if it looks like NULL
+      elsif str.downcase == "null"
+        "NULL"
+      else
+        # Quote as string, escape single quotes
+        "'#{str.gsub("'", "''")}'"
+      end
+    end
+
+    def add_limit_if_missing(query, limit)
+      # Simple check - if query doesn't end with LIMIT clause, add one
+      normalized = query.strip.gsub(/\s+/, " ").downcase
+
+      if normalized.match?(/\blimit\s+\d+\s*(?:offset\s+\d+\s*)?\z/i)
+        # Already has LIMIT
+        query
+      else
+        "#{query} LIMIT #{limit}"
+      end
+    end
   end
 end

data/app/views/pg_reports/dashboard/_show_modals.html.erb

@@ -0,0 +1,105 @@
+<!-- IDE Settings Modal -->
+<div id="ide-settings-modal" class="modal" style="display: none;">
+  <div class="modal-content modal-small">
+    <div class="modal-header">
+      <h3>⚙️ IDE Settings</h3>
+      <button class="modal-close" onclick="closeIdeSettingsModal()">&times;</button>
+    </div>
+    <div class="modal-body">
+      <p class="settings-label">Default IDE for source links:</p>
+      <div class="ide-options">
+        <label class="ide-option">
+          <input type="radio" name="default-ide" value="" onchange="setDefaultIde('')">
+          <span>Show menu (default)</span>
+        </label>
+        <label class="ide-option">
+          <input type="radio" name="default-ide" value="vscode-wsl" onchange="setDefaultIde('vscode-wsl')">
+          <span>VS Code (WSL)</span>
+        </label>
+        <label class="ide-option">
+          <input type="radio" name="default-ide" value="vscode" onchange="setDefaultIde('vscode')">
+          <span>VS Code</span>
+        </label>
+        <label class="ide-option">
+          <input type="radio" name="default-ide" value="rubymine" onchange="setDefaultIde('rubymine')">
+          <span>RubyMine</span>
+        </label>
+        <label class="ide-option">
+          <input type="radio" name="default-ide" value="intellij" onchange="setDefaultIde('intellij')">
+          <span>IntelliJ IDEA</span>
+        </label>
+        <label class="ide-option">
+          <input type="radio" name="default-ide" value="cursor-wsl" onchange="setDefaultIde('cursor-wsl')">
+          <span>Cursor (WSL)</span>
+        </label>
+        <label class="ide-option">
+          <input type="radio" name="default-ide" value="cursor" onchange="setDefaultIde('cursor')">
+          <span>Cursor</span>
+        </label>
+      </div>
+    </div>
+  </div>
+</div>
+
+<!-- Problem Explanation Modal -->
+<div id="problem-modal" class="problem-modal" style="display: none;">
+  <div class="problem-modal-content">
+    <div class="problem-modal-header">
+      <h3>⚠️ Problem Detected</h3>
+      <button class="modal-close" onclick="closeProblemModal()">&times;</button>
+    </div>
+    <div class="problem-modal-body" id="problem-modal-body">
+      <!-- Content will be filled dynamically -->
+    </div>
+  </div>
+</div>
+
+<!-- EXPLAIN ANALYZE Modal -->
+<div id="explain-modal" class="modal" style="display: none;">
+  <div class="modal-content modal-wide">
+    <div class="modal-header">
+      <h3>📊 Query Analyzer</h3>
+      <button class="modal-close" onclick="closeExplainModal()">&times;</button>
+    </div>
+    <div class="modal-body" id="explain-modal-body">
+      <div class="explain-query-section">
+        <label class="explain-label">Query:</label>
+        <pre class="explain-query" id="explain-query-display"></pre>
+      </div>
+      <div id="explain-params-section" class="explain-params-section" style="display: none;">
+        <label class="explain-label">Parameters:</label>
+        <div id="explain-params-inputs"></div>
+      </div>
+      <div class="explain-actions">
+        <button class="btn btn-primary" onclick="executeExplainAnalyze()" id="btn-explain">
+          📊 EXPLAIN ANALYZE
+        </button>
+        <button class="btn btn-secondary" onclick="executeQuery()" id="btn-execute">
+          ▶ Execute Query
+        </button>
+      </div>
+      <div id="explain-loading" class="loading" style="display: none;">
+        <div class="spinner"></div>
+      </div>
+      <div id="explain-content"></div>
+    </div>
+  </div>
+</div>
+
+<!-- Migration Modal -->
+<div id="migration-modal" class="modal" style="display: none;">
+  <div class="modal-content">
+    <div class="modal-header">
+      <h3>🗑️ Drop Index Migration</h3>
+      <button class="modal-close" onclick="closeMigrationModal()">&times;</button>
+    </div>
+    <div class="modal-body" id="migration-modal-body">
+      <p class="settings-label">Generated migration to remove the index:</p>
+      <div id="migration-code" class="migration-code"></div>
+      <div class="migration-actions">
+        <button class="btn btn-secondary" onclick="copyMigrationCode()">📋 Copy Code</button>
+        <button class="btn btn-primary" onclick="createMigrationFile()">📁 Create File & Open in IDE</button>
+      </div>
+    </div>
+  </div>
+</div>