pg_rails 7.5.6 → 7.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b62210d098125764e407b10038d44a3e3fe91a52f6eff700fd83555dded8d194
-  data.tar.gz: 4e9ac223dd652c00045af466a82af01ea07062f8968947286c304014ea3cb5ac
+  metadata.gz: 65d8b10e159a9378f670fed6dac91756cc87b27c66d3aa776803f010eff4fd34
+  data.tar.gz: e27911e05aa920930ef4a25a47f4a25d2d9dcd237b535e2b7ff35e1872464319
 SHA512:
-  metadata.gz: b4cb69cca012bf23c8e1229353cd8b346150bc3029b9e45e995ce2f8ccb74d375c4019ce50ca894aaa9ef7cb5036781dcec219fa8ce108b64264e786d7467cda
-  data.tar.gz: 074b884d3867fffc9a1835aa59ca9c69dc9b64c60042d49151bbc9b60bad72d12488964be429e4eb21626dcb251b6ae8ed4b61d58a40f62cc7d845a12118e72b
+  metadata.gz: b9a503a2eebcce6024f305a06629deebf419beca24b2a2fb9e5e8b8f0fc7d071beb8175eabaa2da25cbe428dc141001f92dfaca71acdbf6d218062c81042aa01
+  data.tar.gz: d978b0345f61e377aa98ac94d194cdf9342ef6affd812b57300390cfc82a3c34dc7a11d32c4603026f286da6e3a43fb88f558a46774b7fb2c6e2a460a612bb3b

data/pg_associable/app/helpers/pg_associable/form_builder_methods.rb

@@ -20,7 +20,7 @@ module PgAssociable
       # porque de todos modos se pisaría en el create
       if !object.persisted? &&
          template.nested_record.present? &&
-         object.send(template.nested_key) == (template.nested_record.id)
+         object.send(atributo) == (template.nested_record)
         options[:disabled] = true
       end
 

data/pg_engine/app/components/asociable_modal_component.html.slim

@@ -1,3 +1,4 @@
+/ TODO: usar ModalComponent?
 .modal[class="#{@klass} modal-#{@modal_id}" tabindex="-1" data-controller="modal"
        data-auto-show="true" data-remove-on-hide="false"
        data-modal-asociable-outlet=".asociable-#{@modal_id}"

data/pg_engine/app/controllers/admin/user_accounts_controller.rb

@@ -7,6 +7,8 @@ module Admin
     include PgEngine::Resource
 
     self.clase_modelo = UserAccount
+    self.nested_class = Account
+    self.nested_key = :account_id
 
     before_action(only: :index) { authorize UserAccount }
 

data/pg_engine/app/controllers/pg_engine/base_controller.rb

@@ -76,6 +76,7 @@ module PgEngine
     rescue_from ActsAsTenant::Errors::NoTenantSet, with: :no_tenant_set
 
     rescue_from PgEngine::BadUserInput, with: :bad_user_input
+    rescue_from ActionController::UnknownFormat, with: :unknown_format
 
     rescue_from ActionController::InvalidAuthenticityToken,
                 with: :invalid_authenticity_token
@@ -96,6 +97,10 @@ module PgEngine
       render_my_component(BadUserInputComponent.new(error_msg: error.message), :bad_request)
     end
 
+    def unknown_format(_error)
+      render_my_component(BadUserInputComponent.new(error_msg: 'Formato incorrecto'), :bad_request)
+    end
+
     def internal_error(error)
       pg_err error
 
@@ -144,7 +149,10 @@ module PgEngine
       navbar_expanded = cookies[:navbar_expand] != 'false'
       @navbar_opened_class = navbar_expanded ? 'opened' : ''
       @navbar_chevron_class = navbar_expanded ? 'bi-chevron-left' : 'bi-chevron-right'
-      @navbar = Navbar.new(Current.user)
+      @navbar = Navbar.new
+      PgEngine.configuracion.navigators.each do |navigator|
+        navigator.configure(@navbar)
+      end
 
       if defined?(Rollbar) && Rollbar.configuration.enabled && Rails.application.credentials.rollbar.present?
         @rollbar_token = Rails.application.credentials.rollbar.access_token_client

data/pg_engine/app/controllers/pg_engine/base_public_controller.rb

@@ -9,6 +9,8 @@ module PgEngine
       # FIXME: make a POST route
       return head :bad_request unless dev_user_or_env?
 
+      Current.namespace = nil
+
       usuario = User.find(params[:id])
       if usuario.confirmed_at.present?
         sign_in(:user, usuario)

data/pg_engine/app/controllers/public/webhooks_controller.rb

@@ -2,6 +2,12 @@ module Public
   class WebhooksController < PublicController
     skip_before_action :verify_authenticity_token
 
+    # TODO: mover a un namespace de webhooks
+    around_action :set_without_tenant
+    def set_without_tenant(&)
+      ActsAsTenant.without_tenant(&)
+    end
+
     before_action :verify_signature, only: :mailgun
 
     rescue_from StandardError do |err|

data/pg_engine/app/models/user.rb

@@ -102,6 +102,12 @@ class User < ApplicationRecord
 
   class Error < PgEngine::Error; end
 
+  def user_accounts_without_tenant
+    ActsAsTenant.without_tenant do
+      user_accounts.to_a
+    end
+  end
+
   def default_account
     raise Error, 'El usuario debe tener cuenta' if accounts.empty?
 

data/pg_engine/app/views/admin/accounts/show.html.slim

@@ -25,3 +25,5 @@ table.table.table-borderless.table-sm.w-auto.mb-0.m-3
   tr
     th = t('attributes.discarded_at')
     td = @account.discarded_at
+
+= embed_index @account, :user_accounts

data/pg_engine/app/views/users/account_switcher/list.html.slim

@@ -1,4 +1,4 @@
-h1 Cambiar a otra cuenta
+h1 ¿Qué cuenta te gustaría utilizar?
 
 / FIXME!: user_accounts add active column
 - if @user_accounts.empty?

data/pg_engine/config/initializers/action_controller.rb

@@ -0,0 +1,7 @@
+ActiveSupport.on_load :action_controller do
+  if defined? UsersController
+    PgEngine.configurar do |config|
+      config.users_controller = UsersController
+    end
+  end
+end

data/pg_engine/config/routes.rb

@@ -44,7 +44,9 @@ Rails.application.routes.draw do
       end
     end
     pg_resource(:users)
-    pg_resource(:accounts)
+    pg_resource(:accounts) do
+      pg_resource(:user_accounts)
+    end
     pg_resource(:user_accounts)
   end
   if defined? ActiveAdmin

data/pg_engine/lib/pg_engine/configuracion.rb

@@ -4,14 +4,11 @@
 
 module PgEngine
   class Configuracion
-    attr_accessor :users_controller, :global_domains
+    attr_accessor :users_controller, :global_domains, :navigators
 
     def initialize
-      if defined? UsersController
-        @users_controller = UsersController
-      end
-
       @global_domains = ['app.localhost.com', 'test.host', 'localhost']
+      @navigators = [PgEngine::Navigator.new]
     end
   end
 end

data/pg_engine/lib/pg_engine/engine.rb

@@ -19,6 +19,14 @@ module PgEngine
       Dir.glob("#{overrides}/**/*.rb").each do |override|
         load override
       end
+
+      ActiveStorage::BaseController.class_eval do
+        around_action :set_without_tenant
+
+        def set_without_tenant(&)
+          ActsAsTenant.without_tenant(&)
+        end
+      end
     end
 
     initializer 'pg_engine.set_exceptions_app' do

data/pg_engine/lib/pg_engine/navigator.rb

@@ -0,0 +1,67 @@
+module PgEngine
+  class Navigator
+    # rubocop:disable Metrics/MethodLength
+    def configure(navbar)
+      navbar.add_item('sidebar.not_signed_in', {
+                        name: 'Crear una cuenta',
+                        path: 'new_user_registration_path'
+                      })
+      navbar.add_item('sidebar.not_signed_in', {
+                        name: 'Iniciar sesión',
+                        path: 'new_user_session_path'
+                      })
+      navbar.add_item('sidebar.not_signed_in', {
+                        name: 'Contacto',
+                        path: 'new_public_mensaje_contacto_path'
+                      })
+
+      # *****************************************************
+
+      navbar.add_item('sidebar.signed_in', {
+                        name: 'Inicio',
+                        path: 'users_root_path',
+                        priority: 0
+                      })
+      navbar.add_item('sidebar.signed_in', {
+                        name: 'Mi perfil',
+                        path: 'edit_user_registration_path',
+                        policy: 'policy(Current.user).edit?'
+                      })
+      navbar.add_item('sidebar.signed_in', {
+                        name: 'Cerrar sesión',
+                        path: 'destroy_user_session_path',
+                        attributes: 'data-turbo-method="delete"'
+                      })
+
+      # *****************************************************
+
+      return unless Current.user&.developer?
+
+      navbar.add_item('sidebar.signed_in', {
+                        name: 'Eventos',
+                        path: 'admin_eventos_path'
+                      })
+      navbar.add_item('sidebar.signed_in', {
+                        name: 'Emails',
+                        path: 'admin_emails_path'
+                      })
+      navbar.add_item('sidebar.signed_in', {
+                        name: 'Email logs',
+                        path: 'admin_email_logs_path'
+                      })
+      navbar.add_item('sidebar.signed_in', {
+                        name: 'Users',
+                        path: 'admin_users_path'
+                      })
+      navbar.add_item('sidebar.signed_in', {
+                        name: 'Accounts',
+                        path: 'admin_accounts_path'
+                      })
+      navbar.add_item('sidebar.signed_in', {
+                        name: 'User Accounts',
+                        path: 'admin_user_accounts_path'
+                      })
+    end
+    # rubocop:enable Metrics/MethodLength
+  end
+end

data/pg_engine/lib/pg_engine.rb

@@ -4,6 +4,7 @@ require_relative 'pg_engine/engine'
 require_relative 'pg_engine/core_ext'
 require_relative 'pg_engine/error'
 require_relative 'pg_engine/configuracion'
+require_relative 'pg_engine/navigator'
 require_relative 'pg_engine/email_observer'
 require_relative 'pg_engine/mailgun/log_sync'
 require_relative 'pg_engine/route_helpers'

data/pg_engine/spec/requests/active_storage_spec.rb

@@ -0,0 +1,16 @@
+require 'rails_helper'
+
+describe 'representations controller' do
+  let(:file) { File.open("#{PgEngine::Engine.root}/spec/fixtures/test.pdf") }
+
+  it do
+    categoria = create :categoria_de_cosa
+    categoria.file.attach(io: file, filename: 'test.pdf')
+    path = polymorphic_url(categoria.file.preview(:thumb), only_path: true)
+    expect(path).to start_with '/rails/active_storage/representations/redirect/'
+    get path
+    ActiveStorage::Current.url_options = { host: 'www.example.com' }
+    expect(response).to have_http_status(:redirect)
+    expect(response.headers['location']).to include '/rails/active_storage/disk/'
+  end
+end

data/pg_engine/spec/requests/base_controller_requests_spec.rb

@@ -76,4 +76,15 @@ describe 'Base requests' do
       include_examples 'manda el status correcto'
     end
   end
+
+  describe 'unknown format' do
+    subject do
+      get '/users/sign_in', headers: { accept: 'application/json' }
+    end
+
+    it 'returns bad request' do
+      subject
+      expect(response).to have_http_status(:bad_request)
+    end
+  end
 end

data/pg_engine/spec/{controllers/public/webhooks_controller_spec.rb → requests/public/webhooks_spec.rb}

@@ -26,14 +26,18 @@ def build_body(log_id, signature, timestamp)
   JSON
 end
 
-describe Public::WebhooksController do
+describe 'webhooks' do
   include ActiveSupport::Testing::TimeHelpers
 
-  before { travel_to Time.zone.at(1_716_564_587) }
+  before do
+    travel_to Time.zone.at(1_716_564_587)
+    ActsAsTenant.current_tenant = nil
+    ActsAsTenant.test_tenant = nil
+  end
 
   describe '#mailgun' do
     subject do
-      post :mailgun, body:, as: :json
+      post '/webhook/mailgun', params: body, headers: { 'content-type': 'application/json' }
     end
 
     let(:signature) { 'c524037907046276117758afae8a340e77a43a6e48eb35a9521426e7a3ff675b' }
@@ -114,11 +118,15 @@ describe Public::WebhooksController do
 
     context 'cuando ya se usó el token' do
       subject do
-        post :mailgun, body: build_body('otro id', signature, timestamp), as: :json
+        post '/webhook/mailgun',
+             params: build_body('otro id', signature, timestamp),
+             headers: { 'content-type': 'application/json' }
       end
 
       before do
-        post :mailgun, body: build_body(log_id, signature, timestamp), as: :json
+        post '/webhook/mailgun',
+             params: build_body(log_id, signature, timestamp),
+             headers: { 'content-type': 'application/json' }
       end
 
       it_behaves_like 'todo bien pero no guarda el log'

data/pg_engine/spec/requests/users/switcher_spec.rb

@@ -55,7 +55,7 @@ describe 'redirection' do
       get '/u/cosas'
       expect(response).to redirect_to users_account_switcher_path
       follow_redirect!
-      expect(response.body).to include 'Cambiar a otra cuenta'
+      expect(response.body).to include '¿Qué cuenta te gustaría utilizar?'
       post "/u/switcher/#{other_user_account.to_param}"
       expect(response).to redirect_to(root_path)
       follow_redirect!

data/pg_engine/spec/system/tenants_spec.rb

@@ -37,7 +37,7 @@ describe 'Tenants' do
       it 'shows the switcher' do
         visitar
 
-        expect(page).to have_text 'Cambiar a otra cuenta'
+        expect(page).to have_text '¿Qué cuenta te gustaría utilizar?'
       end
 
       it 'switches to account' do

data/pg_layout/app/javascript/controllers/clear_timeout_controller.js

@@ -3,11 +3,24 @@ import { Controller } from '@hotwired/stimulus'
 // Connects to data-controller="clear-timeout"
 export default class extends Controller {
   connect () {
-    this.element.dataset.timeoutId.split(',').forEach((el) => {
-      const timeoutId = parseInt(el)
-      clearTimeout(timeoutId)
-      console.log(`clearedTimeout: ${timeoutId}`)
-    })
+    if (this.element.dataset.timeoutId) {
+      this.element.dataset.timeoutId.split(',').forEach((el) => {
+        this.clear(el)
+      })
+    } else {
+      const headId = document.head.dataset.timeoutId
+      if (headId) {
+        headId.split(',').forEach((el) => {
+          this.clear(el)
+        })
+      }
+    }
     this.element.remove()
   }
+
+  clear (id) {
+    const timeoutId = parseInt(id)
+    clearTimeout(timeoutId)
+    console.log(`clearedTimeout: ${timeoutId}`)
+  }
 }

data/pg_layout/app/lib/navbar.rb

@@ -4,10 +4,9 @@ class Navbar
   attr_reader :extensiones
   attr_accessor :logo, :logo_xl, :logo_xl_url
 
-  def initialize(user)
-    @user = user
-    @yaml_data = YAML.load_file("#{Rails.application.root}/config/pg_rails.yml")
-    @yaml_data = ActiveSupport::HashWithIndifferentAccess.new(@yaml_data)
+  def initialize
+    @user = Current.user
+    @yaml_data = ActiveSupport::HashWithIndifferentAccess.new({})
     @extensiones = []
   end
 
@@ -31,15 +30,21 @@ class Navbar
     return [] if bar_data.blank?
 
     # rubocop:disable Security/Eval
+    # rubocop:disable Style/MultilineBlockChain:
+    orig_idx = 0
     bar_data.map do |item|
+      orig_idx += 1
       {
         title: item['name'],
         attributes: item['attributes']&.html_safe,
         path: eval(item['path']),
-        show: item['policy'] ? eval(item['policy']) : true
+        show: item['policy'] ? eval(item['policy']) : true,
+        priority: item['priority'] || 999_999,
+        orig_idx:
       }
-    end
+    end.sort_by { |a| [a[:priority], a[:orig_idx]] }
     # rubocop:enable Security/Eval
+    # rubocop:enable Style/MultilineBlockChain:
   end
 
   def all_children_hidden?(entry)

data/pg_layout/app/views/pg_layout/_sidebar.html.erb

@@ -6,7 +6,7 @@
     <% if user_signed_in? %>
       <span class="d-inline-block px-3 text-end text-light"><%= Current.user %></span>
       <span class="d-block px-3 text-secondary">
-        <% if Current.user.user_accounts.count > 1 %>
+        <% if Current.user.user_accounts_without_tenant.count > 1 %>
           <%= link_to ActsAsTenant.current_tenant, [:users, ActsAsTenant.current_tenant] if ActsAsTenant.current_tenant.present? %>
           <%= link_to users_account_switcher_path do %>
             <% if ActsAsTenant.current_tenant.present? %>

data/pg_layout/spec/lib/navbar_spec.rb

@@ -2,7 +2,11 @@ require 'rails_helper'
 
 describe Navbar do
   let(:user) { create :user }
-  let(:instancia) { described_class.new(user) }
+  let(:instancia) { described_class.new }
+
+  before do
+    Current.user = user
+  end
 
   describe '#add_html' do
     subject { instancia.add_html(some_html) }

data/pg_rails/lib/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PgRails
-  VERSION = '7.5.6'
+  VERSION = '7.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_rails
 version: !ruby/object:Gem::Version
-  version: 7.5.6
+  version: 7.6.0
 platform: ruby
 authors:
 - Martín Rosso
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-09-19 00:00:00.000000000 Z
+date: 2024-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -779,6 +779,7 @@ files:
 - pg_engine/app/views/public/mensaje_contactos/new.html.slim
 - pg_engine/app/views/users/account_switcher/list.html.slim
 - pg_engine/app/views/users/accounts/show.html.slim
+- pg_engine/config/initializers/action_controller.rb
 - pg_engine/config/initializers/action_mailer.rb
 - pg_engine/config/initializers/active_admin.rb
 - pg_engine/config/initializers/acts_as_tenant.rb
@@ -822,6 +823,7 @@ files:
 - pg_engine/lib/pg_engine/engine.rb
 - pg_engine/lib/pg_engine/error.rb
 - pg_engine/lib/pg_engine/mailgun/log_sync.rb
+- pg_engine/lib/pg_engine/navigator.rb
 - pg_engine/lib/pg_engine/route_helpers.rb
 - pg_engine/lib/pg_engine/utils/check_invalid_records.rb
 - pg_engine/lib/pg_engine/utils/pdf_preview_generator.rb
@@ -847,7 +849,6 @@ files:
 - pg_engine/spec/controllers/devise/sessions_controller_spec.rb
 - pg_engine/spec/controllers/pg_engine/base_controller_spec.rb
 - pg_engine/spec/controllers/public/mensaje_contactos_controller_spec.rb
-- pg_engine/spec/controllers/public/webhooks_controller_spec.rb
 - pg_engine/spec/controllers/users/confirmations_controller_spec.rb
 - pg_engine/spec/decorators/email_decorator_spec.rb
 - pg_engine/spec/factories/accounts.rb
@@ -875,10 +876,12 @@ files:
 - pg_engine/spec/models/user_spec.rb
 - pg_engine/spec/overrides/audited_audit_spec.rb
 - pg_engine/spec/pg_engine/pdf_preview_generator_spec.rb
+- pg_engine/spec/requests/active_storage_spec.rb
 - pg_engine/spec/requests/admin/eventos_spec.rb
 - pg_engine/spec/requests/base_controller_requests_spec.rb
 - pg_engine/spec/requests/current_attributes_spec.rb
 - pg_engine/spec/requests/devise_spec.rb
+- pg_engine/spec/requests/public/webhooks_spec.rb
 - pg_engine/spec/requests/users/accounts_spec.rb
 - pg_engine/spec/requests/users/base_controller_spec.rb
 - pg_engine/spec/requests/users/date_jumper_spec.rb