pg_rails 7.0.8.pre.alpha.94 → 7.0.8.pre.alpha.96

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5e21333fd287d450bce56ad59616a460a5f6113e7f28c7d934eddc833abe756a
-  data.tar.gz: 1dcd5fe3cf91b2ca87acaec28b2fe5959f167cac952481613ac9b1a15df4906d
+  metadata.gz: 4c58d9873f250d2dd6439cb23e9a78d04439050bd55834021f46f829f42ea9c6
+  data.tar.gz: a4796df1040075127fcb5045d0ac6841dfd27e49326c17b6189ce41343d14c97
 SHA512:
-  metadata.gz: 01d4202326e81d7f125d17fae6ee75f39d993802d66b45ea8af9cf844206cbef1a239e819de4d4a4e289d63e31c596ec3957b69f3ba66ec13a07816be1e48d45
-  data.tar.gz: c874ed529e846c531314eb161f1933d9d9e471735a88ecd7eeba3d046ac3f7f34bd8793c309ee154c6286a83ce16bedfbfbb196e096045f4cf8d606097300c18
+  metadata.gz: ff4ab5046138fc43e3e5e4ffb4e9047bc7082d7a72c67809d42af3dd35027c5eadd27755d7cec9b42cba57d9b43fa68ced6bcce4d10b3615df22af896a275eb3
+  data.tar.gz: 8446251043b39d5180a933cea8bd561d05f17b421951ac69654fcb358075679c0775a06bd2580f82fcd4d0497a65522039ada390cd4422debc5b76258b65a0a8

data/pg_engine/app/assets/stylesheets/notifications.scss

@@ -0,0 +1,49 @@
+#notifications {
+  display: flex;
+  align-items: center;
+  flex-direction: column;
+  gap: 5px;
+  background-color: #6a2a05;
+  padding: 1.5em 5px;
+}
+
+#notifications-inner {
+  max-width: 400px;
+  display: flex;
+  flex-direction: column;
+  gap: 0.4em;
+}
+.notification {
+  border: 1px solid #0003;
+  border-radius: 2px;
+  position: relative;
+  padding: 0.3em 2.5em;
+  xpadding-left: 2.5em;
+  display: flex;
+  align-items: center;
+  background-color: white;
+}
+.notification:not(.unseen) {
+  xcolor: #646464;
+}
+.notification.unseen {
+  background-color: rgb(230, 225, 251);
+}
+.notification.unseen::before {
+  content: '';
+  padding: 5px;
+  left: 1em;
+  vertical-align: middle;
+  position: absolute;
+  background-color: #079510;
+  border-radius: 50%;
+}
+.notifications-unseen-mark {
+  border: 1px solid #ffffff9d;
+  //background-color: #ea3d2b !important;
+  background-color: #079510;
+}
+.notification--time {
+  font-size: 0.8em;
+  min-width: 6em;
+}

data/pg_engine/app/assets/stylesheets/pg_rails_b5.scss

@@ -1,5 +1,8 @@
 @use 'sass:color';
 
+@import 'notifications';
+
+
 :root,
 [data-bs-theme=light] {
   --bs-form-invalid-color: #b50000;

data/pg_engine/app/components/notification_component.rb

@@ -0,0 +1,19 @@
+class NotificationComponent < BaseComponent
+  def initialize(notification: nil)
+    @notification = notification
+    super
+  end
+
+  erb_template <<~ERB
+    <div class="notification d-flex justify-content-between <%= 'unseen' if @notification.unseen? %>"
+         id="<%= dom_id(@notification) %>" data-id="<%= @notification.id %>">
+      <div>
+        <%= @notification.message %>
+      </div>
+      <div class="notification--time text-body-tertiary text-end ms-4">
+        hace
+        <%= distance_of_time_in_words @notification.created_at, Time.zone.now %>
+      </div>
+    </div>
+  ERB
+end

data/pg_engine/app/controllers/pg_engine/base_controller.rb

@@ -79,6 +79,11 @@ module PgEngine
       if Rollbar.configuration.enabled && Rails.application.credentials.rollbar.present?
         @rollbar_token = Rails.application.credentials.rollbar.access_token_client
       end
+
+      if Current.user.present?
+        @notifications = Current.user.notifications.order(id: :desc)
+        @unseen_notifications = @notifications.unseen.any?
+      end
     end
 
     def mobile_device?

data/pg_engine/app/controllers/users/notifications_controller.rb

@@ -0,0 +1,11 @@
+module Users
+  class NotificationsController < ApplicationController
+    def mark_as_seen
+      # No handleo errores porque no debería fallar, y si falla
+      # se notifica a rollbar y al user no le pasa nada
+      notifications = Noticed::Notification.where(id: params[:ids].split(','))
+      notifications.each(&:mark_as_seen!)
+      head :ok
+    end
+  end
+end

data/pg_engine/app/models/email_log.rb

@@ -19,7 +19,6 @@
 #
 #  fk_rails_...  (email_id => emails.id)
 #
-# generado con pg_rails
 
 class EmailLog < ApplicationRecord
   audited

data/pg_engine/app/models/user.rb

@@ -38,6 +38,7 @@ class User < ApplicationRecord
 
   has_many :user_accounts
   has_many :accounts, through: :user_accounts
+  has_many :notifications, as: :recipient, class_name: 'Noticed::Notification'
 
   validates :nombre, :apellido, presence: true
 

data/pg_engine/app/notifiers/application_notifier.rb

@@ -0,0 +1,2 @@
+class ApplicationNotifier < Noticed::Event
+end

data/pg_engine/app/notifiers/simple_user_notifier.rb

@@ -0,0 +1,28 @@
+# To deliver this notification:
+#
+# SimpleUserNotifier.with(message: "New post").deliver(User.all, enqueue_job: false)
+
+class SimpleUserNotifier < ApplicationNotifier
+  # Add your delivery methods
+  #
+  # deliver_by :email do |config|
+  #   config.mailer = "UserMailer"
+  #   config.method = "new_post"
+  # end
+  #
+  # bulk_deliver_by :slack do |config|
+  #   config.url = -> { Rails.application.credentials.slack_webhook_url }
+  # end
+  #
+  # deliver_by :custom do |config|
+  #   config.class = "MyDeliveryMethod"
+  # end
+  notification_methods do
+    def message
+      params[:message]
+    end
+  end
+  # Add required params
+  #
+  required_param :message
+end

data/pg_engine/config/initializers/anycable.rb

@@ -10,4 +10,7 @@ if defined?(AnyCable::Rails)
   AnyCable::Rails::Rack.middleware.use Warden::Manager do |config|
     Devise.warden_config = config
   end
+
+  # Lo dejo comentado porque no sé si hará falta
+  # AnyCable::Rails.extend_adapter!(ActionCable.server.pubsub) unless AnyCable::Rails.enabled?
 end

data/pg_engine/config/routes.rb

@@ -10,6 +10,9 @@ Rails.application.routes.draw do
     confirmations: 'users/confirmations',
     registrations: 'users/registrations'
   }, failure_app: PgEngine::DeviseFailureApp
+  namespace :users, path: 'u' do
+    post 'notifications/mark_as_seen', to: 'notifications#mark_as_seen'
+  end
   namespace :admin, path: 'a' do
     pg_resource(:emails)
     pg_resource(:email_logs) do

data/pg_engine/db/migrate/20240611000219_create_noticed_tables.noticed.rb

@@ -0,0 +1,37 @@
+# This migration comes from noticed (originally 20231215190233)
+class CreateNoticedTables < ActiveRecord::Migration[6.1]
+  def change
+    primary_key_type, foreign_key_type = primary_and_foreign_key_types
+    create_table :noticed_events, id: primary_key_type do |t|
+      t.string :type
+      t.belongs_to :record, polymorphic: true, type: foreign_key_type
+      if t.respond_to?(:jsonb)
+        t.jsonb :params
+      else
+        t.json :params
+      end
+
+      t.timestamps
+    end
+
+    create_table :noticed_notifications, id: primary_key_type do |t|
+      t.string :type
+      t.belongs_to :event, null: false, type: foreign_key_type
+      t.belongs_to :recipient, polymorphic: true, null: false, type: foreign_key_type
+      t.datetime :read_at
+      t.datetime :seen_at
+
+      t.timestamps
+    end
+  end
+
+  private
+
+  def primary_and_foreign_key_types
+    config = Rails.configuration.generators
+    setting = config.options[config.orm][:primary_key_type]
+    primary_key_type = setting || :primary_key
+    foreign_key_type = setting || :bigint
+    [primary_key_type, foreign_key_type]
+  end
+end

data/pg_engine/db/migrate/20240611000220_add_notifications_count_to_noticed_event.noticed.rb

@@ -0,0 +1,6 @@
+# This migration comes from noticed (originally 20240129184740)
+class AddNotificationsCountToNoticedEvent < ActiveRecord::Migration[6.1]
+  def change
+    add_column :noticed_events, :notifications_count, :integer
+  end
+end

data/pg_engine/spec/system/noticed_spec.rb

@@ -0,0 +1,36 @@
+require 'rails_helper'
+
+describe 'Notifications' do
+  subject do
+    visit '/'
+  end
+
+  let(:user) { create :user }
+
+  before do
+    driven_by ENV['DRIVER']&.to_sym || :selenium_chrome_headless_iphone
+    login_as user
+  end
+
+  context 'no notifications' do
+    it do
+      subject
+      expect(page).to have_no_css('.notifications-unseen-mark')
+    end
+  end
+
+  context 'with unseen notifications' do
+    before do
+      SimpleUserNotifier.with(message: 'probandooo').deliver(User.all)
+    end
+
+    it do
+      subject
+      expect(page).to have_css('.notifications-unseen-mark')
+      find('.bi-bell-fill').click
+      expect(page).to have_no_css('.notifications-unseen-mark', wait: 5)
+    end
+  end
+
+  pending 'with read notifications'
+end

data/pg_layout/app/javascript/controllers/index.js

@@ -7,6 +7,7 @@ import FadeinOnloadController from './fadein_onload_controller'
 import ClearTimeoutController from './clear_timeout_controller'
 import SwitcherController from './switcher_controller'
 import FiltrosController from './filtros_controller'
+import NotificationsController from './notifications_controller'
 
 application.register('navbar', NavbarController)
 application.register('nested', NestedController)
@@ -15,5 +16,6 @@ application.register('fadein_onload', FadeinOnloadController)
 application.register('clear-timeout', ClearTimeoutController)
 application.register('switcher', SwitcherController)
 application.register('filtros', FiltrosController)
+application.register('notifications', NotificationsController)
 
 // TODO: testear con capybara todo lo que se pueda

data/pg_layout/app/javascript/controllers/notifications_controller.js

@@ -0,0 +1,46 @@
+import { Controller } from '@hotwired/stimulus'
+import { post } from '@rails/request.js'
+import { Rollbar } from 'rollbar'
+
+// Connects to data-controller="notifications"
+export default class extends Controller {
+  timeoutId = null
+
+  connect () {
+    this.element.addEventListener('shown.bs.collapse', event => {
+      this.timeoutId = setTimeout(() => {
+        this.markAsSeen()
+      }, 2000)
+      document.addEventListener('turbo:load', () => { this.cancelTimeout() })
+    })
+    this.element.addEventListener('hide.bs.collapse', event => {
+      clearTimeout(this.timeoutId)
+    })
+  }
+
+  async markAsSeen () {
+    const ids = []
+    document.querySelectorAll('.notification')
+      .forEach((e) => { ids.push(e.dataset.id) })
+    const response = await post('/u/notifications/mark_as_seen',
+      { query: { ids }, responseKind: 'turbo-stream' })
+
+    if (response.ok) {
+      document.querySelectorAll('.notification.unseen').forEach(
+        (notif) => {
+          notif.classList.remove('unseen')
+        }
+      )
+      document.querySelector('.notifications-unseen-mark').remove()
+    } else {
+      const text = await response.text
+      Rollbar.error('Error marking as seen: ', text)
+    }
+  }
+
+  cancelTimeout () {
+    if (this.timeoutId) {
+      clearTimeout(this.timeoutId)
+    }
+  }
+}

data/pg_layout/app/views/pg_layout/_navbar.html.erb

@@ -1,7 +1,8 @@
 <nav class="navbar navbar-expand-<%= @breakpoint_navbar_expand %>" data-bs-theme="dark">
   <div class="container-fluid">
     <% unless @sidebar == false %>
-      <button data-controller="navbar" data-action="navbar#expandNavbar" class="btn btn-outline-light me-2 d-none d-<%= @breakpoint_navbar_expand %>-inline-block">
+      <button data-controller="navbar" data-action="navbar#expandNavbar"
+              class="btn btn-outline-light me-2 d-none d-<%= @breakpoint_navbar_expand %>-inline-block">
         <i class="bi <%= @navbar_chevron_class %>"></i>
       </button>
 
@@ -9,12 +10,43 @@
     <% @navbar.extensiones.each do |extension| %>
       <%= extension %>
     <% end %>
+    <% if Current.user.present? %>
+      <button type="button" class="btn btn-primary btn-sm position-relative"
+                            data-bs-toggle="collapse" data-bs-target="#notifications-collapse">
+        <i class="bi-bell-fill fs-5 text-light"></i>
+        <% if @unseen_notifications %>
+          <span class="position-absolute p-1 xbg-danger bg-gradient rounded-circle start-50 notifications-unseen-mark">
+          </span>
+        <% end %>
+      </button>
+    <% end %>
     <%= @navbar.logo if @navbar.logo.present? %>
-    <button class="btn btn-outline-light d-inline-block d-<%= @breakpoint_navbar_expand %>-none" type="button" data-bs-toggle="offcanvas" data-bs-target="#offcanvasExample" aria-controls="offcanvasExample">
+    <button class="btn btn-outline-light d-inline-block d-<%= @breakpoint_navbar_expand %>-none"
+            type="button"
+            data-bs-toggle="offcanvas"
+            data-bs-target="#offcanvasExample" aria-controls="offcanvasExample">
       <i class="bi bi-list"></i>
     </button>
   </div>
 </nav>
+<div class="collapse" id="notifications-collapse" data-controller="notifications">
+  <div id="notifications">
+    <div id="notifications-inner">
+      <% if @notifications&.any? %>
+        <%= render NotificationComponent.with_collection(@notifications) if @notifications&.any? %>
+      <% else %>
+        <span class="text-light">
+          No hay notificaciones
+        </span>
+      <% end %>
+      <div class="text-center">
+        <button type="button" class="btn btn-link text-light btn-sm" data-bs-toggle="collapse" data-bs-target="#notifications-collapse">
+          <i class="bi-chevron-up fs-3"></i>
+        </button>
+      </div>
+    </div>
+  </div>
+</div>
 
 <style type="text/css" media="(max-width: 767px)">
   .navbar .navbar-brand {

data/pg_rails/lib/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PgRails
-  VERSION = '7.0.8-alpha.94'
+  VERSION = '7.0.8-alpha.96'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_rails
 version: !ruby/object:Gem::Version
-  version: 7.0.8.pre.alpha.94
+  version: 7.0.8.pre.alpha.96
 platform: ruby
 authors:
 - Martín Rosso
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-06-10 00:00:00.000000000 Z
+date: 2024-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -542,6 +542,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.12.1
+- !ruby/object:Gem::Dependency
+  name: noticed
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -968,6 +982,7 @@ files:
 - pg_engine/app/assets/images/plantita.png
 - pg_engine/app/assets/javascripts/active_admin.js
 - pg_engine/app/assets/stylesheets/active_admin.scss
+- pg_engine/app/assets/stylesheets/notifications.scss
 - pg_engine/app/assets/stylesheets/pg_rails_b5.scss
 - pg_engine/app/components/alert_component.html.slim
 - pg_engine/app/components/alert_component.rb
@@ -975,6 +990,7 @@ files:
 - pg_engine/app/components/base_component.rb
 - pg_engine/app/components/flash_container_component.rb
 - pg_engine/app/components/internal_error_component.rb
+- pg_engine/app/components/notification_component.rb
 - pg_engine/app/controllers/admin/accounts_controller.rb
 - pg_engine/app/controllers/admin/email_logs_controller.rb
 - pg_engine/app/controllers/admin/emails_controller.rb
@@ -988,6 +1004,7 @@ files:
 - pg_engine/app/controllers/public/mensaje_contactos_controller.rb
 - pg_engine/app/controllers/public/webhooks_controller.rb
 - pg_engine/app/controllers/users/confirmations_controller.rb
+- pg_engine/app/controllers/users/notifications_controller.rb
 - pg_engine/app/controllers/users/registrations_controller.rb
 - pg_engine/app/decorators/account_decorator.rb
 - pg_engine/app/decorators/email_decorator.rb
@@ -1020,6 +1037,8 @@ files:
 - pg_engine/app/models/pg_engine/base_record.rb
 - pg_engine/app/models/user.rb
 - pg_engine/app/models/user_account.rb
+- pg_engine/app/notifiers/application_notifier.rb
+- pg_engine/app/notifiers/simple_user_notifier.rb
 - pg_engine/app/policies/account_policy.rb
 - pg_engine/app/policies/email_log_policy.rb
 - pg_engine/app/policies/email_policy.rb
@@ -1081,6 +1100,8 @@ files:
 - pg_engine/db/migrate/20240506194106_create_emails.rb
 - pg_engine/db/migrate/20240517174821_pg_trgm.rb
 - pg_engine/db/migrate/20240523183651_create_email_logs.rb
+- pg_engine/db/migrate/20240611000219_create_noticed_tables.noticed.rb
+- pg_engine/db/migrate/20240611000220_add_notifications_count_to_noticed_event.noticed.rb
 - pg_engine/db/seeds.rb
 - pg_engine/lib/pg_engine.rb
 - pg_engine/lib/pg_engine/configuracion.rb
@@ -1141,6 +1162,7 @@ files:
 - pg_engine/spec/system/alerts_spec.rb
 - pg_engine/spec/system/destroy_spec.rb
 - pg_engine/spec/system/login_spec.rb
+- pg_engine/spec/system/noticed_spec.rb
 - pg_engine/spec/system/send_mail_spec.rb
 - pg_engine/spec/system/signup_spec.rb
 - pg_layout/app/assets/stylesheets/animations.scss
@@ -1161,6 +1183,7 @@ files:
 - pg_layout/app/javascript/controllers/index.js
 - pg_layout/app/javascript/controllers/navbar_controller.js
 - pg_layout/app/javascript/controllers/nested_controller.js
+- pg_layout/app/javascript/controllers/notifications_controller.js
 - pg_layout/app/javascript/controllers/pg_form_controller.js
 - pg_layout/app/javascript/controllers/switcher_controller.js
 - pg_layout/app/javascript/utils/cookies.js