pg_rails 7.0.8.pre.alpha.36 → 7.0.8.pre.alpha.38

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f1a6272c4bd0f9bd9904d6dc64c733aa31e1b85a4b17373c4b76ae90722d164e
-  data.tar.gz: d02f0465aef54497116f999ed39ecdf124ef624beeff0b848f8418cc514859a3
+  metadata.gz: 683d6ba7d56764dfcf541c11cc57cd17a4e7a07db3cc5381d0b265151370e151
+  data.tar.gz: 6cab86107a332dcf819966a6458b18028dbb2b5e13fc875117f9685217c77c27
 SHA512:
-  metadata.gz: 8e1323b765a22b5170a6d58f71d582a9178584077fbde03bdaf94b6f7bb459565d6b56716016ebc2005b545e75cdbab74c029e36fd8e8b733b03430d195e727d
-  data.tar.gz: 6757f49d2d181e7417e36a8d12769554f4184ed5dbf93886fa433504232d0fd8dc06d6df22af269fe4f48d1badccc125708679990c0a989d90a76bee9137856e
+  metadata.gz: d29164b89d0b98c7e884b32be394f8a13244e5c6f4429fa4c0432ca86f548213a267393c8b1ffae197947130cc668ade1cd2e4b2848e9d09b4842f5422c8684c
+  data.tar.gz: 01a039fa9de8f00165a9f6a883c08383cffcb4b478598a38da0661944e2eadce7a342724c9a40e4e1c7c60d5bc7e8258c5ab01c9788b97a6fef61fd61567a94e

data/pg_engine/app/admin/users.rb

@@ -8,6 +8,7 @@ ActiveAdmin.register User do
     column :email
     column :current_sign_in_at
     column :created_at
+    column :developer
     actions
   end
   filter :email

data/pg_engine/app/controllers/concerns/pg_engine/resource.rb

@@ -32,7 +32,7 @@ module PgEngine
     end
 
     def new
-      add_breadcrumb 'Crear'
+      add_breadcrumb instancia_modelo.submit_default_value
     end
 
     def edit

data/pg_engine/app/controllers/pg_engine/base_controller.rb

@@ -46,6 +46,10 @@ module PgEngine
     # [:alert, :notice, :warning, :success]
     add_flash_types :warning, :success
 
+    before_action do
+      console if params[:show_web_console]
+    end
+
     before_action do
       @breakpoint_navbar_expand = 'md'
       @navbar_opened_class = if cookies[:navbar_expand] == 'false' || !user_signed_in?

data/pg_engine/app/decorators/pg_engine/base_decorator.rb

@@ -78,15 +78,11 @@ module PgEngine
     def new_link(remote: nil, klass: 'btn-warning')
       return unless Pundit.policy!(helpers.send(PgEngine.configuracion.current_user_method), object).new?
 
-      word_to_create = I18n.t("form.#{object.class.nombre_singular.downcase}.create", default: :'form.create')
-
-      full_text = "#{word_to_create} #{object.class.nombre_singular.downcase}"
-
-      helpers.content_tag :span, rel: :tooltip, title: word_to_create do
+      helpers.content_tag :span, rel: :tooltip, title: submit_default_value do
         helpers.link_to(new_object_url, class: "btn btn-sm #{klass}",
                                         remote:) do
           helpers.content_tag(:span, nil,
-                              class: clase_icono('plus').to_s) + "<span class='d-none d-sm-inline'> #{full_text}</span>".html_safe
+                              class: clase_icono('plus').to_s) + "<span class='d-none d-sm-inline'> #{submit_default_value}</span>".html_safe
         end
       end
     end
@@ -111,6 +107,17 @@ module PgEngine
       pg_namespace.present? ? [pg_namespace, object.class] : object.class
     end
 
+    # actionview-7.1.3.2/lib/action_view/helpers/form_helper.rb
+    def submit_default_value
+      key = :create
+      model = object.model_name.human
+      defaults = []
+      defaults << :"helpers.submit.#{object.model_name.i18n_key}.#{key}"
+      defaults << :"helpers.submit.#{key}"
+      defaults << "#{key.to_s.humanize} #{model}"
+      I18n.t(defaults.shift, model:, default: defaults)
+    end
+
     private
 
     def clase_icono(icono)

data/pg_engine/app/helpers/pg_engine/form_helper.rb

@@ -3,6 +3,7 @@
 module PgEngine
   module FormHelper
     def pg_form_for(object, *args, &)
+      resource = object
       if object.is_a? PgEngine::BaseDecorator
         object = object.target_object
       elsif object.is_a?(PgEngine::BaseRecord) &&
@@ -21,6 +22,11 @@ module PgEngine
                                  'pg-form'
                                end
 
+      if resource.errors.any?
+        options[:html][:data] ||= {}
+        options[:html][:data][:errors] = resource.errors.details.to_json
+      end
+
       simple_form_for(object, *(args << options), &)
     end
 

data/pg_engine/app/helpers/pg_engine/print_helper.rb

@@ -101,7 +101,13 @@ module PgEngine
     def print_currency(number, simbolo: '$', precision: nil)
       return if number.blank?
 
-      precision ||= (number % 1).positive? ? 2 : 0
+      # FIXME: testear
+      precision ||= if (number % 0.01).positive?
+                      3
+                    else
+                      (number % 1).positive? ? 2 : 0
+                    end
+
       "#{simbolo} #{number_with_precision(number, delimiter: '.', separator: ',',
                                                   precision:)}"
     end

data/pg_engine/app/lib/pg_form_builder.rb

@@ -32,23 +32,7 @@ class PgFormBuilder < SimpleForm::FormBuilder
     base_message = (base_errors.map(&:to_s).join('<br>') if base_errors.present?)
     base_tag = error_notification(message: base_message, class: 'alert alert-danger') if base_message
 
-    all_errors_tag = build_all_errors_tag unless base_tag
-
-    "#{title}#{base_tag}#{all_errors_tag}".html_safe # rubocop:disable Rails/OutputSafety
-  end
-
-  def build_all_errors_tag
-    details = object.errors.details.dup
-    details.delete(:base)
-    not_base_errors = details.any?
-
-    return unless not_base_errors
-
-    # TODO!: poder pasar un block para que no se ejecute si no se va a loguear por el log level
-    # TODO: quizá esta warning loguearla pero no mandarla a rollbar por si son demasiadas
-    pg_warn "Not base errors en pg_form: #{object.errors.details}. Record: #{object.inspect}", :warn
-
-    "<span class='not_base_errors' data-errors='#{object.errors.details.to_json}'></span>"
+    "#{title}#{base_tag}".html_safe # rubocop:disable Rails/OutputSafety
   end
 
   def mensaje

data/pg_engine/config/locales/es.yml

@@ -11,8 +11,6 @@ es:
     confirmed_at: Fecha de confirmación
     actualizado_por: Actualizado por
     creado_por: Creado por
-  form:
-    create: Crear
   ancestry:
     exclude_self: No puede ser hijx de si mismx
   simple_form:

data/pg_engine/spec/lib/pg_form_builder_spec.rb

@@ -15,9 +15,6 @@ describe PgFormBuilder do
   describe '#mensajes_de_error' do
     subject { instancia.mensajes_de_error }
 
-    # expect(subject)
-    # it { expect(subject).to eq 'Por favor, revisá los campos obligatorios:' }
-
     context 'cuando solo tiene errores de presencia' do
       before do
         categoria.nombre = nil
@@ -25,7 +22,6 @@ describe PgFormBuilder do
       end
 
       it { expect(subject).to include 'Por favor, revisá los campos obligatorios:' }
-      it { expect(subject).to include 'not_base_errors' }
     end
 
     context 'cuando solo tiene errores de :base' do
@@ -35,7 +31,6 @@ describe PgFormBuilder do
       end
 
       it { expect(subject).to include 'Por favor, revisá los siguientes errores' }
-      it { expect(subject).not_to include 'not_base_errors' }
     end
   end
 

data/pg_layout/app/javascript/controllers/pg_form_controller.js

@@ -10,16 +10,19 @@ export default class extends Controller {
         }
       })
     })
-    const notBaseErrors = this.element.querySelector('.not_base_errors')
-
-    if (notBaseErrors) {
-      const invalidFeedback = document.querySelector('.invalid-feedback')
-      if (!invalidFeedback) {
-        console.error(notBaseErrors.dataset.errors)
-        Rollbar.error(notBaseErrors.dataset.errors)
+    const errorTitle = this.element.querySelector('.error-title')
+    if (errorTitle) {
+      const invalidField = document.querySelector('.is-invalid')
+      const baseAlert = document.querySelector('.alert-danger')
+      if (!invalidField && !baseAlert) {
         const errorTitle = this.element.querySelector('.error-title')
+        // FIXME: testear con capybara
         errorTitle.innerText = 'Lo lamentamos mucho pero ocurrió algo inesperado. Por favor, intentá nuevamente o ponete en contacto con nosotros.'
         // FIXME: link a contacto
+        const form = this.element.querySelector('form')
+        const errorMsg = `${form.id} - ${form.action} - ${form.dataset.errors}`
+        console.error(errorMsg)
+        Rollbar.error(errorMsg)
       }
     }
   }

data/pg_rails/lib/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PgRails
-  VERSION = '7.0.8-alpha.36'
+  VERSION = '7.0.8-alpha.38'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_rails
 version: !ruby/object:Gem::Version
-  version: 7.0.8.pre.alpha.36
+  version: 7.0.8.pre.alpha.38
 platform: ruby
 authors:
 - Martín Rosso
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-04-18 00:00:00.000000000 Z
+date: 2024-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails