pg_online_schema_change 0.9.0 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3b959611ab7bbaabb457ac51ee7b25c7449962d8a3ff39986251bfaf2c890a4f
-  data.tar.gz: a8cff6b404a625b2f1e3099d5ccec6d35ad4e0346e0016bc7837dced67664f88
+  metadata.gz: 2900c279c3ecb38f1deb228d82cb9c476f9aac331d669fea97c10ddd6eb41a94
+  data.tar.gz: 84f9a35eed1d5cde22924297e83d9539a218a964b76901005cdd6f389ee3c423
 SHA512:
-  metadata.gz: d4685933d5e8e5d59f6f4301ad36a1fba2002c7f02f851aea36e9f61f8ab435c7f52b26ee475488adfedb5c8ab872d923619de2c7c0a8f907df50be411a5cc97
-  data.tar.gz: 44071e34f1caf2078f909c64c87250ff723cff53a31b2f049475bbbac79cbf6b8cf1881d1d9bad456da9287824aceb3c74777841f0a0f28cca5f40cae2a5b60f
+  metadata.gz: 1395602fbea53d0d0d768fefed3d94f5cab39fae007ccd0c008f8a5818bf9de3b9f179a61b6cb91dbae288fec6cbd99e5bb6b494f1b38c0affe8c5c57d351b15
+  data.tar.gz: 5c0c2a4b305e147932a4fe8a62c9897238914343c95a39114cb5b8b05154eebee35c1e7fa164b592c7938c253c6b9ca8c3f943063b4b6c4b30618f31fefd3ae4

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## [0.9.0] - 2023-05-22
+
+- Fix typo in README.md https://github.com/shayonj/pg-osc/pull/87
+- Support for views https://github.com/shayonj/pg-osc/pull/88
+
 ## [0.8.1] - 2023-05-13
 
 - Gem path and CI fixes

data/Dockerfile

@@ -1,5 +1,5 @@
 FROM ruby:3.0
 
-ARG VERSION=0.2.0
+ARG VERSION
 
-RUN gem install pg_online_schema_change -v $VERSION
+RUN gem install pg_online_schema_change -v $VERSION

data/Gemfile.lock

@@ -1,10 +1,10 @@
 PATH
   remote: .
   specs:
-    pg_online_schema_change (0.9.0)
+    pg_online_schema_change (0.9.2)
       ougai (~> 2.0.0)
-      pg (~> 1.3.2)
-      pg_query (~> 2.1.3)
+      pg (>= 1.3.2, < 1.6.0)
+      pg_query (>= 2.1.3, < 4.3.0)
       thor (~> 1.2.1)
 
 GEM
@@ -13,30 +13,34 @@ GEM
     ast (2.4.2)
     coderay (1.1.3)
     diff-lcs (1.5.0)
-    google-protobuf (3.23.0-arm64-darwin)
+    google-protobuf (3.23.3-arm64-darwin)
+    google-protobuf (3.23.3-x86_64-linux)
     haml (6.1.1)
       temple (>= 0.8.2)
       thor
       tilt
     json (2.6.3)
+    language_server-protocol (3.17.0.3)
     method_source (1.0.0)
-    oj (3.14.3)
+    oj (3.15.0)
     ougai (2.0.0)
       oj (~> 3.10)
     parallel (1.23.0)
-    parser (3.2.2.1)
+    parser (3.2.2.3)
       ast (~> 2.4.1)
-    pg (1.3.5)
-    pg_query (2.1.4)
-      google-protobuf (>= 3.19.2)
+      racc
+    pg (1.5.3)
+    pg_query (4.2.1)
+      google-protobuf (>= 3.22.3)
     prettier_print (1.2.1)
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
+    racc (1.7.1)
     rainbow (3.1.1)
     rake (13.0.6)
     rbs (3.1.0)
-    regexp_parser (2.8.0)
+    regexp_parser (2.8.1)
     rexml (3.2.5)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
@@ -51,17 +55,18 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.0)
-    rubocop (1.51.0)
+    rubocop (1.54.0)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
       rubocop-ast (>= 1.28.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.28.1)
+    rubocop-ast (1.29.0)
       parser (>= 3.2.1.0)
     rubocop-capybara (2.18.0)
       rubocop (~> 1.41)
@@ -69,7 +74,7 @@ GEM
       rubocop (~> 1.33)
     rubocop-packaging (0.5.2)
       rubocop (>= 1.33, < 2.0)
-    rubocop-performance (1.17.1)
+    rubocop-performance (1.18.0)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rake (0.6.0)

data/lib/pg_online_schema_change/functions.rb

@@ -45,7 +45,7 @@ FUNC_CREATE_TABLE_ALL = <<~SQL
         rec record;
     begin
     EXECUTE format(
-          'CREATE TABLE %s (LIKE %s including all)',
+          'CREATE TABLE %s (LIKE %s including all) WITH (autovacuum_enabled = false)',
           newsource_table, source_table);
     END
   $$;

data/lib/pg_online_schema_change/orchestrate.rb

@@ -37,6 +37,7 @@ module PgOnlineSchemaChange
         Store.set(:audit_table_pk, "at_#{pgosc_identifier}_id")
         Store.set(:audit_table_pk_sequence, "#{audit_table}_#{audit_table_pk}_seq")
         Store.set(:shadow_table, "pgosc_st_#{client.table.downcase}_#{pgosc_identifier}")
+        Store.set(:primary_table_storage_parameters, Query.storage_parameters_for(client, client.table_name, true) || "")
 
         Store.set(
           :referential_foreign_key_statements,
@@ -59,7 +60,6 @@ module PgOnlineSchemaChange
 
         setup_trigger!
         setup_shadow_table! # re-uses transaction with serializable
-        disable_vacuum! # re-uses transaction with serializable
         run_alter_statement! # re-uses transaction with serializable
         copy_data! # re-uses transaction with serializable
         run_analyze!
@@ -105,7 +105,7 @@ module PgOnlineSchemaChange
         logger.info("Setting up audit table", { audit_table: audit_table })
 
         sql = <<~SQL
-          CREATE TABLE #{audit_table} (#{audit_table_pk} SERIAL PRIMARY KEY, #{operation_type_column} text, #{trigger_time_column} timestamp, LIKE #{client.table_name});
+          CREATE TABLE #{audit_table} (#{audit_table_pk} SERIAL PRIMARY KEY, #{operation_type_column} text, #{trigger_time_column} timestamp, LIKE #{client.table_name}) WITH (autovacuum_enabled = false);
         SQL
 
         Query.run(client.connection, sql)
@@ -177,28 +177,6 @@ module PgOnlineSchemaChange
         )
       end
 
-      def disable_vacuum!
-        # re-uses transaction with serializable
-        # Disabling vacuum to avoid any issues during the process
-        result = Query.storage_parameters_for(client, client.table_name, true) || ""
-        Store.set(:primary_table_storage_parameters, result)
-
-        logger.debug(
-          "Disabling vacuum on shadow and audit table",
-          { shadow_table: shadow_table, audit_table: audit_table },
-        )
-        sql = <<~SQL
-          ALTER TABLE #{shadow_table} SET (
-            autovacuum_enabled = false, toast.autovacuum_enabled = false
-          );
-
-          ALTER TABLE #{audit_table} SET (
-            autovacuum_enabled = false, toast.autovacuum_enabled = false
-          );
-        SQL
-        Query.run(client.connection, sql, true)
-      end
-
       def run_alter_statement!
         # re-uses transaction with serializable
         statement = Query.alter_statement_for(client, shadow_table)

data/lib/pg_online_schema_change/query.rb

@@ -81,7 +81,6 @@ module PgOnlineSchemaChange
         connection.block
         logger.info("Exception raised, rolling back query", { rollback: true, query: query })
         connection.async_exec("ROLLBACK;")
-        connection.async_exec("COMMIT;")
         raise
       else
         connection.async_exec("COMMIT;") unless reuse_trasaction

data/lib/pg_online_schema_change/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PgOnlineSchemaChange
-  VERSION = "0.9.0"
+  VERSION = "0.9.2"
 end

data/scripts/release.sh

@@ -1,28 +1,22 @@
+#!/bin/bash
+
+set -euo pipefail
+
 export VERSION=$1
 echo "VERSION: ${VERSION}"
 
-echo "=== Pushing tags to github ===="
-git tag v$VERSION
-git push origin --tags
-
 echo "=== Building Gem ===="
 gem build pg_online_schema_change.gemspec
 
 echo "=== Pushing gem ===="
-gem push pg_online_schema_change-$VERSION.gem
+gem push pg_online_schema_change-"$VERSION".gem
 
-echo "=== Sleeping for 5s ===="
-sleep 5 
+echo "=== Sleeping for 15s ===="
+sleep 15
 
-echo "=== Building Image ===="
-docker build . --build-arg VERSION=$VERSION -t shayonj/pg-osc:$VERSION
-
-echo "=== Tagging Image ===="
-docker image tag shayonj/pg-osc:$VERSION shayonj/pg-osc:latest
-
-echo "=== Pushing Image ===="
-docker push shayonj/pg-osc:$VERSION
-docker push shayonj/pg-osc:latest
+echo "=== Pushing tags to github ===="
+git tag v"$VERSION"
+git push origin --tags
 
 echo "=== Cleaning up ===="
-rm pg_online_schema_change-$VERSION.gem
+rm pg_online_schema_change-"$VERSION".gem

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_online_schema_change
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.2
 platform: ruby
 authors:
 - Shayon Mukherjee
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-22 00:00:00.000000000 Z
+date: 2023-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ougai
@@ -28,30 +28,42 @@ dependencies:
   name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.2
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.2
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.6.0
 - !ruby/object:Gem::Dependency
   name: pg_query
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.1.3
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 4.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.1.3
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 4.3.0
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement