pg_online_schema_change 0.7.5 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 973cb542595ffacbaa942636be7b366e018a2141a75c1fd73e38e65e263ddd39
-  data.tar.gz: abe5178f45a6c8a00c0b64a5cee543b7fc22e126d7a5744adefada83fa6ab844
+  metadata.gz: 7ee83ff61d08a5a75a3a4301fa4e001d3a0d34ac7a83497401106e019a81926a
+  data.tar.gz: 6abf876909fd6ef65cd4dc75e307d9a6f0f17dffcb15eb28784f422bb6084401
 SHA512:
-  metadata.gz: 718ae2f4b7c1f0319f9c36d5c5b6f24441ac94e108fb281d357cec5790ee68ba4fdd1237aae4d414e284ccbf8228796027b9e2d6ffb19730bfe8260acb8120ba
-  data.tar.gz: 030dbca6e2f7b2a4f117a6b639f7c1454e7df5514adf4c81f3957d0a2310ce62042ea16d9707f6b7f7590c4f2b04f4276de33100bfc7a1611a1df388a21f8e5e
+  metadata.gz: 651f59026eb0c22e6d761a8834ce959e463ad4a6d24989ecc9790cadf8eb6826bf127cdc124f97090f0002b80105a4f451924391f46ad5ef3325ddc89c2a541d
+  data.tar.gz: 877df2ccfdfea4c52ebc9ea9337ee163c88cc56fe4e9c724b34c29d098d6af215034e1f41cbc6ed760e0d9a3a1a952bbf9bd280818c1c7b1ac00a523d61a4ab0

data/.prettierignore

@@ -0,0 +1,4 @@
+/spec/fixtures
+/docs
+/scripts
+*.sql

data/.prettierrc

@@ -0,0 +1,13 @@
+{
+  "trailingComma": "es5",
+  "overrides": [
+    {
+      "files": ["Gemfile", "*.{rb,ru,rake,gemspec}", ".irbrc", ".pryrc"],
+      "options": {
+        "printWidth": 100,
+        "rubySingleQuote": false,
+        "rubyArrayLiteral": false
+      }
+    }
+  ]
+}

data/.rubocop.yml

@@ -2,131 +2,260 @@ inherit_from: .rubocop_todo.yml
 
 require:
   - rubocop-rspec
-  - rubocop-packaging
-  - rubocop-performance
   - rubocop-rake
 
+inherit_mode:
+  merge:
+    - Include
+    - Exclude
+    - AllowedMethods
+
 AllCops:
-  DisplayCopNames: true
-  DisplayStyleGuide: true
   NewCops: enable
-  TargetRubyVersion: 2.6
   Exclude:
-    - "tmp/**/*"
-    - "vendor/**/*"
+    - "**/.git/**/*"
+    - "**/node_modules/**/*"
+    - "**/Brewfile"
+  TargetRubyVersion: 3.1
+
+Bundler/OrderedGems:
+  Include:
+    - "**/Gemfile"
 
-Layout/HashAlignment:
-  EnforcedColonStyle: key
-  EnforcedHashRocketStyle:  key
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: always
 
-Layout/SpaceAroundEqualsInParameterDefault:
-  EnforcedStyle: space
+Style/MutableConstant:
+  EnforcedStyle: literals
 
-Metrics/AbcSize:
+Style/MethodCallWithArgsParentheses:
   Enabled: true
-  Max: 45
+  EnforcedStyle: require_parentheses
+  AllowedMethods:
+    - yield
+    - raise
+    - fail
+    - puts
+    - require
+    - require_relative
+    - render
+    - redirect_to
+    - head
+    - throw
+    # RSpec
+    - to
+    - not_to
+    - to_not
+    - and
+    - or
   Exclude:
-    - "spec/**/*"
+    - "**/Gemfile"
+    - "**/db/migrate/*"
+    - "**/db/schema.rb"
 
-Metrics/BlockLength:
-  Max: 100
-  Exclude:
-    - "*.gemspec"
-    - "Rakefile"
-    - "spec/**/*"
+Style/RedundantInitialize:
+  Enabled: false
 
-Metrics/ClassLength:
-  Exclude:
-    - "test/**/*"
+Layout:
+  Enabled: false
 
-Metrics/MethodLength:
-  Max: 30
-  Exclude:
-    - "test/**/*"
+Metrics:
+  Enabled: false
 
-Metrics/ParameterLists:
-  Max: 5
+Naming/AccessorMethodName:
+  Enabled: false
 
-Naming/MemoizedInstanceVariableName:
-  Enabled: true
+Naming/MethodParameterName:
+  Enabled: false
+
+Naming/PredicateName:
+  Enabled: false
 
 Naming/VariableNumber:
-  Enabled: true
+  Enabled: false
 
-Style/BarePercentLiterals:
-  EnforcedStyle: percent_q
+Style/AsciiComments:
+  Enabled: false
+
+Style/BlockDelimiters:
+  Enabled: false
+
+Style/CaseLikeIf:
+  Enabled: false
 
 Style/ClassAndModuleChildren:
-  Enabled: true
+  Enabled: false
+
+Style/CommentAnnotation:
+  Enabled: false
 
 Style/Documentation:
   Enabled: false
 
-Style/DoubleNegation:
-  Enabled: true
+Style/IfUnlessModifier:
+  Enabled: false
 
-Style/EmptyMethod:
-  Enabled: true
+Style/Lambda:
+  Enabled: false
 
-Style/FrozenStringLiteralComment:
-  Enabled: true
+Style/ModuleFunction:
+  Enabled: false
+
+Style/MultilineBlockChain:
+  Enabled: false
+
+Style/NumericLiterals:
+  Enabled: false
 
 Style/NumericPredicate:
-  Enabled: true
+  Enabled: false
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Style/PerlBackrefs:
+  Enabled: false
+
+Style/QuotedSymbols:
+  EnforcedStyle: double_quotes
+  Enabled: false
+
+Style/RaiseArgs:
+  Enabled: false
+
+Style/RescueStandardError:
+  Enabled: false
+
+Style/SingleArgumentDig:
+  Enabled: false
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes
+  Enabled: false
 
 Style/StringLiteralsInInterpolation:
-  EnforcedStyle: double_quotes
+  Enabled: false
 
-Style/TrivialAccessors:
-  AllowPredicates: true
+Style/SymbolArray:
+  EnforcedStyle: brackets
 
 Style/TrailingCommaInArguments:
-  EnforcedStyleForMultiline: comma
+  Enabled: false
 
 Style/TrailingCommaInArrayLiteral:
-  EnforcedStyleForMultiline: comma
+  Enabled: false
+  EnforcedStyleForMultiline: consistent_comma
 
 Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: comma
+  Enabled: false
 
-Layout/MultilineArrayBraceLayout:
-  Enabled: true
-  EnforcedStyle: symmetrical
+Style/TrailingUnderscoreVariable:
+  Enabled: false
 
-Layout/MultilineHashBraceLayout:
-  Enabled: true
-  EnforcedStyle: symmetrical
+Style/WordArray:
+  EnforcedStyle: brackets
 
-Layout/MultilineAssignmentLayout:
-  Enabled: true
-  EnforcedStyle: same_line
+Style/ZeroLengthPredicate:
+  Enabled: false
 
-Layout/FirstArrayElementIndentation:
+Style/DateTime:
   Enabled: true
-  EnforcedStyle: consistent
 
-Layout/FirstHashElementIndentation:
-  Enabled: true
-  EnforcedStyle: consistent
+RSpec/ExpectChange:
+  EnforcedStyle: block
 
-Layout/MultilineHashKeyLineBreaks:
-  Enabled: true
+Gemspec/RequireMFA:
+  # Our Gemspec files are internal, MFA isn't needed
+  Enabled: false
 
-Layout/LineLength:
-  Enabled: true
-  Max: 250
+# Temporary Rubocop exclusions
+Style/OpenStructUse:
+  Enabled: false
 
-Style/FormatStringToken:
-  Enabled: true
-  EnforcedStyle: template
+# Ruby 3 migration exclusions
+Style/HashSyntax:
+  Enabled: false
+
+Naming/BlockForwarding:
+  Enabled: false
+
+Lint/RedundantDirGlobSort:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Enabled: false
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/VerifiedDoubles:
+  Enabled: false
+
+RSpec/ContextWording:
+  Enabled: false
+
+RSpec/AnyInstance:
+  Enabled: false
 
 RSpec/MessageSpies:
-  Enabled: true
-  EnforcedStyle: receive
+  Enabled: false
+
+RSpec/RepeatedDescription:
+  Enabled: false
+
+RSpec/RepeatedExample:
+  Enabled: false
+
+RSpec/HookArgument:
+  Enabled: false
+
+RSpec/DescribeClass:
+  Enabled: false
+
+RSpec/DescribedClass:
+  Enabled: false
 
 RSpec/FilePath:
-  Enabled: true
-  SpecSuffixOnly: true
+  Enabled: false
+
+RSpec/IdenticalEqualityAssertion:
+  Enabled: false
+
+RSpec/InstanceVariable:
+  Enabled: false
+
+RSpec/MissingExampleGroupArgument:
+  Enabled: false
+
+RSpec/MultipleDescribes:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Enabled: false
+
+RSpec/PredicateMatcher:
+  Enabled: false
+
+RSpec/Rails/HttpStatus:
+  Enabled: false
+
+RSpec/RepeatedExampleGroupDescription:
+  Enabled: false
+
+RSpec/StubbedMock:
+  Enabled: false
+
+Lint/UnusedMethodArgument:
+  Enabled: false
+
+Lint/MissingSuper:
+  Enabled: false
+
+RSpec/NoExpectationExample:
+  Enabled: false
+
+Style/AccessorGrouping:
+  Enabled: false
+
+Style/FormatStringToken:
+  Enabled: false

data/.rubocop_todo.yml

@@ -1,45 +1,26 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-03-12 14:28:52 UTC using RuboCop version 1.23.0.
+# on 2023-05-13 12:53:02 UTC using RuboCop version 1.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-# Configuration parameters: CountComments, CountAsOne.
-Metrics/ClassLength:
-  Max: 285
-
-# Offense count: 2
-# Configuration parameters: IgnoredMethods.
-Metrics/CyclomaticComplexity:
-  Max: 15
-
-# Offense count: 1
-# Configuration parameters: CountComments, CountAsOne.
-Metrics/ModuleLength:
-  Max: 112
-
-# Offense count: 2
-# Configuration parameters: IgnoredMethods.
-Metrics/PerceivedComplexity:
-  Max: 13
+# Offense count: 12
+# Configuration parameters: EnforcedStyle, AllowedGems, Include.
+# SupportedStyles: Gemfile, gems.rb, gemspec
+# Include: **/*.gemspec, **/Gemfile, **/gems.rb
+Gemspec/DevelopmentDependencies:
+  Exclude:
+    - 'pg_online_schema_change.gemspec'
 
 # Offense count: 1
-Packaging/GemspecGit:
+# Configuration parameters: Severity, Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
   Exclude:
     - 'pg_online_schema_change.gemspec'
 
-# Offense count: 69
-# Configuration parameters: CountAsOne.
-RSpec/ExampleLength:
-  Max: 55
-
-# Offense count: 25
-RSpec/MultipleExpectations:
-  Max: 14
-
 # Offense count: 6
 # Configuration parameters: AllowedMethods.
 # AllowedMethods: respond_to_missing?

data/.ruby-version

@@ -1 +1 @@
-3.0.0
+3.1.3

data/CHANGELOG.md

@@ -1,44 +1,58 @@
+## [0.7.5] - 2023-03-12
 
+- Bump google-protobuf from 3.21.6 to 3.21.7 https://github.com/shayonj/pg-osc/pull/76
+- Supports tablenames containing uppercase letters https://github.com/shayonj/pg-osc/pull/77
+- Update rubocop todo https://github.com/shayonj/pg-osc/pull/78
+- Ensure original triggers are carried over from parent table https://github.com/shayonj/pg-osc/pull/79
 
 ## [0.7.4] - 2022-09-24
-* off-by-one: Don't skip PK sequence value by one https://github.com/shayonj/pg-osc/pull/74
+
+- off-by-one: Don't skip PK sequence value by one https://github.com/shayonj/pg-osc/pull/74
 
 ## [0.7.3] - 2022-09-24
-* Update primary key sequence on shadow table https://github.com/shayonj/pg-osc/pull/72
+
+- Update primary key sequence on shadow table https://github.com/shayonj/pg-osc/pull/72
   - Thanks to @brycethornton for the report
-* Only refresh primary key when a sequence is attached https://github.com/shayonj/pg-osc/pull/73
+- Only refresh primary key when a sequence is attached https://github.com/shayonj/pg-osc/pull/73
 
 ## [0.7.2] - 2022-09-17
+
 **NOTE: Skip to 0.7.3. 0.7.2 release missed the change.**
-* Update primary key sequence on shadow table https://github.com/shayonj/pg-osc/pull/72
+
+- Update primary key sequence on shadow table https://github.com/shayonj/pg-osc/pull/72
   - Thanks to @brycethornton for the report
 
 ## [0.7.1] - 2022-03-13
-* Bump pg to `1.3.4` https://github.com/shayonj/pg-osc/commit/d086c19d4f273dc960491cbedf9e0602d812896b
+
+- Bump pg to `1.3.4` https://github.com/shayonj/pg-osc/commit/d086c19d4f273dc960491cbedf9e0602d812896b
 
 ## [0.7.0] - 2022-03-13
-* Move CI to Github Actions in https://github.com/shayonj/pg-osc/pull/64
-* Set --password as optional since it is deprecated in https://github.com/shayonj/pg-osc/pull/66
-* Smoke tests in https://github.com/shayonj/pg-osc/pull/65
-* Add foreign keys to parent during swap in https://github.com/shayonj/pg-osc/pull/67
+
+- Move CI to Github Actions in https://github.com/shayonj/pg-osc/pull/64
+- Set --password as optional since it is deprecated in https://github.com/shayonj/pg-osc/pull/66
+- Smoke tests in https://github.com/shayonj/pg-osc/pull/65
+- Add foreign keys to parent during swap in https://github.com/shayonj/pg-osc/pull/67
 
 ## [0.6.0] - 2022-02-26
-* Delete items by audit table PK when replaying by @shayonj @jfrost in https://github.com/shayonj/pg-osc/pull/60
+
+- Delete items by audit table PK when replaying by @shayonj @jfrost in https://github.com/shayonj/pg-osc/pull/60
   - Fixes a race condition issue: https://github.com/shayonj/pg-osc/issues/58
 
 ## [0.5.0] - 2022-02-26
-* Share some preliminary load test figures in https://github.com/shayonj/pg-osc/pull/54
-* Reuse existing transaction open for reading table columns in https://github.com/shayonj/pg-osc/pull/53
-* Start to deprecate --password with PGPASSWORD in https://github.com/shayonj/pg-osc/pull/56
-* Introduce configurable PULL_BATCH_COUNT and DELTA_COUNT in https://github.com/shayonj/pg-osc/pull/57
+
+- Share some preliminary load test figures in https://github.com/shayonj/pg-osc/pull/54
+- Reuse existing transaction open for reading table columns in https://github.com/shayonj/pg-osc/pull/53
+- Start to deprecate --password with PGPASSWORD in https://github.com/shayonj/pg-osc/pull/56
+- Introduce configurable PULL_BATCH_COUNT and DELTA_COUNT in https://github.com/shayonj/pg-osc/pull/57
 
 ## [0.4.0] - 2022-02-22
-* Lint sourcecode, setup Rubocop proper and Lint in CI by @shayonj in https://github.com/shayonj/pg-osc/pull/46
-* Uniquely identify operation_type column by @shayonj in https://github.com/shayonj/pg-osc/pull/50
-* Introduce primary key on audit table for ordered reads by @shayonj in https://github.com/shayonj/pg-osc/pull/49
+
+- Lint sourcecode, setup Rubocop proper and Lint in CI by @shayonj in https://github.com/shayonj/pg-osc/pull/46
+- Uniquely identify operation_type column by @shayonj in https://github.com/shayonj/pg-osc/pull/50
+- Introduce primary key on audit table for ordered reads by @shayonj in https://github.com/shayonj/pg-osc/pull/49
   - This addresses an edge case with replay.
-* Uniquely identify trigger_time column by @shayonj in https://github.com/shayonj/pg-osc/pull/51
-* Abstract assertions into a helper function by @shayonj in https://github.com/shayonj/pg-osc/pull/52
+- Uniquely identify trigger_time column by @shayonj in https://github.com/shayonj/pg-osc/pull/51
+- Abstract assertions into a helper function by @shayonj in https://github.com/shayonj/pg-osc/pull/52
 
 ## [0.3.0] - 2022-02-21
 
@@ -53,8 +67,8 @@
 
 Initial release
 
-pg-online-schema-change (`pg-osc`) is a tool for making schema changes (any `ALTER` statements) in Postgres tables with minimal locks, thus helping achieve zero downtime schema changes against production workloads. 
+pg-online-schema-change (`pg-osc`) is a tool for making schema changes (any `ALTER` statements) in Postgres tables with minimal locks, thus helping achieve zero downtime schema changes against production workloads.
 
 `pg-osc` uses the concept of shadow table to perform schema changes. At a high level, it copies the contents from a primary table to a shadow table, performs the schema change on the shadow table and swaps the table names in the end while preserving all changes to the primary table using triggers (via audit table).
 
-Checkout [Readme](https://github.com/shayonj/pg-osc#readme) for more details.
+Checkout [Readme](https://github.com/shayonj/pg-osc#readme) for more details.

data/CODE_OF_CONDUCT.md

@@ -10,21 +10,21 @@ We pledge to act and interact in ways that contribute to an open, welcoming, div
 
 Examples of behavior that contributes to a positive environment for our community include:
 
-* Demonstrating empathy and kindness toward other people
-* Being respectful of differing opinions, viewpoints, and experiences
-* Giving and gracefully accepting constructive feedback
-* Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
-* Focusing on what is best not just for us as individuals, but for the overall community
+- Demonstrating empathy and kindness toward other people
+- Being respectful of differing opinions, viewpoints, and experiences
+- Giving and gracefully accepting constructive feedback
+- Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
+- Focusing on what is best not just for us as individuals, but for the overall community
 
 Examples of unacceptable behavior include:
 
-* The use of sexualized language or imagery, and sexual attention or
+- The use of sexualized language or imagery, and sexual attention or
   advances of any kind
-* Trolling, insulting or derogatory comments, and personal or political attacks
-* Public or private harassment
-* Publishing others' private information, such as a physical or email
+- Trolling, insulting or derogatory comments, and personal or political attacks
+- Public or private harassment
+- Publishing others' private information, such as a physical or email
   address, without their explicit permission
-* Other conduct which could reasonably be considered inappropriate in a
+- Other conduct which could reasonably be considered inappropriate in a
   professional setting
 
 ## Enforcement Responsibilities
@@ -67,7 +67,7 @@ Community leaders will follow these Community Impact Guidelines in determining t
 
 ### 4. Permanent Ban
 
-**Community Impact**: Demonstrating a pattern of violation of community standards, including sustained inappropriate behavior,  harassment of an individual, or aggression toward or disparagement of classes of individuals.
+**Community Impact**: Demonstrating a pattern of violation of community standards, including sustained inappropriate behavior, harassment of an individual, or aggression toward or disparagement of classes of individuals.
 
 **Consequence**: A permanent ban from any sort of public interaction within the community.