pg_online_schema_change 0.7.2 → 0.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d9b2ebcfd1944ac2ddba65466ca474751637d6fdb2db7abcf3a5d587e716c617
-  data.tar.gz: 3a6ac8b49967e9483f75359006097865de640c3ce414dad5bd0e07e766d4a3c3
+  metadata.gz: 2a765e9fe8c466b43b05b45401a6f0bbfc1d6ec3825dbc030308e1c7701ee436
+  data.tar.gz: 5cb07a199e35f6fe1ad2dfb3cad11dded9f6e4b519af2d67a08fad850fdd715d
 SHA512:
-  metadata.gz: a0a7d0bf9bf030859d6b7cb36b1d69770d3af9c7721c5e5042732887959bc1664e1c8bd4f09f076cdafcb1b272a57f49ddf1fbb5d86aad60a4b0b81d79378804
-  data.tar.gz: bb12999f436c8d93591c17b97f5f508d7234355ef25780834565a8222da4c43dd3dfd52450210007bc3f0a32cd0231958a3e7645af538d1af67cc3e620582f14
+  metadata.gz: a39814cfedba956f26f083a5fbbeeeced80818b6273656761e146d244e245627033ffbf48c5b69dc1a5bb4d5c9e3c9e01f10ec9ddbf95a7da9b8e36af60ada6d
+  data.tar.gz: 87e06bd100570d1a18e11ec279894a7a417713237ee4134bace9fc5f62acbffd35d31e668b3b88c5031841d816a9eb8fe30faa546baae5e3027f432bb6567ecc

data/.rubocop.yml

@@ -24,7 +24,7 @@ Layout/SpaceAroundEqualsInParameterDefault:
 
 Metrics/AbcSize:
   Enabled: true
-  Max: 40
+  Max: 45
   Exclude:
     - "spec/**/*"
 

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2022-03-13 19:35:49 UTC using RuboCop version 1.23.0.
+# on 2022-09-24 14:22:44 UTC using RuboCop version 1.23.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -9,7 +9,7 @@
 # Offense count: 2
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 250
+  Max: 266
 
 # Offense count: 2
 # Configuration parameters: IgnoredMethods.
@@ -26,7 +26,7 @@ Packaging/GemspecGit:
   Exclude:
     - 'pg_online_schema_change.gemspec'
 
-# Offense count: 67
+# Offense count: 68
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 55

data/CHANGELOG.md

@@ -1,4 +1,14 @@
 
+## [0.7.3] - 2022-09-24
+* Update primary key sequence on shadow table https://github.com/shayonj/pg-osc/pull/72
+  - Thanks to @brycethornton for the report
+* Only refresh primary key when a sequence is attached https://github.com/shayonj/pg-osc/pull/73
+
+## [0.7.2] - 2022-09-17
+**NOTE: Skip to 0.7.3. 0.7.2 release missed the change.**
+* Update primary key sequence on shadow table https://github.com/shayonj/pg-osc/pull/72
+  - Thanks to @brycethornton for the report
+
 ## [0.7.1] - 2022-03-13
 * Bump pg to `1.3.4` https://github.com/shayonj/pg-osc/commit/d086c19d4f273dc960491cbedf9e0602d812896b
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pg_online_schema_change (0.7.2)
+    pg_online_schema_change (0.7.4)
       ougai (~> 2.0.0)
       pg (~> 1.3.2)
       pg_query (~> 2.1.3)
@@ -13,37 +13,37 @@ GEM
     ast (2.4.2)
     coderay (1.1.3)
     diff-lcs (1.5.0)
-    google-protobuf (3.19.4)
+    google-protobuf (3.21.6)
     method_source (1.0.0)
-    oj (3.13.11)
+    oj (3.13.21)
     ougai (2.0.0)
       oj (~> 3.10)
-    parallel (1.21.0)
-    parser (3.0.3.2)
+    parallel (1.22.1)
+    parser (3.1.2.1)
       ast (~> 2.4.1)
-    pg (1.3.4)
-    pg_query (2.1.3)
+    pg (1.3.5)
+    pg_query (2.1.4)
       google-protobuf (>= 3.19.2)
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    rainbow (3.0.0)
+    rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.2.0)
+    regexp_parser (2.5.0)
     rexml (3.2.5)
-    rspec (3.10.0)
-      rspec-core (~> 3.10.0)
-      rspec-expectations (~> 3.10.0)
-      rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
+    rspec (3.11.0)
+      rspec-core (~> 3.11.0)
+      rspec-expectations (~> 3.11.0)
+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.2)
+      rspec-support (~> 3.11.0)
+    rspec-mocks (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-support (3.10.3)
+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.1)
     rubocop (1.23.0)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
@@ -53,8 +53,8 @@ GEM
       rubocop-ast (>= 1.12.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.15.1)
-      parser (>= 3.0.1.1)
+    rubocop-ast (1.21.0)
+      parser (>= 3.1.1.0)
     rubocop-packaging (0.5.1)
       rubocop (>= 0.89, < 2.0)
     rubocop-performance (1.12.0)
@@ -66,7 +66,7 @@ GEM
       rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
     thor (1.2.1)
-    unicode-display_width (2.1.0)
+    unicode-display_width (2.3.0)
 
 PLATFORMS
   arm64-darwin-20

data/README.md

@@ -260,6 +260,16 @@ rvm use 3.0.0
 
 To install this gem onto your local machine, run `bundle exec rake install`. 
 
+### Local testing 
+```
+docker compose up
+
+pgbench --initialize -s 10 --foreign-keys --host localhost -U jamesbond -d postgres
+pgbench -T 60000 -c 5 --host localhost -U jamesbond -d postgres
+
+bundle exec bin/pg-online-schema-change perform -a 'ALTER TABLE pgbench_accounts ALTER COLUMN aid TYPE BIGINT' -d "postgres" -h "localhost" -u "jamesbond" -w "password"
+```
+
 ## Releasing
 
 - Bump version in `version.rb`

data/lib/pg_online_schema_change/orchestrate.rb

@@ -238,7 +238,10 @@ module PgOnlineSchemaChange
         rows = Replay.rows_to_play(opened)
         Replay.play!(rows, opened)
 
+        query_for_primary_key_refresh = Query.query_for_primary_key_refresh(shadow_table, primary_key, client.table, opened)
+
         sql = <<~SQL
+          #{query_for_primary_key_refresh};
           ALTER TABLE #{client.table} RENAME to #{old_primary_table};
           ALTER TABLE #{shadow_table} RENAME to #{client.table};
           #{referential_foreign_key_statements}

data/lib/pg_online_schema_change/query.rb

@@ -319,6 +319,28 @@ module PgOnlineSchemaChange
           FROM ONLY #{client.table}
         SQL
       end
+
+      def primary_key_sequence(shadow_table, primary_key, opened)
+        query = <<~SQL
+          SELECT pg_get_serial_sequence(\'#{shadow_table}\', \'#{primary_key}\') as sequence_name
+        SQL
+
+        result = run(client.connection, query, opened)
+
+        result.map do |row|
+          row["sequence_name"]
+        end&.first
+      end
+
+      def query_for_primary_key_refresh(shadow_table, primary_key, table, opened)
+        sequence_name = primary_key_sequence(shadow_table, primary_key, opened)
+
+        return "" if sequence_name.nil?
+
+        <<~SQL
+          SELECT setval((select pg_get_serial_sequence(\'#{shadow_table}\', \'#{primary_key}\')), (SELECT max(#{primary_key}) FROM #{table}));
+        SQL
+      end
     end
   end
 end

data/lib/pg_online_schema_change/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PgOnlineSchemaChange
-  VERSION = "0.7.2"
+  VERSION = "0.7.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_online_schema_change
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.4
 platform: ruby
 authors:
 - Shayon Mukherjee
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-17 00:00:00.000000000 Z
+date: 2022-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ougai