pg_online_schema_change 0.7.1 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c49f895f91c72ef491002660c994088b9d527db88d3b5d77cbb851771a2f2ac8
-  data.tar.gz: d57329d32657cd64edb60b8c174c6fc32f4279a202548b5132407e98c59f2f9e
+  metadata.gz: 70f01145ab63bcb06e4aea9e79b8dc5ac1bf5cc37749964589d2dc940214d8c4
+  data.tar.gz: 52f2b7e5fe1b793f1f8a414972d282a41661eb0045b65d095b65b4c9ab2d6a2a
 SHA512:
-  metadata.gz: 963c4c9751301d029857f021b40d033d50f9b8865548a5d8bd752ed4c03a4cf1e5b016c5129e771db45df1e2677a8e29b5c2b488f152932238e7158e4c3a2a8b
-  data.tar.gz: bc8c559ade623ea76794cf1756642474cf32eee08406f884503b9450e1d5b39233778dd77b7fcd56327c140ba046279b21a1a1a64b5ac606bf5c2119cea6b350
+  metadata.gz: d4d0c36d71d4aa8020063c63bba2358ffd2d088ad9da21ce3419a8916acbd74c80dfefd5a134423e708ef6b72f444dcbf0ebfd6ba4ff26956d562c258a94fbcc
+  data.tar.gz: c73369d1a69a0824474d5a930411b2f2eee0e7ac61986fb7b8df47d84e010da2cb35fec6e054e5e8986e6877f1992f256b420404a41f1cdd85620f8f1b9a3bb1

data/.rubocop.yml

@@ -24,7 +24,7 @@ Layout/SpaceAroundEqualsInParameterDefault:
 
 Metrics/AbcSize:
   Enabled: true
-  Max: 40
+  Max: 45
   Exclude:
     - "spec/**/*"
 

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2022-03-13 19:35:49 UTC using RuboCop version 1.23.0.
+# on 2022-09-24 14:22:44 UTC using RuboCop version 1.23.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -9,7 +9,7 @@
 # Offense count: 2
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 250
+  Max: 266
 
 # Offense count: 2
 # Configuration parameters: IgnoredMethods.
@@ -26,7 +26,7 @@ Packaging/GemspecGit:
   Exclude:
     - 'pg_online_schema_change.gemspec'
 
-# Offense count: 67
+# Offense count: 68
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 55

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 
-## [0.6.0] - 2022-03-13
+## [0.7.2] - 2022-09-17
+* Update primary key sequence on shadow table https://github.com/shayonj/pg-osc/pull/72
+  - Thanks to @brycethornton for the report
+
+## [0.7.1] - 2022-03-13
+* Bump pg to `1.3.4` https://github.com/shayonj/pg-osc/commit/d086c19d4f273dc960491cbedf9e0602d812896b
+
+## [0.7.0] - 2022-03-13
 * Move CI to Github Actions in https://github.com/shayonj/pg-osc/pull/64
 * Set --password as optional since it is deprecated in https://github.com/shayonj/pg-osc/pull/66
 * Smoke tests in https://github.com/shayonj/pg-osc/pull/65

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pg_online_schema_change (0.7.0)
+    pg_online_schema_change (0.7.3)
       ougai (~> 2.0.0)
       pg (~> 1.3.2)
       pg_query (~> 2.1.3)
@@ -14,7 +14,6 @@ GEM
     coderay (1.1.3)
     diff-lcs (1.5.0)
     google-protobuf (3.19.4)
-    google-protobuf (3.19.4-x86_64-linux)
     method_source (1.0.0)
     oj (3.13.11)
     ougai (2.0.0)
@@ -71,6 +70,7 @@ GEM
 
 PLATFORMS
   arm64-darwin-20
+  arm64-darwin-21
   x86_64-linux
 
 DEPENDENCIES

data/README.md

@@ -205,6 +205,7 @@ docker run --network host -it --rm shayonj/pg-osc:latest \
     --drop
 ```
 ## Caveats
+- Partitioned tables are not supported as of yet. Pull requests and ideas welcome.
 - A primary key should exist on the table; without it, `pg-osc` will raise an exception
 	- This is because - currently there is no other way to uniquely identify rows during replay.
 - `pg-osc` will acquire `ACCESS EXCLUSIVE` lock on the parent table twice during the operation.
@@ -259,6 +260,16 @@ rvm use 3.0.0
 
 To install this gem onto your local machine, run `bundle exec rake install`. 
 
+### Local testing 
+```
+docker compose up
+
+pgbench --initialize -s 10 --foreign-keys --host localhost -U jamesbond -d postgres
+pgbench -T 60000 -c 5 --host localhost -U jamesbond -d postgres
+
+bundle exec bin/pg-online-schema-change perform -a 'ALTER TABLE pgbench_accounts ALTER COLUMN aid TYPE BIGINT' -d "postgres" -h "localhost" -u "jamesbond" -w "password"
+```
+
 ## Releasing
 
 - Bump version in `version.rb`

data/lib/pg_online_schema_change/orchestrate.rb

@@ -238,7 +238,10 @@ module PgOnlineSchemaChange
         rows = Replay.rows_to_play(opened)
         Replay.play!(rows, opened)
 
+        query_for_primary_key_refresh = Query.query_for_primary_key_refresh(shadow_table, primary_key, client.table, opened)
+
         sql = <<~SQL
+          #{query_for_primary_key_refresh};
           ALTER TABLE #{client.table} RENAME to #{old_primary_table};
           ALTER TABLE #{shadow_table} RENAME to #{client.table};
           #{referential_foreign_key_statements}

data/lib/pg_online_schema_change/query.rb

@@ -319,6 +319,28 @@ module PgOnlineSchemaChange
           FROM ONLY #{client.table}
         SQL
       end
+
+      def primary_key_sequence(shadow_table, primary_key, opened)
+        query = <<~SQL
+          SELECT pg_get_serial_sequence(\'#{shadow_table}\', \'#{primary_key}\') as sequence_name
+        SQL
+
+        result = run(client.connection, query, opened)
+
+        result.map do |row|
+          row["sequence_name"]
+        end&.first
+      end
+
+      def query_for_primary_key_refresh(shadow_table, primary_key, table, opened)
+        sequence_name = primary_key_sequence(shadow_table, primary_key, opened)
+
+        return "" if sequence_name.nil?
+
+        <<~SQL
+          SELECT setval((select pg_get_serial_sequence(\'#{shadow_table}\', \'#{primary_key}\')), (SELECT max(#{primary_key}) FROM #{table})+1);
+        SQL
+      end
     end
   end
 end

data/lib/pg_online_schema_change/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PgOnlineSchemaChange
-  VERSION = "0.7.1"
+  VERSION = "0.7.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_online_schema_change
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.3
 platform: ruby
 authors:
 - Shayon Mukherjee
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-13 00:00:00.000000000 Z
+date: 2022-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ougai