pg_morph 0.3.0 → 1.0.0

data/spec/{pg_morph → lib/pg_morph}/polymorphic_spec.rb

@@ -13,21 +13,53 @@ describe PgMorph::Polymorphic do
 
   it { expect(@polymorphic.child_table).to eq(:bars) }
 
+  describe "#base_table" do
+    it "sets default base table" do
+      expect(@polymorphic.base_table).to eq(:foos_base)
+    end
+
+    it "sets base table with options" do
+      polymorphic = PgMorph::Polymorphic.new(:foos, :bars, column: :baz, base_table: :base)
+      expect(polymorphic.base_table).to eq(:base)
+    end
+  end
+
+  describe '#rename_base_table_sql' do
+    it 'returns proper sql if there is no base table yet' do
+      expect(@polymorphic.rename_base_table_sql.squeeze(' ')).to eq %Q{
+        ALTER TABLE foos RENAME TO foos_base;
+      }.squeeze(' ')
+    end
+
+    it 'returns empty string if base table exists' do
+      expect(@polymorphic).to receive(:can_rename_to_base_table?).and_return(false)
+      expect(@polymorphic.rename_base_table_sql.squeeze(' ')).to eq ''
+    end
+  end
+
+  describe '#create_base_table_view_sql' do
+    it 'returns proper sql' do
+      expect(@polymorphic.create_base_table_view_sql).to eq %Q{
+        CREATE OR REPLACE VIEW foos AS SELECT * FROM foos_base;
+      }
+    end
+  end
+
   describe '#create_proxy_table_sql' do
-    it do
-      @polymorphic.create_proxy_table_sql.squeeze(' ').should == %Q{
+    it 'generates proper sql' do
+      expect(@polymorphic.create_proxy_table_sql.squeeze(' ')).to eq %Q{
       CREATE TABLE foos_bars (
         CHECK (baz_type = 'Bar'),
         PRIMARY KEY (id),
           FOREIGN KEY (baz_id) REFERENCES bars(id)
-      ) INHERITS (foos);
+      ) INHERITS (foos_base);
       }.squeeze(' ')
     end
   end
 
   describe '#create_before_insert_trigger_fun_sql' do
-    it '' do
-      @polymorphic.should_receive(:before_insert_trigger_content)
+    it 'generates proper sql' do
+      expect(@polymorphic).to receive(:before_insert_trigger_content)
 
       @polymorphic.create_before_insert_trigger_fun_sql
     end
@@ -35,7 +67,7 @@ describe PgMorph::Polymorphic do
 
   describe '#create_trigger_body' do
     it 'returns proper sql for new trigger' do
-      @polymorphic.send(:create_trigger_body).squeeze(' ').should == %Q{
+      expect(@polymorphic.send(:create_trigger_body).squeeze(' ')).to eq %Q{
       IF (NEW.baz_type = 'Bar') THEN
         INSERT INTO foos_bars VALUES (NEW.*);
       }.squeeze(' ')
@@ -43,8 +75,8 @@ describe PgMorph::Polymorphic do
   end
 
   describe '#before_insert_trigger_content' do
-    it '' do
-      @polymorphic.send(:before_insert_trigger_content) { 'my block' }.squeeze(' ').should == %Q{
+    it 'generate proper sql' do
+      expect(@polymorphic.send(:before_insert_trigger_content) { 'my block' }.squeeze(' ')).to eq %Q{
       CREATE OR REPLACE FUNCTION foos_baz_fun() RETURNS TRIGGER AS $$
         BEGIN
           my block
@@ -57,42 +89,20 @@ describe PgMorph::Polymorphic do
     end
   end
 
-  describe '#create_after_insert_trigger_fun_sql' do
-    it do
-      @polymorphic.create_after_insert_trigger_fun_sql.squeeze(' ').should == %Q{
-      CREATE OR REPLACE FUNCTION delete_from_foos_master_fun() RETURNS TRIGGER AS $$
-      BEGIN
-        DELETE FROM ONLY foos WHERE id = NEW.id;
-        RETURN NEW;
-      END; $$ LANGUAGE plpgsql;
-      }.squeeze(' ')
-    end
-  end
-
-  describe '#create_after_insert_trigger_sql' do
-    it do
-      @polymorphic.create_after_insert_trigger_sql.squeeze(' ').should == %Q{
-      DROP TRIGGER IF EXISTS foos_after_insert_trigger ON foos;
-      CREATE TRIGGER foos_after_insert_trigger
-        AFTER INSERT ON foos
-        FOR EACH ROW EXECUTE PROCEDURE delete_from_foos_master_fun();
-      }.squeeze(' ')
-    end
-  end
-
   describe '#remove_before_insert_trigger_sql' do
     it 'raise error if no function' do
-      -> { @polymorphic.remove_before_insert_trigger_sql }
-        .should raise_error PG::Error
+      expect { @polymorphic.remove_before_insert_trigger_sql }
+        .to raise_error PG::Error
     end
 
     it 'returns proper sql for single child table' do
       @polymorphic.stub(:get_function).with('foos_baz_fun').and_return('')
 
-      @polymorphic.remove_before_insert_trigger_sql.squeeze(' ').should == %Q{
+      expect(@polymorphic.remove_before_insert_trigger_sql.squeeze(' ')).to eq %Q{
         DROP TRIGGER foos_baz_insert_trigger ON foos;
         DROP FUNCTION foos_baz_fun();
         }.squeeze(' ')
     end
   end
+
 end

data/spec/spec_helper.rb

@@ -1,3 +1,11 @@
+if ENV['CODECLIMATE_REPO_TOKEN']
+  require "codeclimate-test-reporter"
+  CodeClimate::TestReporter.start
+else
+  require 'simplecov'
+  SimpleCov.start
+end
+
 ENV["RAILS_ENV"] ||= 'test'
 require File.expand_path("../dummy/config/environment", __FILE__)
 require 'rspec/rails'

metadata

@@ -1,126 +1,139 @@
 --- !ruby/object:Gem::Specification
 name: pg_morph
 version: !ruby/object:Gem::Version
-  version: 0.3.0
-  prerelease: 
+  version: 1.0.0
 platform: ruby
 authors:
 - Hanka Seweryn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-14 00:00:00.000000000 Z
+date: 2015-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.17'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.3'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
 - !ruby/object:Gem::Dependency
   name: awesome_print
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
 description: Takes care of postgres DB consistency for ActiveRecord polymorphic associations
@@ -131,9 +144,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -175,36 +191,35 @@ files:
 - spec/dummy/db/migrate/20140401124727_create_likes.rb
 - spec/dummy/db/schema.rb
 - spec/dummy/db/seeds.rb
-- spec/pg_morph/adapter_integration_spec.rb
-- spec/pg_morph/adapter_spec.rb
-- spec/pg_morph/naming_spec.rb
-- spec/pg_morph/polymorphic_integration_spec.rb
-- spec/pg_morph/polymorphic_spec.rb
+- spec/lib/pg_morph/adapter_integration_spec.rb
+- spec/lib/pg_morph/adapter_spec.rb
+- spec/lib/pg_morph/naming_spec.rb
+- spec/lib/pg_morph/polymorphic_integration_spec.rb
+- spec/lib/pg_morph/polymorphic_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/LunarLogic/pg_morph
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Takes care of postgres DB consistency for ActiveRecord polymorphic associations
 test_files:
 - spec/dummy/.rspec
@@ -237,10 +252,9 @@ test_files:
 - spec/dummy/db/migrate/20140401124727_create_likes.rb
 - spec/dummy/db/schema.rb
 - spec/dummy/db/seeds.rb
-- spec/pg_morph/adapter_integration_spec.rb
-- spec/pg_morph/adapter_spec.rb
-- spec/pg_morph/naming_spec.rb
-- spec/pg_morph/polymorphic_integration_spec.rb
-- spec/pg_morph/polymorphic_spec.rb
+- spec/lib/pg_morph/adapter_integration_spec.rb
+- spec/lib/pg_morph/adapter_spec.rb
+- spec/lib/pg_morph/naming_spec.rb
+- spec/lib/pg_morph/polymorphic_integration_spec.rb
+- spec/lib/pg_morph/polymorphic_spec.rb
 - spec/spec_helper.rb
-has_rdoc: 

data/spec/pg_morph/adapter_integration_spec.rb

@@ -1,89 +0,0 @@
-require 'spec_helper'
-
-describe PgMorph::Adapter do
-  ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.class_eval do
-    include PgMorph::Adapter
-
-    def run(query)
-      ActiveRecord::Base.connection.select_value(query)
-    end
-  end
-
-  before do
-    @adapter = ActiveRecord::Base.connection
-    @comments_polymorphic = PgMorph::Polymorphic.new(:likes, :comments, column: :likeable)
-    @posts_polymorphic = PgMorph::Polymorphic.new(:likes, :posts, column: :likeable)
-    begin
-      Like.destroy_all
-      Comment.destroy_all
-      @adapter.remove_polymorphic_foreign_key(:likes, :comments, column: :likeable)
-      @adapter.remove_polymorphic_foreign_key(:likes, :posts, column: :likeable)
-    rescue
-    end
-  end
-
-  after do
-    begin
-      @adapter.add_polymorphic_foreign_key(:likes, :comments, column: :likeable)
-    rescue
-    end
-  end
-
-  describe '#add_polymorphic_foreign_key' do
-    it 'creates proxy table' do
-      @adapter.add_polymorphic_foreign_key(:likes, :comments, column: :likeable)
-
-      expect(@adapter.run('SELECT id FROM likes_comments')).to be_nil
-    end
-  end
-
-  describe '#remove_polymorphic_foreign_key' do
-    it 'removes proxy table' do
-      @adapter.add_polymorphic_foreign_key(:likes, :comments, column: :likeable)
-      expect(@adapter.run('SELECT id FROM likes_comments')).to be_nil
-
-      @adapter.remove_polymorphic_foreign_key(:likes, :comments, column: :likeable)
-
-      -> { @adapter.run('SELECT id FROM likes_comments') }
-        .should raise_error ActiveRecord::StatementInvalid
-    end
-  end
-
-  describe 'assertions to a partition' do
-    it 'works properly' do
-      # new record inserted correctly
-      @adapter.add_polymorphic_foreign_key(:likes, :comments, column: :likeable)
-      comment = Comment.create(content: 'comment')
-      like = Like.create(likeable: comment)
-
-      expect(Like.count).to eq(1)
-      expect(like.id).to eq(Like.last.id)
-
-      # new record with more partition tables inserted correctly
-      @adapter.add_polymorphic_foreign_key(:likes, :posts, column: :likeable)
-      post = Post.create(content: 'content')
-      like2 = Like.create(likeable: post)
-
-      expect(Like.count).to eq(2)
-      expect(like2.id).to eq(Like.last.id)
-
-      # after removing partition row not inserted
-      like.destroy
-      expect(Like.count).to eq(1)
-      @adapter.remove_polymorphic_foreign_key(:likes, :comments, column: :likeable)
-
-      -> {  Like.create(likeable: comment) }
-        .should raise_error ActiveRecord::StatementInvalid
-
-      # if no partitions row inserted correctly
-      like2.destroy
-      expect(Like.count).to eq(0)
-      @adapter.remove_polymorphic_foreign_key(:likes, :posts, column: :likeable)
-      like4 = Like.create(likeable: post)
-
-      expect(Like.count).to eq(1)
-      expect(like4.id).to eq(Like.last.id)
-    end
-  end
-
-end