pg_conn 0.58.1 → 0.59.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 204745e57b411c35071db75b18bb3acfa186fb04cb86579e9618a816ef0f0133
-  data.tar.gz: 5a51db5597afebe8e3ba89be2448d78f1e114ae9e587b206ab0600a7c6e1fdf2
+  metadata.gz: 8dd70cb7a067886566b8ae751bb319115450ed3ebc82d3420c74c7f77e5f72ce
+  data.tar.gz: 53393a8ef217ed7502b78d5d7f2f1cb092cc5adbe8e7da30f1cac901a262d31c
 SHA512:
-  metadata.gz: 24b6af4c0443e9aa198f48f409ceeef23412bf348853f96f1b58eb940534446b3b9a22d0e72c500b08b6da0d0a72d6627d4a268075c764ef8fcdd4c02eb7ff64
-  data.tar.gz: 147825fd829abaea034fa436c2c8fa47551204d05d6062bc8ec9f6e5b5f3195de4e8f51cec328915a421667e1c82a0b38011a7433bd77e6d758eeffa90aa1b2d
+  metadata.gz: e09cbbffebf131810a76a0470e85ad130148f556756ca3a6885ebd87cd181b7f354a5a8601f4428d77f1a1ba2fca47c58f7ba5fb9c5d3ac53ea159c5f4207ea2
+  data.tar.gz: 95a2986bcc458774f532adf6c2a28dff576d0ea7596c8c58fd3bf03aa86f218d2911536848ac3c0e5bac6e528ebd8ec6b47a9c3a17f96173a91ba0140fc1c9fc

data/lib/pg_conn/schema_methods.rb

@@ -36,7 +36,7 @@ module PgConn
     end
 
     # Hollow out a schema by dropping all tables and views (but still not
-    # functions and procedures TODO)
+    # functions and procedures TODO). TODO: Swap names with #clean!
     def empty!(schema, exclude: [])
       self.list_tables(schema, exclude: exclude).each { |table|
         conn.execute "drop table if exists #{schema}.#{table} cascade"
@@ -46,11 +46,13 @@ module PgConn
       }
     end
 
-    # Empty all tables in the given schema
-    def clean!(schema, exclude: [])
+    # Empty all tables in the given schema(s)
+    def clean!(*schemas, exclude: [])
       conn.session.triggers(false) {
-        self.list_tables(schema, exclude: exclude).each { |table|
-          conn.execute "delete from #{schema}.#{table}"
+        schemas.flatten.each { |schema|
+          self.list_tables(schema, exclude: exclude).each { |table|
+            conn.execute "delete from #{schema}.#{table}"
+          }
         }
       }
     end

data/lib/pg_conn/version.rb

@@ -1,3 +1,3 @@
 module PgConn
-  VERSION = "0.58.1"
+  VERSION = "0.59.2"
 end

data/lib/pg_conn.rb

@@ -96,7 +96,7 @@ module PgConn
 
   # Simple shorthand for ::quote_value
   def self.quote(value, elem_type: nil, json_type: nil)
-    quote_value(value, elem_type: nil, json_type: nil)
+    quote_value(value, elem_type: elem_type, json_type: json_type)
   end
 
   # Quote values and concatenate them using ',' as separator
@@ -463,6 +463,9 @@ module PgConn
       @pg_connection.close if @pg_connection && !@pg_connection.finished?
     end
 
+    # TODO: Rename #closed?
+    def terminated?() = @pg_connection&.finished?
+
     def self.new(*args, **opts, &block)
       if block_given?
         begin
@@ -882,9 +885,7 @@ module PgConn
     #     { database-column-name: object-method-name } # calls method on object
     #
     def insert(*args, upsert: nil, **opts)
-      # Normalize arguments
-
-      # Add options to args except the special :upsert option
+      # Add options to args except the special :conflict option
       args << opts if !opts.empty?
 
       # Add schema (=nil) if absent
@@ -932,29 +933,42 @@ module PgConn
       else
         raise ArgumentError, "Illegal argument '#{data.inspect}'"
       end
-
-      # On-conflict clause
-      upsert_sql =
-          case upsert
-            when true; "on conflict do nothing"
-            when String; "on conlict #{upsert}"
-            when false, nil; ""
-          else
-            raise ArgumentError, "Illegal value for :upsert option: #{upsert.inspect}"
-          end
+      identifiers_sql = quote_identifiers(fields)
+      values_sql = quote_tuples(tuples)
+      upsert_sql = ""
+
+      # On upsert
+      if upsert
+        other_identifiers_sql = quote_identifiers(fields.map { "excluded.#{_1}" })
+        upsert_sql = %(
+          on conflict (#{quote_identifiers(upsert)}) do update
+            set (#{identifiers_sql}) = (#{other_identifiers_sql}))
+      end
 
       # Execute SQL statement using either :value or :values depending on data arity
       self.send method, <<~SQL
-        insert into #{table} (#{quote_identifiers(fields)})
-          values #{quote_tuples(tuples)}
+        insert into #{table} (#{identifiers_sql})
+          values #{values_sql}
           #{upsert_sql}
           returning id
       SQL
     end
 
-    # Use upsert. Currently only 'on conflict do nothing' is supported
+    # Use upsert instead of insert and resolve conflicts by updating the target
+    # record. Called like #insert but with an additional key argument that is
+    # an array key to check for conflicts, default [:id]
+    #
+    # :call-seq:
+    #   upsert(table, struct|structs|record|records, key)
+    #   upsert(table, fields, struct|structs|record|records|tuples|values, key)
+    #
+    #   upsert(schema, table, struct|structs|record|records, key)
+    #   upsert(schema, table, fields, struct|structs|record|records|tuples|values, key)
+    #
     def upsert(*args)
-      insert(*args, upsert: true)
+      key = args.pop
+      key.is_a?(Array) && !key.empty? or raise ArgumentError, "Illegal value for key: #{key.inspect}"
+      insert(*args, upsert: key)
     end
 
     # Update record(s)
@@ -1004,19 +1018,17 @@ module PgConn
     end
 
     # Execute SQL statement(s) in a transaction and return the number of
-    # affected records (if any). Also sets #timestamp unless a transaction is
-    # already in progress. The +sql+ argument can be a command (String) or an
-    # arbitrarily nested array of commands. Note that you can't have commands
-    # that span multiple lines. The empty array is a NOP but the empty string
-    # is not.
+    # selected or affected records in the last statement. Also sets #timestamp
+    # unless a transaction is already in progress. The +sql+ argument can be a
+    # command (String) or an arbitrarily nested array of commands. The empty
+    # array is a NOP but the empty string is not.
     #
     # #exec pass Postgres exceptions to the caller unless :fail is false in
-    # which case it returns nil if an error occurred
-    #
-    # Note that postgres crashes the whole transaction stack if any error is
-    # met so if you're inside a transaction, the transaction will be in an
-    # error state and if you're also using subtransactions the whole
-    # transaction stack has collapsed
+    # which case it returns nil if an error occurred. Note that postgres
+    # crashes the whole transaction stack if any error is met so if you're
+    # inside a transaction, the transaction will be in an error state and if
+    # you're also using subtransactions the whole transaction stack has
+    # collapsed
     #
     # TODO: Make sure the transaction stack is emptied on postgres errors
     def exec(sql, commit: true, fail: true, silent: self.silent)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pg_conn
 version: !ruby/object:Gem::Version
-  version: 0.58.1
+  version: 0.59.2
 platform: ruby
 authors:
 - Claus Rasmussen