pg_conn 0.41.1 → 0.42.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c3ec749b3c1c7937e8c4fb0869c9ae3ef20549585f5385b44b1bf1f59275f02
-  data.tar.gz: cc620bc609a52ccf03d1976c8c13d5c37cb5d6de1d5edacb44b1a5fb3e334f98
+  metadata.gz: 1885ef3f2d7a35d098e8bf78136148634c7b2d828b33477235a3cd1e38765df6
+  data.tar.gz: 853369281c40c6c6fc60a80785f6166d27fcc500cf7f1e216e348adfed778c30
 SHA512:
-  metadata.gz: f58e940330fe87d38ece2ed98516b2e0ba21b5c14c6f3f561bd3339278176182bd5201e5529d3071a6318c02b8e6f5031a9be7b8b491af0e95ac299c09b8769f
-  data.tar.gz: fa5b3de455427cf6885c2d2757121465e312280f17a22da665fef5d232baa2406b0a14b2babd8ae6ebe22f04bb1d8f4d029d3f93c79be9c58b6ea16d6f9029be
+  metadata.gz: b839c16a46f84ae89f8bb941d08972f24edd3f3bf777d17197ad1cdaf5bc8e5ab368135e8222dac202a3b3d670c04c027e7a9afff00a0b851af8d899f93baef9
+  data.tar.gz: a9171073a19b5ed326eaf58a4d4fbcd4b61fad8bc1154e0c000e99b61c94b068ba8f70c14e773bd9eb455d0d7dd111a2bac02c4646c07b1bd01843d134338cb4

data/lib/pg_conn/schema_methods.rb

@@ -22,15 +22,15 @@ module PgConn
     def create(schema, authorization: nil)
       authorization_clause = authorization ? "authorization #{authorization}" : nil
       stmt = ["create schema", schema, authorization_clause].compact.join(" ")
-      conn.exec stmt
+      conn.execute stmt
     end
 
     # Drop schema
     def drop(schema, cascade: false)
       if cascade
-        conn.exec "drop schema if exists #{schema} cascade"
+        conn.execute "drop schema if exists #{schema} cascade"
       else
-        conn.exec "drop schema if exists #{schema}"
+        conn.execute "drop schema if exists #{schema}"
       end
       true
     end
@@ -39,10 +39,10 @@ module PgConn
     # functions and procedures TODO)
     def empty!(schema, exclude: [])
       self.list_tables(schema, exclude: exclude).each { |table|
-        conn.exec "drop table if exists #{schema}.#{table} cascade"
+        conn.execute "drop table if exists #{schema}.#{table} cascade"
       }
       self.list_views(schema, exclude: exclude).each { |view|
-        conn.exec "drop view if exists #{schema}.#{view} cascade"
+        conn.execute "drop view if exists #{schema}.#{view} cascade"
       }
     end
 
@@ -50,7 +50,7 @@ module PgConn
     def clean!(schema, exclude: [])
       conn.session.triggers(false) {
         self.list_tables(schema, exclude: exclude).each { |table|
-          conn.exec "delete from #{schema}.#{table}"
+          conn.execute "delete from #{schema}.#{table}"
         }
       }
     end
@@ -157,9 +157,9 @@ module PgConn
       uid = "#{schema}.#{table}"
       seq = sequence(schema, table) or raise ArgumentError, "Table #{uid} does not have a sequence"
       if value
-        conn.exec "select setval('#{seq}', #{value})"
+        conn.execute "select setval('#{seq}', #{value})"
       else
-        conn.exec "select setval('#{seq}', 1, false)"
+        conn.execute "select setval('#{seq}', 1, false)"
       end
     end
 

data/lib/pg_conn/version.rb

@@ -1,3 +1,3 @@
 module PgConn
-  VERSION = "0.41.1"
+  VERSION = "0.42.1"
 end

data/lib/pg_conn.rb

@@ -1068,16 +1068,6 @@ module PgConn
 
     # TODO: Move to TransactionMethods
 
-    def commit()
-      if transaction?
-        pop_transaction(fail: false)
-      else
-        pg_exec("commit")
-      end
-    end
-
-    def rollback() raise Rollback end
-
     # True if a transaction is in progress
     #
     # Note that this requires all transactions to be started using PgConn's
@@ -1113,6 +1103,7 @@ module PgConn
       end
     end
 
+    # FIXME :exception is unused
     def pop_transaction(commit: true, fail: true, exception: true)
       if transaction?
         if savepoint = @savepoints.pop
@@ -1156,13 +1147,11 @@ module PgConn
 
     # Start a transaction. If called with a block, the block is executed within
     # a transaction that is auto-committed if the commit option is true (the
-    # default). #transaction returns the result of the block or nil if no block
-    # was given
-    #
-    # The transaction can be rolled back inside the block by raising a
-    # PgConn::Rollback exception in which case #transaction returns nil. Note
-    # that the transaction timestamp is set to the start of the first
-    # transaction even if transactions are nested
+    # default). The transaction is rolled back automatically if :commit is
+    # false or if a PgConn::Rollback is raised with the block. #transaction
+    # returns the result of the block or nil if no block was given. Note that
+    # the transaction timestamp is set to the start of the first transaction
+    # even if transactions are nested
     #
     # FIXME: There is some strange problem in rspec where #insert handles
     # an exception correctly while #exec, #execute, and #transaction does not
@@ -1187,6 +1176,19 @@ module PgConn
       end
     end
 
+    # The flow to global transactions is
+    #
+    #   conn.transaction # Starts a transaction
+    #   ...
+    #   if ok
+    #     conn.commit
+    #   else
+    #     conn.rollback
+    #   end
+    #
+    def commit() pop_transaction(fail: false) end
+    def rollback() pop_transaction(commit: false, fail: false) end
+
     def dump(*query)
       records = self.records(*query)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pg_conn
 version: !ruby/object:Gem::Version
-  version: 0.41.1
+  version: 0.42.1
 platform: ruby
 authors:
 - Claus Rasmussen