pg_conn 0.41.1 → 0.42.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c3ec749b3c1c7937e8c4fb0869c9ae3ef20549585f5385b44b1bf1f59275f02
-  data.tar.gz: cc620bc609a52ccf03d1976c8c13d5c37cb5d6de1d5edacb44b1a5fb3e334f98
+  metadata.gz: 8d9aafa29dec55b879562f1ee2925322ccbde2c829d1c23c0529d41c171210e4
+  data.tar.gz: de71188ab165e6c0d3b8d1d1e947e5ea9deb0615287da2467dfffa7ae048d910
 SHA512:
-  metadata.gz: f58e940330fe87d38ece2ed98516b2e0ba21b5c14c6f3f561bd3339278176182bd5201e5529d3071a6318c02b8e6f5031a9be7b8b491af0e95ac299c09b8769f
-  data.tar.gz: fa5b3de455427cf6885c2d2757121465e312280f17a22da665fef5d232baa2406b0a14b2babd8ae6ebe22f04bb1d8f4d029d3f93c79be9c58b6ea16d6f9029be
+  metadata.gz: 7852a85c9a0b0ec2d31429a800cc1362e0c42d9a143cff80dfc47f81c2cad4fa3517777e91143f2a4876148b641a252d888e9316f53642af8f341772bce2bf8f
+  data.tar.gz: faf876c344f385b50f6813249114df1cec630ce85313517abb3e8a5a521524d14746fd58bed085cfc098298d0514bfa1c5bf17fa84fce0cb06790376a50699d4

data/lib/pg_conn/version.rb

@@ -1,3 +1,3 @@
 module PgConn
-  VERSION = "0.41.1"
+  VERSION = "0.42.0"
 end

data/lib/pg_conn.rb

@@ -1068,16 +1068,6 @@ module PgConn
 
     # TODO: Move to TransactionMethods
 
-    def commit()
-      if transaction?
-        pop_transaction(fail: false)
-      else
-        pg_exec("commit")
-      end
-    end
-
-    def rollback() raise Rollback end
-
     # True if a transaction is in progress
     #
     # Note that this requires all transactions to be started using PgConn's
@@ -1113,6 +1103,7 @@ module PgConn
       end
     end
 
+    # FIXME :exception is unused
     def pop_transaction(commit: true, fail: true, exception: true)
       if transaction?
         if savepoint = @savepoints.pop
@@ -1156,13 +1147,11 @@ module PgConn
 
     # Start a transaction. If called with a block, the block is executed within
     # a transaction that is auto-committed if the commit option is true (the
-    # default). #transaction returns the result of the block or nil if no block
-    # was given
-    #
-    # The transaction can be rolled back inside the block by raising a
-    # PgConn::Rollback exception in which case #transaction returns nil. Note
-    # that the transaction timestamp is set to the start of the first
-    # transaction even if transactions are nested
+    # default). The transaction is rolled back automatically if :commit is
+    # false or if a PgConn::Rollback is raised with the block. #transaction
+    # returns the result of the block or nil if no block was given. Note that
+    # the transaction timestamp is set to the start of the first transaction
+    # even if transactions are nested
     #
     # FIXME: There is some strange problem in rspec where #insert handles
     # an exception correctly while #exec, #execute, and #transaction does not
@@ -1187,6 +1176,19 @@ module PgConn
       end
     end
 
+    # The flow to global transactions is
+    #
+    #   conn.transaction # Starts a transaction
+    #   ...
+    #   if ok
+    #     conn.commit
+    #   else
+    #     conn.rollback
+    #   end
+    #
+    def commit() pop_transaction(fail: false) end
+    def rollback() pop_transaction(commit: false, fail: false) end
+
     def dump(*query)
       records = self.records(*query)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pg_conn
 version: !ruby/object:Gem::Version
-  version: 0.41.1
+  version: 0.42.0
 platform: ruby
 authors:
 - Claus Rasmussen