pg_conn 0.4.1 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e9c82eb8c1dc8b48877759c39ecd0f3f0d2a8bb5f37abfffd0969208c1718cd4
-  data.tar.gz: b003f7990a98a8a63e9bd847ffdb2b44d3de9b61067c37189a8267efd3872346
+  metadata.gz: 6e3c08d86eff1bd5cc3d8d40024dad64bf5879f14e56f20a5facdcc8abf3cc72
+  data.tar.gz: ff23710aa798488f0ad6b18bea834c7b396d54e211bb19af800b8f66d7378430
 SHA512:
-  metadata.gz: 988688435e1c6aa8026772cc4813537101e410c86a4c032dd8369d271a5d519209c7b9ff61d132421d2fb42a4c5cfe533b3b6e994adc2039b930203f3279aad7
-  data.tar.gz: 696363e3cc63c7fc1986d1c898053c012c524179a40817eb632a0080669bae948f3f32d97abb5691a8a194042d100a688626d8f12525197ddbe3e42d92d4badb
+  metadata.gz: e5505ad838a108abdcf146ec2da0ca255bf9931b8ff786d796eced468c5bc00a0222e1a2fb7aca7e6e9ac758ea187bbb253c5b536e51a485e8e54b8da71bb886
+  data.tar.gz: b336099c4158450ef646a022b76d4cbc72399e6b4dfb34fd6905317fd11168459b0d51f4105152df5ccae8135cedf8bd01322733859a45e446a711a952848fab

data/TODO

@@ -1,11 +1,14 @@
 TODO
-  o Option to accept no records when using #value, #tuple, and #struct. The
-    alternative is to use the 'one-table' as base table in the query and then
-    left join the rest
-  o Implement search_path
+  o Use SQL parameters. Optionally with a different syntax:
+      $var - Value that gets single-quoted
+      @var - Identifier that gets double-quoted (@ for "attribute")
+  o Option to accept no records when using #value, #tuple, and #struct. Maybe
+    value?, tuple?, struct?. The alternative is to use the 'one-table' as base
+    table in the query and then left join the rest
   o Proper implementation of call of functions and procedures: Functions should
     be called through #value, #tuple etc. and procedures through #call.
     Proceduer output parameters needs handling too
+  o Implement search_path
   o Create an abstract PgConnBase and have PgStmts (writes statements to array)
     and PgConn (sends statements to server) classes derived from it
   o fix silent

data/lib/pg_conn/version.rb

@@ -1,3 +1,3 @@
 module PgConn
-  VERSION = "0.4.1"
+  VERSION = "0.4.4"
 end

data/lib/pg_conn.rb

@@ -219,10 +219,12 @@ module PgConn
     # Return true if the table or the result of the query is empty
     def empty?(arg, where_clause = nil) 
       if arg =~ /\s/
-        count("select 1 from (#{arg}) as inner_query")
+        value "select count(*) from (#{arg} limit 1) as inner_query"
+      elsif where_clause
+        value "select count(*) from (select 1 from #{arg} where #{where_clause} limit 1) as inner_query"
       else
-        count("select 1 from #{arg}" + (where_clause ? " where #{where_clause}" : ""))
-      end == 1
+        value "select count(*) from (select 1 from #{arg} limit 1) as inner_query"
+      end == 0
     end
 
     # :call-seq:
@@ -433,20 +435,21 @@ module PgConn
     end
 
     # Return the value of calling the given function (which can be a String or
-    # a Symbol). It dynamically detects the structure of the result and return
-    # a value or an array of values if the result contained only one column
-    # (like #value or #values), a tuple if the record has multiple columns
-    # (like #tuple), and an array of of tuples if the result contained more
-    # than one record with multiple columns (like #tuples)
+    # a Symbol and can contain the schema of the function). It dynamically
+    # detects the structure of the result and return a value or an array of
+    # values if the result contained only one column (like #value or #values),
+    # a tuple if the record has multiple columns (like #tuple), and an array of
+    # of tuples if the result contained more than one record with multiple
+    # columns (like #tuples)
     #
-    def call(name, *args, proc: false)
+    def call(name, *args, proc: false) # :proc may interfere with hashes
       args_sql = args.map { |arg| # TODO: Use pg's encoder
         case arg
           when NilClass; "null"
           when String; "'#{arg}'"
           when Integer; arg
           when TrueClass, FalseClass; arg
-          when Array; raise NotImplementedError
+          when Array; "Array['#{arg.join("', '")}']" # Quick and dirty # FIXME
           when Hash; raise NotImplementedError
         else
           raise ArgumentError, "Unrecognized value: #{arg.inspect}"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_conn
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.4
 platform: ruby
 authors:
 - Claus Rasmussen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-06-01 00:00:00.000000000 Z
+date: 2022-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg