pg_conn 0.34.0 → 0.35.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d18d4244a00a767589287122f298966ccdd9e8d53a6467f84097df698be34a6
-  data.tar.gz: 6ad5c4c5cf19459996d744e25627cd852d03fa1fa25688572c40de71a5a61100
+  metadata.gz: a4c942ce055688931946e0d5a71ddc89a722b2dd98ea6d9d0edc150b39421dd9
+  data.tar.gz: 3fea9a99e361c86b3b413845d5f319562051347afe025a27006c80548f822ff4
 SHA512:
-  metadata.gz: 9a476b27de6f211d02957c543cf2ee0742011e3d06a468a006fee143827c3cceb8ad32610ca5dee5692cf0230a4c188dd6a4a57335e1eb51d48bc23a9a52e7d3
-  data.tar.gz: 89dcdcec1bdd52d6b2a6ce56ee688e77661f7d438187e289d26e9344d9d030450caea180e260348050c9abcfd34261465fa1d82cefbded641e16ffde708250b5
+  metadata.gz: aa391cc15005c51ca01503e33096dacecec5743fa3bf6f28c22d7fd2ad7e14d2e23f48dc2cc0e3e9cade6d77bc359d3b56ebb871015e2db9d08cffcedcf8988f
+  data.tar.gz: 6fd5537fe417a8dac42ad2ac3af16c75a329bcafc93118ae2a375a3ec3368d0dc088163f8dbd87d5b56a8cb357b3bc5c76c6f9ec49618d4d4c6099bee472b423

data/lib/pg_conn/version.rb

@@ -1,3 +1,3 @@
 module PgConn
-  VERSION = "0.34.0"
+  VERSION = "0.35.0"
 end

data/lib/pg_conn.rb

@@ -155,19 +155,27 @@ module PgConn
     # #exec or #transaction block. The timestamp includes the current time zone
     attr_reader :timestamptz
 
-    # Controls notices. Valid values are true, false, nil, or a Proc
-    # object that recieves the message. True causes the message to be printed
-    # to standard output, false ignores it, and nil resets the state to the
-    # default given when the connection was initialized
-    def notice=(value) set_option(:notice, value) end
+    # Controls error messages. It can be assigned true, false, nil. True causes
+    # the error message to be printed to standard error, false ignores it, and
+    # nil resets the state to the default given when the connection was
+    # initialized or false if absent. Note that #silent only controls the error
+    # message, the exception is not affected
+    def silent() @options[:silent] end
+    def silent=(value) set_option(:silent, value) end
+
+    # Controls notices. It can be assigned true, false, nil, or a Proc object
+    # that recieves the message. True causes the message to be printed to
+    # standard output, false ignores it, and nil resets the state to the
+    # default given when the connection was initialized or false if absent
     def notice() @options[:notice] end
+    def notice=(value) set_option(:notice, value) end
 
-    # Controls warnings. Valid values are true, false, nil, or a Proc
-    # object that recieves the message. True causes the message to be printed
-    # to standard error, false ignores it, and nil resets the state to the
-    # default given when the connection was initialized
-    def warning=(value) set_option(:warning, value) end
+    # Controls warnings. It can be assigned true, false, nil, or a Proc object
+    # that recieves the message. True causes the message to be printed to
+    # standard error, false ignores it, and nil resets the state to the default
+    # given when the connection was initialized or false if absent
     def warning() @options[:warning] end
+    def warning=(value) set_option(:warning, value) end
 
     # TODO: Move error message handling into the same framework as notice and
     # warning but we have a name collision just below that would need to be
@@ -206,7 +214,7 @@ module PgConn
     # if absent in the Postgres error message
     def errchar = err[2]
 
-    DEFAULT_OPTIONS = { notice: false, warning: false }
+    DEFAULT_OPTIONS = { silent: false, notice: false, warning: false }
 
     # :call-seq:
     #     initialize(dbname = nil, user = nil, **options)
@@ -314,7 +322,8 @@ module PgConn
         # type "uuid" with oid 2950..' warnings
         type_map.default_type_map = PG::TypeMapAllStrings.new
 
-        # Timestamp decoder. FIXME What is this?
+        # Timestamp decoder. FIXME What is this? Why only Timestamp and not
+        # Timestamptz?
         type_map.add_coder PG::TextDecoder::Timestamp.new( # Timestamp without time zone
             oid: 1114,
             flags: PG::Coder::TIMESTAMP_DB_UTC | PG::Coder::TIMESTAMP_APP_UTC)
@@ -329,12 +338,13 @@ module PgConn
 
         @pg_connection.type_map_for_results = type_map
         @pg_connection.field_name_type = @field_name_class.to_s.downcase.to_sym # Use symbol field names
-
-        @options, @default_options = {}, DEFAULT_OPTIONS
-        set_options(options) # require @default_options
-        @default_options = @options.dup
       end
 
+      # Set options even if there is no connection to avoid special casing
+      # absent options
+      @options, @default_options = {}, DEFAULT_OPTIONS.merge(options)
+      set_options(options) if @pg_connection
+
       @schema = SchemaMethods.new(self)
       @role = RoleMethods.new(self)
       @rdbms = RdbmsMethods.new(self)
@@ -685,7 +695,7 @@ module PgConn
     # of the function.  If the :proc option is true the "function" is assumed
     # to be a procedure
     #
-    def call(name, *args, elem_type: nil, silent: false, proc: false) # :proc may interfere with hashes
+    def call(name, *args, elem_type: nil, silent: self.silent, proc: false) # :proc may interfere with hashes
       args_seq = quote_values(args, elem_type: elem_type)
       if proc
         pg_exec "call #{name}(#{args_seq})", silent: silent
@@ -709,7 +719,7 @@ module PgConn
     end
 
     # Like #call with :proc set to true
-    def proc(name, *args, silent: false)
+    def proc(name, *args, silent: self.silent)
       call(name, *args, silent: silent, proc: true)
     end
 
@@ -818,7 +828,7 @@ module PgConn
     end
 
     # Execute block with global options and resets afterwards. Currently only
-    # :notice and :warning is supported. Very useful in RSpec tests
+    # :silent, :notice and :warning is supported. Very useful in RSpec tests
     #
     # TODO: :error, :fail, :symbol, :schema, :search_path
     #
@@ -848,14 +858,14 @@ module PgConn
     # transaction stack has collapsed
     #
     # TODO: Make sure the transaction stack is emptied on postgres errors
-    def exec(sql, commit: true, fail: true, silent: false)
+    def exec(sql, commit: true, fail: true, silent: self.silent)
       transaction(commit: commit) { execute(sql, fail: fail, silent: silent) }
     end
 
-    # Like #exec but returns true/false depending on if the command succeeded.
-    # There is not a corresponding #execute? method because any failure rolls
-    # back the whole transaction stack. TODO: Check which exceptions that
-    # should be captured
+    # Like #exec but returns true/false depending on if the command succeeded,
+    # error messages are suppressed by default.  There is no corresponding
+    # #execute? method because any failure rolls back the whole transaction
+    # stack. TODO: Check which exceptions that should be captured
     def exec?(sql, commit: true, silent: true)
       begin
         exec(sql, commit: commit, fail: true, silent: silent)
@@ -873,7 +883,7 @@ module PgConn
     # unless :fail is false in which case it returns nil
     #
     # TODO: Handle postgres exceptions wrt transaction state and stack
-    def execute(sql, fail: true, silent: false)
+    def execute(sql, fail: true, silent: self.silent)
       if @pg_connection
         begin
           pg_exec(sql, silent: silent)&.cmd_tuples
@@ -994,6 +1004,9 @@ module PgConn
     # PgConn::Rollback exception in which case #transaction returns nil. Note
     # that the transaction timestamp is set to the start of the first
     # transaction even if transactions are nested
+    #
+    # FIXME: There is some strange problem in rspec where an #insert handles
+    # an exception correctly while #exec, #execute, and #transaction does not
     def transaction(commit: true, &block)
       if block_given?
         result = nil
@@ -1165,6 +1178,14 @@ module PgConn
     # that is shared between all connection copies
     def set_option(option, value)
       case option
+        when :silent
+          @options[:silent] =
+              case value
+                when true, false; value
+                when nil; @default_options[:silent]
+              else
+                raise ArgumentError, "Illegal value #{value.inspect}"
+              end
         when :notice, :warning
           @options[option] =
               case value
@@ -1231,7 +1252,7 @@ module PgConn
     # though
     #
     # TODO: Fix silent by not handling exceptions
-    def pg_exec(arg, silent: false)
+    def pg_exec(arg, silent: self.silent)
       if @pg_connection
         begin
           last_stmt = nil # To make the current SQL statement visible to the rescue clause. FIXME Not used?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_conn
 version: !ruby/object:Gem::Version
-  version: 0.34.0
+  version: 0.35.0
 platform: ruby
 authors:
 - Claus Rasmussen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-03-08 00:00:00.000000000 Z
+date: 2025-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg