pg_conn 0.3.4 → 0.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7f16674ecd9e41796dab773ca10d938a61619859676d2f8746a0d6694e598bb2
-  data.tar.gz: 9b88a48fa7692419c2bbf81e6f1162eb8a54477ac821517e3ba80738923b6128
+  metadata.gz: 589bec28c740660ad6dd0f09101eda54af26aad2f03a43a27ed7ffa6e422fdf3
+  data.tar.gz: 17ccef8e37a0699331e7c518d1a856652750719dbd2c1a3d04af5173f0d625f5
 SHA512:
-  metadata.gz: f31c28e8d255792671cce8e1697cdfbc6d140814cb3956ce2935c24aa4d52f2fffb5945761051568b97f1cbdafa39165dbe581a6d7b7ae0a594af238833acc5b
-  data.tar.gz: 44bac37de6928e4905db9c53c97728b1c528a17d23c62a8539b44f830e84d6e2b42c270a18028d5648b05aa840c868ddfb57e9affa3aee8023332f8c53f28aab
+  metadata.gz: 91c48594e61dc7caef44a22de75165f5815e69b4dc2e1b181b024291b5bb7cd3ec9eee97aced702a459424afcc093406af9e6d6cb631b128e8117f0084249ac4
+  data.tar.gz: d485db7de8dd27c0eb81db8c1d6940f02ba822a88514e6d13999747c55e902121306e1a0c04105be8881dd0f84819f73aa46101432004b22745e2e9848b0d3d6

data/lib/pg_conn/role_methods.rb

@@ -44,11 +44,10 @@ module PgConn
     # Create a new role
     def create(rolename, superuser: false, create_database: false, can_login: false, create_role: false)
       user_decl = "create role \"#{rolename}\""
-      superuser_decl = superuser ? "--superuser" : nil
-      create_database_decl = create_database ? "--createdb" : "--nocreatedb"
-      can_login_decl = can_login ? "--login" : "--nologin"
-      create_role_decl = create_role ? "--createrole" : "--nocreaterole"
-
+      superuser_decl = superuser ? "superuser" : "nosuperuser"
+      create_database_decl = create_database ? "createdb" : "nocreatedb"
+      can_login_decl = can_login ? "login" : "nologin"
+      create_role_decl = create_role ? "createrole" : "nocreaterole"
       stmt = [user_decl, superuser_decl, can_login_decl, create_role_decl].compact.join(" ")
       conn.exec stmt
     end

data/lib/pg_conn/schema_methods.rb

@@ -53,7 +53,7 @@ module PgConn
 
     # Return true if table exists
     def exist_table?(schema, table)
-      conn.exist?(relation_exist_query(schema, table, kind: %w(r)))
+      conn.exist?(relation_exist_query(schema, table, kind: %w(r f)))
     end
 
     # Return true if view exists
@@ -73,7 +73,7 @@ module PgConn
 
     # Return list of tables in the schema
     def list_tables(schema)
-      conn.values relation_list_query(schema, kind: %w(r))
+      conn.values relation_list_query(schema, kind: %w(r f))
     end
 
     # Return list of view in the schema
@@ -103,7 +103,7 @@ module PgConn
 
   private
     def relation_exist_query(schema, relation, kind: nil)
-      kind_sql_list = "'" + (kind.nil? ? %w(r v m) : Array(kind).flatten).join("', '") + "'"
+      kind_sql_list = "'" + (kind.nil? ? %w(r f v m) : Array(kind).flatten).join("', '") + "'"
       %(
           select  1
           from    pg_class 
@@ -114,7 +114,7 @@ module PgConn
     end
 
     def relation_list_query(schema, kind: nil)
-      kind_sql_list = "'" + (kind.nil? ? %w(r v m) : Array(kind).flatten).join("', '") + "'"
+      kind_sql_list = "'" + (kind.nil? ? %w(r f v m) : Array(kind).flatten).join("', '") + "'"
       %(
           select  relname
           from    pg_class 

data/lib/pg_conn/version.rb

@@ -1,3 +1,3 @@
 module PgConn
-  VERSION = "0.3.4"
+  VERSION = "0.3.7"
 end

data/lib/pg_conn.rb

@@ -98,6 +98,7 @@ module PgConn
     # https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING
     # for the full list
     #
+    # TODO: Change to 'initialize(*args, **opts)'
     def initialize(*args)
       if args.last.is_a?(Hash)
         @field_name_class = args.last.delete(:field_name_class) || Symbol
@@ -180,17 +181,17 @@ module PgConn
       @pg_connection.close if @pg_connection && !@pg_connection.finished? 
     end
 
-    def self.new(*args, &block)
+    def self.new(*args, **opts, &block)
       if block_given?
         begin
           object = Connection.allocate
-          object.send(:initialize, *args)
+          object.send(:initialize, *args, **opts)
           yield(object) # if object.pg_connection
         ensure
           object.terminate if object.pg_connection
         end
       else
-        super(*args)
+        super(*args, **opts)
       end
     end
 
@@ -450,8 +451,7 @@ module PgConn
           raise ArgumentError, "Unrecognized value: #{arg.inspect}"
         end
       }.join(", ")
-      query = "select * from #{name}(#{args_sql})"
-      r = pg_exec(query)
+      r = pg_exec "select * from #{name}(#{args_sql})"
       if r.ntuples == 0
         raise Error, "No records returned"
       elsif r.ntuples == 1
@@ -477,7 +477,7 @@ module PgConn
     # fail is false #exec instead return nil but note that postgres doesn't
     # ignore it so that if you're inside a transaction, the transaction will be
     # in an error state and if you're also using subtransactions the whole
-    # transaction stack collapses.
+    # transaction stack has collapsed
     #
     # TODO: Make sure the transaction stack is emptied on postgres errors
     def exec(sql, commit: true, fail: true, silent: false)
@@ -636,7 +636,7 @@ module PgConn
     def pg_exec(arg, fail: true, silent: false)
       if @pg_connection
         begin
-          last_stmt = nil # To make the current SQL statement visible to the rescue clause
+          last_stmt = nil # To make the current SQL statement visible to the rescue clause. FIXME Not used?
           if arg.is_a?(String)
             return nil if arg == ""
             last_stmt = arg

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_conn
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.7
 platform: ruby
 authors:
 - Claus Rasmussen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-04-07 00:00:00.000000000 Z
+date: 2022-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg