pg_conn 0.13.4 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47d71f26ef9bedde82dfcaf9c196dfde4bf7e016d8865b195687b717972dc5c9
-  data.tar.gz: aa0aa1f21ac0a15ae1094bab38ff03b7c9099e08bb5437ed3557a70bf7cc38f4
+  metadata.gz: d29017a92f97bb843ada8a10d00ab0a130e0e572e9775f21ddacb9f6d9ca4e66
+  data.tar.gz: e56a31694ec01c3ef15ae35b1f5a28304dad179a918c69a687e08fb267f1b30e
 SHA512:
-  metadata.gz: d9ca49b277657eb5e7ebd9f5a7896168db39ce12b22d7598eb04b39fd9ee8c183fde92adc2c1e2f506ca532a62fd0fda67ec42660843fd74cddd8f6ea2256f0c
-  data.tar.gz: '0648150d407460aaf0c5f2f1cb2fdbd6313eed964e72073b2888e4f54cf82af2d96968dd3b7aaa11469620ed459509e948a8fd717ac54284067230702387f0df'
+  metadata.gz: a920f75a6d118bdc44e5442adbe38e6ecbc6872ac010f3c29390a25db4e95605541d4bc1dd67a0f7ac1332611119d983211aaff1acda885aca07ed1a464705a7
+  data.tar.gz: 4339f922abbdeb6db692a8906a5c5fea4aa21a645be69df90a39473cc2453c9f79c684b8b2e69996a343cc368dcaeaecc960154dbcc78003ec230bd3605363ad

data/lib/pg_conn/role_methods.rb

@@ -79,10 +79,9 @@ module PgConn
 #     end
     end
 
-    # List users. TODO Use RE instead of database argument. Also doc this shit
-    # FIXME: Depends on the <database>__<username> convention
+    # List users. TODO Use RE. Also doc this shit
     def list(database: nil, owner: false, superuser: nil, can_login: nil)
-      database_clause = database && "rolname like '#{database}\_\_%'"
+      database_clause = database && "rolname like '#{database}\\_\\_%'"
       database_clause = database && "(#{database_clause} or rolname = '#{database}')" if owner
       superuser_clause = superuser.nil? ? nil : "rolsuper = #{superuser}"
       can_login_clause = can_login.nil? ? nil : "rolcanlogin = #{can_login}"

data/lib/pg_conn/version.rb

@@ -1,3 +1,3 @@
 module PgConn
-  VERSION = "0.13.4"
+  VERSION = "0.14.0"
 end

data/lib/pg_conn.rb

@@ -175,6 +175,9 @@ module PgConn
           end
 
       if @pg_connection && !using_existing_connection
+        # Set a dummy notice processor to avoid warnings on stderr
+        @pg_connection.set_notice_processor { |message| ; } # Intentionally a nop
+
         # Auto-convert to ruby types
         type_map = PG::BasicTypeMapForResults.new(@pg_connection) 
 
@@ -677,7 +680,9 @@ module PgConn
 
     def rollback() raise Rollback end
 
-    # True if a transaction is in progress
+    # True if a transaction is in progress. Note that this requires all
+    # transactions to be started using PgConn's transaction methods;
+    # transactions started using raw SQL are not registered
     def transaction?() !@savepoints.nil? end
 
     # Returns number of transaction or savepoint levels
@@ -715,7 +720,7 @@ module PgConn
     # invalid and the server is in an invalid state
     #
     # It is not an error to call #cancel_transaction when no transaction is in
-    # progress
+    # progress, the method always succeeds
     def cancel_transaction
       begin
         pg_exec("rollback")
@@ -724,25 +729,34 @@ module PgConn
       @savepoints = nil
     end
 
-    # Execute block within a transaction and return the result of the block.
-    # The transaction can be rolled back by raising a PgConn::Rollback
-    # exception in which case #transaction returns nil. Note that the
-    # transaction timestamp is set to the start of the first transaction even
-    # if transactions are nested
+    # Start a transaction. If called with a block, the block is executed within
+    # a transaction that is auto-committed if the commit option is true (the
+    # default). #transaction returns the result of the block or nil if no block
+    # was given
+    #
+    # The transaction can be rolled back inside the block by raising a
+    # PgConn::Rollback exception in which case #transaction returns nil. Note
+    # that the transaction timestamp is set to the start of the first
+    # transaction even if transactions are nested
     def transaction(commit: true, &block)
-      result = nil
-      begin
+      if block_given?
+        result = nil
+        begin
+          push_transaction
+          result = yield
+        rescue PgConn::Rollback
+          pop_transaction(commit: false)
+          return nil
+        rescue PG::Error
+          @savepoints = nil
+          raise
+        end
+        pop_transaction(commit: commit)
+        result
+      else
         push_transaction
-        result = yield
-      rescue PgConn::Rollback
-        pop_transaction(commit: false)
-        return nil
-      rescue PG::Error
-        @savepoints = nil
-        raise
+        nil
       end
-      pop_transaction(commit: commit)
-      result
     end
 
   private

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pg_conn
 version: !ruby/object:Gem::Version
-  version: 0.13.4
+  version: 0.14.0
 platform: ruby
 authors:
 - Claus Rasmussen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-04-10 00:00:00.000000000 Z
+date: 2024-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg