pg_audit_log 0.4.0 → 0.4.4

data/.gitignore

@@ -1,3 +1,4 @@
+.vimlog
 *.gem
 *~
 .DS_Store

data/.rvmrc

@@ -1 +1 @@
-rvm 1.9.2@pg_audit_log --create
+rvm 1.9.3-p0@pg_audit_log --create

data/README.rdoc

@@ -9,7 +9,9 @@ Comes with specs for your project and a rake task to generate the reverse SQL to
 
 All SQL INSERTs, UPDATEs, and DELETEs will be captured. Record columns that do not change do not generate an audit log entry.
 
-Compatible with Rails 3.0.x and 3.1.x
+Compatible with Rails 3.0.x, 3.1.x and 3.2.x
+
+On a 2.93GHz i7 with postgresql 9.1 the audit log has an overhead of about 0.0035 seconds to each INSERT, UPDATE or DELETE
 
 == INSTALL
 

data/lib/pg_audit_log/entry.rb

@@ -1,6 +1,10 @@
 class PgAuditLog::Entry < ActiveRecord::Base
   TABLE_NAME = "audit_log"
-  set_table_name TABLE_NAME
+  if ::ActiveRecord::VERSION::MAJOR == 3 && ::ActiveRecord::VERSION::MINOR >= 2
+    self.table_name = TABLE_NAME
+  else
+    set_table_name TABLE_NAME
+  end
 
   class CannotDeleteError < StandardError
     def message

data/lib/pg_audit_log/extensions/shared/postgresql_adapter.rb

@@ -30,7 +30,11 @@ class ActiveRecord::ConnectionAdapters::PostgreSQLAdapter
     if PgAuditLog::Triggers.tables_with_triggers.include?(table_name)
       PgAuditLog::Triggers.drop_for_table(table_name)
     end
-    drop_table_without_auditing(table_name, options)
+    if ::ActiveRecord::VERSION::MAJOR == 3 && ::ActiveRecord::VERSION::MINOR >= 2
+      drop_table_without_auditing(table_name)
+    else
+      drop_table_without_auditing(table_name, options)
+    end
   end
   alias_method_chain :drop_table, :auditing
 

data/lib/pg_audit_log/function.rb

@@ -61,40 +61,39 @@ module PgAuditLog
               unique_name varchar;
               column_name varchar;
             BEGIN
+              primary_key_column := NULL;
+              EXECUTE 'SELECT pg_attribute.attname
+                       FROM pg_index, pg_class, pg_attribute
+                       WHERE pg_class.oid = $1::regclass
+                       AND indrelid = pg_class.oid
+                       AND pg_attribute.attrelid = pg_class.oid
+                       AND pg_attribute.attnum = any(pg_index.indkey)
+                       AND indisprimary'
+              INTO primary_key_column USING TG_RELNAME;
+              user_identifier := pg_temp.pg_audit_log_user_identifier();
+              unique_name := pg_temp.pg_audit_log_user_unique_name();
+              primary_key_value := NULL;
+
               FOR col IN SELECT * FROM information_schema.columns WHERE table_name = TG_RELNAME LOOP
                 new_value := NULL;
                 old_value := NULL;
-                primary_key_column := NULL;
-                primary_key_value := NULL;
-                user_identifier := pg_temp.pg_audit_log_user_identifier();
-                unique_name := pg_temp.pg_audit_log_user_unique_name();
                 column_name := col.column_name;
-
-                EXECUTE 'SELECT pg_attribute.attname
-                         FROM pg_index, pg_class, pg_attribute
-                         WHERE pg_class.oid = $1::regclass
-                         AND indrelid = pg_class.oid
-                         AND pg_attribute.attrelid = pg_class.oid
-                         AND pg_attribute.attnum = any(pg_index.indkey)
-                         AND indisprimary'
-                INTO primary_key_column USING TG_RELNAME;
-
-                IF TG_OP = 'INSERT' OR TG_OP = 'UPDATE' THEN
-                  EXECUTE 'SELECT CAST($1 . '|| column_name ||' AS TEXT)' INTO new_value USING NEW;
-                  IF primary_key_column IS NOT NULL THEN
-                    EXECUTE 'SELECT CAST($1 . '|| primary_key_column ||' AS VARCHAR)' INTO primary_key_value USING NEW;
-                  END IF;
-                END IF;
-                IF TG_OP = 'DELETE' OR TG_OP = 'UPDATE' THEN
-                  EXECUTE 'SELECT CAST($1 . '|| column_name ||' AS TEXT)' INTO old_value USING OLD;
-                  IF primary_key_column IS NOT NULL THEN
-                    EXECUTE 'SELECT CAST($1 . '|| primary_key_column ||' AS VARCHAR)' INTO primary_key_value USING OLD;
-                  END IF;
-                END IF;
-
                 IF TG_RELNAME = '#{users_table_name}' AND column_name = '#{users_access_column}' THEN
                   NULL;
                 ELSE
+                  IF TG_OP = 'INSERT' OR TG_OP = 'UPDATE' THEN
+                    EXECUTE 'SELECT CAST($1 . '|| column_name ||' AS TEXT)' INTO new_value USING NEW;
+                    IF primary_key_value IS NULL AND primary_key_column IS NOT NULL THEN
+                      EXECUTE 'SELECT CAST($1 . '|| primary_key_column ||' AS VARCHAR)' INTO primary_key_value USING NEW;
+                    END IF;
+                  END IF;
+                  IF TG_OP = 'DELETE' OR TG_OP = 'UPDATE' THEN
+                    EXECUTE 'SELECT CAST($1 . '|| column_name ||' AS TEXT)' INTO old_value USING OLD;
+                    IF primary_key_value IS NULL AND primary_key_column IS NOT NULL THEN
+                      EXECUTE 'SELECT CAST($1 . '|| primary_key_column ||' AS VARCHAR)' INTO primary_key_value USING OLD;
+                    END IF;
+                  END IF;
+
                   IF TG_OP != 'UPDATE' OR new_value != old_value OR (TG_OP = 'UPDATE' AND ( (new_value IS NULL AND old_value IS NOT NULL) OR (new_value IS NOT NULL AND old_value IS NULL))) THEN
                     INSERT INTO audit_log("operation",
                                           "table_name",

data/lib/pg_audit_log/triggers.rb

@@ -11,7 +11,11 @@ module PgAuditLog
 
     class << self
       def tables
-        connection.tables - (PgAuditLog::IGNORED_TABLES + [PgAuditLog::Entry.table_name])
+        skip_tables = (PgAuditLog::IGNORED_TABLES + [PgAuditLog::Entry.table_name])
+        connection.tables.reject do |table|
+          skip_tables.include?(table) ||
+            skip_tables.any? { |skip_table| skip_table =~ table if skip_table.is_a? Regexp }
+        end
       end
 
       def tables_with_triggers
@@ -28,6 +32,10 @@ module PgAuditLog
         tables - tables_with_triggers
       end
 
+      def all_tables_without_triggers
+        connection.tables - tables_with_triggers
+      end
+
       def install
         tables.each do |table|
           create_for_table(table) unless tables_with_triggers.include?(table)

data/lib/pg_audit_log/version.rb

@@ -1,3 +1,3 @@
 module PgAuditLog
-  VERSION = "0.4.0"
+  VERSION = "0.4.4"
 end

data/pg_audit_log.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency("rails", ">= 3.0.0")
   s.add_dependency("pg", ">= 0.9.0")
-  s.add_development_dependency('rspec-rails')
+  s.add_development_dependency('rspec-rails', "= 2.7")
   s.add_development_dependency('with_model', '>= 0.1.3')
   s.add_development_dependency('autotest')
 end

data/spec/pg_audit_log_spec.rb

@@ -222,6 +222,19 @@ describe PgAuditLog do
         its(:primary_key) { should be_nil }
       end
     end
+
+    describe "performance" do
+      xit "should perform well" do
+        require "benchmark"
+        results = Benchmark.measure do
+          1000.times do
+            AuditedModel.create!(attributes)
+          end
+        end
+        puts results.real
+        puts results.real / 1000.0
+      end
+    end
   end
 
   describe "during migrations" do

data/spec/triggers_spec.rb

@@ -17,6 +17,23 @@ describe PgAuditLog::Triggers do
     PgAuditLog::Triggers.drop_for_table(TableWithoutTriggers.table_name) rescue nil
   end
 
+  describe ".tables" do
+    subject { PgAuditLog::Triggers.tables }
+
+    with_model :table_to_ignore do
+      table {}
+    end
+
+    before do
+      PgAuditLog::IGNORED_TABLES << /ignore/
+    end
+
+    it { should include(TableWithTriggers.table_name) }
+    it { should include(TableWithoutTriggers.table_name) }
+    it { should_not include(PgAuditLog::Entry.table_name) }
+    it { should_not include(TableToIgnore.table_name) }
+  end
+
   describe ".tables_with_triggers" do
     it "should return an array of all tables that do have an audit trigger installed" do
       PgAuditLog::Triggers.tables_with_triggers.should include(TableWithTriggers.table_name)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pg_audit_log
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-03 00:00:00.000000000Z
+date: 2012-02-09 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &2152506680 !ruby/object:Gem::Requirement
+  requirement: &70094371058580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *2152506680
+  version_requirements: *70094371058580
 - !ruby/object:Gem::Dependency
   name: pg
-  requirement: &2152505720 !ruby/object:Gem::Requirement
+  requirement: &70094371056820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,21 +32,21 @@ dependencies:
         version: 0.9.0
   type: :runtime
   prerelease: false
-  version_requirements: *2152505720
+  version_requirements: *70094371056820
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &2152505120 !ruby/object:Gem::Requirement
+  requirement: &70094371056040 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - =
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.7'
   type: :development
   prerelease: false
-  version_requirements: *2152505120
+  version_requirements: *70094371056040
 - !ruby/object:Gem::Dependency
   name: with_model
-  requirement: &2152503960 !ruby/object:Gem::Requirement
+  requirement: &70094371055100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: 0.1.3
   type: :development
   prerelease: false
-  version_requirements: *2152503960
+  version_requirements: *70094371055100
 - !ruby/object:Gem::Dependency
   name: autotest
-  requirement: &2152503100 !ruby/object:Gem::Requirement
+  requirement: &70094371054000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152503100
+  version_requirements: *70094371054000
 description: A completely transparent audit logging component for your application
   using a stored procedure and triggers. Comes with specs for your project and a rake
   task to generate the reverse SQL to undo changes logged
@@ -120,7 +120,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -732310515117041189
+      hash: -4309702284919187778
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -129,10 +129,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -732310515117041189
+      hash: -4309702284919187778
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 1.8.6
 signing_key: 
 specification_version: 3
 summary: postgresql only database-level audit logging of all databases changes