pg 0.9.0-x86-mingw32 → 0.11.0pre229-x86-mingw32

data/ext/compat.c

@@ -8,8 +8,8 @@
   Author: ematsu
   modified at: Wed Jan 20 16:41:51 1999
 
-  $Author: jdavis $
-  $Date: 2007-12-04 14:25:44 -0800 (Tue, 04 Dec 2007) $
+  $Author: ged $
+  $Date: 2010/10/31 23:29:59 $
 ************************************************/
 
 #include <ctype.h>

data/ext/compat.h

@@ -4,6 +4,10 @@
 
 #include <stdlib.h>
 
+#ifdef RUBY_EXTCONF_H
+#include RUBY_EXTCONF_H
+#endif
+
 #include "libpq-fe.h"
 #include "libpq/libpq-fs.h"              /* large-object interface */
 

data/ext/extconf.rb

@@ -1,109 +1,40 @@
+require 'pp'
 require 'mkmf'
 
-if pgdir = with_config( 'pg' )
-	ENV['PATH'] = "#{pgdir}/bin" + File::PATH_SEPERATOR + ENV['PATH']
-end
-
-### Read the output of a command using the fork+pipe syntax so execution errors 
-### propagate to Ruby.
-def read_cmd_output( *cmd )
-	output = IO.read( '|-' ) or exec( *cmd )
-	return output.chomp
-end
-
-### Turn a version string into a Comparable binary datastructure
-def vvec( version )
-	version.split( '.' ).collect {|i| Integer(i) }.pack( 'N*' )
-end
 
-
-if vvec(RUBY_VERSION) < vvec('1.8')
-	puts 'This library is for ruby-1.8 or higher.'
-	exit 1
-end
-
-pgconfig = with_config( 'pg-config' ) || 'pg_config'
-if pgconfig = find_executable( pgconfig )
-	$CPPFLAGS << " -I%s" % [ read_cmd_output(pgconfig, '--includedir') ]
-	$LDFLAGS << " -L%s" % [ read_cmd_output(pgconfig, '--libdir') ]
+if pgdir = with_config( 'pg' )
+	ENV['PATH'] = "#{pgdir}/bin" + File::PATH_SEPARATOR + ENV['PATH']
 end
 
-# Sort out the universal vs. single-archicture build problems on MacOS X
-if RUBY_PLATFORM.include?( 'darwin' )
-	puts "MacOS X build: fixing architecture flags:"
-
-	# Only keep the '-arch <a>' flags present in both the cflags reported
-	# by pg_config and those that Ruby specifies.
-	commonflags = nil
-	if ENV['ARCHFLAGS']
-		puts "  using the value in ARCHFLAGS environment variable (%p)." % [ ENV['ARCHFLAGS'] ]
-		commonflags = ENV['ARCHFLAGS']
-	elsif pgconfig
-		puts "  finding flags common to both Ruby and PostgreSQL..."
-		archflags = []
-		pgcflags = read_cmd_output( pgconfig, '--cflags' )
-		pgcflags.scan( /-arch\s+(\S+)/ ).each do |arch|
-			puts "  testing for architecture: %p" % [ arch ]
-			archflags << "-arch #{arch}" if Config::CONFIG['CFLAGS'].index("-arch #{arch}")
-		end
-
-		commonflags = archflags.join(' ')
-		puts "  common arch flags: %s" % [ commonflags ]
-	else
-		$stderr.puts %{
-		===========   WARNING   ===========
-		
-		You are building this extension on OS X without setting the 
-		ARCHFLAGS environment variable, and pg_config wasn't found in 
-		your PATH. If you are seeing this message, that means that the 
-		build will probably fail.
+if ENV['CROSS_COMPILING']
+	$LDFLAGS << " -L#{CONFIG['libdir']}"
 
-		If it does, you can correct this by either including the path 
-		to 'pg_config' in your PATH or setting the environment variable 
-		ARCHFLAGS to '-arch <arch>' before building.
-
-		For example:
-		(in bash) $ export PATH=/opt/local/lib/postgresql84/bin:$PATH                  
-		          $ export ARCHFLAGS='-arch x86_64'
-		(in tcsh) % set path = ( /opt/local/lib/postgresql84/bin $PATH )
-		          % setenv ARCHFLAGS '-arch x86_64'
-
-		Then try building again.
-
-		===================================
-		}.gsub( /^\t+/, '  ' )
-	end
-
-	if commonflags
-		$CFLAGS.gsub!( /-arch\s+\S+ /, '' )
-		$LDFLAGS.gsub!( /-arch\s+\S+ /, '' )
-		CONFIG['LDSHARED'].gsub!( /-arch\s+\S+ /, '' )
-
-		$CFLAGS << ' ' << commonflags
-		$LDFLAGS << ' ' << commonflags
-		CONFIG['LDSHARED'] << ' ' << commonflags
-	end
+	# Link against all required libraries for static build, if they are available
+	have_library( 'gdi32', 'CreateDC' ) && append_library( $libs, 'gdi32' )
+	have_library( 'secur32' ) && append_library( $libs, 'secur32' )
+	have_library( 'ws2_32', 'WSASocket') && append_library( $libs, 'ws2_32' )
+	have_library( 'crypto', 'BIO_new' ) && append_library( $libs, 'crypto' )
+	have_library( 'ssl', 'SSL_new' ) && append_library( $libs, 'ssl' )
 end
 
-
 dir_config 'pg'
 
-if enable_config("static-build")
-	# Link against all required libraries for static build, if they are available
-	have_library('gdi32', 'CreateDC') && append_library($libs, 'gdi32')
-	have_library('secur32') && append_library($libs, 'secur32')
-	have_library('crypto', 'BIO_new') && append_library($libs, 'crypto')
-	have_library('ssl', 'SSL_new') && append_library($libs, 'ssl')
+if pgconfig = ( with_config('pg-config') || with_config('pg_config') || find_executable('pg_config') )
+	$stderr.puts "Using config values from %s" % [ pgconfig ]
+	$CPPFLAGS << " -I%s" % [ `#{pgconfig} --includedir`.chomp ]
+	$LDFLAGS << " -L%s" % [ `#{pgconfig} --libdir`.chomp ]
+else
+	$stderr.puts "No pg_config... trying anyway. If building fails, please try again with",
+		" --with-pg-config=/path/to/pg_config"
 end
 
-
-abort "Can't find the 'libpq-fe.h header" unless have_header( 'libpq-fe.h' )
-abort "Can't find the 'libpq/libpq-fs.h header" unless have_header('libpq/libpq-fs.h')
+find_header( 'libpq-fe.h' ) or abort "Can't find the 'libpq-fe.h header"
+find_header( 'libpq/libpq-fs.h' ) or abort "Can't find the 'libpq/libpq-fs.h header"
 
 abort "Can't find the PostgreSQL client library (libpq)" unless
-	have_library( 'pq', 'PQconnectdb' ) ||
-	have_library( 'libpq', 'PQconnectdb' ) ||
-	have_library( 'ms/libpq', 'PQconnectdb' )
+	have_library( 'pq', 'PQconnectdb', ['libpq-fe.h'] ) ||
+	have_library( 'libpq', 'PQconnectdb', ['libpq-fe.h'] ) ||
+	have_library( 'ms/libpq', 'PQconnectdb', ['libpq-fe.h'] )
 
 # optional headers/functions
 have_func 'PQconnectionUsedPassword'
@@ -112,15 +43,17 @@ have_func 'PQprepare'
 have_func 'PQexecParams'
 have_func 'PQescapeString'
 have_func 'PQescapeStringConn'
+have_func 'PQgetCancel'
 have_func 'lo_create'
 have_func 'pg_encoding_to_char'
 have_func 'PQsetClientEncoding'
 
+$defs.push( "-DHAVE_ST_NOTIFY_EXTRA" ) if
+	have_struct_member 'struct pgNotify', 'extra', 'libpq-fe.h'
+
 # unistd.h confilicts with ruby/win32.h when cross compiling for win32 and ruby 1.9.1
 have_header 'unistd.h' unless enable_config("static-build")
 
-$CFLAGS << ' -Wall'
-
 create_header()
 create_makefile( "pg_ext" )
 

data/ext/pg.c

@@ -8,8 +8,8 @@
   Author: ematsu
   modified at: Wed Jan 20 16:41:51 1999
 
-  $Author$
-  $Date$
+  $Author: ged $
+  $Date: 2011/03/30 13:13:47 $
 ************************************************/
 
 #include "pg.h"
@@ -17,13 +17,18 @@
 # define M17N_SUPPORTED
 #endif
 
+#ifdef _WIN32
+	// for O_RDWR and O_BINARY
+	#include <fcntl.h>
+#endif
+
 #define rb_define_singleton_alias(klass,new,old) rb_define_alias(rb_singleton_class(klass),new,old)
 
 static VALUE rb_cPGconn;
 static VALUE rb_cPGresult;
 static VALUE rb_ePGError;
 
-static const char *VERSION = "0.9.0";
+static const char *VERSION = "0.11.0";
 
 
 /* The following functions are part of libpq, but not
@@ -50,21 +55,22 @@ static const char *VERSION = "0.9.0";
  * UTILITY FUNCTIONS
  **************************************************************************/
 
-static void free_pgconn(PGconn *);
-static void pgresult_check(VALUE, VALUE);
+static void free_pgconn( PGconn * );
+static void pgresult_check( VALUE, VALUE );
 
-static PGconn *get_pgconn(VALUE self);
-static VALUE pgconn_finish(VALUE self);
-static VALUE pgresult_clear(VALUE self);
-static VALUE pgresult_aref(VALUE self, VALUE index);
-static VALUE make_column_result_array( VALUE self, int col );
+static PGconn *get_pgconn( VALUE );
+static VALUE pgconn_finish( VALUE );
+static VALUE pgresult_clear( VALUE );
+static VALUE pgresult_aref( VALUE, VALUE );
+static VALUE make_column_result_array( VALUE, int );
 
 #ifdef M17N_SUPPORTED
-# define ASSOCIATE_INDEX(obj, index_holder) rb_enc_associate_index((obj), enc_get_index((index_holder)))
-static rb_encoding * pgconn_get_client_encoding_as_rb_encoding(PGconn* conn);
-static int enc_get_index(VALUE val);
+# define ASSOCIATE_INDEX( obj, index_holder ) rb_enc_associate_index((obj), enc_get_index((index_holder)))
+static rb_encoding * pgconn_get_client_encoding_as_rb_encoding( PGconn * );
+static const char *  pgconn_get_rb_encoding_as_pg_encname( rb_encoding * );
+static int enc_get_index( VALUE );
 #else
-# define ASSOCIATE_INDEX(obj, index_holder) /* nothing */
+# define ASSOCIATE_INDEX( obj, index_holder ) /* nothing */
 #endif
 
 static PQnoticeReceiver default_notice_receiver = NULL;
@@ -240,7 +246,7 @@ parse_connect_args(int argc, VALUE *argv, VALUE self)
 	VALUE args,arg;
 	VALUE conninfo_rstr = rb_str_new("",0);
 	char *host, *port, *opt, *tty, *dbname, *login, *pwd;
-	host=port=opt=tty=dbname=login=pwd=NULL;
+	host = port = opt = tty = dbname = login = pwd = NULL;
 
 	rb_scan_args(argc, argv, "0*", &args); 
 	if (RARRAY_LEN(args) == 1) { 
@@ -291,8 +297,9 @@ parse_connect_args(int argc, VALUE *argv, VALUE self)
 		build_key_value_string(conninfo_rstr, "password", rb_ary_entry(args,6));
 	}
 	else {
-		rb_raise(rb_eArgError, 
-			"Expected connection info string, hash, or 7 separate arguments.");
+		rb_raise( rb_eArgError, 
+				  "Expected connection info string, hash, or 7 separate arguments, got a %s.",
+				  RSTRING_PTR(rb_obj_classname( args )) );
 	}
 
 	return conninfo_rstr;
@@ -388,7 +395,10 @@ pgconn_alloc(VALUE klass)
  *   # As an Array
  *   PGconn.connect( nil, 5432, nil, nil, 'test', nil, nil )
  *  
- * On failure, it raises a PGError.
+ * If the Ruby default internal encoding is set (i.e., Encoding.default_internal != nil), the
+ * connection will have its +client_encoding+ set accordingly.
+ * 
+ * @raises [PGError] if the connection fails.
  */
 static VALUE
 pgconn_init(int argc, VALUE *argv, VALUE self)
@@ -396,6 +406,10 @@ pgconn_init(int argc, VALUE *argv, VALUE self)
 	PGconn *conn = NULL;
 	VALUE conninfo;
 	VALUE error;
+#ifdef M17N_SUPPORTED	
+	rb_encoding *enc;
+	const char *encname;
+#endif
 
 	conninfo = parse_connect_args(argc, argv, self);
 	conn = PQconnectdb(StringValuePtr(conninfo));
@@ -412,6 +426,17 @@ pgconn_init(int argc, VALUE *argv, VALUE self)
 		rb_exc_raise(error);
 	}
 
+#ifdef M17N_SUPPORTED
+	/* If Ruby has its Encoding.default_internal set, set PostgreSQL's client_encoding 
+	 * to match */
+	if (( enc = rb_default_internal_encoding() )) {
+		encname = pgconn_get_rb_encoding_as_pg_encname( enc );
+		if ( PQsetClientEncoding(conn, encname) != 0 )
+			rb_warn( "Failed to set the default_internal encoding to %s: '%s'",
+			         encname, PQerrorMessage(conn) );
+	}
+#endif
+
 	if (rb_block_given_p()) {
 		return rb_ensure(rb_yield, self, pgconn_finish, self);
 	}
@@ -427,6 +452,12 @@ pgconn_init(int argc, VALUE *argv, VALUE self)
  * This is an asynchronous version of PGconn.connect().
  *
  * Use PGconn#connect_poll to poll the status of the connection.
+ *
+ * NOTE: this does *not* set the connection's +client_encoding+ for you if 
+ * Encoding.default_internal is set. To set it after the connection is established, 
+ * call PGconn#internal_encoding=. You can also set it automatically by setting 
+ * ENV['PGCLIENTENCODING'], or include the 'options' connection parameter.
+ * 
  */
 static VALUE
 pgconn_s_connect_start(int argc, VALUE *argv, VALUE self)
@@ -489,7 +520,7 @@ pgconn_s_conndefaults(VALUE self)
 	VALUE ary = rb_ary_new();
 	VALUE hash;
 	int i = 0;
-	
+
 	for(i = 0; options[i].keyword != NULL; i++) {
 		hash = rb_hash_new();
 		if(options[i].keyword)
@@ -535,7 +566,7 @@ pgconn_s_encrypt_password(VALUE self, VALUE password, VALUE username)
 {
 	char *encrypted = NULL;
 	VALUE rval = Qnil;
-	
+
 	Check_Type(password, T_STRING);
 	Check_Type(username, T_STRING);
 
@@ -1065,7 +1096,7 @@ pgconn_exec(int argc, VALUE *argv, VALUE self)
 		else
 			paramFormats[i] = NUM2INT(param_format);
 	}
-	
+
 	result = PQexecParams(conn, StringValuePtr(command), nParams, paramTypes, 
 		(const char * const *)paramValues, paramLengths, paramFormats, resultFormat);
 
@@ -1252,7 +1283,7 @@ pgconn_exec_prepared(int argc, VALUE *argv, VALUE self)
 		else
 			paramFormats[i] = NUM2INT(param_format);
 	}
-	
+
 	result = PQexecPrepared(conn, StringValuePtr(name), nParams, 
 		(const char * const *)paramValues, paramLengths, paramFormats, 
 		resultFormat);
@@ -1617,7 +1648,7 @@ pgconn_send_query(int argc, VALUE *argv, VALUE self)
 		else
 			paramFormats[i] = NUM2INT(param_format);
 	}
-	
+
 	result = PQsendQueryParams(conn, StringValuePtr(command), nParams, paramTypes, 
 		(const char * const *)paramValues, paramLengths, paramFormats, resultFormat);
 
@@ -1802,7 +1833,7 @@ pgconn_send_query_prepared(int argc, VALUE *argv, VALUE self)
 		else
 			paramFormats[i] = NUM2INT(param_format);
 	}
-	
+
 	result = PQsendQueryPrepared(conn, StringValuePtr(name), nParams, 
 		(const char * const *)paramValues, paramLengths, paramFormats, 
 		resultFormat);
@@ -2020,7 +2051,7 @@ pgconn_flush(self)
  *    conn.cancel() -> String
  *
  * Requests cancellation of the command currently being
- * processed.
+ * processed. (Only implemented in PostgreSQL >= 8.0)
  *
  * Returns +nil+ on success, or a string containing the
  * error message if a failure occurs.
@@ -2028,6 +2059,7 @@ pgconn_flush(self)
 static VALUE
 pgconn_cancel(VALUE self)
 {
+#ifdef HAVE_PQGETCANCEL
 	char errbuf[256];
 	PGcancel *cancel;
 	VALUE retval;
@@ -2038,13 +2070,16 @@ pgconn_cancel(VALUE self)
 		rb_raise(rb_ePGError,"Invalid connection!");
 
 	ret = PQcancel(cancel, errbuf, 256);
-	if(ret == 1) 
+	if(ret == 1)
 		retval = Qnil;
 	else
 		retval = rb_str_new2(errbuf);
 
 	PQfreeCancel(cancel);
 	return retval;
+#else
+	rb_notimplement();
+#endif
 }
 
 
@@ -2052,14 +2087,14 @@ pgconn_cancel(VALUE self)
  * call-seq:
  *    conn.notifies()
  *
- * Returns a hash of the unprocessed notifiers.
+ * Returns a hash of the unprocessed notifications.
  * If there is no unprocessed notifier, it returns +nil+.
  */
 static VALUE
 pgconn_notifies(VALUE self)
 {
 	PGconn* conn = get_pgconn(self);
-	PGnotify *notify;
+	PGnotify *notification;
 	VALUE hash;
 	VALUE sym_relname, sym_be_pid, sym_extra;
 	VALUE relname, be_pid, extra;
@@ -2068,25 +2103,60 @@ pgconn_notifies(VALUE self)
 	sym_be_pid = ID2SYM(rb_intern("be_pid"));
 	sym_extra = ID2SYM(rb_intern("extra"));
 
-	notify = PQnotifies(conn);
-	if (notify == NULL) {
+	notification = PQnotifies(conn);
+	if (notification == NULL) {
 		return Qnil;
 	}
-	
+
 	hash = rb_hash_new();
-	relname = rb_tainted_str_new2(notify->relname);
-	be_pid = INT2NUM(notify->be_pid);
-	extra = rb_tainted_str_new2(PGNOTIFY_EXTRA(notify));
-	
+	relname = rb_tainted_str_new2(notification->relname);
+	be_pid = INT2NUM(notification->be_pid);
+	extra = rb_tainted_str_new2(PGNOTIFY_EXTRA(notification));
+
 	rb_hash_aset(hash, sym_relname, relname);
 	rb_hash_aset(hash, sym_be_pid, be_pid);
 	rb_hash_aset(hash, sym_extra, extra);
 
-	PQfreemem(notify);
+	PQfreemem(notification);
 	return hash;
 }
 
 
+#ifdef _WIN32
+/* 
+ * Duplicate the sockets from libpq and create temporary CRT FDs
+ */
+void create_crt_fd(fd_set *os_set, fd_set *crt_set)
+{
+	int i;
+	crt_set->fd_count = os_set->fd_count;
+	for (i = 0; i < os_set->fd_count; i++) {
+		WSAPROTOCOL_INFO wsa_pi;
+		/* dupicate the SOCKET */
+		int r = WSADuplicateSocket(os_set->fd_array[i], GetCurrentProcessId(), &wsa_pi);
+		SOCKET s = WSASocket(wsa_pi.iAddressFamily, wsa_pi.iSocketType, wsa_pi.iProtocol, &wsa_pi, 0, 0);
+		/* create the CRT fd so ruby can get back to the SOCKET */
+		int fd = _open_osfhandle(s, O_RDWR|O_BINARY);
+		os_set->fd_array[i] = s;
+		crt_set->fd_array[i] = fd;
+	}
+}
+
+/*
+ * Clean up the CRT FDs from create_crt_fd()
+ */
+void cleanup_crt_fd(fd_set *os_set, fd_set *crt_set)
+{
+	int i;
+	for (i = 0; i < os_set->fd_count; i++) {
+		/* cleanup the CRT fd */
+		_close(crt_set->fd_array[i]);
+		/* cleanup the duplicated SOCKET */
+		closesocket(os_set->fd_array[i]);
+	}
+}
+#endif
+
 /*
  * call-seq:
  *    conn.wait_for_notify( [ timeout ] ) -> String
@@ -2104,48 +2174,67 @@ pgconn_notifies(VALUE self)
 static VALUE
 pgconn_wait_for_notify(int argc, VALUE *argv, VALUE self)
 {
-    PGconn *conn = get_pgconn(self);
-    PGnotify *notify;
-    int sd = PQsocket(conn);
-    int ret;
-    struct timeval timeout;
-    struct timeval *ptimeout = NULL;
-    VALUE timeout_in, relname = Qnil, be_pid = Qnil;
-    double timeout_sec;
-    fd_set sd_rset;
-
-	if (sd < 0)
-		rb_bug("PQsocket(conn): couldn't fetch the connection's socket!");
-
-    if (rb_scan_args(argc, argv, "01", &timeout_in) == 1) {
-    	timeout_sec = NUM2DBL(timeout_in);
-    	timeout.tv_sec = (long)timeout_sec;
-    	timeout.tv_usec = (long)((timeout_sec - (long)timeout_sec) * 1e6);
-    	ptimeout = &timeout;
-    }
-
-    FD_ZERO(&sd_rset);
-    FD_SET(sd, &sd_rset);
-    ret = rb_thread_select(sd+1, &sd_rset, NULL, NULL, ptimeout);
-    if (ret == 0) {
-		return Qnil;
-	} else if (ret < 0) {
-		rb_sys_fail(0);
+	PGconn *conn = get_pgconn( self );
+	PGnotify *notification;
+	int sd = PQsocket( conn );
+	int ret;
+	struct timeval timeout;
+	struct timeval *ptimeout = NULL;
+	VALUE timeout_in, relname = Qnil, be_pid = Qnil, extra = Qnil;
+	double timeout_sec;
+	fd_set sd_rset;
+#ifdef _WIN32
+	fd_set crt_sd_rset;
+#endif
+
+	if ( sd < 0 )
+		rb_bug( "PQsocket(conn): couldn't fetch the connection's socket!" );
+
+	if ( rb_scan_args(argc, argv, "01", &timeout_in) == 1 ) {
+		timeout_sec = NUM2DBL( timeout_in );
+		timeout.tv_sec = (long)timeout_sec;
+		timeout.tv_usec = (long)( (timeout_sec - (long)timeout_sec) * 1e6 );
+		ptimeout = &timeout;
 	}
-	
-    if ( (ret = PQconsumeInput(conn)) != 1 ) {
-		rb_raise(rb_ePGError, "PQconsumeInput == %d: %s", ret, PQerrorMessage(conn));
+
+	/* Check for notifications */
+	while ( (notification = PQnotifies(conn)) == NULL ) {
+		FD_ZERO( &sd_rset );
+		FD_SET( sd, &sd_rset );
+
+#ifdef _WIN32
+		create_crt_fd(&sd_rset, &crt_sd_rset);
+#endif
+
+		/* Wait for the socket to become readable before checking again */
+		ret = rb_thread_select( sd+1, &sd_rset, NULL, NULL, ptimeout );
+
+#ifdef _WIN32
+		cleanup_crt_fd(&sd_rset, &crt_sd_rset);
+#endif
+
+		if ( ret < 0 )
+			rb_sys_fail( 0 );
+
+		/* Return nil if the select timed out */
+		if ( ret == 0 ) return Qnil;
+
+		/* Read the socket */
+		if ( (ret = PQconsumeInput(conn)) != 1 )
+			rb_raise( rb_ePGError, "PQconsumeInput == %d: %s", ret, PQerrorMessage(conn) );
 	}
-	
-    while ((notify = PQnotifies(conn)) != NULL) {
-        relname = rb_tainted_str_new2(notify->relname);
-        be_pid = INT2NUM(notify->be_pid);
-        PQfreemem(notify);
-    }
 
-    if (rb_block_given_p()) rb_yield( rb_ary_new3(2, relname, be_pid) );
+	relname = rb_tainted_str_new2( notification->relname );
+	be_pid = INT2NUM( notification->be_pid );
+#ifdef HAVE_ST_NOTIFY_EXTRA
+	extra = rb_str_new2( notification->extra );
+#endif
+	PQfreemem( notification );
+
+	if ( rb_block_given_p() )
+		rb_yield_values( 3, relname, be_pid, extra );
 
-    return relname;
+	return relname;
 }
 
 
@@ -2472,7 +2561,7 @@ pgconn_transaction(VALUE self)
 	PGresult *result;
 	VALUE rb_pgresult;
 	int status;
-	
+
 	if (rb_block_given_p()) {
 		result = PQexec(conn, "BEGIN");
 		rb_pgresult = new_pgresult(result, conn);
@@ -2490,7 +2579,7 @@ pgconn_transaction(VALUE self)
 			pgresult_check(self, rb_pgresult);
 			rb_jump_tag(status);
 		}
-			
+
 	}
 	else {
 		/* no block supplied? */
@@ -2529,7 +2618,7 @@ pgconn_s_quote_ident(VALUE self, VALUE in_str)
 	 * double-quotes. */
 	char buffer[NAMEDATALEN*2+2];
 	unsigned int i=0,j=0;
-	
+
 	if(strlen(str) >= NAMEDATALEN) {
 		rb_raise(rb_eArgError, 
 			"Input string is longer than NAMEDATALEN-1 (%d)",
@@ -2571,6 +2660,9 @@ pgconn_block( int argc, VALUE *argv, VALUE self ) {
 	VALUE timeout_in;
 	double timeout_sec;
 	fd_set sd_rset;
+#ifdef _WIN32
+	fd_set crt_sd_rset;
+#endif
 
 	/* Always set a timeout in WIN32, as rb_thread_select() sometimes
 	 * doesn't return when a second ruby thread is running although data
@@ -2594,7 +2686,16 @@ pgconn_block( int argc, VALUE *argv, VALUE self ) {
 	while ( PQisBusy(conn) ) {
 		FD_ZERO( &sd_rset );
 		FD_SET( sd, &sd_rset );
-		ret = rb_thread_select( sd+1, &sd_rset, NULL, NULL, ptimeout );
+
+#ifdef _WIN32
+		create_crt_fd(&sd_rset, &crt_sd_rset);
+#endif
+
+		ret = rb_thread_select (sd+1, &sd_rset, NULL, NULL, ptimeout );
+
+#ifdef _WIN32
+		cleanup_crt_fd(&sd_rset, &crt_sd_rset);
+#endif
 
 		/* Return false if there was a timeout argument and the select() timed out */
 		if ( ret == 0 && argc ) 
@@ -3206,7 +3307,7 @@ pgresult_ftablecol(VALUE self, VALUE column_number)
 
 	if( col_number < 0 || col_number >= PQnfields(pgresult)) 
 		rb_raise(rb_eArgError,"Invalid column index: %d", col_number);
-	
+
 	n = PQftablecol(pgresult, col_number);
 	return INT2FIX(n);
 }
@@ -3488,34 +3589,84 @@ pgresult_aref(VALUE self, VALUE index)
 	VALUE fname,val;
 	VALUE tuple;
 
-	if(tuple_num < 0 || tuple_num >= PQntuples(result))
-		rb_raise(rb_eIndexError, "Index %d is out of range", tuple_num);
+	if ( tuple_num < 0 || tuple_num >= PQntuples(result) )
+		rb_raise( rb_eIndexError, "Index %d is out of range", tuple_num );
+
 	tuple = rb_hash_new();
-	for(field_num = 0; field_num < PQnfields(result); field_num++) {
-		fname = rb_tainted_str_new2(PQfname(result,field_num));
+	for ( field_num = 0; field_num < PQnfields(result); field_num++ ) {
+		fname = rb_tainted_str_new2( PQfname(result,field_num) );
 		ASSOCIATE_INDEX(fname, self);
-		if(PQgetisnull(result, tuple_num, field_num)) {
-			rb_hash_aset(tuple, fname, Qnil);
+		if ( PQgetisnull(result, tuple_num, field_num) ) {
+			rb_hash_aset( tuple, fname, Qnil );
 		}
 		else {
-			val = rb_tainted_str_new(PQgetvalue(result, tuple_num, field_num),
-				PQgetlength(result, tuple_num, field_num));
+			val = rb_tainted_str_new( PQgetvalue(result, tuple_num, field_num ),
+			                          PQgetlength(result, tuple_num, field_num) );
 
 			/* associate client encoding for text format only */
-			if(0 == PQfformat(result, field_num)) { 
-				ASSOCIATE_INDEX(val, self);
+			if ( 0 == PQfformat(result, field_num) ) {
+				ASSOCIATE_INDEX( val, self );
 			} else {
 #ifdef M17N_SUPPORTED
-				rb_enc_associate(val, rb_ascii8bit_encoding());
+				rb_enc_associate( val, rb_ascii8bit_encoding() );
 #endif
 			}
-			rb_hash_aset(tuple, fname, val);
+			rb_hash_aset( tuple, fname, val );
 		}
 	}
 	return tuple;
 }
 
 
+/*
+ * call-seq:
+ *    res.values -> Array
+ *
+ * Returns all tuples as an array of arrays.
+ */
+static VALUE
+pgresult_values(VALUE self, VALUE index)
+{
+	PGresult* result = (PGresult*) get_pgresult(self);
+	int row;
+	int field;
+	int num_rows = PQntuples(result);
+	int num_fields = PQnfields(result);
+	VALUE ary = rb_ary_new2(num_rows);
+
+	for ( row = 0; row < num_rows; row++ ) {
+		/* create new row */
+		VALUE new_row = rb_ary_new2(num_fields);
+
+		/* add to return array */
+		rb_ary_store( ary, row, new_row );
+
+		/* populate it */
+		for ( field = 0; field < num_fields; field++ ) {
+			if ( PQgetisnull(result, row, field) ) {
+				rb_ary_store( new_row, field, Qnil );
+			}
+			else {
+				VALUE val = rb_tainted_str_new( PQgetvalue(result, row, field), 
+				                                PQgetlength(result, row, field) );
+
+				/* associate client encoding for text format only */
+				if ( 0 == PQfformat(result, field) ) {
+					ASSOCIATE_INDEX( val, self );
+				} else {
+#ifdef M17N_SUPPORTED
+					rb_enc_associate( val, rb_ascii8bit_encoding() );
+#endif
+				}
+
+				rb_ary_store( new_row, field, val );
+			}
+		}
+	}
+	return ary;
+}
+
+
 /*
  *  call-seq:
  *     res.column_values( n )   -> array
@@ -3548,7 +3699,7 @@ pgresult_field_values( VALUE self, VALUE field )
 
 	if ( fnum < 0 )
 		rb_raise( rb_eIndexError, "no such field '%s' in result", fieldname );
-	
+
 	return make_column_result_array( self, fnum );
 }
 
@@ -3564,7 +3715,7 @@ make_column_result_array( VALUE self, int col )
 	int row = PQntuples( result );
 	VALUE ary = rb_ary_new2( row );
 	VALUE val = Qnil;
-	
+
 	if ( col >= PQnfields(result) )
 		rb_raise( rb_eIndexError, "no column %d in result", col );
 
@@ -3583,7 +3734,7 @@ make_column_result_array( VALUE self, int col )
 
 		rb_ary_store( ary, row, val );
 	}
-	
+
 	return ary;
 }
 
@@ -3630,39 +3781,42 @@ pgresult_fields(VALUE self)
 	return ary;
 }
 
+
 #ifdef M17N_SUPPORTED
 /**
  * The mapping from canonical encoding names in PostgreSQL to ones in Ruby.
  */
 static const char * const (enc_pg2ruby_mapping[][2]) = {
-	    {"BIG5",          "Big5"       },
-	    {"EUC_CN",        "GB2312"     },
-	    {"EUC_JP",        "EUC-JP"     },
-	    {"EUC_JIS_2004",  "EUC-JP"     },
-	    {"EUC_KR",        "EUC-KR"     },
-	    {"EUC_TW",        "EUC-TW"     },
-	    {"GB18030",       "GB18030"    },
-	    {"GBK",           "GBK"        },
-	    {"ISO_8859_5",    "ISO-8859-5" },
-	    {"ISO_8859_6",    "ISO-8859-6" },
-	    {"ISO_8859_7",    "ISO-8859-7" },
-	    {"ISO_8859_8",    "ISO-8859-8" },
-	    /* {"JOHAB",         "JOHAB"     }, dummy */
-	    {"KOI8",          "KOI8-U"     },
-	    {"LATIN1",        "ISO-8859-1" },
-	    {"LATIN2",        "ISO-8859-2" },
-	    {"LATIN3",        "ISO-8859-3" },
-	    {"LATIN4",        "ISO-8859-4" },
-	    {"LATIN5",        "ISO-8859-5" },
-	    {"LATIN6",        "ISO-8859-6" },
-	    {"LATIN7",        "ISO-8859-7" },
-	    {"LATIN8",        "ISO-8859-8" },
-	    {"LATIN9",        "ISO-8859-9" },
+	    {"BIG5",          "Big5"        },
+	    {"EUC_CN",        "GB2312"      },
+	    {"EUC_JP",        "EUC-JP"      },
+	    {"EUC_JIS_2004",  "EUC-JP"      },
+	    {"EUC_KR",        "EUC-KR"      },
+	    {"EUC_TW",        "EUC-TW"      },
+	    {"GB18030",       "GB18030"     },
+	    {"GBK",           "GBK"         },
+	    {"ISO_8859_5",    "ISO-8859-5"  },
+	    {"ISO_8859_6",    "ISO-8859-6"  },
+	    {"ISO_8859_7",    "ISO-8859-7"  },
+	    {"ISO_8859_8",    "ISO-8859-8"  },
+	    /* {"JOHAB",         "JOHAB"       }, dummy */
+	    {"KOI8",          "KOI8-R"      },
+	    {"KOI8R",         "KOI8-R"      },
+	    {"KOI8U",         "KOI8-U"      },
+	    {"LATIN1",        "ISO-8859-1"  },
+	    {"LATIN2",        "ISO-8859-2"  },
+	    {"LATIN3",        "ISO-8859-3"  },
+	    {"LATIN4",        "ISO-8859-4"  },
+	    {"LATIN5",        "ISO-8859-5"  },
+	    {"LATIN6",        "ISO-8859-6"  },
+	    {"LATIN7",        "ISO-8859-7"  },
+	    {"LATIN8",        "ISO-8859-8"  },
+	    {"LATIN9",        "ISO-8859-9"  },
 	    {"LATIN10",       "ISO-8859-10" },
-	    {"MULE_INTERNAL", "Emacs-Mule" },
+	    {"MULE_INTERNAL", "Emacs-Mule"  },
 	    {"SJIS",          "Windows-31J" },
 	    {"SHIFT_JIS_2004","Windows-31J" },
-	    /*{"SQL_ASCII",     NULL        },  special case*/
+	    /* {"SQL_ASCII",     NULL          },  special case*/
 	    {"UHC",           "CP949"       },
 	    {"UTF8",          "UTF-8"       },
 	    {"WIN866",        "IBM866"      },
@@ -3756,6 +3910,30 @@ cache:
 	return enc;
 }
 
+
+/* 
+ * Returns the given rb_encoding as the equivalent PostgreSQL encoding string.
+ * 
+ */
+static const char *
+pgconn_get_rb_encoding_as_pg_encname( rb_encoding *enc )
+{
+	const char *rb_encname = rb_enc_name( enc );
+	const char *encname = NULL;
+	int i;
+
+	for (i = 0; i < sizeof(enc_pg2ruby_mapping)/sizeof(enc_pg2ruby_mapping[0]); ++i) {
+		if (strcmp(rb_encname, enc_pg2ruby_mapping[i][1]) == 0) {
+			encname = enc_pg2ruby_mapping[i][0];
+		}
+	}
+
+	if ( !encname ) encname = "SQL_ASCII";
+
+	return encname;
+}
+
+
 /*
  * call-seq:
  *   conn.internal_encoding() -> Encoding
@@ -3933,7 +4111,7 @@ Init_pg_ext()
 	rb_define_singleton_method(rb_cPGconn, "conndefaults", pgconn_s_conndefaults, 0);
 
 	/******     PGconn CLASS CONSTANTS: Connection Status     ******/
-	
+
 	/* Connection succeeded */
 	rb_define_const(rb_cPGconn, "CONNECTION_OK", INT2FIX(CONNECTION_OK));
 	/* Connection failed */
@@ -3966,7 +4144,7 @@ Init_pg_ext()
 	rb_define_const(rb_cPGconn, "PGRES_POLLING_OK", INT2FIX(PGRES_POLLING_OK));
 
 	/******     PGconn CLASS CONSTANTS: Transaction Status     ******/
-	
+
 	/* Transaction is currently idle (#transaction_status) */
 	rb_define_const(rb_cPGconn, "PQTRANS_IDLE", INT2FIX(PQTRANS_IDLE));
 	/* Transaction is currently active; query has been sent to the server, but not yet completed. (#transaction_status) */
@@ -4241,6 +4419,7 @@ Init_pg_ext()
 	rb_define_method(rb_cPGresult, "[]", pgresult_aref, 1);
 	rb_define_method(rb_cPGresult, "each", pgresult_each, 0);
 	rb_define_method(rb_cPGresult, "fields", pgresult_fields, 0);
+	rb_define_method(rb_cPGresult, "values", pgresult_values, 0);
 	rb_define_method(rb_cPGresult, "column_values", pgresult_column_values, 1);
 	rb_define_method(rb_cPGresult, "field_values", pgresult_field_values, 1);