pg 0.14.0-x86-mingw32 → 0.14.1.pre.363-x86-mingw32

data/ChangeLog

@@ -1,8 +1,102 @@
+2012-08-12  Michael Granger  <ged@FaerieMUD.org>
+
+	* History.rdoc, lib/pg.rb:
+	Bump the patch version, update history.
+	[ef533f731814] [tip]
+
+2012-08-08  Jeremy Evans  <code@jeremyevans.net>
+
+	* ext/extconf.rb, ext/pg_result.c:
+	[PATCH] Recognize PGRES_SINGLE_TUPLE as OK when checking PGresult
+
+	From 10cdc23ac4e3cfc91488f3f8a7a44f3275c9fe0a Mon Sep 17 00:00:00
+	2001 This is used for the new single row mode introduced in
+	9.2beta3, and indicates a successful result when using that mode.
+	--- ext/extconf.rb | 1 + ext/pg_result.c | 3 +++ 2 files
+	changed, 4 insertions(+), 0 deletions(-)
+	[f92b6456c566]
+
+2012-08-10  Michael Granger  <ged@FaerieMUD.org>
+
+	* ext/pg_result.c:
+	Apply the heap vs. stack fix for PG::Result#fields too.
+	[512a362e883e]
+
+	* ext/pg_result.c:
+	Additional fixes for PG::Result#values and #column_values.
+
+	- Revert the row-building loop of Result#values to use the heap,
+	too.
+	- Use the heap for building #column_values, too.
+
+	Props to Lars Kanis for figuring out the problem.
+
+	Refs #135, #136, #138.
+	[62c8ee5406db]
+
+	* ext/pg_result.c:
+	Use heap instead of stack for result array in #values, etc al. (refs
+	#135, #136, #138)
+	[4d5e457062e8]
+
+2012-08-04  Lars Kanis  <kanis@comcard.de>
+
+	* spec/pg/connection_spec.rb:
+	Add missing require for using the TCPServer in connection_spec. This
+	fixes #137 .
+	[72b45840d975]
+
+2012-07-03  Lars Kanis  <kanis@comcard.de>
+
+	* ext/pg_connection.c:
+	Add note about the usage scope of the result object received by the
+	#set_notice_receiver block.
+	[de900bfaff1a]
+
+2012-07-02  Lars Kanis  <kanis@comcard.de>
+
+	* ext/pg_connection.c, spec/pg/connection_spec.rb:
+	Fix encoding of values delivered to the row processor and add specs
+	for binary and text data.
+	[bb9c6625fbc9] <row_processor>
+
+	* ext/pg_connection.c:
+	Polish the documentation a little bit
+	[b7633be3c941] <row_processor>
+
+	* ext/pg_result.c:
+	Add PGRES_COPY_BOTH to documentation of PG::Result#result_status
+	[5e0e06440b1a]
+
+2012-07-01  Lars Kanis  <kanis@comcard.de>
+
+	* ext/pg_connection.c:
+	Get rid of gcc warning about (non-)const PGresult to
+	pg_new_result_for_callback()
+	[1a25786ed8f3] <row_processor>
+
+	* ext/pg_connection.c, spec/pg/connection_spec.rb:
+	Fix wrong encoding for Result object passed to a notice-receiver
+	block. Add proper specs for #set_notice_receiver.
+	[4280826bb9b9] <row_processor>
+
+	* ext/extconf.rb, ext/pg.h, ext/pg_connection.c, ext/pg_result.c,
+	spec/lib/helpers.rb, spec/pg/connection_spec.rb:
+	Implement PostgreSQL-9.2 functions PG::Connection#set_row_processor,
+	get_row_processor, skip_result
+	[b7ce4843f4d1] <row_processor>
+
+2012-06-28  Lars Kanis  <kanis@comcard.de>
+
+	* ext/pg_result.c:
+	Add PGRES_COPY_BOTH to documentation of PG::Result#result_status
+	[63998b47da6e] <copy_both_docu>
+
 2012-06-23  Michael Granger  <ged@FaerieMUD.org>
 
 	* .hgtags:
 	Added tag v0.14.0 for changeset 634e0a42a101
-	[35eecb26bd34] [tip]
+	[35eecb26bd34]
 
 	* .hgsigs:
 	Added signature for changeset a45710f8db30

data/History.rdoc

@@ -1,3 +1,22 @@
+== v0.14.1 [2012-08-12] Michael Granger <ged@FaerieMUD.org>
+
+Important bugfix:
+
+- Fix stack overflow bug in PG::Result#values and #column_values (#135). Thanks
+  to everyone who reported the bug, and Lars Kanis especially for figuring out
+  the problem.
+
+PostgreSQL 9.2 beta fixes:
+
+- Recognize PGRES_SINGLE_TUPLE as OK when checking PGresult (Jeremy Evans)
+
+Documentation fixes:
+
+- Add note about the usage scope of the result object received by the
+  #set_notice_receiver block. (Lars Kanis)
+- Add PGRES_COPY_BOTH to documentation of PG::Result#result_status. (Lars Kanis)
+
+
 == v0.14.0 [2012-06-17] Michael Granger <ged@FaerieMUD.org>
 
 Bugfixes:

data/ext/extconf.rb

@@ -70,6 +70,7 @@ have_func 'rb_encdb_alias'
 have_func 'rb_enc_alias'
 
 have_const 'PGRES_COPY_BOTH', 'libpq-fe.h'
+have_const 'PGRES_SINGLE_TUPLE', 'libpq-fe.h'
 
 $defs.push( "-DHAVE_ST_NOTIFY_EXTRA" ) if
 	have_struct_member 'struct pgNotify', 'extra', 'libpq-fe.h'

data/ext/pg_connection.c

@@ -2325,6 +2325,10 @@ notice_receiver_proxy(void *arg, const PGresult *result)
  * the Proc object previously set, or +nil+ if it was previously the default.
  *
  * If you pass no arguments, it will reset the handler to the default.
+ *
+ * *Note:* The +result+ passed to the block should not be used outside
+ * of the block, since the corresponding C object could be freed after the
+ * block finishes.
  */
 static VALUE
 pgconn_set_notice_receiver(VALUE self)

data/ext/pg_result.c

@@ -67,6 +67,9 @@ pg_result_check( VALUE self )
 		case PGRES_COPY_IN:
 #ifdef HAVE_CONST_PGRES_COPY_BOTH
 		case PGRES_COPY_BOTH:
+#endif
+#ifdef HAVE_CONST_PGRES_SINGLE_TUPLE
+		case PGRES_SINGLE_TUPLE:
 #endif
 		case PGRES_EMPTY_QUERY:
 		case PGRES_COMMAND_OK:
@@ -179,6 +182,7 @@ pgresult_get(VALUE self)
  * * +PGRES_BAD_RESPONSE+
  * * +PGRES_NONFATAL_ERROR+
  * * +PGRES_FATAL_ERROR+
+ * * +PGRES_COPY_BOTH+
  */
 static VALUE
 pgresult_result_status(VALUE self)
@@ -725,15 +729,15 @@ pgresult_values(VALUE self)
 	int field;
 	int num_rows = PQntuples(result);
 	int num_fields = PQnfields(result);
-	VALUE rows[ num_rows ];
+	VALUE ary = rb_ary_new2(num_rows);
 
 	for ( row = 0; row < num_rows; row++ ) {
-		VALUE new_row[ num_fields ];
+		VALUE new_row = rb_ary_new2(num_fields);
 
 		/* populate the row */
 		for ( field = 0; field < num_fields; field++ ) {
 			if ( PQgetisnull(result, row, field) ) {
-				new_row[ field ] = Qnil;
+				rb_ary_store( new_row, field, Qnil );
 			}
 			else {
 				VALUE val = rb_tainted_str_new( PQgetvalue(result, row, field), 
@@ -747,14 +751,14 @@ pgresult_values(VALUE self)
 					rb_enc_associate( val, rb_ascii8bit_encoding() );
 				}
 #endif
-				new_row[ field ] = val;
+				rb_ary_store( new_row, field, val );
 			}
 		}
 
-		rows[ row ] = rb_ary_new4( num_fields, new_row );
+		rb_ary_store( ary, row, new_row );
 	}
 
-	return rb_ary_new4( num_rows, rows );
+	return ary;
 }
 
 
@@ -769,7 +773,7 @@ make_column_result_array( VALUE self, int col )
 	int rows = PQntuples( result );
 	int i;
 	VALUE val = Qnil;
-	VALUE results[ rows ];
+	VALUE results = rb_ary_new2( rows );
 
 	if ( col >= PQnfields(result) )
 		rb_raise( rb_eIndexError, "no column %d in result", col );
@@ -787,10 +791,10 @@ make_column_result_array( VALUE self, int col )
 		}
 #endif
 
-		results[ i ] = val;
+		rb_ary_store( results, i, val );
 	}
 
-	return rb_ary_new4( rows, results );
+	return results;
 }
 
 
@@ -860,16 +864,16 @@ pgresult_fields(VALUE self)
 {
 	PGresult *result = pgresult_get( self );
 	int n = PQnfields( result );
-	VALUE fields[ n ];
+	VALUE fields = rb_ary_new2( n );
 	int i;
 
 	for ( i = 0; i < n; i++ ) {
 		VALUE val = rb_tainted_str_new2(PQfname(result, i));
 		ASSOCIATE_INDEX(val, self);
-		fields[ i ] = val;
+		rb_ary_store( fields, i, val );
 	}
 
-	return rb_ary_new4( n, fields );
+	return fields;
 }
 
 

data/lib/pg.rb

@@ -19,7 +19,7 @@ end
 module PG
 
 	# Library version
-	VERSION = '0.14.0'
+	VERSION = '0.14.1.pre.363'
 
 	# VCS revision
 	REVISION = %q$Revision$

data/spec/pg/connection_spec.rb

@@ -14,6 +14,7 @@ BEGIN {
 require 'rspec'
 require 'spec/lib/helpers'
 require 'timeout'
+require 'socket'
 require 'pg'
 
 describe PG::Connection do

metadata

@@ -1,13 +1,15 @@
 --- !ruby/object:Gem::Specification 
 name: pg
 version: !ruby/object:Gem::Version 
-  hash: 39
-  prerelease: 
+  hash: 1923832471
+  prerelease: 7
   segments: 
   - 0
   - 14
-  - 0
-  version: 0.14.0
+  - 1
+  - pre
+  - 363
+  version: 0.14.1.pre.363
 platform: x86-mingw32
 authors: 
 - Michael Granger
@@ -15,7 +17,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-06-25 00:00:00 Z
+date: 2012-08-14 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: hoe-mercurial
@@ -25,12 +27,12 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 25
+        hash: 7
         segments: 
         - 1
-        - 3
-        - 1
-        version: 1.3.1
+        - 4
+        - 0
+        version: 1.4.0
   type: :development
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
@@ -214,12 +216,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version 
-      hash: 3
+      hash: 25
       segments: 
-      - 0
-      version: "0"
+      - 1
+      - 3
+      - 1
+      version: 1.3.1
 requirements: []
 
 rubyforge_project: pg