pfs 0.0.8 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a085d9259e3eb98f2fe1b761e4c3017d5e078847ebaf196978c36df5b575284
-  data.tar.gz: b5ad378234d9522e3f07a44095876d0f505058c6a122f6a41d78d3976f69f303
+  metadata.gz: b4e9653b341d206ac918d550f50e7dd980b84bd5e5b868f5c65898fa40c929c6
+  data.tar.gz: 59f4248c246f7cdf243126ef1baf356368ce017a23457682f6563e7dc2c338c4
 SHA512:
-  metadata.gz: 63e7bce0ba36f33b5afc7885ba39ebe1e40222fceec9a78235f6f19d69f0a3541ed48d171a874e5dc4de5887130b3a01dfe27d83f051ed3e58f68bbe1d4aca8d
-  data.tar.gz: 8403be7bfe84d11f8ebe5038c3a197587a500fcbc1d0b4305251f1d5cb01d20dd807da4cb076b4c530c01456cddc5cbd4cd634e348a5b44fc932da4d0a08ae23
+  metadata.gz: 9c80eb44c85b46d9fe0951bb4dc45ff648baa5fc72cda344bec474e6332b81c6af633cd461c655e75d6f029a4c3f9bfee5a483ecaed629462ca071c48622c685
+  data.tar.gz: d4d22dc29c4a333062b8b6b1455a6f6a3a4ad3442e4bfaf5c86f44a462207d5833ed8eeb908fa0cf4bfac5495c446682def69f7d8ca89d14078daa9676e1dd3a

data/.github/workflows/release.yml

@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v2
 
       - name: Release Gem
-        uses: cadwallion/publish-rubygems-action@8f9e0538302643309e4e43bf48cd34173ca48cfc # yamllint disable-line
+        uses: cadwallion/publish-rubygems-action@master # yamllint disable-line
         env:
           RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
           RELEASE_COMMAND: rake release

data/lib/pfs/api/statements_service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PFS
   module API
     class StatementsService < Service
@@ -7,6 +9,13 @@ module PFS
         )
         Resources::Statements::Statement.new(response, response.body.dig(:data, :transaction))
       end
+
+      def history(account_id:, start_date:, end_date:, inward_outward:, processor:)
+        response = client.get(
+          "/BankPayment/#{account_id}/Statement?StartDate=#{start_date}&EndDate=#{end_date}&InwardOutward=#{inward_outward}&Processor=#{processor}"
+        )
+        Resources::Statements::Statements.new(response, response.body.dig(:data, :transactions))
+      end
     end
   end
-end
+end

data/lib/pfs/api/transactions_service.rb

@@ -5,7 +5,6 @@ module PFS
     class TransactionsService < Service
       def history(account_id:, start_date:, end_date:)
         response = client.get("/Account/#{account_id}/Transactions?StartDate=#{start_date}&EndDate=#{end_date}")
-        transactions_raw = response.body.dig(:data, :transactions)
         Resources::Transactions::Transactions.new(response, response.body.dig(:data, :transactions))
       end
     end

data/lib/pfs/client.rb

@@ -87,25 +87,14 @@ module PFS
     def handle_request_error(error)
       case error
       when Faraday::ClientError
-        if error.response
-          handle_error_response(error)
-        else
-          handle_network_error(error)
-        end
+        raise ClientError, error
+      when Faraday::ServerError
+        raise ServerError, error
       else
-        raise error
+        raise Error, error
       end
     end
 
-    def handle_error_response(error)
-      puts "ERROR #{error.response}"
-      raise error
-    end
-
-    def handle_network_error(error)
-      raise error
-    end
-
     def login_path?(path)
       path == "/Auth/Jwt"
     end

data/lib/pfs/error.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module PFS
+    class Error < StandardError
+      attr_reader :wrapped_error, :status, :response
+  
+      def initialize(error)
+        @wrapped_error = error
+        @response = @wrapped_error.response if @wrapped_error.respond_to?(:response)
+        @status = structured_response[:status]
+        super(error_message)
+      end
+  
+      private def error_message
+        return @wrapped_error unless @response
+  
+        wrapped_error_description = "#{@wrapped_error.class}: #{@wrapped_error}"
+        response_description = "Status: #{structured_response[:status]} - Response: '#{structured_response[:body]}'"
+        "#{response_description} (#{wrapped_error_description})"
+      end
+  
+      private def structured_response
+        return {} unless @response
+        return @response if @response.is_a?(Hash)
+  
+        {
+          status: @response.status,
+          body: @response.body,
+        }
+      end
+    end
+  
+    class ClientError < Error
+    end
+  
+    class ServerError < Error
+    end
+  end

data/lib/pfs/resources/base.rb

@@ -40,3 +40,4 @@ require_relative "transfers/internal_transfer_to"
 require_relative "transactions/transaction"
 require_relative "transactions/transactions"
 require_relative "statements/statement"
+require_relative "statements/statements"

data/lib/pfs/resources/statements/statements.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module PFS
+    module Resources
+      module Statements
+        class Statements < Collection
+          def initialize(response, attributes_collection)
+            super(response, Statement, attributes_collection)
+          end
+        end
+      end
+    end
+  end

data/lib/pfs/resources/transactions/transaction.rb

@@ -49,7 +49,7 @@ module PFS
                       :walletId
 
         alias available availableBalance
-        alias ledger availableBalance
+        alias ledger ledgerBalance
         alias transaction_origin transactionOrigin
         alias transaction_type transactionType
         alias transaction_description transactionDescription

data/lib/pfs/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PFS
-  VERSION = "0.0.8"
+  VERSION = "0.0.11"
 end

data/lib/pfs.rb

@@ -1,5 +1,6 @@
 
 require "pfs/version"
+require "pfs/error"
 require "pfs/client"
 module PFS
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pfs
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.11
 platform: ruby
 authors:
 - Aitor García Rey
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-08 00:00:00.000000000 Z
+date: 2023-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -111,7 +111,6 @@ files:
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Guardfile
-- LICENSE
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -126,6 +125,7 @@ files:
 - lib/pfs/api/transactions_service.rb
 - lib/pfs/api/transfers_service.rb
 - lib/pfs/client.rb
+- lib/pfs/error.rb
 - lib/pfs/resources/accounts/account.rb
 - lib/pfs/resources/accounts/account_holder.rb
 - lib/pfs/resources/accounts/account_info.rb
@@ -137,6 +137,7 @@ files:
 - lib/pfs/resources/base.rb
 - lib/pfs/resources/collection.rb
 - lib/pfs/resources/statements/statement.rb
+- lib/pfs/resources/statements/statements.rb
 - lib/pfs/resources/transactions/transaction.rb
 - lib/pfs/resources/transactions/transactions.rb
 - lib/pfs/resources/transfers/internal_transfer.rb
@@ -152,7 +153,7 @@ metadata:
   homepage_uri: https://github.com/devengo/pfs-ruby
   source_code_uri: https://github.com/devengo/pfs-ruby
   changelog_uri: https://github.com/devengo/pfs-ruby/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -167,8 +168,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: PFS Finac API ruby client
 test_files: []

data/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2022 Aitor García Rey
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.