pfs 0.0.5 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 043d37e569940a1f1cf3be1d690f4c4f84e3c37924171d3c66f5c314994e55fb
-  data.tar.gz: 5a00857236ba3a0473d7aed84f68ac0fa82147a35a41de7d92b1bbbb234d2eb1
+  metadata.gz: 8a085d9259e3eb98f2fe1b761e4c3017d5e078847ebaf196978c36df5b575284
+  data.tar.gz: b5ad378234d9522e3f07a44095876d0f505058c6a122f6a41d78d3976f69f303
 SHA512:
-  metadata.gz: e7932aea62d9494471bf0922b45f1aa44b80e38f517f430328d556c8899e6bbd5175ac286ce07fe8472f7e0ab4b92bb04e8cbfcae3c06280d79b751049eda285
-  data.tar.gz: 70342f1bfafa3b29c12b0aac381f4411c26d5c95dcdb0d19c09ddbcf8ed21d1026561f45e8d21af60c5a841721b69f68db3f93db73ef41410e7ad5bcf0ad9ce2
+  metadata.gz: 63e7bce0ba36f33b5afc7885ba39ebe1e40222fceec9a78235f6f19d69f0a3541ed48d171a874e5dc4de5887130b3a01dfe27d83f051ed3e58f68bbe1d4aca8d
+  data.tar.gz: 8403be7bfe84d11f8ebe5038c3a197587a500fcbc1d0b4305251f1d5cb01d20dd807da4cb076b4c530c01456cddc5cbd4cd634e348a5b44fc932da4d0a08ae23

data/.github/workflows/ci.yml

@@ -1,7 +1,8 @@
 ---
 name: ci
 
-on:
+# https://github.com/adrienverge/yamllint/issues/430
+"on":
   push:
   pull_request:
   # Allows you to run this workflow manually from the Actions tab

data/.github/workflows/release.yml

@@ -1,7 +1,8 @@
 ---
 name: release
 
-on:
+# https://github.com/adrienverge/yamllint/issues/430
+"on":
   push:
     tags:
       - v*.*.*

data/.rubocop_devengo.yml

@@ -1,3 +1,4 @@
+---
 AllCops:
   DisplayCopNames: true
   TargetRubyVersion: 2.7
@@ -84,10 +85,10 @@ Style/NumericPredicate:
   Enabled: false
 
 Style/HashEachMethods:
-  Enabled: True
+  Enabled: true
 
 Style/HashTransformKeys:
-  Enabled: True
+  Enabled: true
 
 Style/HashTransformValues:
   Enabled: true
@@ -158,25 +159,32 @@ Style/RedundantSelfAssignment:
 Style/SoleNestedConditional:
   Enabled: true
 
-Style/ArgumentsForwarding: # (new in 1.1)
+# (new in 1.1)
+Style/ArgumentsForwarding:
   Enabled: true
 
-Style/DocumentDynamicEvalDefinition: # (new in 1.1)
+# (new in 1.1)
+Style/DocumentDynamicEvalDefinition:
   Enabled: true
 
-Style/SwapValues: # (new in 1.1)
+# (new in 1.1)
+Style/SwapValues:
   Enabled: true
 
-Style/CollectionCompact: # (new in 1.2)
+# (new in 1.2)
+Style/CollectionCompact:
   Enabled: true
 
-Style/NegatedIfElseCondition: # (new in 1.2)
+# (new in 1.2)
+Style/NegatedIfElseCondition:
   Enabled: true
 
-Style/NilLambda: # (new in 1.3)
+# (new in 1.3)
+Style/NilLambda:
   Enabled: true
 
-Style/RedundantArgument: # (new in 1.4)
+# (new in 1.4)
+Style/RedundantArgument:
   Enabled: true
 
 Style/FetchEnvVar:
@@ -251,28 +259,36 @@ Lint/UselessMethodDefinition:
 Lint/UselessTimes:
   Enabled: true
 
-Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
+# (new in 1.1)
+Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
 
-Lint/EmptyBlock: # (new in 1.1)
+# (new in 1.1)
+Lint/EmptyBlock:
   Enabled: true
 
-Lint/ToEnumArguments: # (new in 1.1)
+# (new in 1.1)
+Lint/ToEnumArguments:
   Enabled: true
 
-Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
+# (new in 1.1)
+Lint/UnmodifiedReduceAccumulator:
   Enabled: true
 
-Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
+# (new in 1.2)
+Lint/NoReturnInBeginEndBlocks:
   Enabled: true
 
-Lint/DuplicateBranch: # (new in 1.3)
+# (new in 1.3)
+Lint/DuplicateBranch:
   Enabled: true
 
-Lint/EmptyClass: # (new in 1.3)
+# (new in 1.3)
+Lint/EmptyClass:
   Enabled: true
 
-Lint/UnexpectedBlockArity: # (new in 1.5)
+# (new in 1.5)
+Lint/UnexpectedBlockArity:
   Enabled: true
 
 RSpec/AggregateExamples:

data/Gemfile

@@ -2,6 +2,3 @@ source "https://rubygems.org"
 
 # Specify your gem's dependencies in pfs.gemspec
 gemspec
-
-gem "rake", "~> 12.0"
-gem "rspec", "~> 3.0"

data/Guardfile

@@ -0,0 +1,48 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec features) \
+#  .select{|d| Dir.exist?(d) ? d : UI.warning("Directory #{d} does not exist")}
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+
+  # Turnip features and steps
+  watch(%r{^spec/acceptance/(.+)\.feature$})
+  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$}) do |m|
+    Dir[File.join("**/#{m[1]}.feature")][0] || "spec/acceptance"
+  end
+end

data/lib/pfs/api/transfers_service.rb

@@ -15,9 +15,26 @@ module PFS
         }
         data[:isinstant] = true if options[:instant]
         data[:reference] = options[:reference] if options[:reference]
+        data[:unstructuredreference] = options[:unstructured_reference] if options[:unstructured_reference]
+        data[:userdefinedfields] = options[:user_defined_fields] if options[:user_defined_fields]
         response = client.post("/BankPayment/#{account_id}/OneOffPayment", data, options)
         Resources::Transfers::Transfer.new(response, response.body[:data])
       end
+
+      def internal(from_account_id, to_account_id, amount, currency, fee_code, description, terminal_id)
+        data = {
+          id: from_account_id,
+          toId: to_account_id,
+          amount: amount,
+          currencyCode: currency,
+          description: description,
+          feeCode: fee_code,
+          terminalId: terminal_id,
+        }
+
+        response = client.post("/Account/CardholderToCardholderTransfer", data)
+        Resources::Transfers::InternalTransfer.new(response, response.body[:data])
+      end
     end
   end
 end

data/lib/pfs/resources/base.rb

@@ -34,6 +34,9 @@ require_relative "accounts/balance_credit"
 require_relative "accounts/status"
 require_relative "authentication/token"
 require_relative "transfers/transfer"
+require_relative "transfers/internal_transfer"
+require_relative "transfers/internal_transfer_from"
+require_relative "transfers/internal_transfer_to"
 require_relative "transactions/transaction"
 require_relative "transactions/transactions"
 require_relative "statements/statement"

data/lib/pfs/resources/statements/statement.rb

@@ -42,7 +42,6 @@ module PFS
         alias processor_type processorType
         alias status paymentStatus
         alias user_defined_fields userDefinedFields
-
       end
     end
   end

data/lib/pfs/resources/transfers/internal_transfer.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module PFS
+  module Resources
+    module Transfers
+      class InternalTransfer < Base
+        attr_reader :from,
+                    :to
+        def initialize(response, attributes = {})
+          super(response, attributes)
+          @from = InternalTransferFrom.new(response, attributes[:from])
+          @to = InternalTransferTo.new(response, attributes[:to])
+        end
+      end
+    end
+  end
+end

data/lib/pfs/resources/transfers/internal_transfer_from.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module PFS
+  module Resources
+    module Transfers
+      class InternalTransferFrom < Base
+        map :id, :id
+        map :balance, :balance
+        map :currencyCode, :currency
+        map :debitedAmount, :amount
+        map :conversionRate, :conversion_rate
+        map :transferFee, :transfer_fee
+      end
+    end
+  end
+end

data/lib/pfs/resources/transfers/internal_transfer_to.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module PFS
+  module Resources
+    module Transfers
+      class InternalTransferTo < Base
+        map :id, :id
+        map :balance, :balance
+        map :currencyCode, :currency
+        map :creditedAmount, :amount
+        map :loadFee, :load_fee
+      end
+    end
+  end
+end
+

data/lib/pfs/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PFS
-  VERSION = "0.0.5"
+  VERSION = "0.0.8"
 end

data/pfs.gemspec

@@ -26,4 +26,10 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = ">= 2.5.0"
   spec.add_dependency "faraday", '>= 0.15'
+
+  spec.add_development_dependency "guard", "~> 2.0"
+  spec.add_development_dependency "guard-rspec", "~> 4.0"
+  spec.add_development_dependency "rake", "~> 12.0"
+  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "webmock", "~> 3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pfs
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.8
 platform: ruby
 authors:
 - Aitor García Rey
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-07-01 00:00:00.000000000 Z
+date: 2022-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -24,6 +24,76 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0.15'
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 description: A ruby client to consume PFS Finac API
 email:
 - aitor@devengo.com
@@ -40,6 +110,7 @@ files:
 - ".rubocop_devengo.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
+- Guardfile
 - LICENSE
 - LICENSE.txt
 - README.md
@@ -68,6 +139,9 @@ files:
 - lib/pfs/resources/statements/statement.rb
 - lib/pfs/resources/transactions/transaction.rb
 - lib/pfs/resources/transactions/transactions.rb
+- lib/pfs/resources/transfers/internal_transfer.rb
+- lib/pfs/resources/transfers/internal_transfer_from.rb
+- lib/pfs/resources/transfers/internal_transfer_to.rb
 - lib/pfs/resources/transfers/transfer.rb
 - lib/pfs/version.rb
 - pfs.gemspec