peter-mueller 1.0.1 → 1.0.2

data/HISTORY.rdoc

@@ -1,3 +1,8 @@
+== Version 1.0.2 - 4-MAY-2012
+
+* some new methods for creating Email#user.
+* Company#employee now creates the Email#user according to a typical schema.
+
 == Version 1.0.1 - 3-MAY-2012
 
 * new methods Company#name= and Company#domain=

data/lib/peter-mueller/company.rb

@@ -58,6 +58,7 @@ module PeterMueller
       p = Person.new
       p.office_phonenumber = Phonenumber.new(@phonenumber.prefix, phonenumber.number, @last_ext.to_s)
       p.office_email = Email.new(p)
+      p.office_email.user_from_names(p, ".")
       p.office_email.host = @domain
       p
     end

data/lib/peter-mueller/email.rb

@@ -11,22 +11,22 @@ module PeterMueller
     # Creates a new email address.
     def initialize(person = Person.new, owndomain = (rand(1..50) == 2))
       if owndomain
-        @user = [
-                 user_from_names(person),
-                 user_from_firstname(person, ""),
-                 user_from_initials(person, ""),
-                ].sample
+        [
+         lambda{ user_from_names(person) },
+         lambda{ user_from_firstname(person, "") },
+         lambda{ user_from_initials(person, "") },
+        ].sample.call
 
         @host = [
-                 user_from_names(person),
+                 from_names(person),
                  TLD.sample,
                 ].join(".")
       else
-        @user = [
-                 user_from_names(person),
-                 user_from_firstname(person),
-                 user_from_initials(person),
-                ].sample
+        [
+         lambda{ user_from_names(person) },
+         lambda{ user_from_firstname(person) },
+         lambda{ user_from_initials(person) },
+        ].sample.call
 
         @host = FREEMAIL_PROVIDER.sample
       end
@@ -48,24 +48,30 @@ module PeterMueller
         gsub("ß","ss")
     end
 
-    private
+    # Generates the user-part from the names of a Person.
     def user_from_names(person, sepchar=["","_","."].sample)
-      part1 = self.class.umlautfix(person.firstname).gsub(/[^a-zA-Z]/,"").downcase
-      part2 = self.class.umlautfix(person.lastname).gsub(/[^a-zA-Z]/,"").downcase
-      "#{part1}#{sepchar}#{part2}"
+      @user = from_names(person, sepchar)
     end
 
+    # Generates the user-part from the firstname and a number.
     def user_from_firstname(person, number = rand(1..9999).to_s)
       part = self.class.umlautfix(person.firstname).gsub(/[^a-zA-Z]/,"").downcase
-      "#{part}#{number}"
+      @user = "#{part}#{number}"
     end
 
+    # Generates the user-part from the initials and a number.
     def user_from_initials(person, number = rand(1..9999).to_s)
       part1 = self.class.umlautfix(person.firstname).gsub(/[^a-zA-Z]/,"").downcase
       part2 = self.class.umlautfix(person.lastname).gsub(/[^a-zA-Z]/,"").downcase
-      "#{part1[0]}#{part2[0]}#{number}"
+      @user = "#{part1[0]}#{part2[0]}#{number}"
     end
 
+    private
+    def from_names(person, sepchar=["","_","."].sample)
+      part1 = self.class.umlautfix(person.firstname).gsub(/[^a-zA-Z]/,"").downcase
+      part2 = self.class.umlautfix(person.lastname).gsub(/[^a-zA-Z]/,"").downcase
+      "#{part1}#{sepchar}#{part2}"
+    end
   end
 
 end

data/lib/peter-mueller/version.rb

@@ -2,7 +2,7 @@ module PeterMueller
   module VERSION #:nodoc:
     MAJOR = 1
     MINOR = 0
-    TINY  = 1
+    TINY  = 2
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: peter-mueller
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &16750960 !ruby/object:Gem::Requirement
+  requirement: &20824180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 0.9.2
   type: :development
   prerelease: false
-  version_requirements: *16750960
+  version_requirements: *20824180
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &16750180 !ruby/object:Gem::Requirement
+  requirement: &20823600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '2.9'
   type: :development
   prerelease: false
-  version_requirements: *16750180
+  version_requirements: *20823600
 - !ruby/object:Gem::Dependency
   name: ZenTest
-  requirement: &16746360 !ruby/object:Gem::Requirement
+  requirement: &20822980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +43,7 @@ dependencies:
         version: 4.7.0
   type: :development
   prerelease: false
-  version_requirements: *16746360
+  version_requirements: *20822980
 description: ! "A library for creating fictitious German address data.\n                     The
   addresses look real, though they are of pure random and fictitious origin."
 email: