periodic_records 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3814eb5113a83a80a809ea54ec7511afdf4854ef
-  data.tar.gz: 52f39906d98f4c0a143b1425629964be386a1a69
+  metadata.gz: 517b17390003ad69bdd1df93b29302b22056f914
+  data.tar.gz: 0e7fe3fa98fa5ac0bcb740aded5f648de6a53a34
 SHA512:
-  metadata.gz: 144a026349034e933dd588f32113285ed9fef109b2219908ed735d54ac690806ba59311b94a4148c0c9f8a0fa92c320313d584bc78180a191df404ec18a80aa3
-  data.tar.gz: c63c6d7d46261c4a5b84327e9241108c81e41894e8e930616fc3e25b141d0b75b672db6d25671b7b9425641df37e9ca7739205363d4a0bd460750ccce7d569ea
+  metadata.gz: 608187e68129461db42bb131a9734502109068ae2946dab474ed413208f6d3dfbd8a6f2923fb0d7725316683ab50a43b28af5885e8e9a0e4313d8241644f40f2
+  data.tar.gz: 6934f812a9a02eb33128aa8b7996c2c3d057a3b8e5e66dd83f1b9512b14b3b97544f00c301a6871e679d463f6b0af62da2b2623f013f1f8024941aac8ed7245e

data/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.2.0] - 2016-04-08
+
+- Use before_save for adjust_overlapping_records so that it works with
+  database constraints
+- Fixed spelling for methods (overlaping -> overlapping)
+
 ## [0.1.1] - 2015-11-09
 
 - Fix preloading with rails 4.2

data/README.md

@@ -121,6 +121,36 @@ employees.each do |employee|
 end
 ```
 
+## Database Constraints
+
+To avoid inconsistent data in race conditions, you can add database constraint
+that checks overlapping periods.
+
+Postgres:
+
+```ruby
+class AddEmployeeAssignmentsOverlappingDatesConstraint < ActiveRecord::Migration
+  def up
+    execute "CREATE EXTENSION IF NOT EXISTS btree_gist"
+    execute <<-SQL
+      ALTER TABLE employee_assignments
+      ADD CONSTRAINT employee_assignments_overlapping_dates
+      EXCLUDE USING GIST(
+        employee_id WITH =,
+        TSRANGE(start_at, end_at) WITH &&
+      )
+    SQL
+  end
+
+  def down
+    execute <<-SQL.squish
+      ALTER TABLE employee_assignments
+      DROP CONSTRAINT employee_assignments_overlapping_dates
+    SQL
+  end
+end
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies.

data/lib/periodic_records/model.rb

@@ -10,7 +10,7 @@ module PeriodicRecords
       validate :validate_dates
 
       after_initialize :set_default_period, if: :set_default_period_after_initialize?
-      after_save :adjust_overlaping_records
+      before_save :adjust_overlapping_records
     end
 
     module ClassMethods
@@ -48,22 +48,22 @@ module PeriodicRecords
       raise NotImplementedError
     end
 
-    def overlaping_records
-      @overlaping_records ||= siblings.within_interval(start_at, end_at)
+    def overlapping_records
+      @overlapping_records ||= siblings.within_interval(start_at, end_at)
     end
 
-    def adjust_overlaping_records
-      overlaping_records.each do |overlaping_record|
-        if overlaping_record.start_at >= start_at &&
-             overlaping_record.end_at <= end_at
-          destroy_overlaping_record(overlaping_record)
-        elsif overlaping_record.start_at < start_at &&
-                overlaping_record.end_at > end_at
-          split_overlaping_record(overlaping_record)
-        elsif overlaping_record.start_at < start_at
-          adjust_overlaping_record_end_at(overlaping_record)
-        elsif overlaping_record.end_at > end_at
-          adjust_overlaping_record_start_at(overlaping_record)
+    def adjust_overlapping_records
+      overlapping_records.each do |overlapping_record|
+        if overlapping_record.start_at >= start_at &&
+             overlapping_record.end_at <= end_at
+          destroy_overlapping_record(overlapping_record)
+        elsif overlapping_record.start_at < start_at &&
+                overlapping_record.end_at > end_at
+          split_overlapping_record(overlapping_record)
+        elsif overlapping_record.start_at < start_at
+          adjust_overlapping_record_end_at(overlapping_record)
+        elsif overlapping_record.end_at > end_at
+          adjust_overlapping_record_start_at(overlapping_record)
         end
       end
     end
@@ -79,30 +79,30 @@ module PeriodicRecords
       self.end_at   ||= MAX
     end
 
-    def destroy_overlaping_record(overlaping_record)
-      overlaping_record.destroy
+    def destroy_overlapping_record(overlapping_record)
+      overlapping_record.destroy
     end
 
-    def split_overlaping_record(overlaping_record)
-      overlaping_record_end = overlaping_record.dup
-      overlaping_record_end.start_at = end_at + 1.day
-      overlaping_record_end.end_at   = overlaping_record.end_at
+    def split_overlapping_record(overlapping_record)
+      overlapping_record_end = overlapping_record.dup
+      overlapping_record_end.start_at = end_at + 1.day
+      overlapping_record_end.end_at   = overlapping_record.end_at
 
-      overlaping_record_start = overlaping_record
-      overlaping_record_start.end_at = start_at - 1.day
+      overlapping_record_start = overlapping_record
+      overlapping_record_start.end_at = start_at - 1.day
 
-      overlaping_record_start.save(validate: false)
-      overlaping_record_end.save(validate: false)
+      overlapping_record_start.save(validate: false)
+      overlapping_record_end.save(validate: false)
     end
 
-    def adjust_overlaping_record_end_at(overlaping_record)
-      overlaping_record.end_at = start_at - 1.day
-      overlaping_record.save(validate: false)
+    def adjust_overlapping_record_end_at(overlapping_record)
+      overlapping_record.end_at = start_at - 1.day
+      overlapping_record.save(validate: false)
     end
 
-    def adjust_overlaping_record_start_at(overlaping_record)
-      overlaping_record.start_at = end_at + 1.day
-      overlaping_record.save(validate: false)
+    def adjust_overlapping_record_start_at(overlapping_record)
+      overlapping_record.start_at = end_at + 1.day
+      overlapping_record.save(validate: false)
     end
 
     def validate_dates

data/lib/periodic_records/version.rb

@@ -1,3 +1,3 @@
 module PeriodicRecords
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: periodic_records
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Edgars Beigarts
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-11-09 00:00:00.000000000 Z
+date: 2016-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord