perform_later 1.0.8 → 1.1.0

data/lib/object_perform_later.rb

@@ -20,9 +20,10 @@ module ObjectPerformLater
   private 
     def perform_later_enqueue(worker, queue, method, args)
       if PerformLater.config.enabled?
-        Resque::Job.create(queue, worker, self.name, method, args)
+        Resque::Job.create(queue, worker, self.name, method, *args)
       else
-        self.send(method, args)
+        args = PerformLater::ArgsParser.args_from_resque(args)
+        self.send(method, *args)
       end  
     end
 end

data/lib/perform_later/version.rb

@@ -1,3 +1,3 @@
 module PerformLater
-  VERSION = "1.0.8"
+  VERSION = "1.1.0"
 end

data/lib/perform_later/workers/active_record/lone_worker.rb

@@ -4,7 +4,7 @@ module PerformLater
       class LoneWorker
         def self.perform(klass, id, method, args)
           # Remove the loner flag from redis
-          digest = PerformLater::PayloadHelper.get_digest(klass, method_name, args)
+          digest = PerformLater::PayloadHelper.get_digest(klass, method, args)
           Resque.redis.del(digest)
 
           args = PerformLater::ArgsParser.args_from_resque(args)

data/lib/resque/plugins/later/method.rb

@@ -46,11 +46,12 @@ module Resque::Plugins::Later::Method
   end
 
   private 
-    def enqueue_in_resque_or_send(worker, queue, method, args)
+    def enqueue_in_resque_or_send(worker, queue, method, *args)
       if PerformLater.config.enabled?
         Resque::Job.create(queue, worker, self.class.name, self.id, method, *args)   
       else
-        self.send(method, args)
+        args = PerformLater::ArgsParser.args_from_resque(args)
+        self.send(method, *args)
       end
     end
 end

data/spec/lib/object_perform_later_spec.rb

@@ -2,7 +2,11 @@ require 'spec_helper'
 
 class DummyClass 
   def self.do_something_really_heavy
-    
+        
+  end
+
+  def self.do_something_with_string(value)
+    value
   end
 end
 
@@ -36,5 +40,11 @@ describe ObjectPerformLater do
     Resque.peek(:generic, 0, 20).length.should == 1
   end
 
-
+  describe :perform_later! do
+    it "should pass the correct value (String)" do
+      PerformLater.config.stub!(:enabled?).and_return(false)
+      DummyClass.should_receive(:do_something_with_string).with("Avi Tzurel")
+      DummyClass.perform_later!(:generic, :do_something_with_string, "Avi Tzurel")  
+    end
+  end
 end

data/spec/lib/resque/plugins/later/method_spec.rb

@@ -58,6 +58,22 @@ describe Resque::Plugins::Later::Method do
     user.should respond_to(:now_long_running_method)
   end
 
+  describe :perform_later! do
+    it "should send the correct params on the method (with hash)" do
+      PerformLater.config.stub!(:enabled?).and_return(false)
+       user = User.create
+       user.should_receive(:method_with_hash_as_option).with({:some_option => "Brown fox"})
+       user.perform_later!(:generic, :method_with_hash_as_option, :some_option => "Brown fox")
+    end
+
+    it "should send the correct params on the method (with integer)" do
+      PerformLater.config.stub!(:enabled?).and_return(false)
+       user = User.create
+       user.should_receive(:method_with_integer_option).with(1).and_return(1)
+       user.perform_later!(:generic, :method_with_integer_option, 1)
+    end 
+  end
+
 
 
   

data/spec/support/database_models.rb

@@ -13,4 +13,13 @@ class User < ActiveRecord::Base
     # Your code here
   end
   later :lonely_long_running_method, :loner => true, queue: :some_queue_name
+
+  def method_with_hash_as_option(options = {})
+    options[:some_option]
+  end
+
+  def method_with_integer_option(integer)
+    integer
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: perform_later
 version: !ruby/object:Gem::Version
-  version: 1.0.8
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors: