perforated 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 683803eb90edeac727bca419d2f5ab5e4f4db280
-  data.tar.gz: 2d465ab7a114dd20db77d731003fba5933fb5428
+  metadata.gz: 64e25f900f7679d5f4f579b0241ae489e282067f
+  data.tar.gz: 89faaf88ca21ab566ae430bcf191340e979657fd
 SHA512:
-  metadata.gz: d3df769d45345f7d02d3653703c8da995954ea6686b51a7bc055b085861a554ab5a512d3cead7be248754c7b98f8403c8cb2da96ca654d934da93c6021a3182f
-  data.tar.gz: d5266599fb68f53c1d95e38f06cf7b4b000d3e98990c59de7326fca99a024a636d993246d0339f9febc224d2f46155d506776dbc1abc15face89652a53a3ab6b
+  metadata.gz: 71f125afe780caffb948823f4df8650e03f9909ae20e4fa9bc4d00aae486f9fa2826389150ec75c086091da6adfc084f50f974d9c455f95b333f2c82610424b0
+  data.tar.gz: dcaad74a443699fbaf91c35cee0df77c96b75ffa98c63600f0db07313072e3b181165311d78745a5db681469def7f24a18cbd22fe40b27b1a178f6d3a0971857

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## Version 0.6.0
+
+* Prevent frozen string errors by duplicating hash keys before fetching.
+* Use the native cache store's `fetch_multi` implementation if available.
+
 ## Version 0.5.0
 
 * Initial release!

data/lib/perforated/cache.rb

@@ -9,16 +9,18 @@ module Perforated
 
     def as_json(*)
       keyed = keyed_enumerable('as-json')
+      keys  = keyed.keys.map(&:dup)
 
-      fetch_multi(*keyed.keys) do |key|
+      Perforated::Compatibility.fetch_multi(*keys) do |key|
         keyed[key].as_json
       end
     end
 
     def to_json(*)
       keyed = keyed_enumerable('to-json')
+      keys  = keyed.keys.map(&:dup)
 
-      json_objects = fetch_multi(*keyed.keys) do |key|
+      json_objects = Perforated::Compatibility.fetch_multi(*keys) do |key|
         keyed[key].to_json
       end
 
@@ -27,20 +29,6 @@ module Perforated
 
     private
 
-    # Backward compatible implementation of fetch multi.
-    def fetch_multi(*names)
-      options = {}
-      results = Perforated.cache.read_multi(*names, options)
-
-      names.map do |name|
-        results.fetch(name) do
-          value = yield name
-          Perforated.cache.write(name, value, options)
-          value
-        end
-      end
-    end
-
     def keyed_enumerable(suffix = '')
       enumerable.inject({}) do |memo, object|
         memo[key_strategy.expand_cache_key(object, suffix)] = object

data/lib/perforated/compatibility/fetch_multi.rb

@@ -0,0 +1,25 @@
+module Perforated
+  module Compatibility
+    def self.fetch_multi(*names, &block)
+      if Perforated.cache.respond_to?(:fetch_multi)
+        Perforated.cache.fetch_multi(*names, &block)
+      else
+        custom_fetch_multi(*names, &block)
+      end
+    end
+
+    # Backward compatible implementation of fetch multi.
+    def self.custom_fetch_multi(*names)
+      options = {}
+      results = Perforated.cache.read_multi(*names, options)
+
+      names.map do |name|
+        results.fetch(name) do
+          value = yield name
+          Perforated.cache.write(name, value, options)
+          value
+        end
+      end
+    end
+  end
+end

data/lib/perforated/version.rb

@@ -1,3 +1,3 @@
 module Perforated
-  VERSION = '0.5.0'
+  VERSION = '0.6.0'
 end

data/lib/perforated.rb

@@ -1,6 +1,7 @@
 require 'active_support/cache'
 require 'json'
 require 'perforated/cache'
+require 'perforated/compatibility/fetch_multi'
 require 'perforated/strategy/default'
 require 'perforated/version'
 

data/spec/perforated/compatibility/fetch_multi_spec.rb

@@ -0,0 +1,23 @@
+require 'perforated'
+
+describe Perforated::Compatibility do
+  after { Perforated.cache = nil }
+
+  describe '.fetch_multi' do
+    it 'uses the fetch_multi method on the configured cache if present' do
+      cache = Perforated.cache = double(:cache, fetch_multi: true)
+
+      Perforated::Compatibility.fetch_multi(:one, :two)
+
+      expect(cache).to have_received(:fetch_multi).with(:one, :two)
+    end
+
+    it 'falls back to the custom backfill if the cache does not support it' do
+      cache = Perforated.cache
+
+      Perforated::Compatibility.fetch_multi(:one, :two) do |key|
+        key
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: perforated
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Parker Selbert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-12 00:00:00.000000000 Z
+date: 2013-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -83,10 +83,12 @@ files:
 - Rakefile
 - lib/perforated.rb
 - lib/perforated/cache.rb
+- lib/perforated/compatibility/fetch_multi.rb
 - lib/perforated/strategy/default.rb
 - lib/perforated/version.rb
 - perforated.gemspec
 - spec/perforated/cache_spec.rb
+- spec/perforated/compatibility/fetch_multi_spec.rb
 - spec/perforated_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/sorentwo/perforated
@@ -118,5 +120,6 @@ summary: 'The most expensive part of serving a JSON request is converting the se
   this several ways:'
 test_files:
 - spec/perforated/cache_spec.rb
+- spec/perforated/compatibility/fetch_multi_spec.rb
 - spec/perforated_spec.rb
 - spec/spec_helper.rb