perfect_audit 0.2.3 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 31c210d13c9eec483be8e9dc4278986b816e063628fa9abce7c6b30262ca2b35
-  data.tar.gz: b1916f4e5bc65ee12a61480c2592ecdc38545864bda953f6a5a63edcc3fc2ed8
+  metadata.gz: 37964af9226a77b0adcbe2619adebdfcef92f0c6a41dee9163faf80ef75abb40
+  data.tar.gz: 58e3750c9076f75773370e56510e2c0fe5725880940c45fde356813dca8a6070
 SHA512:
-  metadata.gz: 8f53132ca903a8be131bf574f8c2e08b364cba9910bf6a67daca1e6e928be9b88e2fa7543cedad347d1c13c07eba1d00631eedfd55dd936b0b96849a7a048250
-  data.tar.gz: 5baf99d2fc678b936fb6191336706396845dd44a39e3cfe78ac32b8548b9901c72b5b153b52b1efe201f2b6475b7f8ec4d457fb539780292e37bd68845fe84b3
+  metadata.gz: d44df8fa1402e817ede0b6b7f280830a860020774d105a8811d56d12e20341b4aa6c6fdcffab9cbcb430752247d77abaf96fe48dba2d35e807fcb540d607379a
+  data.tar.gz: 8806f8b74208d3b5d14a70c71114e27f29ee5a998307b8e6b666bdd9d90b76ef73c2c1e65d9b5517e5723f6610a1a6e5ac46364a15b46a204533b0a8473ec2df

data/.github/workflows/rubocop.yml

@@ -0,0 +1,21 @@
+name: RuboCop
+
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+
+jobs:
+  rubocop:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7
+    - name: Lint Ruby code with RuboCop
+      run: |
+        gem install bundler
+        bundle install --gemfile gemfiles/rubocop.gemfile --jobs 4 --retry 3
+        bundle exec --gemfile gemfiles/rubocop.gemfile rubocop

data/.irbrc

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 begin
   require 'pry'
   Pry.start

data/.rubocop.yml

@@ -0,0 +1,7 @@
+inherit_from: .rubocop_todo.yml
+
+inherit_gem:
+  jetrockets-standard: config/gems.yml
+
+AllCops:
+  TargetRubyVersion: 2.7

data/.rubocop_todo.yml

@@ -0,0 +1,43 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2023-03-13 17:14:29 UTC using RuboCop version 1.44.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 3
+Lint/IneffectiveAccessModifier:
+  Exclude:
+    - 'lib/perfect_audit.rb'
+
+# Offense count: 2
+RSpec/Be:
+  Exclude:
+    - 'spec/perfect_audit_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: IgnoredMetadata.
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/perfect_audit_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
+# Include: **/*_spec*rb*, **/spec/**/*
+RSpec/FilePath:
+  Exclude:
+    - 'spec/api/books_repository_spec.rb'
+    - 'spec/api/connection_spec.rb'
+    - 'spec/api/documents_repository_spec.rb'
+
+# Offense count: 4
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 1
+RSpec/MultipleDescribes:
+  Exclude:
+    - 'spec/perfect_audit_spec.rb'

data/.ruby-version

@@ -0,0 +1 @@
+2.7.6

data/Gemfile

@@ -1,4 +1,8 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in perfect_audit.gemspec
 gemspec
+
+eval_gemfile 'gemfiles/rubocop.gemfile'

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "perfect_audit"
+require 'bundler/setup'
+require 'perfect_audit'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +11,5 @@ require "perfect_audit"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

data/gemfiles/rubocop.gemfile

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+source 'https://rubygems.org' do
+  gem 'jetrockets-standard', '~> 1.0'
+end

data/lib/perfect_audit/api/bank_account.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'perfect_audit/api/period'
 
 module PerfectAudit
@@ -6,20 +8,22 @@ module PerfectAudit
 
     option :pk, as: :id
     option :book_pk, as: :book_id
-    option :account_type#, optional: true
-    option :account_holder#, optional: true
-    option :account_number#, optional: true
-    option :holder_zip#, optional: true
-    option :holder_state#, optional: true
-    option :holder_city#, optional: true
-    option :holder_address_1#, optional: true
-    option :holder_address_2#, optional: true
+    option :account_type # , optional: true
+    option :account_holder # , optional: true
+    option :account_number # , optional: true
+    option :holder_zip # , optional: true
+    option :holder_state # , optional: true
+    option :holder_city # , optional: true
+    option :holder_address_1 # , optional: true
+    option :holder_address_2 # , optional: true
     option :name
     option :periods, as: :_periods
 
     def periods
       _periods.map do |item|
-        PerfectAudit::Period.new(item.inject({}){|memo,(k,v)| memo[k.to_sym] = v; memo})
+        PerfectAudit::Period.new(item.each_with_object({}) { |(k, v), memo|
+                                   memo[k.to_sym] = v
+                                 })
       end
     end
   end

data/lib/perfect_audit/api/book.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'perfect_audit/api/bank_account'
 require 'perfect_audit/api/document'
 
@@ -18,13 +20,17 @@ module PerfectAudit
 
     def bank_accounts
       _bank_accounts.map do |id, params|
-        PerfectAudit::BankAccount.new(params.inject({}){|memo,(k,v)| memo[k.to_sym] = v; memo})
+        PerfectAudit::BankAccount.new(params.each_with_object({}) { |(k, v), memo|
+                                        memo[k.to_sym] = v
+                                      })
       end
     end
 
     def documents
       _documents.map do |item|
-        PerfectAudit::Document.new(item.inject({}){|memo,(k,v)| memo[k.to_sym] = v; memo})
+        PerfectAudit::Document.new(item.each_with_object({}) { |(k, v), memo|
+                                     memo[k.to_sym] = v
+                                   })
       end
     end
 
@@ -41,6 +47,3 @@ module PerfectAudit
     end
   end
 end
-
-
-

data/lib/perfect_audit/api/document.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module PerfectAudit
   class Document
     extend Dry::Initializer
 
-    STATUSES = %w(
+    STATUSES = %w[
       queued
       failed
       verifying
@@ -10,7 +12,7 @@ module PerfectAudit
       deleting
       deleted
       rejected
-    )
+    ]
 
     option :pk, as: :id
     option :pages

data/lib/perfect_audit/api/period.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PerfectAudit
   class Period
     extend Dry::Initializer
@@ -11,6 +13,3 @@ module PerfectAudit
     option :secondary_recon_error_reason
   end
 end
-
-
-

data/lib/perfect_audit/api/repositories.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'perfect_audit/api/book'
 require 'http/form_data'
 
@@ -6,11 +8,11 @@ module PerfectAudit
     include PerfectAudit::AutoInject[:connection]
     include PerfectAudit::AutoInject[:response_parser]
 
-    CREATE_PATH = 'book/add'.freeze
-    ALL_PATH = 'books'.freeze
-    FIND_PATH = 'book/info'.freeze
-    DELETE_PATH = 'book/remove'.freeze
-    EXCEL_EXPORT_PATH = 'book/export/xlsx/analytics'.freeze
+    CREATE_PATH = 'book/add'
+    ALL_PATH = 'books'
+    FIND_PATH = 'book/info'
+    DELETE_PATH = 'book/remove'
+    EXCEL_EXPORT_PATH = 'book/export/xlsx/analytics'
 
     # Create book in Perfect Audit
     #
@@ -23,8 +25,7 @@ module PerfectAudit
         json: {
           name: name.to_s,
           is_public: public.to_s
-        }
-      )
+        })
 
       PerfectAudit::Book.new(response_parser.parse(response.body.to_s))
     end
@@ -36,12 +37,11 @@ module PerfectAudit
     def all
       response = connection.get(ALL_PATH)
 
-      response_parser.parse(response.body.to_s).map{ |item|
+      response_parser.parse(response.body.to_s).map { |item|
         PerfectAudit::Book.new(item)
       }
     end
 
-
     # Find book in Perfect Audit
     #
     # @param id [Integer] ID of book
@@ -51,8 +51,7 @@ module PerfectAudit
       response = connection.get(FIND_PATH,
         params: {
           pk: id.to_s
-        }
-      )
+        })
 
       PerfectAudit::Book.new(response_parser.parse(response.body.to_s))
     end
@@ -67,8 +66,7 @@ module PerfectAudit
       response = connection.post(DELETE_PATH,
         json: {
           book_id: id
-        }
-      )
+        })
 
       response_parser.parse(response.body.to_s)
 
@@ -80,8 +78,7 @@ module PerfectAudit
       response = connection.get(EXCEL_EXPORT_PATH,
         params: {
           pk: id.to_s
-        }
-      )
+        })
 
       response.body.to_s
     end
@@ -91,7 +88,7 @@ module PerfectAudit
     include PerfectAudit::AutoInject[:connection]
     include PerfectAudit::AutoInject[:response_parser]
 
-    CREATE_PATH = 'book/upload'.freeze
+    CREATE_PATH = 'book/upload'
 
     def create(book_or_id, file)
       id = book_or_id.is_a?(PerfectAudit::Book) ? book_or_id.id.to_s : book_or_id.to_s
@@ -100,8 +97,7 @@ module PerfectAudit
         form: {
           pk: id,
           upload: HTTP::FormData::File.new(file)
-        }
-      )
+        })
 
       response_parser.parse(response.body.to_s)
 

data/lib/perfect_audit/connection.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'dry-initializer'
 require 'http'
 
@@ -5,17 +7,17 @@ module PerfectAudit
   class Connection
     extend Dry::Initializer
 
-    BASE_PATH = 'https://api.ocrolus.com/v1/'.freeze
+    BASE_PATH = 'https://api.ocrolus.com/v1/'
 
     option :api_key
     option :api_secret
 
     def post(path, params = {})
-      HTTP.basic_auth(:user => api_key, :pass => api_secret).post(url(path), params)
+      HTTP.basic_auth(user: api_key, pass: api_secret).post(url(path), params)
     end
 
     def get(path, params = {})
-      HTTP.basic_auth(:user => api_key, :pass => api_secret).get(url(path), params)
+      HTTP.basic_auth(user: api_key, pass: api_secret).get(url(path), params)
     end
 
     private

data/lib/perfect_audit/error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PerfectAudit
   class Error < StandardError
     attr_reader :code

data/lib/perfect_audit/response_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'ostruct'
 require 'perfect_audit/error'
 
@@ -10,10 +12,14 @@ module PerfectAudit
 
       case struct.response
       when Hash
-        struct.response.inject({}){|memo,(k,v)| memo[k.to_sym] = v; memo}
+        struct.response.each_with_object({}) { |(k, v), memo|
+          memo[k.to_sym] = v
+        }
       when Array
         struct.response.map do |item|
-          item.inject({}){ |memo,(k,v)| memo[k.to_sym] = v; memo }
+          item.each_with_object({}) { |(k, v), memo|
+            memo[k.to_sym] = v
+          }
         end
       else
         struct.response

data/lib/perfect_audit/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PerfectAudit
-  VERSION = '0.2.3'.freeze
+  VERSION = '0.3.0'
 end

data/lib/perfect_audit.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'dry-container'
 require 'dry-auto_inject'
 
@@ -6,7 +8,6 @@ require 'perfect_audit/response_parser'
 require 'perfect_audit/version'
 
 module PerfectAudit
-
   class << self
     def configure
       yield configuration

data/perfect_audit.gemspec

@@ -1,25 +1,26 @@
-# coding: utf-8
+# frozen_string_literal: true
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'perfect_audit/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "perfect_audit"
-  spec.version       = PerfectAudit::VERSION
-  spec.authors       = ["Igor Alexandrov"]
-  spec.email         = ["igor.alexandrov@gmail.com"]
+  spec.name = 'perfect_audit'
+  spec.version = PerfectAudit::VERSION
+  spec.authors = ['Igor Alexandrov']
+  spec.email = ['igor.alexandrov@gmail.com']
 
-  spec.summary       = %q{Perfect Audit API wrapper.}
-  spec.description   = %q{Perfect Audit API wrapper. https://www.ocrolus.com/api-doc/}
-  spec.homepage      = "https://github.com/igor-alexandrov/perfect_audit"
-  spec.license       = "MIT"
+  spec.summary = 'Perfect Audit API wrapper.'
+  spec.description = 'Perfect Audit API wrapper. https://www.ocrolus.com/api-doc/'
+  spec.homepage = 'https://github.com/igor-alexandrov/perfect_audit'
+  spec.license = 'MIT'
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.bindir = 'exe'
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '~> 2.3'
+  spec.required_ruby_version = '>= 2.7.0'
 
   # a b c d e f g h i j k l m n o p q r s t u v w x y z
   spec.add_dependency 'dry-auto_inject'
@@ -28,16 +29,15 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'http'
   spec.add_dependency 'http-form_data'
 
-
-  spec.add_development_dependency 'bundler', "~> 1.11"
+  spec.add_development_dependency 'bundler', '>= 1.11'
 
   spec.add_development_dependency 'factory_bot'
   spec.add_development_dependency 'faker'
 
   spec.add_development_dependency 'pry'
 
-  spec.add_development_dependency 'rake', "~> 10.0"
-  spec.add_development_dependency 'rspec', "~> 3.0"
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec-collection_matchers'
 
   spec.add_development_dependency 'simplecov'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: perfect_audit
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.0
 platform: ruby
 authors:
 - Igor Alexandrov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-08 00:00:00.000000000 Z
+date: 2023-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-auto_inject
@@ -84,14 +84,14 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.11'
 - !ruby/object:Gem::Dependency
@@ -227,9 +227,13 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/rubocop.yml"
 - ".gitignore"
 - ".irbrc"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".ruby-version"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -237,6 +241,7 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- gemfiles/rubocop.gemfile
 - lib/perfect_audit.rb
 - lib/perfect_audit/api/bank_account.rb
 - lib/perfect_audit/api/book.rb
@@ -258,16 +263,16 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Perfect Audit API wrapper.