perf_check 0.9.1 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 41079cbdafd8462c82702d76fab786610669da60
-  data.tar.gz: f7f26e3fe1814d062ac41ac21abf7e42a1cc8c4e
+  metadata.gz: 5062bd7a7355129ad3ecc4d92c339ed3601f0bec
+  data.tar.gz: e7d4a37ed76c224a9aa8932c47b70c5c2fb9b339
 SHA512:
-  metadata.gz: 0b53f5e34c216cfce23dfc4a99eb38164a0a0089c266854e3f8db3f910a0263d085171569f2e7c0a3bc2bd883145ad592e107a814079ce55ba6840020d9dc4f4
-  data.tar.gz: 844ea3199990935191c141ad6c6fe4186c0be5469dea517b377ea12efe7760ae41f05b2d2d6269cd44f8aa1000d2875f076a7dac4c7579d8332a130fa3169b0d
+  metadata.gz: 93fbee2f1dddef79edc4cd96034fd908bfefddf7ea5587c61e14c717358b87083513a5415d4730cb40ae19bf49b6f796970423730f887d5f4ce5cecc99153db9
+  data.tar.gz: 38aba1e73b1b9214ea3d2498971353be3e4721c57df1131de8198911431c2432806fa1918f34ccdd5942cff2a6301b47ba8100a1e9c30e6770a65836fec87e6d

data/lib/perf_check/server.rb

@@ -40,7 +40,6 @@ class PerfCheck
     end
 
     def pid
-      pidfile = "#{perf_check.app_root}/tmp/pids/server.pid"
       File.read(pidfile).to_i if File.exists?(pidfile)
     end
 
@@ -94,26 +93,31 @@ class PerfCheck
     end
 
     def exit
-      p = pid
-      if p
-        Process.kill('QUIT', pid)
+      if pid
+        Process.kill('KILL', pid)
         sleep(1.5)
+        File.delete(pidfile) if File.exist?(pidfile)
       end
     end
 
     def start
-      ENV['PERF_CHECK'] = '1'
+      perf_check_args = { 'PERF_CHECK' => '1' }
       if perf_check.options.verify_no_diff
-        ENV['PERF_CHECK_VERIFICATION'] = '1'
+        perf_check_args['PERF_CHECK_VERIFICATION'] = '1'
       end
       unless perf_check.options.caching
-        ENV['PERF_CHECK_NOCACHING'] = '1'
+        perf_check_args['PERF_CHECK_NOCACHING'] = '1'
       end
 
       app_root = Shellwords.shellescape(perf_check.app_root)
-      Bundler.with_clean_env do
+      Bundler.with_original_env do
         Dir.chdir app_root do
-          `bundle exec rails server -b 127.0.0.1 -d -p 3031 >/dev/null`
+          pid = Process.spawn(
+            perf_check_args,
+            "bundle exec rails server -b #{host} -d -p #{port}",
+            [:out] => '/dev/null'
+          )
+          Process.wait pid
         end
       end
       sleep(1.5)
@@ -145,5 +149,11 @@ class PerfCheck
     end
 
     class Profile < OpenStruct; end
+
+    private
+
+    def pidfile
+      @pidfile ||= "#{perf_check.app_root}/tmp/pids/server.pid"
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: perf_check
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.10.0
 platform: ruby
 authors:
 - rubytune
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-09 00:00:00.000000000 Z
+date: 2018-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec