percy-selenium 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 945ce201dd584f7572e5c0072267e979ed2babcad71ddd39bdf3b26d30d37b96
-  data.tar.gz: 23afec0288668a630ce79c2d89e6fff6433f56fcb06caf822eed7094f8b8546a
+  metadata.gz: 21d5089e6a2652952602feef700b0e9aa1a1345ef6c8b464c2c85646e8a36679
+  data.tar.gz: 2c9a17360becb96df488b8ae678172a89bad4ffbb596b05cf560e9a0a66fbcd6
 SHA512:
-  metadata.gz: 4253c8396bd175129d82819aee0b975a4de3d5e0060bcc1c6d5449d93de64387513b1397f1570596e7455dee7ec6d2d15d7c8614c5dba44081327e5096e874c5
-  data.tar.gz: b567e1065b7b971a79da4f18d0e6cd1327129fcde8a0dce5b12299054fe9cd404af19d4643372320226010af7d28780114911b8e7c891b49dad1277868a2dd2a
+  metadata.gz: bca3d0f5ebce8d35f9bffc7727b8af1b42c5fb19c30b6a578a1ff7573b50e5d3613f26885227f3d906c8cd5b7677302af4cb31b20ae0651564a61fc7c5f784b4
+  data.tar.gz: 0f6631b9d1ca037ff738c59ff5a8d3fd9abecde33a71b4bbae266748bd00b8269bb0cc9ed4c674bcc646fde837a8bcfa370b06d3b150165c6a0f5faf4f4a6789

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -5,7 +5,14 @@ title: ''
 labels: ''
 assignees: ''
 ---
+
 <!--
+## Have you read the "Debugging SDKs" doc yet?
+
+There are common setup gotchas that happen with Percy's SDKs, it would be worth reading
+the debugging document, which might already answer your question:
+https://docs.percy.io/docs/debugging-sdk
+
 ## Reach out to Percy support instead?
 
 If you’re having issues that _aren’t SDK bugs_, it would be best for you to
@@ -35,10 +42,11 @@ If necessary, describe the problem you have been experiencing in more detail.
 
 ## Debug logs
 
-If you are reporting a bug, _always_ include logs! Run a Percy build with
-`--verbose` to get the full debug logs. You can also set an environment var
-`PERCY_LOGLEVEL=debug` to get debug logs. For example, `percy exec --verbose --
-[test command]`.  Please include the full complete test output.
+If you are reporting a bug, _always_ include logs! [Give the "Debugging SDKs"
+document a quick read for how to gather logs](https://docs.percy.io/docs/debugging-sdks#debugging-sdks)
+
+Please do not trim or edit these logs, often times there are hints in the full
+logs that help debug what is going on.
 
 ## Code to reproduce issue
 

data/.github/workflows/Semgrep.yml

@@ -0,0 +1,48 @@
+# Name of this GitHub Actions workflow.
+name: Semgrep
+
+on:
+  # Scan changed files in PRs (diff-aware scanning):
+  # The branches below must be a subset of the branches above
+  pull_request:
+    branches: ["master", "main"]
+  push:
+    branches: ["master", "main"]
+  schedule:
+    - cron: '0 6 * * *'
+
+
+permissions:
+  contents: read
+
+jobs:
+  semgrep:
+    # User definable name of this GitHub Actions job.
+    permissions:
+      contents: read  # for actions/checkout to fetch code
+      security-events: write  # for github/codeql-action/upload-sarif to upload SARIF results
+    name: semgrep/ci 
+    # If you are self-hosting, change the following `runs-on` value: 
+    runs-on: ubuntu-latest
+
+    container:
+      # A Docker image with Semgrep installed. Do not change this.
+      image: returntocorp/semgrep
+
+    # Skip any PR created by dependabot to avoid permission issues:
+    if: (github.actor != 'dependabot[bot]')
+
+    steps:
+      # Fetch project source with GitHub Actions Checkout.
+      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
+      # Run the "semgrep ci" command on the command line of the docker image.
+      - run: semgrep ci --sarif --output=semgrep.sarif
+        env:
+            # Add the rules that Semgrep uses by setting the SEMGREP_RULES environment variable. 
+            SEMGREP_RULES: p/default # more at semgrep.dev/explore
+
+      - name: Upload SARIF file for GitHub Advanced Security Dashboard
+        uses: github/codeql-action/upload-sarif@6c089f53dd51dc3fc7e599c3cb5356453a52ca9e # v2.20.0
+        with:
+          sarif_file: semgrep.sarif
+        if: always()

data/.github/workflows/test.yml

@@ -2,8 +2,12 @@ name: Test
 on:
   push:
     branches: [main]
-  pull_request:
   workflow_dispatch:
+    inputs:
+      branch:
+        required: false
+        type: string
+        default: master
 jobs:
   test:
     name: Test
@@ -13,6 +17,15 @@ jobs:
         ruby: ['2.6', '2.7']
     runs-on: ${{ matrix.os }}
     steps:
+      - uses: actions-ecosystem/action-regex-match@v2
+        id: regex-match
+        if: ${{ github.event_name == 'workflow_dispatch' }}
+        with:
+          text: ${{ github.event.inputs.branch }}
+          regex: '^[a-zA-Z0-9_/\-]+$'
+      - name: Break on invalid branch name
+        run: exit 1
+        if: ${{ github.event_name == 'workflow_dispatch' && steps.regex-match.outputs && steps.regex-match.outputs.match == '' }}
       - uses: actions/checkout@v2
       - uses: ruby/setup-ruby@v1
         with:
@@ -23,4 +36,30 @@ jobs:
           path: "./vendor/bundle"
           key: v1/${{ runner.os }}/ruby-${{ matrix.ruby }}/${{ hashFiles('**/Gemfile.lock') }}
           restore-keys: v1/${{ runner.os }}/ruby-${{ matrix.ruby }}/
-      - run: bundle exec rspec
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 16
+      - name: Get yarn cache directory path
+        id: yarn-cache-dir-path
+        run: echo "::set-output name=dir::$(yarn cache dir)"
+      - uses: actions/cache@v3
+        with:
+          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+          key: v1/${{ runner.os }}/node-${{ matrix.node }}/${{ hashFiles('**/yarn.lock') }}
+          restore-keys: v1/${{ runner.os }}/node-${{ matrix.node }}/
+      - run: yarn
+      - name: Set up @percy/cli from git
+        if: ${{ github.event_name == 'workflow_dispatch' }}
+        run: |
+          cd /tmp
+          git clone --branch ${{ github.event.inputs.branch }} --depth 1 https://github.com/percy/cli
+          cd cli
+          PERCY_PACKAGES=`find packages -mindepth 1 -maxdepth 1 -type d | sed -e 's/packages/@percy/g' | tr '\n' ' '`
+          git log -1
+          yarn
+          yarn build
+          yarn global:link
+          cd ${{ github.workspace }} 
+          yarn remove @percy/cli && yarn link `echo $PERCY_PACKAGES`
+          npx percy --version
+      - run: npx percy exec --testing -- bundle exec rspec

data/CODEOWNERS

@@ -0,0 +1 @@
+* @percy/percy-product-reviewers

data/Gemfile

@@ -7,7 +7,8 @@ gem "guard-rspec", require: false
 
 group :test, :development do
   gem "webmock"
-  gem "puma"
+  gem "puma", '~> 5.6'
+  gem "rackup"
   gem "pry"
   gem "simplecov", require: false
 end

data/lib/percy.rb

@@ -31,6 +31,9 @@ module Percy
       unless response.body.to_json['success']
         raise StandardError, data['error']
       end
+
+      body = JSON.parse(response.body)
+      body['data']
     rescue StandardError => e
       log("Could not take DOM snapshot '#{name}'")
 
@@ -90,7 +93,11 @@ module Percy
     uri = URI("#{PERCY_SERVER_ADDRESS}/#{url}")
 
     response = if data
-      Net::HTTP.post(uri, data.to_json)
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.read_timeout = 600 # seconds
+      request = Net::HTTP::Post.new(uri.path)
+      request.body = data.to_json
+      http.request(request)
     else
       Net::HTTP.get_response(uri)
     end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module Percy
-  VERSION = '1.0.1'.freeze
+  VERSION = '1.0.2'.freeze
 end

data/package.json

@@ -0,0 +1,10 @@
+{
+    "private": true,
+    "scripts": {
+      "test": "percy exec --testing -- bundle exec rspec"
+    },
+    "devDependencies": {
+      "@percy/cli": "^1.28.0"
+    }
+  }
+  

data/spec/lib/percy/percy_spec.rb

@@ -1,3 +1,4 @@
+# rubocop:disable RSpec/MultipleDescribes
 RSpec.describe Percy, type: :feature do
   before(:each) do
     WebMock.disable_net_connect!(allow: '127.0.0.1', disallow: 'localhost')
@@ -89,7 +90,7 @@ RSpec.describe Percy, type: :feature do
         .to_return(status: 200, body: '{"success": "true" }', headers: {})
 
       visit 'index.html'
-      Percy.snapshot(page, 'Name', widths: [944])
+      data = Percy.snapshot(page, 'Name', widths: [944])
 
       expect(WebMock).to have_requested(:post, "#{Percy::PERCY_SERVER_ADDRESS}/percy/snapshot")
         .with(
@@ -103,6 +104,69 @@ RSpec.describe Percy, type: :feature do
             widths: [944],
           }.to_json,
         ).once
+
+      expect(data).to eq(nil)
+    end
+
+    it 'sends snapshots for sync' do
+      stub_request(:get, "#{Percy::PERCY_SERVER_ADDRESS}/percy/healthcheck")
+        .to_return(status: 200, body: '', headers: {'x-percy-core-version': '1.0.0'})
+
+      stub_request(:get, "#{Percy::PERCY_SERVER_ADDRESS}/percy/dom.js")
+        .to_return(
+          status: 200,
+          body: 'window.PercyDOM = { serialize: () => document.documentElement.outerHTML };',
+          headers: {},
+        )
+
+      stub_request(:post, 'http://localhost:5338/percy/snapshot')
+        .to_return(status: 200, body: '{"success": "true", "data": "sync_data" }', headers: {})
+
+      visit 'index.html'
+      data = Percy.snapshot(page, 'Name', {sync: true})
+
+      expect(WebMock).to have_requested(:post, "#{Percy::PERCY_SERVER_ADDRESS}/percy/snapshot")
+        .with(
+          body: {
+            name: 'Name',
+            url: 'http://127.0.0.1:3003/index.html',
+            dom_snapshot:
+              "<html><head><title>I am a page</title></head><body>Snapshot me\n</body></html>",
+            client_info: "percy-selenium-ruby/#{Percy::VERSION}",
+            environment_info: "selenium/#{Selenium::WebDriver::VERSION} ruby/#{RUBY_VERSION}",
+            widths: [944],
+          }.to_json,
+        ).once
+
+      expect(data).to eq('sync_data')
+    end
+  end
+end
+
+RSpec.describe Percy, type: :feature do
+  before(:each) do
+    WebMock.reset!
+    WebMock.allow_net_connect!
+    Percy._clear_cache!
+  end
+
+  describe 'integration', type: :feature do
+    it 'sends snapshots to percy server' do
+      visit 'index.html'
+      Percy.snapshot(page, 'Name', widths: [375])
+      sleep 5 # wait for percy server to process
+      resp = Net::HTTP.get_response(URI("#{Percy::PERCY_SERVER_ADDRESS}/test/requests"))
+      requests = JSON.parse(resp.body)['requests']
+      healthcheck = requests[0]
+      expect(healthcheck['url']).to eq('/percy/healthcheck')
+
+      snap = requests[2]['body']
+      expect(snap['name']).to eq('Name')
+      expect(snap['url']).to eq('http://127.0.0.1:3003/index.html')
+      expect(snap['client_info']).to include('percy-selenium-ruby')
+      expect(snap['environment_info']).to include('selenium')
+      expect(snap['widths']).to eq([375])
     end
   end
 end
+# rubocop:enable RSpec/MultipleDescribes

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-selenium
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Perceptual Inc.
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-27 00:00:00.000000000 Z
+date: 2024-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
@@ -104,6 +104,7 @@ files:
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/dependabot.yml"
 - ".github/release-drafter.yml"
+- ".github/workflows/Semgrep.yml"
 - ".github/workflows/changelog.yml"
 - ".github/workflows/lint.yml"
 - ".github/workflows/release.yml"
@@ -113,6 +114,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".yardopts"
+- CODEOWNERS
 - Gemfile
 - Guardfile
 - LICENSE
@@ -121,6 +123,7 @@ files:
 - Rakefile
 - lib/percy.rb
 - lib/version.rb
+- package.json
 - percy-selenium.gemspec
 - spec/fixture/index.html
 - spec/lib/percy/percy_spec.rb
@@ -131,7 +134,7 @@ licenses:
 metadata:
   bug_tracker_uri: https://github.com/percy/percy-selenium-ruby/issues
   source_code_uri: https://github.com/percy/percy-selenium-ruby
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -146,8 +149,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.5.3
+signing_key:
 specification_version: 4
 summary: Percy visual testing for Ruby Selenium
 test_files: