percy-common 2.0.0 → 3.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ff0436bf3b67e3b1ba96ceef1acb452769389899
-  data.tar.gz: 9f89386fbf9f6e0b64b6246f09700d08af9f3e17
+SHA256:
+  metadata.gz: 9fd27d7a6c0fa5188832abb43534aef2681d8dae719b823dbed82bdbd2c40f85
+  data.tar.gz: '08d2f567ecf0ef5b70772f9b5080d48dea45461ace3245fb729f0c00f8e4c028'
 SHA512:
-  metadata.gz: 07a215cba17815974cf1ef9d9b8e577a5739e7d47c8d3cd652bc1563cbc82dfb17cecbe79ffcd01d6766f6ba199de7231157d8f35b320e75fc075f0aa65ee91d
-  data.tar.gz: 6030828cb677b3ba831d8626a5045f859d95c537b72cee5531c684eba0679e388d3a9231af649098112829c8f4edf64d173b5a7361a4ac6d020a4a3669d84752
+  metadata.gz: a6b81c030ef1251a4440508ad153fb567a738f0a84c98ec922db41fcc24c628c7a9d4c67372f03973fb169015158f1639b80a9919cd94e6c295106287006c3f7
+  data.tar.gz: 4b4f7eb6f01b10fb3625696c672cd5b45c498a5c975dd27b52d5258c60730f6326d25fc9057c733d01ea4aaeeed2787ef641d11182f64f10581ca75e9695c779

data/.circleci/config.yml

@@ -0,0 +1,18 @@
+version: 2.1
+
+jobs:
+  ruby_25:
+    docker:
+      - image: circleci/ruby:2.5-node-browsers
+    steps:
+      - checkout
+      - run: gem update --system
+      - run: gem install bundler
+      - run: bundle install
+      - run: bundle exec rubocop -D
+
+workflows:
+  version: 2
+  test:
+    jobs:
+      - ruby_25

data/.rubocop.yml

@@ -2,6 +2,10 @@ inherit_gem:
   percy-style:
     - default.yml
 
+inherit_mode:
+  merge:
+    - Include
+
 RSpec/DescribeClass:
   Exclude:
     - spec/percy/logger_spec.rb

data/lib/percy/common/version.rb

@@ -1,5 +1,5 @@
 module Percy
   module Common
-    VERSION = '2.0.0'.freeze
+    VERSION = '3.0.2'.freeze
   end
 end

data/lib/percy/logger.rb

@@ -2,7 +2,7 @@ require 'logger'
 
 module Percy
   def self.logger
-    @logger if defined?(@logger)
+    return @logger if defined?(@logger)
     @logger ||= Logger.new(STDOUT)
     @logger.level = Logger::INFO if ENV['PERCY_ENV'] == 'production'
     @logger.formatter = proc do |severity, _datetime, _progname, msg|

data/lib/percy/stats.rb

@@ -3,30 +3,74 @@ require 'time'
 
 module Percy
   class Stats < ::Datadog::Statsd
-    def initialize(host = nil, port = nil, opts = {}, max_buffer_size = 50)
-      host ||= ENV.fetch('DATADOG_AGENT_HOST', ::Datadog::Statsd::DEFAULT_HOST)
-      port ||= Integer(ENV.fetch('DATADOG_AGENT_PORT', ::Datadog::Statsd::DEFAULT_PORT))
-      opts[:tags] ||= []
-      opts[:tags] << "env:#{ENV['PERCY_ENV'] || 'development'}"
-      super(host, port, opts, max_buffer_size)
+    DEFAULT_HOST = ENV.fetch(
+      'DATADOG_AGENT_HOST',
+      ::Datadog::Statsd::Connection::DEFAULT_HOST,
+    )
+
+    DEFAULT_PORT = Integer(
+      ENV.fetch(
+        'DATADOG_AGENT_PORT',
+        ::Datadog::Statsd::Connection::DEFAULT_PORT,
+      ),
+    )
+
+    DEFAULT_TAGS = %W[
+      env:#{ENV.fetch('PERCY_ENV', 'development')}
+    ].freeze
+
+    def initialize(
+      host = DEFAULT_HOST,
+      port = DEFAULT_PORT,
+      tags: DEFAULT_TAGS,
+      **kwargs
+    )
+      super(host, port, tags: tags, **kwargs)
     end
 
-    # Equivalent to stats.time, but without wrapping in blocks and dealing with var scoping issues.
+    # Equivalent to stats.time, but without wrapping in blocks and dealing with
+    # var scoping issues.
     #
     # @example Report the time taken to activate an account.
     #   stats.start_timing
     #   account.activate!
     #   stats.stop_timing('account.activate')
     def start_timing
-      @_timing_start = Time.now
+      @_timing_start = now
       true
     end
 
     def stop_timing(stat, options = {})
-      raise 'no timing started' unless @_timing_start # Programmer mistake, so raise an error.
-      time_since(stat, @_timing_start, options)
+      # Programmer mistake, so raise an error.
+      raise 'no timing started' unless @_timing_start
+
+      time_since_monotonic(stat, @_timing_start, options)
       @_timing_start = nil
       true
     end
+
+    # dogstatsd uses a monotonic (linearly increasing) clock to calculate time
+    # intervals, so this should be used where necessary. However, it's not
+    # possible to compare monotonic time values with fixed times, so both are
+    # available.
+    def time_since_monotonic(stat, start, opts = {})
+      unless start.instance_of? Float
+        raise ArgumentError, 'start value must be Float'
+      end
+
+      timing(stat, ((now.to_f - start.to_f) * 1000).round, opts)
+    end
+
+    def time_since(stat, start, opts = {})
+      unless start.instance_of? Time
+        raise ArgumentError, 'start value must be Time'
+      end
+
+      timing(stat, ((Time.now.to_f - start.to_f) * 1000).round, opts)
+    end
+
+    private def now
+      Process.clock_gettime(Process::CLOCK_MONOTONIC)
+    end
   end
 end

data/percy-common.gemspec

@@ -16,12 +16,12 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'dogstatsd-ruby', '~> 3.1'
+  spec.add_dependency 'dogstatsd-ruby', '~> 4.4.0'
   spec.add_dependency 'excon', '~> 0.57'
 
-  spec.add_development_dependency 'bundler', '~> 1.15'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'bundler', '~> 2.0.2'
+  spec.add_development_dependency 'rake', '~> 12.3'
   spec.add_development_dependency 'rspec', '~> 3.2'
   spec.add_development_dependency 'guard-rspec', '~> 4.7'
-  spec.add_development_dependency 'percy-style'
+  spec.add_development_dependency 'percy-style', '~> 0.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-common
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 3.0.2
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-13 00:00:00.000000000 Z
+date: 2019-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dogstatsd-ruby
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: 4.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: 4.4.0
 - !ruby/object:Gem::Dependency
   name: excon
   requirement: !ruby/object:Gem::Requirement
@@ -44,28 +44,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: 2.0.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: 2.0.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -98,16 +98,16 @@ dependencies:
   name: percy-style
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.0
 description: ''
 email:
 - team@percy.io
@@ -115,10 +115,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
 - Gemfile
 - Guardfile
 - LICENSE
@@ -152,8 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: Server-side common library for Percy.

data/.travis.yml

@@ -1,11 +0,0 @@
-language: ruby
-sudo: false
-cache: bundler
-rvm:
-  - 2.4
-  - ruby-head
-before_install:
-  - gem update bundler
-script:
-  - bundle exec rubocop -D
-  - bundle exec rspec