percy-client 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a88cabf223f1d717cc86375818e02d37627da2193c4b0fe1406f60515d4db8b
-  data.tar.gz: 2f8eeba9710b0d07f588b6a8c3c64b4b94ad99f6acc0040b510d740819485f86
+  metadata.gz: cb32f605c7e39943ceeebc882d52885339e064be73030eb027f3d749934a57b8
+  data.tar.gz: b01052119256ca5704ae42f4f05b32124c1a86877398fe596b8b1e2e0f8d220f
 SHA512:
-  metadata.gz: ef1d3c5a7641e276b4c044750cef300bb2ede4716cb4f9d2a8e9d0a52b0445c585c8f92e0429f11814f025e9b0b9705cf39a9d5f2de28f4da0ddbdf7a63b000d
-  data.tar.gz: f1897c81a9d3762f41878a2a55fbd77a19e4828ef3270773e25f5add2698514a51e259b5654474d4341992e767974a83a260ec9207b09417bcfffea0caa9494c
+  metadata.gz: 4f9970b7e41b709a81fb6739190ffc60d9e37152f285a745749c4e9e10b526e919e687db7c2d501bb138bd1875d46cf6baac9ef78f1f83f5b256ac4516d4ab34
+  data.tar.gz: 614d24dbb43c4e5a26840889b0444ed634c393bcee7ad90c032f01251197a5974c550f6ba66c1bb18401d442afe76711f7c5c0dbfe70236b63b4a300804de873

data/.travis.yml

@@ -8,7 +8,6 @@ addons:
     - libgmp-dev
 cache: bundler
 rvm:
-  - ruby-2.2.6
   - ruby-2.3.3
   - ruby-2.4.0
   - ruby-2.5.0

data/appveyor.yml

@@ -3,12 +3,11 @@ environment:
     - RUBY_VERSION: 25
     - RUBY_VERSION: 24
     - RUBY_VERSION: 23
-    - RUBY_VERSION: 22
-    - RUBY_VERSION: 21
 
 # Install scripts. (runs after repo cloning)
 install:
   - set PATH=C:\Ruby%RUBY_VERSION%\bin;%PATH%
+  - gem install bundler
   - bundle install
 
 before_test:

data/lib/percy/client.rb

@@ -65,6 +65,12 @@ module Percy
     # 503
     class ServiceUnavailableError < ServerError; end
 
+    # 504
+    class GatewayTimeoutError < ServerError; end
+
+    # 520..530.
+    class CloudflareError < ServerError; end
+
     attr_reader :config, :client_info, :environment_info
 
     def initialize(options = {})

data/lib/percy/client/connection.rb

@@ -30,6 +30,10 @@ module Percy
             error_class = Percy::Client::BadGatewayError
           when 503
             error_class = Percy::Client::ServiceUnavailableError
+          when 504
+            error_class = Percy::Client::GatewayTimeoutError
+          when 520..530
+            error_class = Percy::Client::CloudflareError
           when CLIENT_ERROR_STATUS_RANGE # Catchall.
             error_class = Percy::Client::HttpError
           end
@@ -70,9 +74,9 @@ module Percy
           raise Percy::Client::TimeoutError
         rescue Faraday::ConnectionFailed
           raise Percy::Client::ConnectionFailed
-        rescue Percy::Client::HttpError => e
-          # Retry on 502 errors.
-          if e.status == 502 && (retries -= 1) >= 0
+        rescue Percy::Client::ServerError => e
+          # Retry on 5XX errors.
+          if (retries -= 1) >= 0
             sleep(rand(1..3))
             retry
           end
@@ -98,6 +102,7 @@ module Percy
         rescue Faraday::ConnectionFailed
           raise Percy::Client::ConnectionFailed
         rescue Percy::Client::ServerError => e
+          # Retry on 5XX errors.
           if (retries -= 1) >= 0
             sleep(rand(1..3))
             retry

data/lib/percy/client/version.rb

@@ -1,5 +1,5 @@
 module Percy
   class Client
-    VERSION = '2.0.1'.freeze
+    VERSION = '2.0.2'.freeze
   end
 end

data/percy-client.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'excon'
   spec.add_dependency 'addressable'
 
-  spec.add_development_dependency 'bundler', '~> 1.7'
+  spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.2'
   spec.add_development_dependency 'vcr'

data/spec/lib/percy/client/connection_spec.rb

@@ -12,6 +12,8 @@ RSpec.describe Percy::Client::Connection do
   let(:ci_version) { '8.14.3-ee' }
   let(:uri) { "#{Percy.config.api_url}/test" }
 
+  SERVER_ERROR_CODES = ((500..504).to_a + (520..530).to_a).freeze
+
   shared_examples_for 'a connection that sets headers with HTTP method' do |http_method|
     it 'sets headers' do
       stub_request(http_method, uri)
@@ -51,12 +53,14 @@ RSpec.describe Percy::Client::Connection do
       expect { response }.to raise_error(Percy::Client::ConnectionFailed)
     end
 
-    it 'retries on 502 errors' do
-      stub_request(:get, uri)
-        .to_return(body: {foo: true}.to_json, status: 502)
-        .then.to_return(body: {foo: true}.to_json, status: 200)
+    it 'retries on 5XX errors' do
+      SERVER_ERROR_CODES.each do |error_code|
+        stub_request(:get, uri)
+          .to_return(body: {foo: true}.to_json, status: error_code)
+          .then.to_return(body: {foo: true}.to_json, status: 200)
 
-      expect(response).to eq('foo' => true)
+        expect(response).to eq('foo' => true)
+      end
     end
 
     it 'raises error after 3 retries' do
@@ -124,6 +128,9 @@ RSpec.describe Percy::Client::Connection do
       '500' => Percy::Client::InternalServerError,
       '502' => Percy::Client::BadGatewayError,
       '503' => Percy::Client::ServiceUnavailableError,
+      '504' => Percy::Client::GatewayTimeoutError,
+      '520' => Percy::Client::CloudflareError,
+      '530' => Percy::Client::CloudflareError,
     }
 
     http_errors.each do |http_status, error_class|
@@ -131,11 +138,13 @@ RSpec.describe Percy::Client::Connection do
     end
 
     it 'retries on server errors' do
-      stub_request(:post, uri)
-        .to_return(body: {foo: true}.to_json, status: 500)
-        .then.to_return(body: {foo: true}.to_json, status: 200)
+      SERVER_ERROR_CODES.each do |error_code|
+        stub_request(:post, uri)
+          .to_return(body: {foo: true}.to_json, status: 500)
+          .then.to_return(body: {foo: true}.to_json, status: 200)
 
-      expect(response).to eq('foo' => true)
+        expect(response).to eq('foo' => true)
+      end
     end
 
     it 'raises error after 3 retries' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-client
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-19 00:00:00.000000000 Z
+date: 2019-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement