percy-client 1.13.0 → 1.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b94954861b98e83a57b9320d28682b66a66e49ee
-  data.tar.gz: b6b9a044bab771d3f3fa37ab4922a865c3cc465a
+  metadata.gz: dd5e53a2a31b6d624b67f40255d1cb403e43df54
+  data.tar.gz: c7272d9503ead0a38e147bc33b2923f1227d742f
 SHA512:
-  metadata.gz: 9c70290afed751c1612eb3dec8024511c4bc5cb127f3919f84eb1ccec87e30ad2df515153d7c1d0ed4be78423f026ca021847d43bc8a21b20b62f9fa9278573a
-  data.tar.gz: 0637dcf07a4c97a5f8904bb4653ce9d6bfac3aa8f576c39a550a35a1cc0fd5716a84d074f62bef4980d67aa13b4b4fe9492dd9ee7fbf7349edd4228ede60c8da
+  metadata.gz: '09c9153ac7a3b8f30402a54ec48f23f795f539e8cbd13810f006d037d94c0131ac96142b06f406b7ba5b96242c3a74354e60562e6edf49eebb0bcee2760c20b0'
+  data.tar.gz: 0473a03972385f577096e39ce9bbf46f5f46e69ccdec4160f5ac7f47d0702b6cc14fc2183458705c2a136c12d570325c464a667168c9030de7e12c37be78da4c

data/.rubocop.yml

@@ -1,76 +1,7 @@
-require: rubocop-rspec
-inherit_from: .rubocop_todo.yml
-AllCops:
-  Include:
-    - Rakefile
-    - lib/**/*.rake
-  Exclude:
-    - 'vendor/**/*'
-    - 'percy-client.gemspec'
-
-Lint/EndAlignment:
-  EnforcedStyleAlignWith: variable
-
-Metrics/LineLength:
-  Max: 101
-
-Style/AlignParameters:
-  EnforcedStyle: with_fixed_indentation
-
-Style/CaseIndentation:
-  EnforcedStyle: end
-
-Style/Documentation:
-  Enabled: false
-
-Style/DoubleNegation:
-  Enabled: false
-
-Style/IndentArray:
-  EnforcedStyle: consistent
-
-Style/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-
-Style/MultilineOperationIndentation:
-  EnforcedStyle: indented
-
-# Disable Style/NumericLiterals so numbers don't need underscores
-Style/NumericLiterals:
-  Enabled: false
-
-Style/FileName:
-  Enabled: false
+inherit_gem:
+  percy-style:
+    - default.yml
 
-Style/SymbolArray:
-  Enabled: false
-
-Style/NumericPredicate:
-  EnforcedStyle: comparison
-
-Style/RedundantBegin:
-  Enabled: false
-
-Style/RegexpLiteral:
-  EnforcedStyle: slashes
-  AllowInnerSlashes: true
-
-Style/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-
-Style/TrailingCommaInArguments:
-  EnforcedStyleForMultiline: consistent_comma
-
-Style/TrailingCommaInLiteral:
-  EnforcedStyleForMultiline: consistent_comma
-
-RSpec/MessageSpies:
-  EnforcedStyle: receive
-
-RSpec/NotToNot:
-  Enabled: false
-
-
-# Will be able to do this in >= v1.11
-# RSpec/DescribedClass:
-#   EnforcedStyle: explicit
+RSpec/InstanceVariable:
+  Exclude:
+    - spec/lib/percy/client/environment_spec.rb

data/Gemfile

@@ -8,8 +8,3 @@ gem 'guard-rspec', require: false
 group :test, :development do
   gem 'pry'
 end
-
-group :test do
-  gem 'rubocop'
-  gem 'rubocop-rspec'
-end

data/lib/percy.rb

@@ -58,4 +58,9 @@ module Percy
     client.send(method_name, *args, &block)
   end
   private :method_missing
+
+  # @private
+  def self.respond_to_missing?(method_name, _ = false)
+    client.respond_to?(method_name)
+  end
 end

data/lib/percy/client/environment.rb

@@ -36,7 +36,7 @@ module Percy
         commit_sha = _commit_sha || output && output.match(/COMMIT_SHA:(.*)/)[1]
 
         # If not running in a git repo, allow nils for certain commit attributes.
-        extract_or_nil = ->(regex) { (output && output.match(regex) || [])[1] }
+        parse = ->(regex) { (output && output.match(regex) || [])[1] }
         {
           # The only required attribute:
           branch: branch,
@@ -44,14 +44,14 @@ module Percy
           sha: commit_sha,
 
           # Optional attributes:
-          message: extract_or_nil.call(/COMMIT_MESSAGE:(.*)/m),
-          committed_at: extract_or_nil.call(/COMMITTED_DATE:(.*)/),
+          message: parse.call(/COMMIT_MESSAGE:(.*)/m),
+          committed_at: parse.call(/COMMITTED_DATE:(.*)/),
           # These GIT_ environment vars are from the Jenkins Git Plugin, but could be
           # used generically. This behavior may change in the future.
-          author_name: extract_or_nil.call(/AUTHOR_NAME:(.*)/) || ENV['GIT_AUTHOR_NAME'],
-          author_email: extract_or_nil.call(/AUTHOR_EMAIL:(.*)/) || ENV['GIT_AUTHOR_EMAIL'],
-          committer_name: extract_or_nil.call(/COMMITTER_NAME:(.*)/) || ENV['GIT_COMMITTER_NAME'],
-          committer_email: extract_or_nil.call(/COMMITTER_EMAIL:(.*)/) || ENV['GIT_COMMITTER_EMAIL'],
+          author_name: parse.call(/AUTHOR_NAME:(.*)/) || ENV['GIT_AUTHOR_NAME'],
+          author_email: parse.call(/AUTHOR_EMAIL:(.*)/) || ENV['GIT_AUTHOR_EMAIL'],
+          committer_name: parse.call(/COMMITTER_NAME:(.*)/) || ENV['GIT_COMMITTER_NAME'],
+          committer_email: parse.call(/COMMITTER_EMAIL:(.*)/) || ENV['GIT_COMMITTER_EMAIL'],
         }
       end
 
@@ -100,7 +100,7 @@ module Percy
 
         result = case current_ci
         when :jenkins
-          ENV['ghprbTargetBranch']
+          ENV['ghprbSourceBranch']
         when :travis
           if pull_request_number
             ENV['TRAVIS_PULL_REQUEST_BRANCH']
@@ -185,6 +185,7 @@ module Percy
           end
         when :codeship
           # Unfortunately, codeship always returns 'false' for CI_PULL_REQUEST. For now, return nil.
+          nil
         when :drone
           ENV['CI_PULL_REQUEST']
         when :semaphore
@@ -204,6 +205,8 @@ module Percy
           ENV['TRAVIS_BUILD_NUMBER']
         when :circle
           ENV['CIRCLE_BUILD_NUM']
+        when :jenkins
+          ENV['BUILD_NUMBER']
         when :codeship
           ENV['CI_BUILD_NUMBER']
         when :semaphore

data/lib/percy/client/version.rb

@@ -1,5 +1,5 @@
 module Percy
   class Client
-    VERSION = '1.13.0'.freeze
+    VERSION = '1.13.1'.freeze
   end
 end

data/percy-client.gemspec

@@ -28,4 +28,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.2'
   spec.add_development_dependency 'vcr'
   spec.add_development_dependency 'webmock'
+  spec.add_development_dependency 'percy-style'
 end

data/spec/lib/percy/client/builds_spec.rb

@@ -1,5 +1,5 @@
 RSpec.describe Percy::Client::Builds, :vcr do
-  let(:content) { "hello world! #{described_class.name}" }
+  let(:content) { "hello world! #{Percy::Client::Builds.name}" }
   let(:sha) { Digest::SHA256.hexdigest(content) }
 
   describe '#create_build' do

data/spec/lib/percy/client/environment_spec.rb

@@ -23,9 +23,10 @@ RSpec.describe Percy::Client::Environment do
 
     # Unset Jenkins vars.
     ENV['JENKINS_URL'] = nil
+    ENV['BUILD_NUMBER'] = nil
     ENV['ghprbPullId'] = nil
     ENV['ghprbActualCommit'] = nil
-    ENV['ghprbTargetBranch'] = nil
+    ENV['ghprbSourceBranch'] = nil
 
     # Unset Circle CI vars.
     ENV['CIRCLECI'] = nil
@@ -244,17 +245,20 @@ RSpec.describe Percy::Client::Environment do
   context 'in Jenkins CI' do
     before(:each) do
       ENV['JENKINS_URL'] = 'http://localhost:8080/'
-      ENV['ghprbPullId'] = '123'
-      ENV['ghprbTargetBranch'] = 'jenkins-target-branch'
+      ENV['BUILD_NUMBER'] = '111'
+      ENV['ghprbPullId'] = '256'
+      ENV['ghprbSourceBranch'] = 'jenkins-source-branch'
       ENV['ghprbActualCommit'] = 'jenkins-actual-commit'
     end
 
     it 'has the correct properties' do
       expect(Percy::Client::Environment.current_ci).to eq(:jenkins)
-      expect(Percy::Client::Environment.branch).to eq('jenkins-target-branch')
+      expect(Percy::Client::Environment.branch).to eq('jenkins-source-branch')
       expect(Percy::Client::Environment._commit_sha).to eq('jenkins-actual-commit')
-      expect(Percy::Client::Environment.pull_request_number).to eq('123')
+      expect(Percy::Client::Environment.pull_request_number).to eq('256')
       expect(Percy::Client::Environment.repo).to eq('percy/percy-client')
+      expect(Percy::Client::Environment.parallel_nonce).to eq('111')
+      expect(Percy::Client::Environment.parallel_total_shards).to eq(nil)
     end
   end
 

data/spec/lib/percy/client/resources_spec.rb

@@ -2,7 +2,7 @@ require 'digest'
 
 # rubocop:disable RSpec/MultipleDescribes
 RSpec.describe Percy::Client::Resources, :vcr do
-  let(:content) { "hello world! #{described_class.name}" }
+  let(:content) { "hello world! #{Percy::Client::Resources.name}" }
   let(:sha) { Digest::SHA256.hexdigest(content) }
 
   describe '#upload_resource' do
@@ -19,11 +19,11 @@ RSpec.describe Percy::Client::Resources, :vcr do
 end
 
 RSpec.describe Percy::Client::Resource do
-  let(:content) { "hello world! #{described_class.name}" }
+  let(:content) { "hello world! #{Percy::Client::Resource.name}" }
   let(:sha) { Digest::SHA256.hexdigest(content) }
 
   it 'can be initialized with minimal data' do
-    resource = described_class.new('/foo.html', sha: sha)
+    resource = Percy::Client::Resource.new('/foo.html', sha: sha)
     expect(resource.serialize).to eq(
       'type' => 'resources',
       'id' => sha,
@@ -35,7 +35,7 @@ RSpec.describe Percy::Client::Resource do
     )
   end
   it 'can be initialized with all data' do
-    resource = described_class.new(
+    resource = Percy::Client::Resource.new(
       '/foo new.html',
       sha: sha,
       is_root: true,
@@ -53,48 +53,54 @@ RSpec.describe Percy::Client::Resource do
     )
   end
   it 'errors if not given sha or content' do
-    expect { described_class.new('/foo.html') }.to raise_error(ArgumentError)
+    expect { Percy::Client::Resource.new('/foo.html') }.to raise_error(ArgumentError)
   end
 
   describe 'object equality' do
-    subject(:resource) { described_class.new('/some-content', sha: sha, mimetype: mimetype) }
+    subject(:resource) do
+      Percy::Client::Resource.new('/some-content', sha: sha, mimetype: mimetype)
+    end
 
     let(:sha) { '123456' }
     let(:mimetype) { 'text/plain' }
 
     describe 'two resources with same properties' do
-      let(:other) { described_class.new('/some-content', sha: sha, mimetype: mimetype) }
+      let(:other) { Percy::Client::Resource.new('/some-content', sha: sha, mimetype: mimetype) }
 
-      it { is_expected.to eq(other) }
-      it { is_expected.to eql(other) }
+      it { should eq(other) }
+      it { should eql(other) }
       it { expect(resource.hash).to eq(other.hash) }
       it('makes their array unique') { expect([resource, other].uniq).to eq([resource]) }
     end
 
     describe 'two resources with different sha' do
-      let(:other) { described_class.new('/some-content', sha: sha.reverse, mimetype: mimetype) }
+      let(:other) do
+        Percy::Client::Resource.new('/some-content', sha: sha.reverse, mimetype: mimetype)
+      end
 
-      it { is_expected.not_to eq(other) }
-      it { is_expected.not_to eql(other) }
-      it { expect(resource.hash).not_to eq(other.hash) }
+      it { should_not eq(other) }
+      it { should_not eql(other) }
+      it { expect(resource.hash).to_not eq(other.hash) }
       it('makes array unique') { expect([resource, other].uniq).to eq([resource, other]) }
     end
 
     describe 'two resources with different url' do
-      let(:other) { described_class.new('/different-content', sha: sha, mimetype: mimetype) }
+      let(:other) do
+        Percy::Client::Resource.new('/different-content', sha: sha, mimetype: mimetype)
+      end
 
-      it { is_expected.not_to eq(other) }
-      it { is_expected.not_to eql(other) }
-      it { expect(resource.hash).not_to eq(other.hash) }
+      it { should_not eq(other) }
+      it { should_not eql(other) }
+      it { expect(resource.hash).to_not eq(other.hash) }
       it('makes array unique') { expect([resource, other].uniq).to eq([resource, other]) }
     end
 
     describe 'two resources with different mimetype' do
-      let(:other) { described_class.new('/some-content', sha: sha, mimetype: 'text/css') }
+      let(:other) { Percy::Client::Resource.new('/some-content', sha: sha, mimetype: 'text/css') }
 
-      it { is_expected.not_to eq(other) }
-      it { is_expected.not_to eql(other) }
-      it { expect(resource.hash).not_to eq(other.hash) }
+      it { should_not eq(other) }
+      it { should_not eql(other) }
+      it { expect(resource.hash).to_not eq(other.hash) }
       it('makes array unique') { expect([resource, other].uniq).to eq([resource, other]) }
     end
   end

data/spec/lib/percy/config_spec.rb

@@ -1,5 +1,5 @@
 RSpec.describe Percy::Config do
-  let(:config) { described_class.new }
+  let(:config) { Percy::Config.new }
 
   it 'returns the correct defaults' do
     expect(config.keys).to eq(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-client
 version: !ruby/object:Gem::Version
-  version: 1.13.0
+  version: 1.13.1
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-22 00:00:00.000000000 Z
+date: 2017-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -122,6 +122,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: percy-style
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: ''
 email:
 - team@percy.io
@@ -132,7 +146,6 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".rubocop_todo.yml"
 - ".travis.yml"
 - Gemfile
 - Guardfile
@@ -189,7 +202,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.2
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: Percy::Client

data/.rubocop_todo.yml

@@ -1,101 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2017-02-11 20:36:15 -0800 using RuboCop version 0.47.1.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 1
-Lint/EmptyWhen:
-  Exclude:
-    - 'lib/percy/client/environment.rb'
-
-# Offense count: 13
-Metrics/AbcSize:
-  Max: 65
-
-# Offense count: 24
-# Configuration parameters: CountComments, ExcludedMethods.
-Metrics/BlockLength:
-  Max: 450
-
-# Offense count: 10
-Metrics/CyclomaticComplexity:
-  Max: 14
-
-# Offense count: 1
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 101
-
-# Offense count: 14
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 57
-
-# Offense count: 1
-# Configuration parameters: CountComments.
-Metrics/ModuleLength:
-  Max: 220
-
-# Offense count: 6
-Metrics/PerceivedComplexity:
-  Max: 13
-
-# Offense count: 4
-RSpec/AnyInstance:
-  Exclude:
-    - 'spec/lib/percy/client/builds_spec.rb'
-    - 'spec/lib/percy/client/snapshots_spec.rb'
-
-# Offense count: 113
-# Configuration parameters: SkipBlocks.
-RSpec/DescribedClass:
-  Exclude:
-    - 'spec/lib/percy/client/environment_spec.rb'
-    - 'spec/lib/percy/client_spec.rb'
-    - 'spec/lib/percy_spec.rb'
-
-# Offense count: 22
-# Configuration parameters: Max.
-RSpec/ExampleLength:
-  Exclude:
-    - 'spec/lib/percy/client/builds_spec.rb'
-    - 'spec/lib/percy/client/connection_spec.rb'
-    - 'spec/lib/percy/client/environment_spec.rb'
-    - 'spec/lib/percy/client/resources_spec.rb'
-    - 'spec/lib/percy/client/snapshots_spec.rb'
-    - 'spec/lib/percy/config_spec.rb'
-    - 'spec/lib/percy_spec.rb'
-
-# Offense count: 20
-# Configuration parameters: SupportedStyles.
-# SupportedStyles: implicit, each, example
-RSpec/HookArgument:
-  EnforcedStyle: each
-
-# Offense count: 8
-# Configuration parameters: AssignmentOnly.
-RSpec/InstanceVariable:
-  Exclude:
-    - 'spec/lib/percy/client/environment_spec.rb'
-
-# Offense count: 27
-RSpec/MultipleExpectations:
-  Max: 10
-
-# Offense count: 12
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: not_to, to_not
-RSpec/NotToNot:
-  Exclude:
-    - 'spec/lib/percy/client/builds_spec.rb'
-    - 'spec/lib/percy/client/environment_spec.rb'
-    - 'spec/lib/percy_spec.rb'
-
-# Offense count: 1
-Style/MethodMissing:
-  Exclude:
-    - 'lib/percy.rb'