percy-client 1.10.0 → 1.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: faeea13f560dc02b0e342b7ff1b150f1cb328992
-  data.tar.gz: 66c65cadf25bf1f38c43d8408235aa383dd0649a
+  metadata.gz: 8c6c5d15e4d9aad29d9ec9f1ff5bf4f551f10caa
+  data.tar.gz: a177a1b2e91a815ea115b08c28961cc5139cd7f1
 SHA512:
-  metadata.gz: c8cdecfd7259f45698e015f57b09c2f7c6800daacaea64c88ba36cf5b905220bedc98a3b5c9141743d15e651ea838f23df1742d5d76dc6884dfbe8c98b4c1c88
-  data.tar.gz: f6c3d6f4f5fa2870c6cde224e954c297ff49b88700cbdd0417a43eadcbada8cd053d2a3aa265a6aa575e5afe019d4b7daeb826fd0eb3c6dc0bc5f5f3012e4198
+  metadata.gz: 730613e8ca357612b2caa17b1f09837667d6207d964576f42cd8713969436a113395b9c205c030b8619055f0709ea74cfbee1670ddfbe0f803b00e0ae708c1b1
+  data.tar.gz: aeb0147032f403c4874962b56d7f1782e19cfcc51348bab2e8013e567abc204f94d4eceaf9ebb6612f00a3d2256a8a147efa83eba767a36f7af1502b2f97a4a8

data/.rubocop.yml

@@ -4,6 +4,9 @@ AllCops:
   Include:
     - Rakefile
     - lib/**/*.rake
+  Exclude:
+    - 'vendor/**/*'
+    - 'percy-client.gemspec'
 
 Lint/EndAlignment:
   EnforcedStyleAlignWith: variable
@@ -36,6 +39,12 @@ Style/MultilineOperationIndentation:
 Style/NumericLiterals:
   Enabled: false
 
+Style/FileName:
+  Enabled: false
+
+Style/SymbolArray:
+  Enabled: false
+
 Style/NumericPredicate:
   EnforcedStyle: comparison
 
@@ -58,8 +67,8 @@ Style/TrailingCommaInLiteral:
 RSpec/MessageSpies:
   EnforcedStyle: receive
 
-
-
+RSpec/NotToNot:
+  Enabled: false
 
 
 # Will be able to do this in >= v1.11

data/Guardfile

@@ -1,5 +1,5 @@
-guard :rspec, cmd: "bundle exec rspec" do
-  require "guard/rspec/dsl"
+guard :rspec, cmd: 'bundle exec rspec' do
+  require 'guard/rspec/dsl'
   dsl = Guard::RSpec::Dsl.new(self)
 
   # RSpec files

data/lib/percy/client/resources.rb

@@ -43,6 +43,21 @@ module Percy
         }
       end
 
+      def ==(other)
+        other.is_a?(self.class) &&
+          other.sha == sha &&
+          other.resource_url == resource_url &&
+          other.mimetype == mimetype
+      end
+
+      def hash
+        [sha, resource_url, mimetype].hash
+      end
+
+      def eql?(other)
+        self == other && hash == other.hash
+      end
+
       def inspect
         content_msg = content.nil? ? '' : "content.length: #{content.length}"
         "<Resource #{sha} #{resource_url} is_root:#{!!is_root} #{mimetype} #{content_msg}>"

data/lib/percy/client/version.rb

@@ -1,5 +1,5 @@
 module Percy
   class Client
-    VERSION = '1.10.0'.freeze
+    VERSION = '1.10.1'.freeze
   end
 end

data/percy-client.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'percy/client/version'
@@ -8,8 +9,8 @@ Gem::Specification.new do |spec|
   spec.version       = Percy::Client::VERSION
   spec.authors       = ['Perceptual Inc.']
   spec.email         = ['team@percy.io']
-  spec.summary       = %q{Percy::Client}
-  spec.description   = %q{}
+  spec.summary       = 'Percy::Client'
+  spec.description   = ''
   spec.homepage      = ''
   spec.license       = 'MIT'
 

data/spec/lib/percy/client/resources_spec.rb

@@ -1,44 +1,10 @@
 require 'digest'
 
+# rubocop:disable RSpec/MultipleDescribes
 RSpec.describe Percy::Client::Resources, :vcr do
   let(:content) { "hello world! #{described_class.name}" }
   let(:sha) { Digest::SHA256.hexdigest(content) }
 
-  describe 'Percy::Client::Resource' do
-    it 'can be initialized with minimal data' do
-      resource = Percy::Client::Resource.new('/foo.html', sha: sha)
-      expect(resource.serialize).to eq(
-        'type' => 'resources',
-        'id' => sha,
-        'attributes' => {
-          'resource-url' => '/foo.html',
-          'mimetype' => nil,
-          'is-root' => nil,
-        },
-      )
-    end
-    it 'can be initialized with all data' do
-      resource = Percy::Client::Resource.new(
-        '/foo new.html',
-        sha: sha,
-        is_root: true,
-        mimetype: 'text/html',
-        content: content,
-      )
-      expect(resource.serialize).to eq(
-        'type' => 'resources',
-        'id' => sha,
-        'attributes' => {
-          'resource-url' => '/foo%20new.html',
-          'mimetype' => 'text/html',
-          'is-root' => true,
-        },
-      )
-    end
-    it 'errors if not given sha or content' do
-      expect { Percy::Client::Resource.new('/foo.html') }.to raise_error(ArgumentError)
-    end
-  end
   describe '#upload_resource' do
     it 'returns true with success' do
       build = Percy.create_build('fotinakis/percy-examples')
@@ -51,3 +17,85 @@ RSpec.describe Percy::Client::Resources, :vcr do
     end
   end
 end
+
+RSpec.describe Percy::Client::Resource do
+  let(:content) { "hello world! #{described_class.name}" }
+  let(:sha) { Digest::SHA256.hexdigest(content) }
+
+  it 'can be initialized with minimal data' do
+    resource = described_class.new('/foo.html', sha: sha)
+    expect(resource.serialize).to eq(
+      'type' => 'resources',
+      'id' => sha,
+      'attributes' => {
+        'resource-url' => '/foo.html',
+        'mimetype' => nil,
+        'is-root' => nil,
+      },
+    )
+  end
+  it 'can be initialized with all data' do
+    resource = described_class.new(
+      '/foo new.html',
+      sha: sha,
+      is_root: true,
+      mimetype: 'text/html',
+      content: content,
+    )
+    expect(resource.serialize).to eq(
+      'type' => 'resources',
+      'id' => sha,
+      'attributes' => {
+        'resource-url' => '/foo%20new.html',
+        'mimetype' => 'text/html',
+        'is-root' => true,
+      },
+    )
+  end
+  it 'errors if not given sha or content' do
+    expect { described_class.new('/foo.html') }.to raise_error(ArgumentError)
+  end
+
+  describe 'object equality' do
+    subject(:resource) { described_class.new('/some-content', sha: sha, mimetype: mimetype) }
+
+    let(:sha) { '123456' }
+    let(:mimetype) { 'text/plain' }
+
+    describe 'two resources with same properties' do
+      let(:other) { described_class.new('/some-content', sha: sha, mimetype: mimetype) }
+
+      it { is_expected.to eq(other) }
+      it { is_expected.to eql(other) }
+      it { expect(resource.hash).to eq(other.hash) }
+      it('makes their array unique') { expect([resource, other].uniq).to eq([resource]) }
+    end
+
+    describe 'two resources with different sha' do
+      let(:other) { described_class.new('/some-content', sha: sha.reverse, mimetype: mimetype) }
+
+      it { is_expected.not_to eq(other) }
+      it { is_expected.not_to eql(other) }
+      it { expect(resource.hash).not_to eq(other.hash) }
+      it('makes array unique') { expect([resource, other].uniq).to eq([resource, other]) }
+    end
+
+    describe 'two resources with different url' do
+      let(:other) { described_class.new('/different-content', sha: sha, mimetype: mimetype) }
+
+      it { is_expected.not_to eq(other) }
+      it { is_expected.not_to eql(other) }
+      it { expect(resource.hash).not_to eq(other.hash) }
+      it('makes array unique') { expect([resource, other].uniq).to eq([resource, other]) }
+    end
+
+    describe 'two resources with different mimetype' do
+      let(:other) { described_class.new('/some-content', sha: sha, mimetype: 'text/css') }
+
+      it { is_expected.not_to eq(other) }
+      it { is_expected.not_to eql(other) }
+      it { expect(resource.hash).not_to eq(other.hash) }
+      it('makes array unique') { expect([resource, other].uniq).to eq([resource, other]) }
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-client
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.10.1
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-22 00:00:00.000000000 Z
+date: 2017-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -188,7 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.7
 signing_key: 
 specification_version: 4
 summary: Percy::Client