percy-client 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5cb1162a266bd022d172fd7f3480434d70a32c64
-  data.tar.gz: fd764e8b3a6a1474ffa6f59e1bb54765c6e20ae6
+  metadata.gz: a7a8bd76ef52e70893c756fd9427f919abece1ae
+  data.tar.gz: 71ce699a4b4b17564732ffe8f9dc0c951d70c81d
 SHA512:
-  metadata.gz: 16d2abf05c798b824d7e3387b1404df556596fa4c52652571075572a69d34e6cd7f9a18f533ffe79c262dbd28068a150593eb41fe761de04b41038f9fa29a61a
-  data.tar.gz: a2d8c8e124c448f6fd99da12d85b1b26e9fba3b295ec20a9022df370dea539d06ea528064ccc949841823971a74c7e7cf476da19d0198990a0cb668f07b78a8a
+  metadata.gz: 0f9eafbf5f941f767af79bf868a2acb5af4e1baf6699e6c3afd69820b9bd1dfefeada9c56cec8516cbb83044b5da23ce3523d84bd894d65fc2b3106f96a97d02
+  data.tar.gz: 8b43b15a64cbf8c35d85414646e697958172ef7c25a15d37c0c654e01d1f3adf41d901497758e293bcc303822f807b490c4018e3dfcfaff90b266a6df2ce5318

data/lib/percy/client/environment.rb

@@ -164,6 +164,8 @@ module Percy
         case current_ci
         when :circle
           ENV['CIRCLE_BUILD_NUM']
+        when :travis
+          ENV['TRAVIS_BUILD_NUMBER']
         end
       end
 
@@ -172,7 +174,12 @@ module Percy
 
         case current_ci
         when :circle
-          Integer(ENV['CIRCLE_NODE_TOTAL']) if !ENV['CIRCLE_NODE_TOTAL'].empty?
+          var = 'CIRCLE_NODE_TOTAL'
+          Integer(ENV[var]) if ENV[var] && !ENV[var].empty?
+        when :travis
+          # Support for https://github.com/ArturT/knapsack
+          var = 'CI_NODE_TOTAL'
+          Integer(ENV[var]) if ENV[var] && !ENV[var].empty?
         end
       end
 

data/lib/percy/client/version.rb

@@ -1,5 +1,5 @@
 module Percy
   class Client
-    VERSION = '0.10.0'
+    VERSION = '0.11.0'
   end
 end

data/spec/lib/percy/client/environment_spec.rb

@@ -10,10 +10,12 @@ RSpec.describe Percy::Client::Environment do
 
     # Unset Travis vars.
     ENV['TRAVIS_BUILD_ID'] = nil
+    ENV['TRAVIS_BUILD_NUMBER'] = nil
     ENV['TRAVIS_COMMIT'] = nil
     ENV['TRAVIS_BRANCH'] = nil
     ENV['TRAVIS_PULL_REQUEST'] = nil
     ENV['TRAVIS_REPO_SLUG'] = nil
+    ENV['CI_NODE_TOTAL'] = nil
 
     # Unset Jenkins vars.
     ENV['JENKINS_URL'] = nil
@@ -47,6 +49,7 @@ RSpec.describe Percy::Client::Environment do
   before(:each) do
     @original_env = {
       'TRAVIS_BUILD_ID' => ENV['TRAVIS_BUILD_ID'],
+      'TRAVIS_BUILD_NUMBER' => ENV['TRAVIS_BUILD_NUMBER'],
       'TRAVIS_COMMIT' => ENV['TRAVIS_COMMIT'],
       'TRAVIS_BRANCH' => ENV['TRAVIS_BRANCH'],
       'TRAVIS_PULL_REQUEST' => ENV['TRAVIS_PULL_REQUEST'],
@@ -57,6 +60,7 @@ RSpec.describe Percy::Client::Environment do
   after(:each) do
     clear_env_vars
     ENV['TRAVIS_BUILD_ID'] = @original_env['TRAVIS_BUILD_ID']
+    ENV['TRAVIS_BUILD_NUMBER'] = @original_env['TRAVIS_BUILD_NUMBER']
     ENV['TRAVIS_COMMIT'] = @original_env['TRAVIS_COMMIT']
     ENV['TRAVIS_BRANCH'] = @original_env['TRAVIS_BRANCH']
     ENV['TRAVIS_PULL_REQUEST'] = @original_env['TRAVIS_PULL_REQUEST']
@@ -198,10 +202,12 @@ RSpec.describe Percy::Client::Environment do
   context 'in Travis CI' do
     before(:each) do
       ENV['TRAVIS_BUILD_ID'] = '1234'
+      ENV['TRAVIS_BUILD_NUMBER'] = 'build-number'
       ENV['TRAVIS_PULL_REQUEST'] = '256'
       ENV['TRAVIS_REPO_SLUG'] = 'travis/repo-slug'
       ENV['TRAVIS_COMMIT'] = 'travis-commit-sha'
       ENV['TRAVIS_BRANCH'] = 'travis-branch'
+      ENV['CI_NODE_TOTAL'] = '3'
     end
 
     describe '#current_ci' do
@@ -229,6 +235,20 @@ RSpec.describe Percy::Client::Environment do
         expect(Percy::Client::Environment.repo).to eq('travis/repo-slug')
       end
     end
+    describe '#parallel_nonce' do
+      it 'reads from the CI environment (the CI build number)' do
+        expect(Percy::Client::Environment.parallel_nonce).to eq('build-number')
+      end
+    end
+    describe '#parallel_total_shards' do
+      it 'reads from the CI environment (the number of nodes)' do
+        expect(Percy::Client::Environment.parallel_total_shards).to eq(3)
+      end
+      it 'is nil if empty' do
+        ENV['CI_NODE_TOTAL'] = ''
+        expect(Percy::Client::Environment.parallel_total_shards).to be_nil
+      end
+    end
   end
   context 'in Circle CI' do
     before(:each) do
@@ -269,7 +289,7 @@ RSpec.describe Percy::Client::Environment do
       end
     end
     describe '#parallel_nonce' do
-      it 'reads from the CI environment (the CI build ID)' do
+      it 'reads from the CI environment (the CI build number)' do
         expect(Percy::Client::Environment.parallel_nonce).to eq('build-number')
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-client
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-06 00:00:00.000000000 Z
+date: 2015-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday