percy-capybara 2.4.0 → 2.4.1

data/spec/lib/percy/capybara/loaders/sprockets_loader_spec.rb

@@ -1,7 +1,7 @@
 require 'sprockets'
 
 class SimpleRackApp
-  def self.call(env)
+  def self.call(_env)
     [200, {}, 'Hello World']
   end
 end
@@ -11,11 +11,11 @@ RSpec.describe Percy::Capybara::Loaders::SprocketsLoader do
     described_class.new(
       page: page,
       sprockets_environment: environment,
-      sprockets_options: sprockets_options,
+      sprockets_options: sprockets_options
     )
   end
   let(:environment) do
-    root = File.expand_path("../../client/testdata", __FILE__)
+    root = File.expand_path('../../client/testdata', __FILE__)
     environment = Sprockets::Environment.new(root)
     environment.append_path '.'
     environment
@@ -32,12 +32,12 @@ RSpec.describe Percy::Capybara::Loaders::SprocketsLoader do
 
   describe '#snapshot_resources' do
     context 'Rack::Test', type: :feature do
-      before(:each) { Capybara.app = SimpleRackApp }
+      before { Capybara.app = SimpleRackApp }
 
       it 'returns the root HTML resource' do
         visit '/'
         resources = loader.snapshot_resources
-        expect(resources.map { |r| r.resource_url }).to eq(["/"])
+        expect(resources.map(&:resource_url)).to eq(['/'])
         expect(resources.first.is_root).to eq(true)
         expect(resources.first.content).to include('Hello World')
       end
@@ -46,7 +46,7 @@ RSpec.describe Percy::Capybara::Loaders::SprocketsLoader do
       it 'returns the root HTML resource' do
         visit '/'
         resources = loader.snapshot_resources
-        expect(resources.map { |r| r.resource_url }).to eq(["/"])
+        expect(resources.map(&:resource_url)).to eq(['/'])
         expect(resources.first.is_root).to eq(true)
         expect(resources.first.content).to include('Hello World!</body></html>')
       end
@@ -69,11 +69,11 @@ RSpec.describe Percy::Capybara::Loaders::SprocketsLoader do
         '/assets/images/srcset-second.png',
         '/assets/js/base.js',
       ]
-      expect(resources.map { |r| r.resource_url }).to eq(expected_resources)
+      expect(resources.map(&:resource_url)).to eq(expected_resources)
       expect(resources.first.content).to include('.colored-by-base')
     end
     context 'Rails app' do
-      before(:each) do
+      before do
         # Pretend like we're in a Rails app right now, all we care about is Rails.public_path.
         rails_double = double('Rails')
         # Pretend like the entire testdata directory is the public/ folder.
@@ -85,10 +85,10 @@ RSpec.describe Percy::Capybara::Loaders::SprocketsLoader do
         # Weak test that more things are in this list, because it merges asset pipeline with public.
         expect(resources.length).to be > 5
 
-        resource_urls = resources.map { |r| r.resource_url }
-        expect(resource_urls).to include('/assets/images/bg-relative.png')  # From asset pipeline.
-        expect(resource_urls).to include('/percy-from-public.svg')  # Public merged into root.
-        expect(resource_urls).to_not include('/large-file-skipped.png')  # Public merged into root.
+        resource_urls = resources.map(&:resource_url)
+        expect(resource_urls).to include('/assets/images/bg-relative.png') # From asset pipeline.
+        expect(resource_urls).to include('/percy-from-public.svg') # Public merged into root.
+        expect(resource_urls).not_to include('/large-file-skipped.png') # Public merged into root.
       end
       context 'digest enabled' do
         let(:digest_enabled) { true }
@@ -99,7 +99,8 @@ RSpec.describe Percy::Capybara::Loaders::SprocketsLoader do
           # `config.assets.digest = true` set can safely run "rake assets:precompile" before tests.
           resources = loader.build_resources
           expected_digest_url = \
-            '/assets/css/digested-f3420c6aee71c137a3ca39727052811bae84b2f37d898f4db242e20656a1579e.css'
+            '/assets/css/digested-f3420c6aee71c137a3ca39727052811bae84b2f37' \
+            'd898f4db242e20656a1579e.css'
           digested_resources = resources.select { |r| r.resource_url == expected_digest_url }
           expect(digested_resources.length).to eq(1)
         end

data/spec/lib/percy/capybara_spec.rb

@@ -1,10 +1,10 @@
 RSpec.describe Percy::Capybara do
-  before(:each) do
+  before do
     Percy::Capybara.reset!
     @original_env = ENV['TRAVIS_BUILD_ID']
     ENV['TRAVIS_BUILD_ID'] = nil
   end
-  after(:each) do
+  after do
     ENV['TRAVIS_BUILD_ID'] = @original_env
     ENV.delete('PERCY_ENABLE')
   end
@@ -41,7 +41,7 @@ RSpec.describe Percy::Capybara do
   end
   describe '#finalize_build' do
     it 'returns silently if no build is initialized' do
-      expect { Percy::Capybara.finalize_build }.to_not raise_error
+      expect { Percy::Capybara.finalize_build }.not_to raise_error
     end
     it 'delegates to Percy::Capybara::Client' do
       capybara_client = Percy::Capybara.capybara_client
@@ -55,9 +55,9 @@ RSpec.describe Percy::Capybara do
     it 'silently skips if disabled' do
       ENV['PERCY_ENABLE'] = '0'
       capybara_client = Percy::Capybara.capybara_client
-      expect(capybara_client.client).to_not receive(:create_build)
+      expect(capybara_client.client).not_to receive(:create_build)
       Percy::Capybara.initialize_build
-      expect(capybara_client).to_not receive(:finalize_current_build)
+      expect(capybara_client).not_to receive(:finalize_current_build)
       Percy::Capybara.finalize_build
     end
   end
@@ -65,7 +65,7 @@ RSpec.describe Percy::Capybara do
     it 'clears the current capybara_client' do
       capybara_client = Percy::Capybara.capybara_client
       Percy::Capybara.reset!
-      expect(Percy::Capybara.capybara_client).to_not eq(capybara_client)
+      expect(Percy::Capybara.capybara_client).not_to eq(capybara_client)
     end
   end
   describe '#disable!' do
@@ -82,14 +82,14 @@ RSpec.describe Percy::Capybara do
     class DummyLoader < Percy::Capybara::Loaders::NativeLoader; end
 
     it 'sets the current capybara client\'s loader' do
-      expect(Percy::Capybara.capybara_client.loader).to_not be
+      expect(Percy::Capybara.capybara_client.loader).not_to be
       Percy::Capybara.use_loader(DummyLoader)
       expect(Percy::Capybara.capybara_client.loader).to be
     end
 
     it 'sets the current capybara client\'s loader options' do
       expect(Percy::Capybara.capybara_client.loader_options).to eq({})
-      Percy::Capybara.use_loader(DummyLoader, {test_option: 3})
+      Percy::Capybara.use_loader(DummyLoader, test_option: 3)
       expect(Percy::Capybara.capybara_client.loader_options).to be
       expect(Percy::Capybara.capybara_client.loader_options[:test_option]).to eq(3)
     end

data/spec/spec_helper.rb

@@ -55,7 +55,7 @@ RSpec.configure do |config|
   # You can test this server manually by running:
   # ruby -run -e httpd spec/lib/percy/capybara/client/testdata/ -p 9090
   config.before(:all, type: :feature) do
-    port = get_random_open_port
+    port = random_open_port
     Capybara.app = nil
     Capybara.app_host = "http://localhost:#{port}"
     Capybara.run_server = false

data/spec/support/test_helpers.rb

@@ -3,9 +3,9 @@ require 'timeout'
 require 'sprockets'
 
 module TestHelpers
-  class ServerDown < Exception; end
+  class ServerDown < RuntimeError; end
 
-  def get_random_open_port
+  def random_open_port
     # Using a port of "0" relies on the system to pick an open port.
     server = TCPServer.new('127.0.0.1', 0)
     port = server.addr[1]
@@ -35,7 +35,7 @@ module TestHelpers
   end
 
   def setup_sprockets(capybara_client)
-    root = File.expand_path("../../lib/percy/capybara/client/testdata", __FILE__)
+    root = File.expand_path('../../lib/percy/capybara/client/testdata', __FILE__)
     environment = Sprockets::Environment.new(root)
     environment.append_path '.'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-capybara
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - Perceptual Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-09 00:00:00.000000000 Z
+date: 2017-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: percy-client
@@ -87,6 +87,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.6'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.12.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -94,6 +97,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.6'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.12.0
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
@@ -173,6 +179,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
@@ -224,7 +232,7 @@ files:
 - spec/lib/percy/capybara/client/testdata/test-images.html
 - spec/lib/percy/capybara/client/testdata/test-localtest-me-images.html
 - spec/lib/percy/capybara/client_spec.rb
-- spec/lib/percy/capybara/httpfetcher_spec.rb
+- spec/lib/percy/capybara/http_fetcher_spec.rb
 - spec/lib/percy/capybara/loaders/base_loader_spec.rb
 - spec/lib/percy/capybara/loaders/filesystem_loader_spec.rb
 - spec/lib/percy/capybara/loaders/native_loader_spec.rb
@@ -288,7 +296,7 @@ test_files:
 - spec/lib/percy/capybara/client/testdata/test-images.html
 - spec/lib/percy/capybara/client/testdata/test-localtest-me-images.html
 - spec/lib/percy/capybara/client_spec.rb
-- spec/lib/percy/capybara/httpfetcher_spec.rb
+- spec/lib/percy/capybara/http_fetcher_spec.rb
 - spec/lib/percy/capybara/loaders/base_loader_spec.rb
 - spec/lib/percy/capybara/loaders/filesystem_loader_spec.rb
 - spec/lib/percy/capybara/loaders/native_loader_spec.rb