percy-appium-app 0.0.5 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e78f2676c90003ca32a0a765f50825da64db7127bf7413c6836470b270323e92
-  data.tar.gz: 30aa4ab566db291ff462d230f6ea1d2a78a37f8dd5da6968c44eea90aa3296de
+  metadata.gz: 8894474b866e7988f60b776f782f3c04887b4aa626cf2a384f2c97d983a534fc
+  data.tar.gz: 461ea9e2bf18840893f9b805ea93e8005874b4c9ddbcdf447d71e691051a015f
 SHA512:
-  metadata.gz: e2dc8e58117d35b93c3239fece03898ebc4599d0bc0c0ce8694ac8a4924cea8109e58def6ac93a5853ce235ea6a20db231995a293ae6cd43740387cbb37c511f
-  data.tar.gz: 82b18011008074818858a9120b25e026f34e7aac23bfc757155faaba52b6c033a00cc1aeba45710fdaca486506dc42d35cd0c21206516031ad14ac1c4f828e4c
+  metadata.gz: c91b292ad5b7a2ba6d04a64294d539caf6da3a9da7809663625a07f441563d242e00a37025ef2a96bdeafe3f604af7b286709676debeb18ca0834f22590e790c
+  data.tar.gz: e670e5434e2d4ace31348e736134f6976d8fa2bc1548febe7b7d70faeab6f057b833fc1809c84cf1c3b7b5a21922f41d75df3134b4fc7d2167a9354775da8d86

data/.github/workflows/test.yml

@@ -37,4 +37,4 @@ jobs:
           key: v1/${{ runner.os }}/ruby-${{ matrix.ruby }}/${{ hashFiles('**/Gemfile.lock') }}
           restore-keys: v1/${{ runner.os }}/ruby-${{ matrix.ruby }}/
       - run: bundle install
-      - run: for file in specs/*.rb; do ruby $file; done
+      - run: for file in specs/*.rb; do echo $file; bundle exec ruby $file; done

data/percy/common/common.rb

@@ -2,14 +2,13 @@
 
 require 'dotenv/load'
 
-PERCY_LOGLEVEL = ENV['PERCY_LOGLEVEL']
-PERCY_DEBUG = PERCY_LOGLEVEL == 'debug'
-LABEL = "[\e[35m#{PERCY_DEBUG ? 'percy:ruby' : 'percy'}\e[39m]"
 
 def log(message, on_debug: nil)
-  return unless on_debug.nil? || (on_debug.is_a?(TrueClass) && PERCY_DEBUG)
+  return unless on_debug.nil? || (on_debug.is_a?(TrueClass) && percy_debug)
 
-  puts "#{LABEL} #{message}"
+  label = "[\e[35m#{percy_debug ? 'percy:ruby' : 'percy'}\e[39m]"
+
+  puts "#{label} #{message}"
 end
 
 def hashed(object)
@@ -17,3 +16,7 @@ def hashed(object)
 
   object
 end
+
+def percy_debug
+  ENV['PERCY_LOGLEVEL'] == 'debug'
+end

data/percy/metadata/metadata.rb

@@ -103,7 +103,10 @@ module Percy
       return @device_info unless @device_info.empty?
 
       @device_info = DEVICE_INFO[device_name.downcase] || {}
-      log("#{device_name.downcase} does not exist in config.") if @device_info.empty?
+      if @device_info.empty?
+        log("#{device_name.downcase} does not exist in config. Making driver call to get the device info.",
+            on_debug: true)
+      end
       @device_info
     end
   end

data/percy/providers/generic_provider.rb

@@ -106,8 +106,8 @@ module Percy
 
     def get_region_object(selector, element)
       scale_factor = metadata.scale_factor
-      location = hashed(element.location)
-      size = hashed(element.size)
+      location = { 'x' => element.location.x, 'y' => element.location.y }
+      size = { 'height' => element.size.height, 'width' => element.size.width }
       coordinates = {
         'top' => location['y'] * scale_factor,
         'bottom' => (location['y'] + size['height']) * scale_factor,
@@ -133,7 +133,9 @@ module Percy
 
     def get_regions_by_ids(elements_array, ids)
       ids.each do |id|
-        element = driver.find_element(Appium::Core::Base::SearchContext::FINDERS[:accessibility_id], id)
+        # Appium::Core::Base::SearchContext::FINDERS[:xpath] returns `accessibility id`
+        # instead of `:accessibility_id`, causes error
+        element = driver.find_element(:accessibility_id, id)
         selector = "id: #{id}"
         region = get_region_object(selector, element)
         elements_array << region

data/percy/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Percy
-  VERSION = '0.0.5'.freeze
+  VERSION = '0.0.7'.freeze
 end

data/specs/generic_providers.rb

@@ -233,8 +233,10 @@ class TestGenericProvider < Minitest::Test
 
   def test_get_region_object
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 100, 'height' => 200 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(100, 200))
+    end
 
     result = @generic_provider.get_region_object('my-selector', mock_element)
     expected_result = {
@@ -248,8 +250,10 @@ class TestGenericProvider < Minitest::Test
 
   def test_get_regions_by_xpath
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 100, 'height' => 200 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(100, 200))
+    end
 
     @mock_webdriver.expect(:find_element, mock_element,
                            [Appium::Core::Base::SearchContext::FINDERS[:xpath], '//path/to/element'])
@@ -279,11 +283,12 @@ class TestGenericProvider < Minitest::Test
 
   def test_get_regions_by_ids
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 100, 'height' => 200 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(100, 200))
+    end
 
-    @mock_webdriver.expect(:find_element, mock_element,
-                           [Appium::Core::Base::SearchContext::FINDERS[:accessibility_id], 'some_id'])
+    @mock_webdriver.expect(:find_element, mock_element, [:accessibility_id, 'some_id'])
 
     elements_array = []
     ids = ['some_id']
@@ -299,8 +304,10 @@ class TestGenericProvider < Minitest::Test
 
   def test_get_regions_by_ids_with_non_existing_element
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 100, 'height' => 200 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(100, 200))
+    end
 
     @mock_webdriver.expect(:find_element, [Appium::Core::Base::SearchContext::FINDERS[:accessibility_id], 'id1']) do
       raise Appium::Core::Error::NoSuchElementError, 'Test error'
@@ -315,8 +322,10 @@ class TestGenericProvider < Minitest::Test
 
   def test_get_regions_by_elements
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 100, 'height' => 200 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(100, 200))
+    end
     mock_element.expect(:attribute, 'textView', ['class'])
 
     elements_array = []

data/specs/metadata.rb

@@ -28,11 +28,39 @@ class TestMetadata < Minitest::Test
     ENV['PERCY_LOGLEVEL'] = 'debug'
   end
 
-  def test_get_device_info_device_not_present
+  def test_get_device_info_device_not_present_when_log_level_is_debug
+    # redirecting the standard output temporarily and capture the output in a string. 
+    captured_output = StringIO.new
+    $stdout = captured_output
+    ENV['PERCY_LOGLEVEL'] = 'debug'
     device_name = 'Some Phone 123'
-    assert_output(/#{Regexp.escape(device_name.downcase)} does not exist in config\./) do
-      @metadata.get_device_info(device_name)
-    end
+    @metadata.get_device_info(device_name)
+    # Restore standard output
+    $stdout = STDOUT
+
+    # Get the captured output as a string
+    output = captured_output.string
+    regex_pattern = /#{Regexp.escape(device_name.downcase)} does not exist in config\. Making driver call to get the device info\./
+
+    assert_match(regex_pattern, output)
+    ENV['PERCY_LOGLEVEL'] = nil
+  end
+
+  def test_get_device_info_device_not_present_when_log_level_is_info
+    # redirecting the standard output temporarily and capture the output in a string. 
+    captured_output = StringIO.new
+    $stdout = captured_output
+    ENV['PERCY_LOGLEVEL'] = nil
+    device_name = 'Some Phone 123'
+    @metadata.get_device_info(device_name)
+
+    # Restore standard output
+    $stdout = STDOUT
+
+    # Get the captured output as a string
+    output = captured_output.string
+
+    assert_equal(output, '')
   end
 
   def test_metadata_get_orientation

data/specs/screenshot.rb

@@ -339,8 +339,10 @@ class TestPercyScreenshot < Minitest::Test
     mock_screenshot
 
     mock_element = Minitest::Mock.new
-    mock_element.expect(:location, { 'x' => 10, 'y' => 20 })
-    mock_element.expect(:size, { 'width' => 200, 'height' => 400 })
+    2.times do
+      mock_element.expect(:location, Selenium::WebDriver::Point.new(10, 20))
+      mock_element.expect(:size, Selenium::WebDriver::Dimension.new(200, 400))
+    end
 
     xpaths = ['//path/to/element']
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: percy-appium-app
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.7
 platform: ruby
 authors:
 - BroswerStack
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-19 00:00:00.000000000 Z
+date: 2024-02-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appium_lib