percona_migrator 0.1.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 59ecf09f58f8aa46d64cf996a2a91a8acfa6dc8b
-  data.tar.gz: 24daf3f8ba0bd51f1804b23857a0a94d4d345bfc
+  metadata.gz: 686c3a5b5ab858a587451fba1c6aa0b934f1cf9c
+  data.tar.gz: d01ece64414481d9b43a143a16f748ce134afc7a
 SHA512:
-  metadata.gz: 1b1e0e1b42bcf64cd145a34882de830b572e9aabfcd3616a03bf7f81d1545864ca91951b1217f0bbf78191d41aeaa1b29761e3542fa7c110abff1823e4c845ff
-  data.tar.gz: 02eae12611279a35d0cfaf243c1cda0a883c8ad91c792fea9ae11826b1b49e208eb6fa0da434f68706560fcc5ecf7535c5e9b3e366c406d010b53766aded8e27
+  metadata.gz: 104039977e6a970cad93bcb93e7ff628a2a00c0a10715543daaf9915fca08a1bf6e1643dc2e2e34e947f494f43abc9662c62a0a3e53ae9c98a0500abf9a9576e
+  data.tar.gz: f7e205f53c0cfd327dd293d0357b8e1e85b64ddf0a7a2cca14679a22607e3d5c8d1731757cb0ed1a25d83c38f31795fe23a74fc9cfd82af5cad1f42e67ce4e84

data/CHANGELOG.md

@@ -6,30 +6,20 @@ Please follow the format in [Keep a Changelog](http://keepachangelog.com/)
 
 ## [Unreleased]
 
-### Added
-### Changed
-### Removed
-### Fixed
-
-## [0.1.1] - 2017-03-10
+## [1.0.0] - 2016-11-30
 
 ### Added
 
+- Show pt-online-schema-change's stdout while the migration is running instead
+    of at then and all at once.
 - Store pt-online-schema-change's stderr to percona_migrator_error.log in the
     default Rails tmp folder.
-- Allow configuring the tmp directory where the error log gets written into.
-- Output a deprecation warning when installing and running the gem. It will be
-    replaced by Departure soon.
-
-### Changed
-
-- No longer a hard dependency on mysql2 0.3.20. Will accept 0.3.20 or any
-    higher patch revisions.
-
-### Fixed
-
-- Output pt-online-schema-change's stdout while the migration is running instead
-    of all of it at the end.
+- Allow configuring the tmp directory where the error log gets written into,
+    with the `tmp_path` configuration setting.
+- Support for ActiveRecord 4.0. Adds the following migration methods:
+  - #rename_index, #change_column_null, #add_reference, #remove_reference,
+    #set_field_encoding, #add_timestamps, #remove_timestamps, #rename_table,
+    #rename_column
 
 ## [0.1.0.rc.7] - 2016-09-15
 

data/README.md

@@ -1,6 +1,6 @@
-# Departure [![Build Status](https://travis-ci.org/redbooth/departure.svg?branch=master)](https://travis-ci.org/redbooth/percona_migrator) [![Code Climate](https://codeclimate.com/github/redbooth/percona_migrator/badges/gpa.svg)](https://codeclimate.com/github/redbooth/percona_migrator)
+# Percona Migrator [![Build Status](https://travis-ci.org/redbooth/percona_migrator.svg?branch=master)](https://travis-ci.org/redbooth/percona_migrator) [![Code Climate](https://codeclimate.com/github/redbooth/percona_migrator/badges/gpa.svg)](https://codeclimate.com/github/redbooth/percona_migrator)
 
-Departure is an **ActiveRecord connection adapter** that allows running
+Percona Migrator is an **ActiveRecord connection adapter** that allows running
 **MySQL online and non-blocking DDL** through `ActiveRecord::Migration` without needing
     to use a different DSL other than Rails' migrations DSL.
 
@@ -9,17 +9,9 @@ It uses `pt-online-schema-change` command-line tool of
 Toolkit](https://www.percona.com/doc/percona-toolkit/2.0/pt-online-schema-change.html)
 which runs MySQL alter table statements without downtime.
 
-## Rename from "Percona Migrator"
-
-This project was formerly known as "Percona Migrator", but this incurs in an
-infringement of Percona's trade mark policy and thus has to be renamed. Said
-name is likely to cause confusion as to the source of the wrapper.
-
-The next major versions will use "Departure" as gem name.
-
 ## Installation
 
-Departure relies on `pt-online-schema-change` from [Percona
+Percona Migrator relies on `pt-online-schema-change` from [Percona
 Toolkit](https://www.percona.com/doc/percona-toolkit/2.0/pt-online-schema-change.html)
 
 ### Mac
@@ -70,7 +62,7 @@ migration.
 ### LHM support
 
 If you moved to Soundcloud's [Lhm](https://github.com/soundcloud/lhm) already,
-we got you covered. Departure overrides Lhm's DSL so that all the alter
+we got you covered. Percona Migrator overrides Lhm's DSL so that all the alter
 statements also go through `pt-online-schema-change` as well.
 
 You can keep your Lhm migrations and start using Rails migration's DSL back
@@ -91,7 +83,7 @@ It's strongly recommended to name it after this gems name, such as
 
 ## How it works
 
-When booting your Rails app, Departure extends the
+When booting your Rails app, Percona Migrator extends the
 `ActiveRecord::Migration#migrate` method to reset the connection and reestablish
 it using the `PerconaAdapter` instead of the one you defined in your
 `config/database.yml`.
@@ -129,7 +121,8 @@ git commits and tags, and push the `.gem` file to
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at
-https://github.com/redbooth/percona_migrator.
+https://github.com/redbooth/percona_migrator. They need to be opened against
+`master` or `v3.2` only if the changes fix a bug in Rails 3.2 apps.
 
 Please note that this project is released with a Contributor Code of Conduct. By
 participating in this project you agree to abide by its terms.

data/RELEASING.md

@@ -0,0 +1,17 @@
+# Releasing Percona Migrator
+
+All releases come from the master branch. All other branches won't be maintained
+and will receive bug fix releases only.
+
+In order to give support to a new major Rails version, we'll branch off of
+master, name it following the Rails repo convention, such as `v4.2`, and
+we'll keep it open for bug fixes.
+
+1. Update `lib/percona_migrator/version.rb` accordingly
+2. Review the `CHANGELOG.md` and add a new section following the format
+   `[version] - YYYY-MM-DD`. We conform to the guidelines of
+   http://keepachangelog.com/
+3. Commit the changes with the message `Prepare release VERSION`
+4. Execute the release rake task as `bundle exec rake release`. It creates the
+   tag, builds and pushes the gem to Rubygems.
+5. Announce it! :tada:

data/lib/active_record/connection_adapters/percona_adapter.rb

@@ -5,12 +5,14 @@ require 'percona_migrator'
 require 'forwardable'
 
 module ActiveRecord
-  class Base
+  module ConnectionHandling
     # Establishes a connection to the database that's used by all Active
     # Record objects.
-    def self.percona_connection(config)
+    def percona_connection(config)
       mysql2_connection = mysql2_connection(config)
 
+      config[:username] = 'root' if config[:username].nil?
+
       verbose = ActiveRecord::Migration.verbose
       percona_logger = PerconaMigrator::LoggerFactory.build(verbose: verbose)
       cli_generator = PerconaMigrator::CliGenerator.new(config)
@@ -45,7 +47,7 @@ module ActiveRecord
 
       ADAPTER_NAME = 'Percona'.freeze
 
-      def_delegators :mysql_adapter, :last_inserted_id, :each_hash
+      def_delegators :mysql_adapter, :last_inserted_id, :each_hash, :set_field_encoding
 
       def initialize(connection, _logger, connection_options, _config)
         super
@@ -59,7 +61,7 @@ module ActiveRecord
       end
       alias :exec_update :exec_delete
 
-      def exec_insert(sql, name, binds)
+      def exec_insert(sql, name, binds, pk = nil, sequence_name = nil)
         execute(to_sql(sql, binds), name)
       end
 
@@ -77,7 +79,7 @@ module ActiveRecord
       # Executes a SELECT query and returns an array of record hashes with the
       # column names as keys and column values as values.
       def select(sql, name = nil, binds = [])
-        exec_query(sql, name, binds).to_a
+        exec_query(sql, name, binds)
       end
 
       # Returns true, as this adapter supports migrations
@@ -85,8 +87,8 @@ module ActiveRecord
         true
       end
 
-      def new_column(field, default, type, null, collation)
-        Column.new(field, default, type, null, collation)
+      def new_column(field, default, type, null, collation, extra = "")
+        Column.new(field, default, type, null, collation, extra)
       end
 
       # Adds a new index to the table

data/lib/percona_migrator/cli_generator.rb

@@ -28,6 +28,10 @@ module PerconaMigrator
 
   # Generates the equivalent Percona's pt-online-schema-change command to the
   # given SQL statement
+  #
+  # --no-check-alter is used to allow running CHANGE COLUMN statements. For
+  #   more details, check: www.percona.com/doc/percona-toolkit/2.2/pt-online-schema-change.html#cmdoption-pt-online-schema-change--[no]check-alter
+  #
   class CliGenerator # Command
     BASE_COMMAND = 'pt-online-schema-change'
     BASE_OPTIONS = %w(
@@ -35,6 +39,7 @@ module PerconaMigrator
       --statistics
       --recursion-method=none
       --alter-foreign-keys-method=auto
+      --no-check-alter
     )
 
     # Constructor

data/lib/percona_migrator/runner.rb

@@ -70,17 +70,11 @@ module PerconaMigrator
     #
     # @yield
     def logging
-      log_deprecations
       log_started
       yield
       log_finished
     end
 
-    def log_deprecations
-      logger.write("\n")
-      logger.write("[DEPRECATION] This gem has been renamed to Departure and will no longer be supported. Please switch to Departure as soon as possible.")
-    end
-
     # Logs when the execution started
     def log_started
       logger.write("\n")

data/lib/percona_migrator/version.rb

@@ -1,3 +1,3 @@
 module PerconaMigrator
-  VERSION = '0.1.1'.freeze
+  VERSION = '1.0.0'.freeze
 end

data/percona_migrator.gemspec

@@ -15,17 +15,11 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'http://github.com/redbooth/percona_migrator'
   spec.license       = 'MIT'
 
-  spec.post_install_message = <<-MESSAGE
-  !    The Percona_migrator gem has been deprecated and has been replaced by Departure.
-  !    See: https://rubygems.org/gems/departure
-  !    And: https://github.com/redbooth/departure
-  MESSAGE
-
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'rails', '~>3.2.22'
-  spec.add_runtime_dependency 'mysql2', '~>0.3.20'
+  spec.add_runtime_dependency 'rails', '>= 3.2.22', '~> 4.0.0'
+  spec.add_runtime_dependency 'mysql2', '0.3.20'
 
   spec.add_development_dependency 'bundler', '~> 1.10'
   spec.add_development_dependency 'rake', '~> 10.0'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: percona_migrator
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Ilya Zayats
@@ -11,34 +11,40 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-10 00:00:00.000000000 Z
+date: 2016-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.22
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.22
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: mysql2
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
         version: 0.3.20
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
         version: 0.3.20
 - !ruby/object:Gem::Dependency
@@ -141,6 +147,7 @@ files:
 - Gemfile
 - LICENSE.txt
 - README.md
+- RELEASING.md
 - Rakefile
 - bin/console
 - bin/setup
@@ -168,10 +175,7 @@ homepage: http://github.com/redbooth/percona_migrator
 licenses:
 - MIT
 metadata: {}
-post_install_message: |2
-    !    The Percona_migrator gem has been deprecated and has been replaced by Departure.
-    !    See: https://rubygems.org/gems/departure
-    !    And: https://github.com/redbooth/departure
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -187,7 +191,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: pt-online-schema-change runner for ActiveRecord migrations